Commit Graph

102 Commits

Author SHA1 Message Date
Charles Kerr 677dc73eac
refactor: use GTest for running tests (#1383)
* refactor: use google-test on libtransmission tests
2020-08-11 13:11:55 -05:00
Bogdan Vasiliev a6482b0061
GTK: behavior improvements of the torrent details window (#892)
* gtk: torrent details file-list default sort

* gtk: save torrent details window size

* gtk: torrent details window size & sort, code style

* gtk: torrent details window, conf.c dict fix

Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 16:34:02 -05:00
Mike Gelfand 4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand 2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Mike Gelfand cdf3cf62f9 Fix some issues revealed by coverity 2015-05-09 11:56:35 +00:00
Mike Gelfand 2321bc3fad Fix some issues revealed by coverity 2015-05-09 08:37:55 +00:00
Jordan Lee beeb4d3b77 (trunk, gtk) minor fix to tr_prefs_init_default() -- avoid redundant calls to g_get_user_special_dir 2013-06-12 00:22:41 +00:00
Jordan Lee c1559f3cc4 (trunk, libT) first drop of the tr_quark patch. 2012-12-22 20:35:19 +00:00
Jordan Lee e96ed247fe refactor libtransmission's tr_benc class as tr_variant. 2012-12-14 04:34:42 +00:00
Jordan Lee 9ddd7e0166 preallocate a couple of dictionaries to the right size before using them. 2012-12-09 21:28:20 +00:00
Jordan Lee 3d38723ad9 Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00
Jordan Lee cf716904f9 (trunk, gtk) #4573 'fix crash when opening a torrent file on systems that don't define G_USER_DIRECTORY_DOWNLOAD'. Thanks to Felipe Contreras for the initial patch. 2012-04-08 16:02:48 +00:00
Jordan Lee d524deecb0 (trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner. 2011-12-10 19:00:50 +00:00
Jordan Lee a7a9c2b12e (trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done. 2011-08-13 22:58:49 +00:00
Jordan Lee 4d4eeae682 (trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee! 2011-08-09 02:30:31 +00:00
Jordan Lee b7371264fb fix r12638 regression caused by the difference in return values from gtr_mkdir_with_parents() and g_mkdir_with_parents() 2011-08-08 16:56:36 +00:00
Jordan Lee 270126820a (trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency 2011-08-07 16:42:38 +00:00
Jordan Lee bb57ac3c50 (trunk gtk) #4372 "make notification and system sounds configurable" -- fixed. 2011-07-23 17:23:12 +00:00
Jordan Lee 375694eda9 (trunk) copyediting: remove some unneeded #includes, and annotate some needed ones 2011-03-24 21:49:42 +00:00
Jordan Lee b4d36aeb54 (trunk) #4138 "use stdbool.h instead of tr_bool" -- done. 2011-03-22 15:19:54 +00:00
Jordan Lee c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr 057487d18e (trunk gtk) more gtr_ naming cleanup 2010-12-22 06:25:30 +00:00
Charles Kerr b86e1e1056 (trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below 2010-12-22 06:11:49 +00:00
Charles Kerr 42c2fccbfb (trunk gtk) remove dead code 2010-08-06 15:35:10 +00:00
Charles Kerr 83bdedec8e (trunk gtk) Remove the `PREF_KEY_MAIN_WINDOW_LAYOUT_ORDER' preferences key. This feature seemed like a good idea once upon a time, but I've never heard a report of anyone actually using it... 2010-08-06 06:22:05 +00:00
Charles Kerr 70be70d85f nice job. 2010-08-05 13:24:46 +00:00
Charles Kerr 65176f2b83 (trunk gtk) remove dead code 2010-07-30 22:21:14 +00:00
Charles Kerr e1607c8354 (trunk) #2898 "add pausing and deletion to daemon" -- committed patch from Longinus00 to trunk for 2.00 2010-03-17 19:23:03 +00:00
Charles Kerr 41d090b735 (trunk, gtk) rename the slightly-pejorative "minimal view" as "compact view" 2010-03-15 14:42:43 +00:00
Charles Kerr a334b422c3 (trunk) remove unnecessary #includes 2010-01-28 13:33:40 +00:00
Charles Kerr d9369718b3 (trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down 2009-12-16 18:20:01 +00:00
Charles Kerr ed6e95eef3 (trunk) add #include guards to prevent non-libtransmission files from #including implementation headers 2009-12-15 00:51:39 +00:00
Charles Kerr c7db82d48c (trunk gtk) #2597: add an optional "download complete" sound to the gtk client 2009-11-22 18:55:24 +00:00
Charles Kerr 3631a38e67 (trunk, gtk, qt) #2478: popup dialog for first-time users 2009-10-02 22:53:19 +00:00
Charles Kerr 9d87314eb0 (trunk gtk) #2478: popup dialog for first-time users 2009-10-02 21:03:55 +00:00
Charles Kerr 86ada18266 (trunk)
#1699: Announce to multiple trackers at once
#2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
Charles Kerr 61e95595b8 (trunk) move tr_lockfile from libtransmission/ to gtk/, since the gtk client is the only one who uses it anymore 2009-08-14 12:53:08 +00:00
Charles Kerr 3de46ad019 (trunk gtk) grr, I accidentally committed the Novell patch related to #2222. That's supposed to be a downstream patch for SuSE only. 2009-08-11 19:52:52 +00:00
Charles Kerr cb79214854 (trunk) remove trailing spaces 2009-08-10 20:04:08 +00:00
Charles Kerr 450cfb74af (trunk gtk) minor tweak: replace mkdir_p() with gtr_mkdir_with_parents() for symmetry with glib 2009-07-22 20:39:12 +00:00
Charles Kerr 859c1b6fff (trunk gtk) #2201: transmission doesn't remember maximized state 2009-06-11 22:36:45 +00:00
Charles Kerr 9238fb0299 (trunk) #2131: clean up benc read/write API 2009-06-02 01:48:48 +00:00
Charles Kerr 787ebbfab4 (trunk gtk) drop support for the gtk client's 0.80 config file. this format hasn't been used since September 2007 and it's not clear to me that the code works correctly anymore. 2009-06-01 17:24:12 +00:00
Charles Kerr 245108e7ec (trunk gtk) remember filtering mode between sessions 2009-04-10 04:22:57 +00:00
Charles Kerr 6373802ca8 better bool, real handling in (1) the gtk prefs interface, (2) the dictionary merge code, (2) the json parser 2009-04-05 23:46:53 +00:00
Charles Kerr 248a0c7fcb (trunk) change the bencode type enum to prevent OS-level collision 2009-04-05 18:02:11 +00:00
Charles Kerr f4557fab8e (trunk) use tr_bencDict{Find,Add}Bool() where appropriate 2009-03-29 23:05:32 +00:00