Commit Graph

107 Commits

Author SHA1 Message Date
Jordan Lee 287d61197a (trunk gtk) set GtkLabel's "single-line-mode" flag to TRUE in the toolbar, in the stats dialog, and in the details dialog's info tab.
According to the GTK+ documentation, this "can be an advantage in situations where resizing the label because of text changes would be distracting, e.g. in a statusbar." It doesn't seem to prevent relayout in GTK+ 2.20.1, but maybe other versions of GTK+ will make better use of the flag.
2011-01-21 17:31:35 +00:00
Jordan Lee acd941f17a (trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.

I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.

By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024 

However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
Jordan Lee aea77bc9f6 (trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.

There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
Jordan Lee 131afcc3a4 (trunk) #3926: use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed. 2011-01-20 19:48:13 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr e5bb3205a1 (trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :) 2010-12-27 19:18:17 +00:00
Charles Kerr f5b13c46dc (trunk gtk) #3847 "GTK+ 3 transition: Use accessor functions instead direct access" -- don't directly access GtkCellRenderer.xpad, GtkCellRenderer.ypad, or GtkWidget.window. 2010-12-24 09:04:52 +00:00
Charles Kerr 057487d18e (trunk gtk) more gtr_ naming cleanup 2010-12-22 06:25:30 +00:00
Charles Kerr 5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr 27a1b2dc33 (trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits 2010-12-12 16:43:19 +00:00
Charles Kerr 5d72e8b7f7 (trunk gtk) futz with the preferences dialog layout & terminology a little bit. steal a little back from qBittorrent. 2010-12-11 18:49:59 +00:00
Charles Kerr 0a64fd4b40 (trunk gtk) #3701 "Unblur statusbar icons" -- fixed. 2010-11-27 19:30:20 +00:00
Charles Kerr d57ba48775 (trunk) #3577 -- replace gear icon for GTK+, Qt clients 2010-09-24 15:22:53 +00:00
Charles Kerr c75c2c13e9 (trunk gtk) fix label clipping issue in the statusbar 2010-08-06 23:50:35 +00:00
Charles Kerr e934290980 (trunk gtk) portability: use g_dngettext() instead of ngettext() 2010-08-06 14:38:54 +00:00
Charles Kerr 92e989f553 (trunk gtk) experimentally remove sexy-icon-entry from the GTK+ client... GtkEntry can handle it now 2010-08-06 06:54:42 +00:00
Charles Kerr 83bdedec8e (trunk gtk) Remove the `PREF_KEY_MAIN_WINDOW_LAYOUT_ORDER' preferences key. This feature seemed like a good idea once upon a time, but I've never heard a report of anyone actually using it... 2010-08-06 06:22:05 +00:00
Charles Kerr 344e4bedc5 (trunk) set minimum widths for the upload/download labels in the statusbar 2010-07-31 06:20:17 +00:00
Charles Kerr 65176f2b83 (trunk gtk) remove dead code 2010-07-30 22:21:14 +00:00
Charles Kerr 52c04a0d06 (trunk) some units formatter cleanup. 2010-07-09 20:53:38 +00:00
Charles Kerr 42104d9a9b (trunk gtk) ensure that the space allocated the up/down speed labels in the statusbar are wide enough to show all speeds without truncating the label 2010-07-08 21:24:26 +00:00
Charles Kerr 6e5af03d78 (trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings 2010-07-04 06:07:21 +00:00
Charles Kerr cdcc4705aa (trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while. 2010-07-03 00:25:22 +00:00
Charles Kerr f097e05d7b (trunk gtk) add portability wrapper for gtk_widget_get_realized() in gtk+ < 2.20 2010-06-26 16:07:15 +00:00
Charles Kerr 01a10a2b6e (trunk gtk) #3346 "busy icon needed while processing request" -- added. 2010-06-26 15:55:19 +00:00
Charles Kerr e2b4933777 (trunk gtk) #3344 "statusbar needs better grouping of speeds and their icons" -- fixed 2010-06-25 20:15:05 +00:00
Charles Kerr 06f044680a (trunk) #3174 "Use IEC standard units (KiB, MiB, GiB) instead of (KB, MB, GB)" -- implemented for gtk, qt, daemon, cli, and web client 2010-04-28 01:26:46 +00:00
Charles Kerr 41d090b735 (trunk, gtk) rename the slightly-pejorative "minimal view" as "compact view" 2010-03-15 14:42:43 +00:00
Charles Kerr 824182df54 (trunk gtk) add favicon support to the new filterbar 2010-03-15 02:53:31 +00:00
Charles Kerr 2aa1e69f98 (trunk gtk) first draft of a filterbar experiment 2010-03-14 05:13:02 +00:00
Charles Kerr 40adcb5491 (trunk gtk) don't dereference a NULL pointer if a torrent has no "name" 2010-02-06 05:21:25 +00:00
Charles Kerr fa94830df1 (trunk gtk) remove a few very minor memory leaks in the GTK+ client 2010-01-11 21:54:54 +00:00
Charles Kerr 7af6abcee1 (trunk gtk) remove debugging message I accidentally left in the last commit 2010-01-10 02:19:08 +00:00
Charles Kerr 719446516d (trunk gtk) #2739 "the status bar oscillates ostensibly" -- implemented for 1.80 2010-01-10 01:43:04 +00:00
Charles Kerr ae6bdbae6e (trunk gtk) #2708 "missing tooltips" -- add previously-missing tooltips to two of the statusbar buttons 2010-01-03 17:38:24 +00:00
Charles Kerr 6b98510841 (trunk gtk) #2668 "minor memory leaks in gtk client" -- fix two GtkImages that were being leaked in the main window 2009-12-14 19:24:05 +00:00
Charles Kerr 4e252aa106 (trunk) fix warnings found by the clang static analyzer, reported & patched by wereHamster 2009-12-07 04:06:14 +00:00
Charles Kerr a8e11d9e3a (trunk gtk) #2616: "for the ratio mode button, use the yin/yang icon submitted by jimmac" 2009-11-27 14:55:52 +00:00
Charles Kerr 5e3949f37c (trunk gtk) #2110 "allow adding torrents with no trackers" - don't crash when sorting or filtering by tracker. (Reported by Rolcol and jch) 2009-11-26 04:06:49 +00:00
Charles Kerr c7741230af (trunk gtk) increase the temporary buffer size to avoid string truncations 2009-09-12 07:26:13 +00:00
Charles Kerr 7800e163f1 (trunk T) possible fix for gtk crash reported by Michael Stoykov 2009-09-11 23:43:42 +00:00
Charles Kerr bc6343f577 (trunk, gtk ) #2361: Turtle toggle button is not visible using old GTK 2.6.x library 2009-08-29 14:07:51 +00:00
Charles Kerr 9101f64684 (trunk gtk) #2339: set "is-important" property of some toolbar actions in preparation for gnome 2.28 <http://blogs.gnome.org/thos/2009/07/29/toolbar-styles/> 2009-08-16 03:09:06 +00:00
Charles Kerr e339aab7c7 (trunk gtk) fix r8900 oops 2009-08-15 22:11:54 +00:00
Charles Kerr be3f3a617e (trunk gtk) fix minor regression in #2292 that limited the gtk client's speed display to not count fractions-of-a-KiB/s 2009-08-12 13:42:49 +00:00
Charles Kerr cb79214854 (trunk) remove trailing spaces 2009-08-10 20:04:08 +00:00
Charles Kerr 1083535d9b (trunk gtk) fix #2292: wrong speed in bottom bar 2009-08-07 20:49:06 +00:00
Charles Kerr 58ba65f55b (trunk, gtk/qt) use Monsoon's strings for encryption preferences and Deluge's system tray tooltip. 2009-06-30 18:08:50 +00:00
Charles Kerr bd5c9cf3a8 (trunk gtk) #2251: gtk client should use GDK-safe versions of g_idle_add() and g_timeout_add*() 2009-06-29 17:22:35 +00:00
Charles Kerr 0861ca3908 (trunk gtk,qt) more o/c simplification of the prefs dialog 2009-06-27 05:23:13 +00:00