Commit Graph

13421 Commits

Author SHA1 Message Date
Rahim Nathwani 79833abdf1
Update README with missing 'cd build' command 2018-07-28 15:38:25 -07:00
Tom Richards 8a67a8cb5d Check return value of localtime
Dereferencing this value before checking it may result in a null
pointer dereference (segfault)
2018-05-05 10:25:12 -04:00
Mike Gelfand c11f2870fd Fix CMake-based build on Mac after 2.9x merge 2018-05-01 23:22:05 +03:00
Mike Gelfand c951848a5b Merge branch '2.9x' 2018-05-01 22:44:51 +03:00
Mike Gelfand d8e60ee44f Bump version, update news 2018-05-01 20:18:29 +03:00
Mike Gelfand c89cce792d
Merge pull request #593 from userwithuid/fixcurltls
fix logic for setting the curl ca bundle file
2018-04-25 09:57:34 +01:00
userwithuid 873006c373 fix logic for setting the curl ca bundle file
we do not want to delete the system default by setting this to NULL...
2018-04-25 08:21:50 +00:00
userwithuid 8c160aad2d cmake: replace intltool with gettext
requires gettext 0.19.7 or higher
2018-04-18 09:25:13 +00:00
Zachary J. Slater f388d17c2d Updated copyright string to 2018
Small update to copyright string
2018-04-17 00:50:33 -10:00
Mike Gelfand 913d9d3f37 HTML-escape torrent name displayed in trackers inspector tab
This will prevent injection of arbitrary HTML when multiple torrents are
selected. Follow-up to the previous commit.
2018-04-17 13:25:49 +03:00
Mike Gelfand 523d8c1317 Tracker error XSS in inspector (web client)
Tracker error messages are inadequately output encoded when rendered by the
tracker information page inside the WebUI, allowing a malicious tracker to
inject an XSS payload into the page. Esploiting this issue allows an
attacker to supply arbitrary client-side code that will ultimately be
rendered and executed within the end user's web browser.

Found by Rory McNamara (Gotham Digital Science). CVE pending.
2018-04-17 13:25:49 +03:00
Mike Gelfand 69d9afd75a Adjust CFBundleVersion format to fix Sparkle update check
Set the first version component to be the same as the last Subversion-based
release build version and add two more components (major and minor version
numbers). To allow for nightly build updates this should probably include
another component (e.g. build timestamp), but we're not there yet.
2018-04-17 13:25:49 +03:00
geertjan cc0b931431 Fix setting the ETA timestamps
Field etaDLSpeedCalculatedAt was set too early, causing the condition
following it to always be false. The same for etaULSpeedCalculatedAt.
2018-04-06 22:52:29 +03:00
Mike Gelfand 444f15edf8
Merge pull request #522 from gjalsem/master
Fix setting the ETA timestamps
2018-04-06 22:49:27 +03:00
dubhater 85c0399d8c Qt: Fix bad downloaded percentage in DetailsDialog
It was always 0.0% as long as the torrent was not finished.
2018-04-06 22:47:11 +03:00
Mike Gelfand 0b5ec3a00d
Merge pull request #547 from dubhater/patch-6
Qt: Fix bad downloaded percentage in DetailsDialog
2018-04-06 22:44:54 +03:00
Mike Gelfand ab4d707305
Merge pull request #528 from neheb/patches
Fix compile errors for 2.9x
2018-04-06 22:34:11 +03:00
Bernard Spil 06a1644e29 Fix build with LibreSSL 2.7
LibreSSL 2.7 adds OpenSSL 1.1 API

See also: https://bugs.freebsd.org/226953
Signed-off-by: Bernard Spil <brnrd@FreeBSD.org>
2018-04-06 22:17:41 +03:00
Niklas Haas 11d29ff62d LibreSSL compatibility
This seems to be the idiomatic way to fix libressl compatibility issues,
judging by what most other open source projects seem to be doing.

I've confirmed that transmission builds with libressl for me after this
patch is applied.
2018-04-06 22:16:26 +03:00
Mike Gelfand 9d96f87ec3 Fix coding style and building with !TR_LIGHTWEIGHT 2018-04-06 22:15:22 +03:00
Mike Gelfand 11f1d46e1b
Merge pull request #570 from Sp1l/master
Fix build with LibreSSL 2.7
2018-04-06 22:03:24 +03:00
Bernard Spil bdffe25b42 Fix build with LibreSSL 2.7
LibreSSL 2.7 adds OpenSSL 1.1 API

See also: https://bugs.freebsd.org/226953
Signed-off-by: Bernard Spil <brnrd@FreeBSD.org>
2018-04-01 22:39:09 +02:00
dubhater e19ab0b7a9
Qt: Fix bad downloaded percentage in DetailsDialog
It was always 0.0% as long as the torrent was not finished.
2018-03-08 14:12:52 +02:00
Mike Gelfand b21a6140e9 Fix FTCBFS due to AC_RUN_IFELSE (patch by Helmut Grohne)
Fixes: #475
2018-02-23 20:49:14 -08:00
Mike Gilbert 357cccb9cf cmake: link against libmbedcrypto if available
In recent versions of mbed TLS, several symbols are moved to
libmbedcrypto.

Fixes: https://github.com/transmission/transmission/issues/115
2018-02-23 20:48:14 -08:00
Mike Gelfand 4d5fe6ede9 Add support for mbedtls (formely polarssl) 2018-02-23 20:46:39 -08:00
Mike Gelfand cefd8a3149 Bump version to 2.93+, fix NEWS date 2018-02-22 23:44:19 +03:00
geertjan 23e469a6b2 Fix setting the ETA timestamps
Field etaDLSpeedCalculatedAt was set too early, causing the condition
following it to always be false. The same for etaULSpeedCalculatedAt.
2018-02-19 21:06:34 +01:00
Mike Gelfand 96926a8337 Update DHT library to 0.25
Fixes: #508
2018-02-10 11:35:14 +03:00
Mike Gelfand 896de2b593
Merge pull request #500 from michaelskree/null-terminate
Ensure buffer contents are null-terminated
2018-02-03 23:27:29 +03:00
Michael Skree 663c4532f0 Ensure buffer contents are null-terminated
Data added with `evbuffer_add` isn't null-terminated. This was causing
extra characters to appear at the end of the output.

Fixes: #174
2018-02-03 13:45:44 -06:00
Mike Gelfand 991f066618 Fix progress bar width with Breeze style (Qt client)
In compact torrents view, use BAR_WIDTH as groove area width instead of
total progress bar width, to improve the appearance in case progress text
is drawn outside of the groove area (because of style settings).

Initial patch provided by dubhater.

Fixes: #491
2018-02-03 22:36:54 +03:00
Mike Gelfand ee259c617f Fix some leaks in tr-remote reported by GCC's sanitizer 2018-02-03 12:39:24 +03:00
Mike Gelfand 30a6a3244a
Merge pull request #494 from dubhater/patch-1
Qt: Fix assert with one-letter root folder names
2018-02-03 11:44:33 +03:00
Mike Gelfand 2c15ca024c
Merge pull request #495 from neheb/patch-1
Set compression to curl defaults
2018-02-03 11:27:43 +03:00
Rosen Penev a3ef28bd68 Set compression to curl defaults
While zlib is mandatory for transmission, it is not mandatory for curl.

A libcurl that has been compiled with no support for zlib will return no data if compressed responses are set to on.

In the basic case this prevents the port checking functionality from working properly. It also prevents web seeding from working as well.
2018-01-31 20:59:01 -08:00
dubhater 1e850cd874
Qt: Fix assert with one-letter root folder names
An assertion failure happens shortly after opening the
"Torrent properties" dialog if the torrent's root folder has
a one-letter name, e. g.
A/
A/Some Linux distro.iso
A/Some other Linux distro.iso

Off by one errors are great, eh?

This fixes https://trac.transmissionbt.com/ticket/6141
2018-01-30 23:44:12 +02:00
Mike Gelfand 7669c97e12
Merge pull request #57 from Teteros/update-wiki-links
Update migrated wiki links in man pages
2018-01-26 08:38:14 +03:00
Mike Gelfand d86bd614bf Fix FTCBFS due to AC_RUN_IFELSE (patch by Helmut Grohne)
Fixes: #475
2018-01-26 08:31:16 +03:00
Mike Gelfand 6903f24ea8 Use `magick convert` instead of `convert`
This adjusts to the new ImageMagick command naming (way to go,
GraphicsMagick had this from the beginning) and avoids confusion with
same-named windows utility which serves completely different purpose.
2018-01-26 07:56:11 +03:00
Mike Gelfand 94be7dbd9b Merge branch '2.9x' 2018-01-25 03:07:52 +03:00
Mike Gelfand 4b6529d883 Don't crash if path passed to tr-create doesn't exist 2018-01-24 23:45:13 +03:00
Mike Gelfand 3106675261 Fix UNC paths resolution on Windows
While resolved paths always contain the	`\\?\` prefix, it's not	always
correct	to strip only those 4 chars. In	case of	UNC paths, the prefix
is actually a bit longer (`\\?\UNC\`) and needs	to be replaced with `\\`
instead.

Failing	to do so results in invalid paths, e.g.	`\\Host\Share\File` becomes
`UNC\Host\Share\File` which totally wrong.
2018-01-24 23:45:08 +03:00
Mike Gelfand 6da6629887 Add unit tests uncovering improper UNC paths resolution
While resolved paths always contain the `\\?\` prefix, it's not always
correct to strip only those 4 chars. In case of UNC paths, the prefix
is actually a bit longer (`\\?\UNC\`) and needs to be replaced with `\\`
instead.

Failing to do so results in invalid paths, e.g. `\\Host\Share\File` becomes
`UNC\Host\Share\File` which totally wrong.
2018-01-24 23:12:17 +03:00
Mike Gelfand 3c5870d4f5 Use `head` instead of bash extension to get revision substring 2018-01-23 22:14:01 +03:00
Mike Gelfand 7f008edab6 Improve version.h file generation
Store full revision hash in REVISION file. Write fixes 10 chars of revision
hash to version.h. Use `#pragma once` in version.h. Support getting revision
from TeamCity environment variable (similar to Jenkins).
2018-01-23 21:59:09 +03:00
Mike Gelfand f6b23c02f0 Don't search for SVN revision when calculating version 2018-01-23 21:58:50 +03:00
Mike Gelfand b875e79f3d Replace SVN and SCM with VCS everywhere 2018-01-23 21:58:33 +03:00
Mike Gelfand b237a260c5 Try getting SVN revision from Jenkins environment when using CMake (copy logic from update-version-h.sh) 2018-01-23 21:57:52 +03:00
Mike Gelfand 99c9b90965 Fix memory leak in `tr_dhtInit` in failure condition
Fixes: #482
2018-01-23 21:20:30 +03:00