mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-02-22 06:00:41 +00:00
Code Issues Releases Wiki Activity
13547 commits 50 branches 124 tags 154 MiB
Commit graph

1739 commits

Author SHA1 Message Date
Mike Gelfand
8f3cb1c68d Wrap sizeof arguments in braces 2017-05-20 19:29:23 +03:00
Mike Gelfand
7a1a1acd22 Fix autotools build 2017-05-17 00:56:39 +03:00
Mike Gelfand
ef8cb30f7c Merge pull request #224 from wjt/appdata 
gtk: add AppData file
 2017-05-16 23:13:25 +03:00
Mike Gelfand
1e3d20422a Reduce for loop variables scope 2017-05-14 01:38:31 +03:00
Will Thompson
23d61b6457
gtk: add AppData file 
This file was originally written by Richard Hughes, for Fedora, who
proposed it on the Transmission forum here:
https://forum.transmissionbt.com/viewtopic.php?f=3&t=16443

It's used to display a nice description and screenshot in GNOME
Software. The format is documented here:
https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html

The <_name/> and <_summary/> fields match the Name= and Comment= fields
in the .desktop file so are already translated.

The screenshot is taken with Transmission 2.92 (14714) on Fedora 25.
It's at one of the sizes recommended by the GNOME Shell Screenshot
Window Sizer extension.

The <update_contact/> is based on the Git history.
 2017-05-03 17:43:23 +01:00
Mike Gelfand
b99fb6f07a Add queue up/down hotkeys (GTK+ client) 2017-05-01 18:58:27 +03:00
Mike Gelfand
14370e5353 Fix a number of other style inconsistencies met along the way (part 2) 2017-05-01 18:47:49 +03:00
Mike Gelfand
e1d53855f4 Avoid declaring multiple variables on the same line 2017-05-01 18:46:41 +03:00
Mike Gelfand
fbd8d4c79f Fix a number of other style inconsistencies met along the way 2017-04-30 19:33:55 +03:00
Mike Gelfand
a762c770f2 Make conditional expressions explicitly boolean 2017-04-30 19:26:01 +03:00
Mike Gelfand
4f9d9ad92b Code style change leftovers 
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
 2017-04-21 10:40:57 +03:00
Mike Gelfand
dadffa2c0f Align type qualifiers to the right (code style) 
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
 2017-04-20 19:53:20 +03:00
Mike Gelfand
d7930984ef Adjust uncrustify config, reformat all but Mac client 
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
 2017-04-20 10:01:22 +03:00
Mike Gelfand
ecd1eb7914 Update file icon when its name changes in details dialog (GTK+ client) 
Additionally, make main window redraw the torrent so that new name and icon
are visible right away.
 2017-02-21 23:21:25 +03:00
Piotr Drąg
297c734c0b Add Keywords to the .desktop file 
It's a part of the Desktop Entry Specification [1] and it's used by,
among others, the search system in GNOME 3.

The comment is there to hopefully minimize the chance of translators
making a mistake that could potentially break build.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
 2017-01-29 01:13:53 +01:00
Piotr Drąg
5cefddeaee Remove X-GNOME-FullName from the .desktop file 
It's a GNOME-specific hack for the 2.x era menu system that was never
standardized in [1] and is now unused in GNOME 3.

[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
 2017-01-28 23:52:32 +01:00
Mike Gelfand
5f3abbd6d8 Add myself to the list of Transmission authors 2017-01-15 01:38:45 +03:00
Markus Amalthea Magnuson
5b9ba3be0d HTTPS links for trac, forum, portcheck, and build subdomains. 2016-11-02 20:50:22 +01:00
Markus Amalthea Magnuson
727b9671f7 Update all website links to canonical HTTPS version. 2016-10-31 10:00:11 +01:00
Robert Vehse
13bae8179e Update all instances of the donation link. Fixes #26. 2016-09-23 04:36:41 +02:00
Mike Gelfand
2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Jordan Lee
1af60ad6ad use '#pragma once' instead of #ifndef..#define..#endif guards 2016-03-29 16:37:21 +00:00
Mike Gelfand
c955c04d8f Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean 2016-03-13 22:11:01 +00:00
Mike Gelfand
197fc132b3 Update user-facing copyright years 2016-02-27 23:18:02 +00:00
Mike Gelfand
495e9b2fa0 Load icons with GResource, remove deprecated inline pixbufs 2016-02-23 04:34:57 +00:00
Mike Gelfand
939b31ae3d #6051: transmission-gtk --version shouldn't require display 2016-01-09 18:06:17 +00:00
Mike Gelfand
13a98a02b8 Use TR_BAD_SIZE instead of -1 in tr_quark_new() calls 
Extend quark test to improve branch coverage.
 2016-01-07 19:20:14 +00:00
Mike Gelfand
4f266a5b15 Optimize URL-parsing functions a bit; rewrite tr_urlParse() 2015-12-28 23:52:26 +00:00
Mike Gelfand
4a4badd4af Ongoing refactoring (use size_t instead of int) 2015-12-25 10:19:50 +00:00
Mike Gelfand
bfc336614e Add libevent include directories to GTK+ client 2015-12-12 18:46:39 +00:00
Jordan Lee
b559a20029 const correctness 
silence some qual-cast warnings by sprinkling more consts throughout,
e.g. casting a const void* to a const struct foo * const *
 2015-12-06 22:13:10 +00:00
Jordan Lee
f3cebc6663 link transmission-gtk against libappindicator if necessary 2015-12-06 16:12:27 +00:00
Mike Gelfand
88983c1ac1 Use tr_sys_path_remove instead of remove 2015-10-23 04:09:40 +00:00
Mike Gelfand
f89fab72f9 Remove unused session tag 2015-10-18 18:39:14 +00:00
Mike Gelfand
18ea8c429a Improve RPC performance for local sessions 
Don't unnecessarily de-/serialize JSON data if local session is used.
 2015-07-13 00:32:48 +00:00
Mike Gelfand
2e6d5c8bc9 Add more booleans to the picture 2015-05-31 22:13:31 +00:00
Mike Gelfand
cdf3cf62f9 Fix some issues revealed by coverity 2015-05-09 11:56:35 +00:00
Mike Gelfand
2321bc3fad Fix some issues revealed by coverity 2015-05-09 08:37:55 +00:00
Mike Gelfand
363069ff97 #5930: Fix style of Gtk+3.16 overshoot and undershoot (patch by nagisa) 2015-05-03 10:30:35 +00:00
Mike Gelfand
06d73853b9 Even better (and unified) torrent origin logic for GTK+, Qt and web clients 2015-04-22 21:04:49 +00:00
Mike Gelfand
829cbffaf7 Add version info to executables (on Windows). Group projects into folders (CMake). 2015-04-14 22:46:40 +00:00
Mike Gelfand
c7d2a7f959 #4400: Add CyaSSL support 2015-01-07 02:04:08 +00:00
Mike Gelfand
c43a10ab9d Mark GTK and Qt clients as GUI programs on Windows (detach from console) 2015-01-04 10:57:09 +00:00
Mike Gelfand
440f482d01 Replace tabs with spaces; remove trailing spaces 2015-01-02 11:15:31 +00:00
Mike Gelfand
b928ae1ba8 Use libb64 instead of OpenSSL to encode/decode BASE64 
Some crypto libraries (like CyaSSL, MatrixSSL and CommonCrypto) either
don't have or expose this functionality at all, expose only part of it,
or (like OpenSSL) have heavyweight API for it. Also, for the task as
easy as BASE64 encoding and decoding it's much better to use small and
simple specialized library.
 2015-01-01 21:16:36 +00:00
Mike Gelfand
83c4edb008 #5828: Initial CMake build system support 2014-12-01 19:55:22 +00:00
Jordan Lee
b325bc0a16 (trunk) #5759 compilation error, undefined reference to sqrt 2014-08-20 17:14:17 +00:00
Jordan Lee
ab24ef9fcb use pkg-config to get the zlib cflags/libs; remove obsolete zlib.m4 macro 2014-07-13 21:54:56 +00:00
Jordan Lee
0323639e57 (trunk, libT) #4160 'foreign character support' -- merge mike.dld's 4160-02b-path.patch, which updates the codebase to use the new tr_sys_path_*() portability wrappers introduced in 4160-02a 2014-07-08 00:08:43 +00:00
Jordan Lee
d7368a58f5 Copyedit the license's revised text: (1) fix accidental word concatenations in the Qt and GTK+ clients' license popup text 2014-01-21 03:15:33 +00:00
Jordan Lee
02cff80c2d Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text 2014-01-21 03:10:30 +00:00
Jordan Lee
5f2daaafb3 (trunk, gtk/qt/web) #5581: 'Inconsistent ordering of Upload and Download speed limits' -- fixed. 2014-01-20 23:56:06 +00:00
Jordan Lee
bf85441aab remove '-DGTK_DISABLE_DEPRECATED' for now; we'll migrate from GtkUIManager to GtkBuilder in transmission-gtk 2.90 2014-01-20 21:30:41 +00:00
Jordan Lee
4b9626bb83 Licensing changes: 
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed

2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)

3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
 2014-01-19 01:09:44 +00:00
Jordan Lee
4904b923fb (trunk) restore copyright year as suggested in email by rms 2014-01-18 20:56:57 +00:00
Jordan Lee
4c8bda8805 function pointer type correctness. mikedld 2013-09-08 17:08:18 +00:00
Jordan Lee
28fe36f1f8 #include limits.h where we use it, and don't where we don't 2013-08-24 17:53:45 +00:00
Jordan Lee
229f9e5ae6 (trunk, gtk) #5450: in transmission-gtk's main.c::on_app_exit(), check to see if shutdown's already been initiated so that we don't call tr_sessionClose() twice. 2013-08-05 02:39:30 +00:00
Jordan Lee
33795457b1 (trunk, gtk) #5032 'gobject warning' -- fix typo introduced in r14144 2013-07-27 18:20:32 +00:00
Jordan Lee
14c0256861 (trunk, gtk) #5032 'gobject warning when updating blocklist from URL' -- fixed with patch from fanatid 2013-07-24 17:20:21 +00:00
Jordan Lee
16ab373503 (trunk gtk) #5320 'can't opena folder with '#' in its name': in gtr_open_file(), use g_file_new_for_path(). 2013-07-24 17:11:21 +00:00
Jordan Lee
cc1b1cd430 since Transmission supports older versions of glib, add a portability wrapper for G_DEFINE_QUARK 2013-07-24 00:13:31 +00:00
Jordan Lee
6a47b4a5d3 don't use a '-' character in the QN argument to G_DEFINE_QUARK. https://forum.transmissionbt.com/viewtopic.php?p=65548#p65548 2013-07-22 23:00:10 +00:00
Jordan Lee
f83ff36cd5 (trunk gtk) use G_SOURCE_REMOVE where appropriate 2013-07-20 16:37:59 +00:00
Jordan Lee
7cbb20279b use consistent code indentation/whitespace in open dialog, file list, and set location dialog 2013-07-20 16:19:15 +00:00
Jordan Lee
2d6ace29ba (trunk, gtk) #5430: periodic update timer in 'Torrent > Set Location...' should be cleared immediately when dialog is closed. 2013-07-20 15:55:29 +00:00
Jordan Lee
94fd3b486b (trunk) slightly better image compression by passing them through pngwolf 2013-07-14 23:03:31 +00:00
Jordan Lee
d244545979 use G_DEFINE_QUARK instead of rolling our own quark getters 2013-07-09 22:44:24 +00:00
Jordan Lee
7f9f86c55a fix a minor GAppInfo memory leak in transmission-gtk 2013-07-08 19:34:58 +00:00
Jordan Lee
59af132947 replace deprecated gtk_icon_info_free() calls with g_object_unref() in GTK+ >= 3.8.0 2013-07-08 16:25:18 +00:00
Jordan Lee
59f27cc1c6 remove the ShowOnlyIn=Unity desktop entries. These were from bug #4804 as an interim measure until XDG action groups were more widely supported, and can be removed. 2013-07-02 21:20:33 +00:00
Jordan Lee
a95b6c1e6c (trunk) #5382: better compression of our bundled png files. recompressed by Mangix 2013-06-26 02:06:43 +00:00
Jordan Lee
beeb4d3b77 (trunk, gtk) minor fix to tr_prefs_init_default() -- avoid redundant calls to g_get_user_special_dir 2013-06-12 00:22:41 +00:00
Jordan Lee
027e3f3066 (trunk, libT) #4682 'Add return id from duplicate torrent torrent-add rpc' -- added. 2013-05-22 20:35:38 +00:00
Jordan Lee
96786b7fa1 (trunk) update web.h's API s.t. there's an explicit function to use when downloading webseed content. 2013-04-13 20:25:28 +00:00
Jordan Lee
c51132ad78 #5335: better compression of .png files by Mangix 2013-04-10 02:27:42 +00:00
Jordan Lee
0abb762ed5 segfault when opening prefs dialog in gtk+ 3.8.0 2013-04-10 02:12:19 +00:00
Jordan Lee
d1571bda02 (gtk) use replace strcmp() with g_strcmp0() everywhere 2013-02-14 15:17:42 +00:00
Jordan Lee
76a3b116f0 use g_strcmp0() instead of strcmp() to guard against corrupt settings in the config file 2013-02-10 23:06:05 +00:00
Jordan Lee
90b95697e0 (gtk) #5284 'file tree should show the wanted size of the subtree, not the entire size': done. 2013-02-09 19:28:38 +00:00
Jordan Lee
cd09204a6e (trunk) first draft of changing the FreeSpace API to behave as https://trac.transmissionbt.com/ticket/4076#comment:25 -- libT, rpc, qt, and gtk implementations. 2013-02-09 04:05:03 +00:00
Jordan Lee
d76d2a34d9 (gtk) match transmission-qt's way of showing up & down speeds in the statusbar 2013-02-08 01:34:59 +00:00
Jordan Lee
445609f690 (trunk) prefer tr_remove() to unlink() or rmdir() 2013-02-04 21:53:19 +00:00
Jordan Lee
1a768ab06f (gtk) #5271 'once we start shutting down the application, stop updating the Action states': more safeguards 2013-02-04 18:34:39 +00:00
Jordan Lee
2e251f73cb (gtk) #5246 'problems when incomplete-dir is a subdirectory of download-dir': change the file chooser API calls, based on suggestion from kraai 2013-02-04 16:51:52 +00:00
Jordan Lee
0c8c2b5bdd (gtk) #5271 'once we start shutting down the application, stop updating the Action states': fixed 2013-02-04 16:11:08 +00:00
Jordan Lee
1c90e929d1 (gtk) #4076 'free space indicator': tweak the GTK+ client's visible count label's behavior as the previous commit did for the Qt client 2013-02-02 23:01:33 +00:00
Jordan Lee
085c37584e #4076 'free space indicator': in the Qt and GTK+ clients, add 'Free' to the freespace labels to give more context of what the number means 2013-02-01 21:02:40 +00:00
Jordan Lee
16d46a72a1 in the Qt and GTK+ clients, move the torrent count indicator from the statusbar to the filterbar 2013-02-01 20:58:55 +00:00
Jordan Lee
69f3e31230 (libT) change the API signature for tr_torrentVerify() s.t. client code can be notified when the verify is finished 2013-01-31 21:58:25 +00:00
Jordan Lee
a4bbceb483 fix r13896 oops 2013-01-30 00:28:53 +00:00
Jordan Lee
20fe66bccf more experimentation with the shortTransferString 2013-01-30 00:22:52 +00:00
Jordan Lee
4a059b79b8 when sorting by activity and both torrents' upload and download speed is zero, use how many peers we're ready to upload to / download from as a secondary key. 2013-01-30 00:20:51 +00:00
Jordan Lee
1d3bf93618 synchronize the Qt and GTK+ client's statusbars, including the new freespace indicator. Make the up/down speed ordering consistent between statusbar and torrent list. 2013-01-27 23:05:47 +00:00
Jordan Lee
f75027d5e9 make all the log functions/structs/enums use a single 'tr_log' namespace, such as tr_logGetQueue, tr_logAddInfo, tr_logIsLevelActive 2013-01-25 23:34:20 +00:00
Jordan Lee
29d6f5d934 (gtk) #5190 'Add borders instead of shadow on scrolled window': fixed, patch by nagisa 2013-01-21 17:05:55 +00:00
Jordan Lee
dc42791380 (gtk) remember to clear out the error pointer 2013-01-21 03:18:44 +00:00
Jordan Lee
6002ffdc37 (gtk) #5235 'Plural wrong in torrent-cell-renderer' -- fix with patch by RamsesDeNorre 2013-01-21 00:15:21 +00:00
Jordan Lee
5093f99652 (gtk) silence a couple of potential GFileInfo console warnings 2013-01-20 04:10:47 +00:00
Jordan Lee
03ac81e7c7 (trunk) #1220 'change top folder names' -- add file-renaming to the GTK+ GUI 2013-01-19 08:44:23 +00:00