Mike Gelfand
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
Mike Gelfand
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
Mike Gelfand
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
Mike Gelfand
495e9b2fa0
Load icons with GResource, remove deprecated inline pixbufs
2016-02-23 04:34:57 +00:00
Mike Gelfand
13a98a02b8
Use TR_BAD_SIZE instead of -1 in tr_quark_new() calls
...
Extend quark test to improve branch coverage.
2016-01-07 19:20:14 +00:00
Jordan Lee
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
Jordan Lee
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
Jordan Lee
76a3b116f0
use g_strcmp0() instead of strcmp() to guard against corrupt settings in the config file
2013-02-10 23:06:05 +00:00
Jordan Lee
ff3a6df7a6
silence console warnings when fallback icons can't be found
2012-12-27 17:49:52 +00:00
Jordan Lee
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
Jordan Lee
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
Jordan Lee
631a77287d
(trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…).
2012-02-03 15:51:36 +00:00
Jordan Lee
0e48418f26
(trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010).
2011-08-07 18:41:13 +00:00
Jordan Lee
270126820a
(trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency
2011-08-07 16:42:38 +00:00
Jordan Lee
307754e807
#671 "torrent queuing" -- modify the queue implementation s.t. every torrent has a queuePosition, even if it's not currently in the queue.
2011-08-02 03:59:54 +00:00
Jordan Lee
61174b007e
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
Jordan Lee
4a15899499
(trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer.
2011-04-12 11:13:41 +00:00
Jordan Lee
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
Jordan Lee
a63fdd15b4
(trunk) #3926 "use 'Open Torrent' instead of 'Add Torrent' in GTK+ and Qt clients" -- fix accelerator ambiguity.
...
Using Ctrl-O for "Open File" causes a conflict with the existing Ctrl-O for "Open Folder." The HIG-compliant shortcut wins the conflict, so "Open Folder" gets a new accelerator.
2011-01-20 20:32:28 +00:00
Jordan Lee
7dd9427a1f
(trunk gtk) #3909 -- don't use Ctrl-M as the shortcut for "Copy Magnet Link to Clipboard."
2011-01-20 20:07:09 +00:00
Jordan Lee
131afcc3a4
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed.
2011-01-20 19:48:13 +00:00
Jordan Lee
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
Charles Kerr
057487d18e
(trunk gtk) more gtr_ naming cleanup
2010-12-22 06:25:30 +00:00
Charles Kerr
5eafe91824
(trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately.
2010-12-21 19:20:58 +00:00
Charles Kerr
5d72e8b7f7
(trunk gtk) futz with the preferences dialog layout & terminology a little bit. steal a little back from qBittorrent.
2010-12-11 18:49:59 +00:00
Charles Kerr
d57ba48775
(trunk) #3577 -- replace gear icon for GTK+, Qt clients
2010-09-24 15:22:53 +00:00
Charles Kerr
43f03f3de6
remove sort-by-tracker from the GTK+ client
2010-09-06 00:23:44 +00:00
Charles Kerr
fb03acbbc2
(trunk) consistency tweaks between the GTK+ and Qt client:
...
1. synchronize some of the keyboard shortcuts
2. synchronize some text in the preferences dialog
3. add a "Desktop" tab in the Qt client's preferences dialog
4. add a "Donate" button to the Qt client's help menu
2010-08-02 03:07:42 +00:00
Charles Kerr
dba6e3a1e7
(trunk gtk) #3179 "GTK+ Client should use the 24-pixel-wide icon in the system tray" -- fixed in trunk for 2.00
2010-04-29 15:39:29 +00:00
Charles Kerr
c8ba63ca07
(trunk gtk) #3146 "Toggle state of 'toggle-main-window' not updated when window is shown after launch with running instance" -- fixed in trunk for 2.00 by a patch from qense
2010-04-17 00:41:24 +00:00
Charles Kerr
41d090b735
(trunk, gtk) rename the slightly-pejorative "minimal view" as "compact view"
2010-03-15 14:42:43 +00:00
Charles Kerr
67b9c83df5
(trunk gtk) #2780 "for themability, T needs unique icon names for window, system tray, and popup icons" -- added to trunk for 1.81
2010-01-21 20:51:48 +00:00
Charles Kerr
9ec94bc91f
(trunk gtk) HIG: reorganize the menu items in the tray icon
2010-01-14 07:03:29 +00:00
Charles Kerr
5c26afdb52
happy new year!
2010-01-04 21:00:47 +00:00
Charles Kerr
78ead8c3dd
(trunk) update the copyright notices
2009-12-05 02:19:24 +00:00
Charles Kerr
a87c15b389
(trunk gtk) #2625 : "ability to create a manget link" -- remove the magnet link from the properties dialog; add a "Copy _Magnet Link to Clipboard" menu & context menu item instead
2009-11-29 18:23:06 +00:00
Charles Kerr
52699591dc
(trunk gtk) the Torrent menu's getting crowded... split it into File and Torrent
2009-11-29 07:41:13 +00:00
Charles Kerr
a8e11d9e3a
(trunk gtk) #2616 : "for the ratio mode button, use the yin/yang icon submitted by jimmac"
2009-11-27 14:55:52 +00:00
Charles Kerr
bda3103740
(trunk gtk) #2556 : in GTK+ client's menu, rename "Add.." as "Add File..." for symmetry with "Add URL..."
2009-11-24 16:14:59 +00:00
Charles Kerr
c06d889269
(trunk gtk) #2556 : add a torrent from a URL. works from the menu and from URLs passed in the command line at startup
2009-11-22 16:20:22 +00:00
Charles Kerr
149f8c90d8
(trunk gtk) add a Donate item to the Help menu
2009-09-10 17:39:44 +00:00
Charles Kerr
07d1773bbd
(trunk gtk) revise r8945 to compile OK on gtk < 2.16
2009-08-16 03:25:58 +00:00
Charles Kerr
9101f64684
(trunk gtk) #2339 : set "is-important" property of some toolbar actions in preparation for gnome 2.28 < http://blogs.gnome.org/thos/2009/07/29/toolbar-styles/ >
2009-08-16 03:09:06 +00:00
Charles Kerr
f4ab711517
(trunk gtk,qt) #2264 : Duplicate keyboard accelerators in the GTK+ client's "View" menu
2009-07-03 20:10:05 +00:00
Charles Kerr
36eac9e36a
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
