1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-30 19:46:56 +00:00
Commit graph

55 commits

Author SHA1 Message Date
Mike Gelfand
e1d53855f4 Avoid declaring multiple variables on the same line 2017-05-01 18:46:41 +03:00
Mike Gelfand
4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand
dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand
d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand
2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Jordan Lee
02cff80c2d Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text 2014-01-21 03:10:30 +00:00
Jordan Lee
4b9626bb83 Licensing changes:
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed

2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)

3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee
4904b923fb (trunk) restore copyright year as suggested in email by rms 2014-01-18 20:56:57 +00:00
Jordan Lee
10b96f0f12 (gtk) copyediting: update several files to be closer to the gtk+ indentation style. 2013-01-04 19:45:39 +00:00
Jordan Lee
2a52ebab20 (gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate 2013-01-04 16:36:52 +00:00
Jordan Lee
61bc1eabd6 fewer redundant gobject dynamic casts 2012-12-13 03:00:57 +00:00
Jordan Lee
3d38723ad9 Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00
Jordan Lee
cdd71c6427 (trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2 2012-07-14 19:26:55 +00:00
Jordan Lee
b5de483362 (trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places. 2011-08-13 21:08:53 +00:00
Jordan Lee
6d1869c33b remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped. 2011-08-08 17:06:46 +00:00
Jordan Lee
45bdc18210 (trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761 2011-05-02 17:58:27 +00:00
Jordan Lee
0a62f69f1c (trunk gtk) copyediting. 2011-03-04 15:49:51 +00:00
Jordan Lee
c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee
287d61197a (trunk gtk) set GtkLabel's "single-line-mode" flag to TRUE in the toolbar, in the stats dialog, and in the details dialog's info tab.
According to the GTK+ documentation, this "can be an advantage in situations where resizing the label because of text changes would be distracting, e.g. in a statusbar." It doesn't seem to prevent relayout in GTK+ 2.20.1, but maybe other versions of GTK+ will make better use of the flag.
2011-01-21 17:31:35 +00:00
Jordan Lee
aea77bc9f6 (trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.

There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
Jordan Lee
879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr
e5bb3205a1 (trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :) 2010-12-27 19:18:17 +00:00
Charles Kerr
0a160aec49 (trunk gtk) GTK_DIALOG_NO_SEPARATOR will be removed in GTK 3, so don't use it. 2010-12-25 02:05:15 +00:00
Charles Kerr
6627aade08 (trunk gtk) don't use the GSEAL'ed variable vbox GtkDialog directly... use gtk_dialog_get_content_area() instead 2010-12-22 03:12:47 +00:00
Charles Kerr
5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr
e934290980 (trunk gtk) portability: use g_dngettext() instead of ngettext() 2010-08-06 14:38:54 +00:00
Charles Kerr
28726d031d (trunk gtk) make it easier to change the periodic refresh intervals at the code level 2010-02-01 04:54:10 +00:00
Charles Kerr
5c26afdb52 happy new year! 2010-01-04 21:00:47 +00:00
Charles Kerr
736d39d34e (trunk gtk) #2707 "add confirmation dialog when resetting statistics" -- implemented 2010-01-03 17:58:33 +00:00
Charles Kerr
b7fc7bd955 (trunk gtk) #2706 "Statistics window Delete button label" -- rename the "Delete" button as "Reset" 2010-01-03 17:33:22 +00:00
Charles Kerr
78ead8c3dd (trunk) update the copyright notices 2009-12-05 02:19:24 +00:00
Charles Kerr
fe816d8135 (trunk) update the GPL code's copyright dates 2009-01-10 23:09:07 +00:00
Charles Kerr
e44239fc4e (trunk gtk) #1585: use g_timeout_add_seconds() where appropriate to group timers together for fewer scheduled wakeups 2008-12-22 05:39:03 +00:00
Charles Kerr
9594112d27 updated email address 2008-12-16 00:20:44 +00:00
Charles Kerr
d698ff7510 (gtk) don't use code marked as deprecated in gtk 2.14 2008-10-31 18:25:21 +00:00
Charles Kerr
91ac2ec337 janitorial: tr_handle -> tr_session 2008-10-28 19:49:33 +00:00
Charles Kerr
cc89872dd4 run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened 2008-09-23 19:11:04 +00:00
Charles Kerr
2d1c6921d2 (gtk) #1105: slightly better fix than r6387's 2008-07-23 13:42:30 +00:00
Charles Kerr
30a81af036 (gtk) #1105: "Statistics" window uses the same keyboard shortcut for "Clear" and "Close" buttons 2008-07-22 21:01:28 +00:00
Charles Kerr
dec4847b3f (gtk) #998: gtk client crashes if you quit while the stats window is still up 2008-06-05 20:41:32 +00:00
Charles Kerr
26b5a16630 (libt) more janitorial work on cleaning up tr_session*() and tr_torrent*() functions: session stats, torrent count, and manual update. 2008-05-22 20:44:41 +00:00
Charles Kerr
0c1599608d add statistics "reset" button 2008-04-22 14:07:42 +00:00
Charles Kerr
531dd851ad more string work before the freeze. (1) use %'d to get thousands' grouping in end-user strings (2) follow HiG capitalization, quotation guidelines (3) fold a few more strings 2008-03-19 20:07:27 +00:00
Charles Kerr
7bb54cece8 (gtk) small string folding & i18n tweaks. 2008-03-19 17:14:47 +00:00
Charles Kerr
ea7cca30d2 (gtk) plug a minor leak in the Statistics dialog. 2008-03-08 16:10:13 +00:00
Charles Kerr
6ef6ac0928 the last i18n-centric commit for awhile, I hope. 2008-03-08 04:53:11 +00:00
Charles Kerr
851e6ce008 (gtk) make the filename naming scheme a little more consistent. 2008-02-26 19:58:03 +00:00
Charles Kerr
446855bb4a (gtk) HIG window layout 2008-02-12 16:56:44 +00:00
Charles Kerr
d7b8c70cf5 (gtk) make TrCore's fields private 2008-02-09 17:29:05 +00:00
Charles Kerr
802f34a245 (gtk) handle TR_RATIO_NA and TR_RATIO_INF everywhere 2008-01-04 18:52:39 +00:00