2 commits

Author	SHA1	Message	Date
Mike Gelfand	92b74fee74	Fix issues reported by clang-tidy modernize checks (GTK client) (#4137) ... * Fix `modernize-avoid-c-arrays` clang-tidy issues * Fix `modernize-raw-string-literal` clang-tidy issues * Fix `modernize-use-nodiscard` clang-tidy issues * Fix `modernize-deprecated-headers` clang-tidy issues * Fix `modernize-pass-by-value` clang-tidy issues * Extend clang-tidy configuration Enable all `modernize` checks except for one (use-trailing-return-type) which is an extensive stylistic change for later.	2022-11-10 20:35:31 +01:00
Mike Gelfand	eec93de5ca	Fix issues reported by clang-tidy readability checks (GTK client) (#4127) ... * Fix `readability-container-data-pointer` clang-tidy issues * Fix `readability-container-size-empty` clang-tidy issues * Fix `readability-isolate-declaration` clang-tidy issues * Fix `readability-convert-member-functions-to-static` clang-tidy issues * Fix `readability-else-after-return` clang-tidy issues * Fix `readability-redundant-member-init` clang-tidy issues * Fix `readability-uppercase-literal-suffix` clang-tidy issues * Fix `readability-make-member-function-const` clang-tidy issues * Fix `readability-simplify-boolean-expr` clang-tidy issues * Fix `readability-qualified-auto` clang-tidy issues * Fix `readability-avoid-const-params-in-decls` clang-tidy issues * Fix `readability-implicit-bool-conversion` clang-tidy issues * Fix `readability-inconsistent-declaration-parameter-name` clang-tidy issues * Add initial .clang-tidy configuration Currently enabling readability checks only, others to follow. Of the four disabled readability checks, three (function-cognitive-complexity, identifier-length, magic-numbers) require extensive refactoring and were left for later, and one (redundant-access-specifiers) is not planned to be fixed due to the current coding style - using extra sections to separate methods from variables of the same visibility.	2022-11-09 16:58:36 +00:00