9fc9daf40d
Fails with an error if data removal was not possible ( #6055 )
...
* Do not remove torrent if trashing files failed.
Instead, stop the torrent and sets an error.
* Fixing GTK interface with new file removal behavior.
* C++17 compliant.
* Reverting unrelated change.
* Avoiding allocating unecessary objects.
* Easy review fixes.
* Fixing merge error.
* Adding result callback to tr_torrentRemove().
Using the new callback in Gtk GUI to decide when to remove it from the
interface.
* Reducing indentation level and making the function more readable.
* Using existing Session RefPtr.
* Notifying the client before freeing the torrent in the session.
* Addressing comments and synchronizing callback.
* Moving include.
* Fix constness issue reported by clang-tidy
2024-08-13 05:26:09 +01:00
92478ec849
refactor: rename "UpdateQueue" to "UpdateTorrentsState" ( #6613 )
2024-05-25 18:43:08 -05:00
cdbc8574a7
feat(macos): added last known location ( #6610 )
...
* feat(macos): added last known location
* fix data file label and reveal data button positions
* code review: code style
---------
Co-authored-by: BogdanArdelean <bogdan.ardelean@ymail.com>
2024-04-01 09:53:48 -05:00
81008a1692
only use a single concurrent queue for timeMachineExclude instead of one queue per torrent ( #6523 )
...
* only use a single concurrent queue for timeMachineExclude instead of one queue per torrent
* moving to +initialize for now (will become a `static let` in Swift anyway)
* DISPATCH_QUEUE_SERIAL because DISPATCH_QUEUE_CONCURRENT is limited to 64 simultaneous torrent dispatch_async
* `static` is better than `global`, to make it private to a single compilation unit
2024-01-28 22:49:06 -06:00
e5e768e2ab
fix: implicit conversion loses integer precision ( #6466 )
2023-12-31 14:04:26 -06:00
bcbd9b77af
feat: add stats for known peers, not just connected ones ( #4900 )
2023-11-08 11:17:00 -06:00
586a9eb862
fix: Implicit conversion loses integer precision ( #4919 )
2023-11-05 09:06:24 -06:00
a952a0731f
refactor: remove the tr_error** idiom ( #6198 )
...
* refactor: remove the tr_error** idiom
* fix: tr_error::message() is only constexpr in c++20 and up
* chore: silence a couple of g++-12 Wshadow warnings
2023-11-04 11:39:41 -05:00
2a65169461
refactor: remove unnecessary NSNotificationCenter observer removals ( #5118 )
2023-11-03 12:50:45 -05:00
8ac323d5d6
chore: removed copyright timespans in headers ( #4850 )
2023-11-01 16:11:11 -05:00
72d2823851
refactor: remove tr_torrentTotalSize() ( #6166 )
...
this interim function should have been removed when tr_torrentView() was introduced
2023-10-25 16:37:09 -04:00
8f7330523c
chore: remove unused progress arg from tr_torrentSetLocation() ( #6147 )
2023-10-21 22:33:41 -04:00
c14094f4c9
Use clang-format for qualifier alignment ( #5845 )
...
`QualifierAlignment` option is available since clang-format v14 and
works better than our own script.
2023-07-30 16:43:43 +01:00
c61d8b7cf7
refactor: rename tr_tracker_view.host to .host_and_port for clarity ( #5508 )
2023-05-08 20:28:10 -05:00
52c45eb85f
fix: some typos in macos source code comments ( #5475 )
2023-04-29 14:00:35 -05:00
1851b80d8c
feat: add sort-by-ETA for macOS ( #4169 )
2023-04-14 12:19:06 -05:00
f551b4adbf
fix: magnet links are always paused when added ( #4856 )
2023-02-13 12:33:33 -06:00
4b8cfa2e57
chore: update copyrights to 2023 ( #4834 )
2023-02-11 14:49:42 -06:00
1e988c9ce4
fix magnet link start logic ( #4528 )
2023-02-02 00:19:20 -06:00
8a5260f24c
Fixed DragOverlayWindow file icon and name ( #4428 )
...
* Fixed DragOverlayWindow file icon and name
* Fixed dragging for BitComet torrents
2022-12-22 20:07:45 -06:00
db802afc4f
Addressed various warnings ( #4414 )
2022-12-21 14:21:16 -06:00
e4276a3018
Use NSIndexSet getIndexes:maxCount:inIndexRange: directly ( #4179 )
2022-11-27 23:10:03 -06:00
292b092f54
Fix hang in CSBackupSetItemExcluded ( #4208 )
2022-11-19 08:50:13 -06:00
6fcdb526c7
Fix crash on torrent filenames in non-UTF-8 encoding ( #4144 )
2022-11-18 10:03:25 -06:00
bde1359d5d
Adopt localizedStringWithFormat for displayed quantities ( #4109 )
...
* Adopt localizedStringWithFormat for displayed quantities
* xib internationalization support is done
2022-11-14 18:30:03 +00:00
69fda72a8b
refactor: remove superfluous interface declarations ( #4110 )
2022-11-08 23:36:53 -06:00
d2ee0d2d08
feat: Align active filter macOS ( #3944 )
2022-11-07 11:20:15 -06:00
69ee92113f
Fix: values above INT_MAX (68 years) are interpreted as negative values ( #4085 )
2022-11-07 08:27:51 -06:00
12e564096b
fix: "Implicit conversion loses integer precision" warnings ( #3960 )
2022-10-25 11:14:42 -05:00
70f623f32b
Add user data parameter for torrent removal callback ( #4009 )
2022-10-23 11:51:35 -05:00
3a8dc9d203
Replace preprocessor defines with constants in objc code ( #3974 )
2022-10-19 14:28:21 -05:00
4ea9c87fea
fix: some typos ( #3904 )
2022-10-13 09:35:10 -05:00
cc5ae321a5
Fix "Capture of autoreleasing out parameter inside autorelease pool that may exit before method returns" ( #3886 )
2022-10-10 18:08:47 -05:00
5ba2186f1f
Rollback #3871 ( #3889 )
2022-10-07 10:21:01 -05:00
ec373f9041
macos: Allign active filter with other clients ( #3871 )
2022-10-06 17:15:33 -05:00
e49747ab51
feat: add tr_strvToBuf() ( #3657 )
...
* feat: add tr_getDefaultConfigDirToBuf()
* feat: add tr_getDefaultDownloadDirToBuf()
* feat: add tr_strvToBuf()
* feat: add tr_torrentFindFileToBuf()
* feat: add tr_torrentGetMagnetLinkToBuf()
* refactor: remove unused makeString() from tests
* feat: add tr_torrentFilenameToBuf()
* feat: add tr_torrentGetTrackerListToBuf()
* chore: remove obsolete comment references to tr_free
* chore: remove unused tr_strdup()
* chore: remove unused forward declarations
2022-08-16 19:28:57 -05:00
6278ea7017
refactor: reduce use of tr_malloc / tr_free ( #3652 )
...
* refactor: avoid tr_new in macos Torrent.trashDataFile
* refactor: avoid tr_new in maco PiecesView
* refactor: avoid tr_new in qt createVariant()
2022-08-16 12:03:09 -05:00
47fe7c47d2
refactor: replace per-torrent callbacks with per-session ones. ( #3495 )
2022-07-23 01:04:34 -05:00
c806a1435e
[macOS] Fix Group auto-assigning based on NSPredicate ( #3289 )
...
* [macOS] Fix Group NSPredicate
Property was renames, but previously saved predicates were not updated.
* [macOS] Update xibs for creating Group NSPredicate with new name.
* [macOS] Allow execution for Group NSPredicate restored secured storage.
2022-06-14 10:17:02 -05:00
af5db6e6f2
refactor: autogenerate the macOS client's Message Log dots ( #3224 )
...
* Replaces DotFlat png with generated icons
* code review: udating popup item icons
* code review: increasing inset
2022-06-08 16:35:51 -05:00
a28b07b390
Revert "refactor: move tr_torrent callbacks to tr_session ( #3003 )" ( #3104 )
...
This reverts commit 27fbfd8da6Fixes #3088 .
2022-05-16 13:48:43 -05:00
82bede40d1
fix for macOS "Stay within the global bandwith limits" always displaying true ( #3079 )
2022-05-14 12:57:22 -05:00
27fbfd8da6
refactor: move tr_torrent callbacks to tr_session ( #3003 )
...
* refactor: move tr_torrent callbacks to tr_session
* Support tr_sessionSet* (#3044 )
Co-authored-by: Antoine Cœur <coeur@gmx.fr>
2022-05-14 10:00:13 -05:00
5d52da8726
Address format conversion warnings in localizations ( #3059 )
2022-05-14 00:31:24 -05:00
7eecdca68e
clang-format version 12.0.1 + 14.0.3 ( #3027 )
2022-04-30 12:49:52 -05:00
34ec2f5aa4
Adopting lightweight generics ( #2974 )
2022-04-29 17:51:40 -05:00
31c65eec1f
refactor: remove tr_strvJoin() ( #2896 )
2022-04-07 17:26:59 -05:00
d943f069f5
Fix code_style.sh to include *.mm files after switch to Obj-C++ ( #2846 )
2022-03-31 00:52:23 +03:00
fa8aaf7631
refactor: remove remaining vararg log messages ( #2776 )
2022-03-17 17:39:06 -05:00
4f2472cd93
Update Torrent.mm ( #2777 )
2022-03-16 15:16:23 -05:00
Lucas Clemente Vella