Commit Graph

4892 Commits

Author SHA1 Message Date
Charles Kerr 581d9c34cc
fix: gcc-13 warnings pt. 2 (#6404)
* fix: tr_priority_t usage warnings

* build: disable -Wnull-dereference warnings when building GTest

* fix: -Wunused-result warning in tr_spawn_async()

* fix: -Warray-bounds warning in NetTest::compact4()
2023-12-23 10:32:04 -06:00
Mingye Wang e951ed2508
Use screen.visibleFrame instead of screen.frame (#6321)
* Use screen.visibleFrame instead of screen.frame

NSScreen.frame does not account for the dock, which can be at the bottom or any of the sides. As a result, layout errors that smash things into the dock can occur in the Y or X direction. visibleFrame accounts for the dock.

Should fix #4779. Untested.

* Update TorrentTableView.mm

* Remove -= 50 in max height calculation
2023-12-16 09:22:06 -06:00
Cœur e10689beea
refactor: support deallocating VDKQueue object (#6290) 2023-11-29 18:17:43 -06:00
Cœur 4b3f0a15c1
fix: compiler warning "not legal to call -layoutSubtreeIfNeeded on a view which is already being laid out." (#6299) 2023-11-26 19:48:02 -06:00
Cœur 089a697809
build: Xcode 11.3.1 compatibility (#6292) 2023-11-25 22:01:44 -06:00
Charles Kerr 76521a1751
refactor: Values pt. 7 - remove tr_formatter_init methods (#6258)
* refactor: initialize libtransmission::Values units in Application::initUnits()

* refactor: use libtransmission::Values instead of Formatter::unitStr()

* refactor: remove Formatter::Size, Formatter:Type

* refactor: use Values::Config to init units in transmission-qt

* refactor: use Values::Config to init units in transmission-mac

* chore: remove unused tr_formatter_foo_init() functions

* chore: make Value::operator+() const

* use Values::Speed, Values::Storage in GTK client

* chore: use snake_case for Formatter methods

* refactor: use Values::Speed in GTK client details dialog

* feat: add Values::Value::is_zero()

* refactor: remove unnecessary UTF8String calls
2023-11-15 22:15:40 -06:00
Cœur bcbd9b77af
feat: add stats for known peers, not just connected ones (#4900) 2023-11-08 11:17:00 -06:00
Cœur 5d56e9039a
fix: torrentTableView crash after superview.superview.superview (#6207) 2023-11-05 14:35:22 -06:00
Cœur 586a9eb862
fix: Implicit conversion loses integer precision (#4919) 2023-11-05 09:06:24 -06:00
Charles Kerr a952a0731f
refactor: remove the tr_error** idiom (#6198)
* refactor: remove the tr_error** idiom

* fix: tr_error::message() is only constexpr in c++20 and up

* chore: silence a couple of g++-12 Wshadow warnings
2023-11-04 11:39:41 -05:00
Dmitry Serov 2a65169461
refactor: remove unnecessary NSNotificationCenter observer removals (#5118) 2023-11-03 12:50:45 -05:00
Julien 424a9b5e17
chore: cleanup timespans in remaining headers (#6199)
* chore: cleanup timespans in remaining headers

* fix: reverted change in generated file

See https://github.com/transmission/transmission/actions/runs/6744426558/job/18334261137?pr=6199
2023-11-03 08:31:39 -05:00
Dzmitry Neviadomski 1b53226853
chore: replace deprecated NSNamePboardType with NSPasteboardTypeName (#6107)
* chore: replace deprecated NSNamePboardType with NSPasteboardTypeName

* chore: remove NSServices section from Info.plist

It appears to be noop on modern macOS if no action specified.
2023-11-03 00:22:45 -05:00
Julien 2df67c1a73
chore: updated some leftover front-facing copyright years (#6196) 2023-11-03 00:21:35 -05:00
Julien 8ac323d5d6
chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
Dzmitry Neviadomski 1c18737e67
refactor: move macOS default app logic to dedicated class (#6120) 2023-10-30 20:44:32 -04:00
Mike Gelfand 1c421d6d23
Minor CMake maintainability improvements (#6186)
* Prefer `PROJECT_{SOURCE,BINARY}_DIR` to `CMAKE_` ones

* Extend use of 3rd-party dir vars to reduce duplication

* Fix typo in submodule repo name

* Remove `CURL::libcurl` target fallback

The target is always available since CMake 3.12, which is our current
minimum version.
2023-10-30 20:44:34 +03:00
Charles Kerr 72d2823851
refactor: remove tr_torrentTotalSize() (#6166)
this interim function should have been removed when tr_torrentView() was introduced
2023-10-25 16:37:09 -04:00
Benedikt Bergenthal b5eaff114c
macosx/BlocklistDownloader.mm: (#6096)
in (void)startDownload: now trimming whitespaces at the beginning and
end of the BlocklistURL, otherwise the download will fail, if the URL
contains a beginning or trailing whitespace.

Signed-off-by: Benedikt Bergenthal <benedikt@kdrennert.de>
Co-authored-by: Benedikt Bergenthal <benedikt@kdrennert.de>
2023-10-24 11:45:45 -04:00
Dzmitry Neviadomski fab21fc9c2
feat: add option to set macOS client as default for torrent files (#6099) 2023-10-23 08:33:37 -04:00
Charles Kerr 8f7330523c
chore: remove unused progress arg from tr_torrentSetLocation() (#6147) 2023-10-21 22:33:41 -04:00
Dzmitry Neviadomski af5da12a71
feat: support dark mode in legacy html-based QuickLook plugin (#6101)
Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-10-21 20:40:22 -05:00
Dzmitry Neviadomski 6af7cde55e
feat: directly open macOS notifications preferences for app (#6121) 2023-10-20 16:01:30 -05:00
Cœur c5f6678c7d
fix: larger display group name (#6104) 2023-10-20 12:20:04 -05:00
Dzmitry Neviadomski 8ef7eba3bd
feat: render file tree in legacy html-based QuickLook preview extension (#6091)
Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-10-12 18:53:57 -05:00
Cœur 1722f00777
chore: apply clang-format version 17.0.1 (#6054) 2023-10-01 18:45:52 -05:00
Cœur 6f59d340d6
fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 (#6053) 2023-10-01 08:39:39 -05:00
Cœur a7f93f4f15
feat: support redirects to magnet (#6012) 2023-09-30 16:02:10 -05:00
Charles Kerr aa0ff75c16
fix: "Unrecognized colorspace number -1" (#6049) 2023-09-29 20:44:59 -05:00
Cœur c6b1d8851f
fix: broken UI and windows on macOS Sonoma (#6016) 2023-09-25 21:48:23 -05:00
Charles Kerr 6ead147620
refactor: use new tr_variant API in tr_session (#6006) 2023-09-16 08:23:35 -05:00
Cœur 92c8c41c0b
fix: selected torrents when moving rows (#5991)
* Fix selected torrents when moving rows

* code review: keep selected torrents when toggling group presentation
2023-09-10 21:39:01 -05:00
Charles Kerr ebb1b775af
refactor: public tr_session settings API now returns tr_variants (#5983) 2023-09-07 19:05:16 -05:00
Cœur 78a5d4da74
refactor: torrent cell and small torrent cell (#5846) 2023-09-01 20:41:03 -05:00
Charles Kerr 5837603b6f
refactor: make tr_variant follow RAII (#5923) 2023-08-20 23:15:23 -05:00
SweetPPro 1a86c65b44
fix: missing priority icon in torrent cell (#5856)
* regression fix: missing priority icon in torrent cell

Fix #5826 (regression from #5147) - autolayout alternative to #5846

* Update TorrentCell.mm

* Update SmallTorrentCell.mm
2023-08-13 14:37:42 -05:00
Mike Gelfand c14094f4c9
Use clang-format for qualifier alignment (#5845)
`QualifierAlignment` option is available since clang-format v14 and
works better than our own script.
2023-07-30 16:43:43 +01:00
tearfur 2211086338
fix: conform to libcurl requirements to avoid memory leak (#5702) 2023-07-05 22:05:03 -05:00
Charles Kerr 8183d7fddf
refactor: utils naming (#5696)
* chore: rename tr_strvContains to tr_strv_contains

* chore: rename tr_strvStartsWith to tr_strv_starts_with

* chore: rename tr_strvEndsWith to tr_strv_ends_with

* chore: rename tr_strvSep to tr_strv_sep

* chore: rename tr_strvStrip to tr_strv_strip

* chore: rename tr_strvToBuf to tr_strv_to_buf

* refactor: rename tr_saveFile() to tr_file_save()

rename tr_loadFile() to tr_file_read()

rename tr_moveFile() to tr_file_move()

* refactor: rename tr_parseNum() to tr_num_parse()

refactor: rename tr_parseNumRange() to tr_num_parse_range()

* chore: group related functions together in header
2023-06-30 09:49:58 -05:00
SweetPPro 635268854b
refactor: view-based TorrentTableView in macOS client (#5147)
Converted TorrentTableView from older style cell based table to more modern view based
* floating group rows are now used for an improved groups experience
* individual group indicators are hidden when _Use Groups_ is selected to minimize visual clutter (see #3328 )
* removed negated `usesAlternatingRowBackgroundColors` flag for minimal view in Controller.mm (personal preference - easy to restore)
2023-06-27 14:40:44 -05:00
Emir SARI 38ea020eca
i18n: Apply i18n to percentage values (#5568)
Some languages use different percentage formatting style other than
100% (e.g. Turkish and French, %100-100 %). This commit enables the use
of NSNumberFormatter(), in order to provide localized formatting.
2023-06-21 23:21:24 -05:00
Gary Elshaw 0fd7989b18
fix: restore png files that were corrupted in recent "compression" script 2023-06-18 14:11:56 -05:00
Cœur bd9d110d45
fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 (#5633) 2023-06-18 13:32:34 -05:00
Cœur 76166d8fa7
refactor: replace NSMutableDictionary with constant attributes (#5221) 2023-06-12 11:03:22 -05:00
Charles Kerr 0ef58c2a20
chore: improve lossless compression of png files (#5586) 2023-06-05 17:03:11 -05:00
Cœur 61679e1adc
Support localized punctuation for "Port:" (#4452)
* Support localized punctuation for "Port:"

* Code review: adopting "Port: %@"

* updating other locales for "Port" -> "Port: %@"
2023-05-29 09:43:43 -04:00
Charles Kerr c61d8b7cf7
refactor: rename tr_tracker_view.host to .host_and_port for clarity (#5508) 2023-05-08 20:28:10 -05:00
Charles Kerr 0d3b321bac
refactor: use snake_case for libtransmission class methods (#5497) 2023-05-05 23:11:05 -05:00
Gary Elshaw 52c45eb85f
fix: some typos in macos source code comments (#5475) 2023-04-29 14:00:35 -05:00
Zhenfu Shi f34b1e624c
fix: wrong case in AppKit.h (#5456) 2023-04-27 13:39:52 -05:00