Commit Graph

146 Commits

Author SHA1 Message Date
Jordan Lee 7a5f87a207 (trunk gtk) #3972 "Verify progress changes not displaying" -- fixed.
make sure to call gtk_list_store_set() on rows matching torrents whose tr_stat.recheckProgress value has changed, triggering a row change event that causes the verify progress change to be displayed.
2011-02-02 02:45:20 +00:00
Jordan Lee 88df1b15ee (trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fix minor r11799 regression.
Clearing the model on shutdown generated a warning because it used the wrong cast. Rather than fixing the cast, add tr_core_clear() for symmetry with tr_core_load().
2011-02-01 01:45:41 +00:00
Jordan Lee b084493bfe (trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fixed.
Long description in #3970. Split tr_core's torrent GtkTreeModel into two models: one low-level unsorted one, and one proxy sorted one. That way we don't have to disable sorting before walking through the low-level one to sync the table's attributes with the tr_torrent and tr_stat.
2011-01-31 23:01:46 +00:00
Jordan Lee 4d529db419 (trunk gtk) include the torrent hashcode in the model's collated name.
This simplifies sorting by name by merging the primary and secondary keys (case-insensitive name, and hash string) into a single key.
2011-01-21 18:30:08 +00:00
Jordan Lee acd941f17a (trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.

I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.

By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024 

However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
Jordan Lee 58c7556534 (trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fix r11737 typo. 2011-01-21 16:36:57 +00:00
Jordan Lee 9ce58e33ac (trunk gtk) #3916 "Reorder the list when metadata is downloaded" -- fixed.
When tr_info.name changes, update the collated name in the main window's TreeStore.
2011-01-21 02:58:58 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Jordan Lee 88d58502aa (trunk gtk) #3896 "Redundant call to tr_torrentStat() in tr_core_update()" -- fixed. 2011-01-13 11:50:58 +00:00
Charles Kerr bf2835c557 (trunk gtk) remove unused code: tr_core_quit() 2010-12-23 21:50:09 +00:00
Charles Kerr 057487d18e (trunk gtk) more gtr_ naming cleanup 2010-12-22 06:25:30 +00:00
Charles Kerr b86e1e1056 (trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below 2010-12-22 06:11:49 +00:00
Charles Kerr 5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr fee807cd57 minor tweak: tr_core_load() should return void, not int 2010-12-21 16:49:57 +00:00
Charles Kerr 345b14adbc (trunk) #3836 "libevent2 support" -- bump libevent2 requirement to 2.0.10. This will break the Mac build for a minute intil BMW applies his Mac patch 2010-12-20 02:07:51 +00:00
Charles Kerr 5bf05ab31b (trunk gtk) #3838 "Unselected active torrents not counted for quit check" -- fixed. 2010-12-19 09:33:02 +00:00
Charles Kerr 821d315453 (trunk) #3675 "Not all .part files are removed" -- added patch for libtransmission and GTK+ client 2010-12-16 03:38:07 +00:00
Charles Kerr 27a1b2dc33 (trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits 2010-12-12 16:43:19 +00:00
Charles Kerr d216d435a2 (trunk gtk, qt) #3770 "GTK and Qt clients should sort-by-progress as the Mac client does" -- fixed. 2010-12-01 05:41:58 +00:00
Charles Kerr 04c60c7221 (trunk gtk) #3697 "make blocklist URL configurable" -- better error handling in GTK+ client if the user-specified blocklist can't be fetched 2010-11-13 17:05:22 +00:00
Charles Kerr 1c2a7359af (trunk gtk) "hibernation inhibition broke in transmission-2.00" -- fixed. 2010-10-21 20:04:00 +00:00
Charles Kerr 6e62d0d99d (trunk gtk) fix a minor UMR error that Valgrind found 2010-09-23 17:05:40 +00:00
Charles Kerr 43f03f3de6 remove sort-by-tracker from the GTK+ client 2010-09-06 00:23:44 +00:00
Daniel Lee c30ed43082 (trunk) #3185: Number on drop-down menu "Activity" - "Active" seems does not follow a change in torrent status correctly 2010-08-04 17:35:48 +00:00
Daniel Lee fc15c5ba4b (trunk gtk) Clean up r11086 2010-08-04 05:25:43 +00:00
Charles Kerr 5624840ac4 (trunk) #3478 "Display bug when magnet links without display names are added" -- fixed in trunk 2010-08-03 03:16:21 +00:00
Charles Kerr 36064b8120 (trunk gtk) rewrite the main window's drag-and-drop handler s.t. it's GTK+ 3 compliant 2010-08-02 22:31:31 +00:00
Charles Kerr 59f5f3ed6b (trunk gtk) replace tr_strcmp() with gtr_strcmp0(), a porability wrapper around g_strcmp0() 2010-08-01 19:13:34 +00:00
Charles Kerr 3fa4865863 (trunk) #3450 "regression: Qt client dbus support broken" -- fixed 2010-08-01 18:55:04 +00:00
Daniel Lee ff23406f38 (trunk) #3471:Add 'finished' to filterbar 2010-08-01 17:43:35 +00:00
Charles Kerr f4e3b6e670 (trunk gtk) simplify the collation process for sorting torrents by name 2010-07-30 22:19:20 +00:00
Charles Kerr 6e5af03d78 (trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings 2010-07-04 06:07:21 +00:00
Charles Kerr cdcc4705aa (trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while. 2010-07-03 00:25:22 +00:00
Charles Kerr 01a10a2b6e (trunk gtk) #3346 "busy icon needed while processing request" -- added. 2010-06-26 15:55:19 +00:00
Charles Kerr 688ec1bafc (trunk gtk) #3345 "Remove button deselects selected torrents" -- fixed 2010-06-25 19:24:26 +00:00
Charles Kerr c927189fed (trunk gtk) #3348 "Add URL doesn't warn upon corrupt torrents" -- fixed. 2010-06-25 17:40:55 +00:00
Charles Kerr fa267d9f2b (trunk gtk) experimental fix for #3335 "magnet link options dialog does not respect setting." 2010-06-23 16:51:16 +00:00
Charles Kerr 2f56196206 (trunk) add "filename" arg to the dbus message when passing a .torrent from one instance of Transmission to another 2010-06-03 19:53:01 +00:00
Charles Kerr e7e627c3e7 (trunk gtk) #2612 "Display new transfer window when adding magnet transfer" -- implemented in GTK+ for 2.00 2010-05-13 13:12:27 +00:00
Charles Kerr d384b38f07 (trunk) minor transmission.h API cleanup.
1. remove tr_sessionGetActiveTorrentCount()
2. make tr_sessionCountTorrents() package-visible instead of public.
3. make tr_torrentGetActivity() private instead of public.
2010-04-29 23:08:11 +00:00
Charles Kerr b477d24222 (trunk gtk) add gtr_warn_if_fail(), a portability wrapper for systems too old for g_warn_if_fail() 2010-04-21 19:23:27 +00:00
Charles Kerr ceba9e6722 (trunk gtk) #3143 "remote RPC calls cause gtk+ API calls to be made from the wrong thread" -- fixed in trunk for 2.00 2010-04-21 04:38:54 +00:00
Charles Kerr c8ba63ca07 (trunk gtk) #3146 "Toggle state of 'toggle-main-window' not updated when window is shown after launch with running instance" -- fixed in trunk for 2.00 by a patch from qense 2010-04-17 00:41:24 +00:00
Charles Kerr e1607c8354 (trunk) #2898 "add pausing and deletion to daemon" -- committed patch from Longinus00 to trunk for 2.00 2010-03-17 19:23:03 +00:00
Charles Kerr 2aa1e69f98 (trunk gtk) first draft of a filterbar experiment 2010-03-14 05:13:02 +00:00
Charles Kerr 40adcb5491 (trunk gtk) don't dereference a NULL pointer if a torrent has no "name" 2010-02-06 05:21:25 +00:00
Charles Kerr 3b82968c31 (trunk gtk) #2864 "when adding a non-BitTorrent magnet link fails, explain why to the user" -- implemented for GTK+ client for 1.90 2010-02-05 13:59:44 +00:00
Charles Kerr 36d97610bd (trunk) #2802, #2716, #2717 -- remember magnet links and their settings between sessions, and allow their trackers to be modified 2010-02-02 22:45:22 +00:00
Charles Kerr 182cbb8b90 (trunk) one of the less-interesting commits in a while: remove trailing spaces from lines 2010-01-05 23:47:50 +00:00
Charles Kerr 7d266ed4d6 (trunk gtk) #2728 "Creates auto-download dir when non-existant" -- fixed for 1.80 2010-01-05 23:23:26 +00:00