Commit Graph

2829 Commits

Author SHA1 Message Date
Charles Kerr bccaf64e55 (trunk libT) #2558: "build failure in r9484" 2009-11-06 12:53:05 +00:00
Charles Kerr acc0ded449 (trunk libT) undo #2552's commit r9482 because it causes new problems. #2552 will need a different fix instead. 2009-11-05 15:41:54 +00:00
Charles Kerr 45e84d9ac6 (trunk libT) #2552: Torrent state doesn't change automatically anymore 2009-11-05 01:31:35 +00:00
Mitchell Livingston 288a6d143a fix BitLet peer id 2009-11-04 13:16:53 +00:00
Charles Kerr 197ccfff98 (trunk libT) #2554: JSON_int_t won't use "long long int" unless STDC_VERSION is defined 2009-11-04 03:41:59 +00:00
Mitchell Livingston dd5fa2e6b8 more typo fixes 2009-11-04 02:45:58 +00:00
Mitchell Livingston 77d7a53181 fix typo 2009-11-02 01:40:26 +00:00
Mitchell Livingston aac02231c4 4.3 not 4.2 2009-11-02 01:10:04 +00:00
Mitchell Livingston a43b73aad0 only mark a function as hot when compiled with GCC >= 4.3 2009-11-02 01:09:11 +00:00
Charles Kerr 4d817b0701 (trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies...(trunk libT) undo r9465 + r9466, which was the experimental new request manager. It still still needs some tinkering before it's ready for the nightlies... 2009-11-02 00:17:30 +00:00
Charles Kerr 296411e093 (trunk libT) turn off a debugging message in the terminal 2009-11-01 03:56:10 +00:00
Charles Kerr 0a4d8602e0 (trunk libT) #2548: T's request queue can send out too many duplicate requests 2009-11-01 02:10:47 +00:00
Charles Kerr 37dda955a1 (trunk libT) use __attribute__((nonnull)) where appropriate. remove two unused functions tr_int2ptr(), tr_ptr2int() 2009-11-01 01:35:06 +00:00
Charles Kerr 060bd2f722 (trunk libT) #2547: fix tr_lowerBound() 2009-10-31 22:16:06 +00:00
Charles Kerr 3a75050be4 (trunk libT) undo all the test commits for #2533 from r9445 through r9451. The problem appears to be an llvm issue, reported upstream @ apple dev center bug #7353773 2009-10-31 00:54:03 +00:00
Charles Kerr 7113ae2502 (trunk libT) BANG 2009-10-30 22:03:32 +00:00
Charles Kerr 9ae5ce0bf8 (trunk libT) tear out another line of code. subtle, this isn't. this is like figuring out which neighbor is stealing your newspaper in the morning by secretly shooting a different neighbor each morning until the paper stops disappearing. 2009-10-30 21:51:59 +00:00
Charles Kerr 66eac308ef (trunk libT) still banging along at #2533 2009-10-30 21:41:41 +00:00
Charles Kerr 632f98c8fd throwing darts in the dark. this smells like a compiler bug. 2009-10-30 17:29:51 +00:00
Charles Kerr 8bdaedc723 (trunk libT) lather, rinse, repeat 2009-10-30 17:17:53 +00:00
Charles Kerr 586deb9d12 (trunk libT) Adding term debug messages to help track down #2533 w/m1b and *acrocivious 2009-10-30 16:46:33 +00:00
Charles Kerr a7361372c3 Adding term debug messages to help track down #2533 w/m1b 2009-10-30 16:24:58 +00:00
Charles Kerr 08e936704c (trunk libT) fix signed/unsigned comparison warnings on amd64 2009-10-30 14:53:17 +00:00
Charles Kerr a34d742e36 (trunk libT) OS X fix for tr_torrentDeleteLocalData() -- .DS_Store gave it trouble 2009-10-30 04:23:51 +00:00
Charles Kerr f5b97d43c9 (trunk libT) portability improvements to tr_moveFile() 2009-10-30 03:53:41 +00:00
Charles Kerr ea072953c5 (trunk libT) one-liner fix for #2544 (launchpad 458735): crash in port forwarding if evtimer gets deleted 2009-10-30 03:20:53 +00:00
Charles Kerr d60fa654cb (trunk libT) fix regression introduced by #2539 that caused single-file torrents to not be deleted even if the user requested it 2009-10-30 02:58:30 +00:00
Charles Kerr 35d8a00912 (trunk libT) another hammer-the-network-less patch like r9414 2009-10-29 18:11:10 +00:00
Charles Kerr c61f8987de (trunk libT) #2538 startup takes too long 2009-10-29 17:25:03 +00:00
Charles Kerr b5042148e8 (trunk libT) #2539: "incomplete folder" feature may lead to deleted files 2009-10-29 17:00:22 +00:00
Charles Kerr 3680896a19 (trunk libT) #2508 atom->port never updated 2009-10-29 16:10:03 +00:00
Charles Kerr c9b071015f (trunk libT) #2530: Announce attempt to invalid tracker occurs too often 2009-10-28 04:53:39 +00:00
Charles Kerr 4b804e32ed (trunk libT) another tweak to tr_torrentSetLocation() 2009-10-28 04:50:37 +00:00
Mitchell Livingston 693897ce4c BitTorrent Embedded -> SDK 2009-10-28 03:48:54 +00:00
Mitchell Livingston c0d68a06c9 add "BitTorrent Embedded" to client list 2009-10-28 03:31:02 +00:00
Charles Kerr 22e3f1175a (trunk libT) #2531: when the user moves a torrent from one location to another, we don't need to reverify if the files are just rename()d 2009-10-27 23:00:34 +00:00
Charles Kerr 087f75e1ce (trunk libT) #2518: overzealously alarmist re unresponsive trackers 2009-10-27 21:03:13 +00:00
Charles Kerr bcce43021f (trunk libT) fix #2534: if port forwarding is disabled, tr_sessionClose() closes a random file descriptor 2009-10-27 20:29:02 +00:00
Charles Kerr 858e691381 (trunk libT) add a wrapper function, tr_netCloseSocket(), around EVUTIL_CLOSESOCKET() so that not all of our code has to #include evutil 2009-10-27 20:27:27 +00:00
Charles Kerr 7a4f22ba12 (trunk libT) use part of hexum's patch from <http://forum.transmissionbt.com/viewtopic.php?p=41572#p41572>. The part added sorts peers by their overall speed when deciding which ones to disconnect from first, and which to request from first. 2009-10-27 20:06:55 +00:00
Charles Kerr 2acc006807 (trunk libT) There seems to be a lot of talk about T hosing routers, preventing other network traffic, etc. As an experiment let's try reducing the number of new connections we allow per second and see if/how that affects performance. 2009-10-27 16:08:38 +00:00
Mitchell Livingston 130c9af1d1 on second thought, the other UI's might want this value sooner or later, and it's cheaper to calculate it in the stat function 2009-10-25 18:49:20 +00:00
Mitchell Livingston a5e0b6e5b2 since the Mac UI is the only one to use it, move percentRatio calculation into the Mac code 2009-10-25 18:45:35 +00:00
Mitchell Livingston 9254de1a36 smooth out the upload eta the same way as the download eta 2009-10-25 02:42:57 +00:00
Mitchell Livingston 47e19c4410 when calculating the "smoothed" eta, 1. only factor in previous speeds when those speeds were recent (ie. if we just resumed from pause, discard the previous speed) and 2. factor in if the speed was 0 as well 2009-10-25 02:36:03 +00:00
Charles Kerr 55c59fa478 (trunk) fix r9380 #2412 timing issue 2009-10-23 05:48:56 +00:00
Charles Kerr 37aaf66d4e (trunk) #2527: daemon should log messages to syslog 2009-10-23 05:00:16 +00:00
Charles Kerr c85ee09fef (trunk) trunk's just been too stable lately. #2119: reload settings.json on SIGHUP 2009-10-23 03:41:36 +00:00
Charles Kerr 00197cc461 (trunk libT) undo today's earlier commit r9381 for #2508 -- looks like I introduced a bug into the patch. 2009-10-22 19:08:45 +00:00
Charles Kerr 73222ce7aa (trunk libT) revert r9345, because all our .torrent and .resume files' hex letters are in lowercase 2009-10-22 18:48:26 +00:00
Charles Kerr bb541fc8d6 (trunk libT) #2508: atom->port never updated 2009-10-22 15:05:56 +00:00
Charles Kerr 9affe9ef59 (trunk libT) #2412: tracker query should use bind address 2009-10-22 05:15:34 +00:00
Charles Kerr baa860e6ce (trunk libT) #2518: r9334 overzealously alarmist wrt unresponsive trackers 2009-10-22 01:28:39 +00:00
Charles Kerr d9e4ddab1f (trunk libT) #2510: port messages not sent for outgoing peer connections 2009-10-22 01:03:17 +00:00
Mitchell Livingston 236bdc594f #2524 torrent peer limit not saved right away 2009-10-21 23:32:02 +00:00
Charles Kerr c59ae60488 libT doesn't need to create the Incomplete directory until it's needed 2009-10-21 19:33:37 +00:00
Charles Kerr adfb6f70a1 (trunk libT) show sha1's hex letters in uppercase, as suggested by waldorf 2009-10-21 16:24:58 +00:00
Charles Kerr 95989a0b21 (trunk libT) add callback notification when a torrent has been moved via RPC 2009-10-21 14:02:02 +00:00
Charles Kerr 0c53f3fa62 (trunk libT) add a couple of hooks for the mac client to use when migrating from its earlier move-on-complete code 2009-10-21 05:03:10 +00:00
Charles Kerr 8d1d91499a (trunk libT) #2520: tor->isRunning is not always saved to .resume file 2009-10-21 02:45:49 +00:00
Charles Kerr eef6177f0a (trunk libT) #1483: fix bug introduced in r9328 2009-10-20 20:19:41 +00:00
Charles Kerr 0df58b9ab4 (trunk libT) change the new public API a little bit -- clearer, but a little wordier 2009-10-20 04:43:51 +00:00
Charles Kerr 7b5dcdf6d1 (trunk libT) semi-paranoid safeguard: when searching for a torrent's file, look for finished versions (normal filename) before unfinished ones (with the .part suffix). In the unlikely event of a bug where both exist, it's better for Transmission to use the finished one... 2009-10-20 04:15:10 +00:00
Charles Kerr 27b9f6e27d (trunk libT) make the ".part" suffix an optional feature as per BMW's request. Clean up the code a little. 2009-10-20 03:14:44 +00:00
Charles Kerr 5a96ee9fc4 (trunk libT) make tr_torrentFindFile() a public API 2009-10-19 13:55:42 +00:00
Charles Kerr 6af5b7691e (trunk libT) make tr_torrentFileCompleted() safe for older torrents that were incomplete before the ".part" feature was added 2009-10-19 13:15:46 +00:00
Charles Kerr c35beb3843 (trunk) #1483: move completed torrents to a user-specified directory 2009-10-19 05:25:50 +00:00
Charles Kerr 05c77cc975 (trunk) #1483: move completed torrents to a user-specified directory + #629: different file extension for incomplete files 2009-10-19 05:05:00 +00:00
Charles Kerr d6acde35d3 (trunk libT) #2360: ratio-limit becomes a strange value on uClibc 2009-10-14 13:22:42 +00:00
Charles Kerr 2e3a3e60aa (trunk libT) #2498: DHT broken 2009-10-12 23:16:51 +00:00
Charles Kerr 3da08652ba (trunk libT) #2494: Adding a tracker changes announce status from time to "queued." 2009-10-12 06:08:28 +00:00
Mitchell Livingston 2af26e1d7c #2488 when sorting by tracker, first use the tracker that comes first alphabetically 2009-10-11 13:42:10 +00:00
Charles Kerr fde3abaa1e (trunk libT) fix scrape status string error reporte by bmw 2009-10-11 04:39:24 +00:00
Charles Kerr 504eaa6410 (trunk, libT) #2425: New torrents are verified after pause. 2009-10-11 03:10:17 +00:00
Mitchell Livingston 4290927563 retain previous announce/scrape info when a tracker becomes a backup 2009-10-10 20:46:24 +00:00
Mitchell Livingston 2730f9ac9c finish #2463 2009-10-10 20:25:05 +00:00
Charles Kerr b7677f7059 (trunk libT) #2463 if at first you don't succeed... 2009-10-10 20:14:26 +00:00
Charles Kerr fe2d851e5b (trunk libT) #2489: stricter checking of fringe cases in tr_torrentSetAnnounceList() 2009-10-10 19:39:43 +00:00
Charles Kerr 2a22e1782f (trunk libT) #2489: tr_torrentSetAnnounceList() should check for invalid and duplicate announce URLs 2009-10-10 19:16:21 +00:00
Charles Kerr 0fd817b757 (trunk libT) more assertions to help find the cause of #2480 2009-10-10 17:37:34 +00:00
Charles Kerr 61042404ad (trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup" 2009-10-10 00:17:00 +00:00
Charles Kerr f607c7591a (trunk) #2463: 'Mac Client shows huge "next announce in" timer' 2009-10-09 21:30:34 +00:00
Charles Kerr f92fd55a80 (trunk libT) add a couple more debugging assertions into the nightlies to try & smoke out the handshake/peer-io crashes 2009-10-09 20:06:22 +00:00
Charles Kerr 5b19021ab1 (trunk libT) #2393: Transmission deletes all files when moving to the same physical directory 2009-10-07 03:49:55 +00:00
Charles Kerr 90d612f9a9 (trunk libT) remove randOffset from announcer; the new announce queue handles load balancing 2009-10-03 14:08:05 +00:00
Charles Kerr aad2a886be fix oops 2009-10-03 13:17:18 +00:00
Charles Kerr 412f0b40a2 (trunk libT) fix a crash reported by John Clay and silence a gcc warning 2009-10-03 13:15:32 +00:00
Charles Kerr 21bd104bda (trunk libT) #2471: added/removed trackers aren't applied until restart 2009-10-02 04:54:02 +00:00
Charles Kerr b9a4f418ed (trunk, libT) filter out unsupported announce addresses 2009-10-02 02:03:30 +00:00
Charles Kerr 5819ffc2d8 (trunk, libT) #2464: Mac Client shows incorrect announce/scrape results for backup trackers 2009-09-30 20:49:52 +00:00
Charles Kerr d08ab9e510 (trunk libT) #2429: add some more assertions to help smoke out this bug 2009-09-28 18:22:57 +00:00
Mitchell Livingston 79b5c3e596 show N/A for peer counts when there hasn't been a scrape/announce yet 2009-09-28 15:16:23 +00:00
Charles Kerr b32e5cc25d (trunk libT) #2450: --find should not delete original 2009-09-27 18:48:00 +00:00
Charles Kerr a2b8588206 (trunk libT) possibly fix a crash-on-shutdown reported by John_ 2009-09-27 00:27:51 +00:00
Charles Kerr 79035d3b83 (trunk libT) possibly fix a crash-on-shutdown reported by John_ 2009-09-26 23:54:30 +00:00
Charles Kerr 9bf4c599b8 (trunk libT,gtk) plug a couple of minor leaks reported by valgrind 2009-09-26 23:46:30 +00:00
Charles Kerr 459bea37f9 (trunk libT) remove a couple more debugging printf() calls 2009-09-26 13:21:46 +00:00
Charles Kerr 681584e58e (trunk libT) possibly fix a crash reported by stdisease 2009-09-26 06:43:44 +00:00
Charles Kerr 4a09a1de13 (trunk) remove tr_stats fields: downloaders, leechers, seeders, timesCompleted as per discussion with livings 2009-09-26 06:20:33 +00:00
Charles Kerr d7c4537f2a (trunk, libT) #2379: infinite ratio shows as nan, invalid json 2009-09-26 04:24:45 +00:00
Charles Kerr 52f212fc9a (trunk libT) remove some debug printfs 2009-09-26 04:13:09 +00:00
Charles Kerr 28e119c1bb (trunk) copy-by-value changes to tr_tracker_stat 2009-09-26 03:36:58 +00:00
Charles Kerr 5b46b63b23 (trunk gtk) implement 'edit trackers' window in gtk client 2009-09-26 00:48:07 +00:00
Charles Kerr 86ada18266 (trunk)
#1699: Announce to multiple trackers at once
#2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
Charles Kerr 172d64c32c (trunk libT) #2416: possible fix for 'crash in event_queue_insert' on Snow Leopard 2009-09-23 15:28:11 +00:00
Charles Kerr 6656c6d71e (trunk libT) #2420 - Transmission should follow PEX conventions 2009-09-17 19:05:18 +00:00
Charles Kerr 034d14639a (trunk libT) use tr_torrentName() instead of tor->info.name 2009-09-17 03:24:35 +00:00
Charles Kerr 9b9c910d67 when creating a new torrent and a tracker announce URL can't be parsed, set a variable so that the client can learn which announce URL was the bad one 2009-09-17 01:18:59 +00:00
Charles Kerr ff260ee2fb (trunk libT) fix a couple of compiler warnings from the last commit. 2009-09-10 03:28:55 +00:00
Charles Kerr 19b3a84133 (trunk libT) fix oops 2009-09-10 03:07:54 +00:00
Charles Kerr fb83a0464e (trunk libT) #2395: caching too many peers between sessions makes startup slow and uses too much memory (KyleK, stdisease, et al) 2009-09-10 02:20:35 +00:00
Charles Kerr fa1fa11fdb (trunk, libT) #2390: when you add a new torrent while one is verifying local data, the new torrent will be added on wait list, rather than download automatically. (Reported by Adys in irc) 2009-09-09 12:44:11 +00:00
Charles Kerr 9af75365d2 (trunk libT) a test commit -- possible fseek fix for Rabbitbunny 2009-09-09 03:23:50 +00:00
Charles Kerr 9a02f9e48e fix r9073 oops; I committed a few debugging changes by accident too 2009-09-08 20:02:51 +00:00
Charles Kerr b7821bfb16 delete the obsolete zsh bindings 2009-09-08 20:01:12 +00:00
Charles Kerr 3524ae637e (trunk libT) sync the announce/scrape timeout intervals in trunk with those in 1.7x 2009-09-08 18:39:20 +00:00
Charles Kerr c7e2a29f57 add better logging to track down tr_ioRead() error messages reported by Rabbitbunny 2009-09-08 06:25:40 +00:00
Charles Kerr bd41421591 decide at runtime, rather than compile time, whether to use curl_multi_action 2009-09-08 05:18:46 +00:00
Charles Kerr 600e2d26ec (trunk libT) make tr_ptrArrayErase() private 2009-09-07 21:57:15 +00:00
Charles Kerr 0ef34b64b7 (trunk, libT) sibling to r9027, remove more unused code 2009-09-07 06:23:15 +00:00
Charles Kerr e22922f682 (trunk libT) disable the sorted ptrArray assertions in non-mac release builds 2009-09-06 22:52:13 +00:00
Charles Kerr c930f805cb (trunk libT) #2383: Faster verification for local data with small piece size 2009-09-06 14:05:06 +00:00
Charles Kerr 44d785f9ca (trunk libT) #2284: crashes when some invalid torrents are added. reported by Flemzard in irc 2009-09-05 16:51:22 +00:00
Charles Kerr 515a3f986f (trunk, libT) fix code in the UTF8-to-JSON serializer that could fall into an infinite loop when fed some inputs. This may be ticket #2326 or may get its own retroactive ticket, depending on feedback from #2326's reporter 2009-09-02 15:26:34 +00:00
Charles Kerr 1184d58302 (trunk libT) revert r9026 from ticket #2357 2009-09-01 03:42:16 +00:00
Charles Kerr be98310bb5 remove unused code 2009-08-31 23:31:43 +00:00
Charles Kerr 78b23a933d (trunk libT) #2357: the "upload_only" key sent in PEX should also be sent to trackers 2009-08-31 18:33:25 +00:00
Charles Kerr fdc61b0d0b (trunk libT) #2373: Handle HTTP redirects more gracefully 2009-08-31 17:18:58 +00:00
Charles Kerr 23b3faada4 (trunk libT) #2372: 'Unregistered Torrent Pass' Pauses Download 2009-08-31 16:41:54 +00:00
Charles Kerr ed512c215f (trunk, libT) #2365: Peer settings for an individual torrent should override the global limit. 2009-08-31 15:59:43 +00:00
Charles Kerr ae9e59c8af add KGet to the clients list 2009-08-29 14:42:58 +00:00
Charles Kerr 6a2de9864d fix --disable-dht error in 1.74 reported by DimStar 2009-08-25 13:55:32 +00:00
Charles Kerr 786887b147 (trunk libT) tell libcurl to set a time limit of 120 seconds for announces; 30 seconds for scrapes 2009-08-22 23:22:50 +00:00
Charles Kerr e7a4ee9d82 (trunk) un-remove the conditional DHT compiling for now for reasons discussed @ http://lists.opensuse.org/opensuse-gnome/2009-08/msg00033.html. I'll re-remove it for 1.80. :) 2009-08-18 16:02:16 +00:00
Charles Kerr 6dedb0433b (trunk libT) better throttling back of outgoing download requests when speed limits are turned on 2009-08-18 01:57:17 +00:00
Erick Turnquist fbfaeda8df (trunk libT): do EAFNOSUPPORT check on socket() errno on all platforms 2009-08-17 18:49:21 +00:00
Charles Kerr 14dfd896ba (trunk libT) a debugging message was accidenally being dumped to the terminal. Reported by ubuntuforums user "Nevermor7" in <http://ubuntuforums.org/showpost.php?p=7743702&postcount=1> 2009-08-16 21:09:08 +00:00
Charles Kerr 37a4a5c68e (trunk libT) fix pause-on-shutdown bug reported by KyleK and introduced in r8878 for #2317. 2009-08-15 21:09:06 +00:00
Charles Kerr 1c5b344c85 (trunk libT) remove dead code noticed by geirha 2009-08-15 15:52:10 +00:00
Charles Kerr f7129f2f30 (trunk libT) #2335: when verifying local data, pause a few msec between pieces to give the system some breathing room and other processes a shot at the disk IO 2009-08-14 20:55:22 +00:00
Charles Kerr 30bc1c6e7a (trunk libT) revision to r8910 for #2162: check to see if a field's value has actually changed before setting the "dirty" flag. 2009-08-14 14:41:59 +00:00
Charles Kerr 61e95595b8 (trunk) move tr_lockfile from libtransmission/ to gtk/, since the gtk client is the only one who uses it anymore 2009-08-14 12:53:08 +00:00
Charles Kerr d318f1f0b8 (trunk libT) revision of r8915 for #1765: give the same user-level warning message if T first notices that a torrent's disappeared when it's doing a tr_torrentVerify() 2009-08-13 19:28:06 +00:00
Charles Kerr 9d0760e58c (trunk libT) revision of r8915 for #1766: flag the warning message for translation. 2009-08-13 17:56:50 +00:00
Charles Kerr deb25906d0 (trunk libT) fix #1765: "if a downloaded file disappears, stop the torrent instead of redownloading it" 2009-08-13 17:50:41 +00:00
Charles Kerr 11717de1d0 (trunk libT) fix #2332: filesystem-based error messages lack context 2009-08-13 17:25:26 +00:00
Charles Kerr d08d53d8ed (trunk libT) make the RPC 409 error message easier to understand 2009-08-13 16:50:50 +00:00
Charles Kerr 784464450a (trunk libT) fix #2162: .resume file doesn't get saved often enough when its contents change 2009-08-13 14:47:56 +00:00
Charles Kerr 8e4d837967 (trunk, libT) fix for #2269 ("error message cleared unexpectedly"): a successful scrape clears the error message, and there's no point in scraping an error torrent anyway, so don't scrape until the torrent's error is cleared by a successful announce. 2009-08-12 20:12:52 +00:00
Charles Kerr 306d26a97c (trunk libT) very minor tweak: tr_httpIsValidURL() should return a tr_bool, not an int. 2009-08-12 19:44:32 +00:00