Commit Graph

45 Commits

Author SHA1 Message Date
Jordan Lee acd941f17a (trunk gtk) companion commit to r11738 to reduce unnecessary re-rendering in the main window
The main window called gtk_tree_model_filter_refilter() once per second to refresh the torrent list's filtering. This is not an efficient approach: gtk_tree_model_filter_refilter() emits a "row changed" event for every row, causing unnecessary re-rendering.

I've removed the call to gtk_tree_model_filter_refilter() and expanded the model to includes all the fields necessary for filtering. That way we only fire "row changed" events for rows that actually change.

By reducing the number of renders in steady state, this might ameliorate https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/655024 

However it will *not* help the related "CPU spikes to 100% on scrolling" ticket at https://trac.transmissionbt.com/ticket/3887 because rendering paused torrents is still exceptionally expensive in the murrine theme.
2011-01-21 17:07:23 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr bf2835c557 (trunk gtk) remove unused code: tr_core_quit() 2010-12-23 21:50:09 +00:00
Charles Kerr b86e1e1056 (trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below 2010-12-22 06:11:49 +00:00
Charles Kerr 5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr fee807cd57 minor tweak: tr_core_load() should return void, not int 2010-12-21 16:49:57 +00:00
Charles Kerr 5bf05ab31b (trunk gtk) #3838 "Unselected active torrents not counted for quit check" -- fixed. 2010-12-19 09:33:02 +00:00
Daniel Lee c30ed43082 (trunk) #3185: Number on drop-down menu "Activity" - "Active" seems does not follow a change in torrent status correctly 2010-08-04 17:35:48 +00:00
Charles Kerr 3fa4865863 (trunk) #3450 "regression: Qt client dbus support broken" -- fixed 2010-08-01 18:55:04 +00:00
Daniel Lee ff23406f38 (trunk) #3471:Add 'finished' to filterbar 2010-08-01 17:43:35 +00:00
Charles Kerr 01a10a2b6e (trunk gtk) #3346 "busy icon needed while processing request" -- added. 2010-06-26 15:55:19 +00:00
Charles Kerr 2f56196206 (trunk) add "filename" arg to the dbus message when passing a .torrent from one instance of Transmission to another 2010-06-03 19:53:01 +00:00
Charles Kerr d384b38f07 (trunk) minor transmission.h API cleanup.
1. remove tr_sessionGetActiveTorrentCount()
2. make tr_sessionCountTorrents() package-visible instead of public.
3. make tr_torrentGetActivity() private instead of public.
2010-04-29 23:08:11 +00:00
Charles Kerr ceba9e6722 (trunk gtk) #3143 "remote RPC calls cause gtk+ API calls to be made from the wrong thread" -- fixed in trunk for 2.00 2010-04-21 04:38:54 +00:00
Charles Kerr 2aa1e69f98 (trunk gtk) first draft of a filterbar experiment 2010-03-14 05:13:02 +00:00
Charles Kerr a334b422c3 (trunk) remove unnecessary #includes 2010-01-28 13:33:40 +00:00
Charles Kerr c06d889269 (trunk gtk) #2556: add a torrent from a URL. works from the menu and from URLs passed in the command line at startup 2009-11-22 16:20:22 +00:00
Charles Kerr 3ca7f7f63c (trunk gtk) rewrite the 'create torrent' dialog 2009-09-17 01:28:45 +00:00
Charles Kerr cb79214854 (trunk) remove trailing spaces 2009-08-10 20:04:08 +00:00
Charles Kerr 1083535d9b (trunk gtk) fix #2292: wrong speed in bottom bar 2009-08-07 20:49:06 +00:00
Charles Kerr 1c3b53244d (trunk) clean up the return value of tr_torrentParse() 2009-08-05 01:59:16 +00:00
Charles Kerr d7e837c814 remove some unused utilities. better commenting on the utils that remain. 2009-07-22 15:55:48 +00:00
Charles Kerr 58ba65f55b (trunk, gtk/qt) use Monsoon's strings for encryption preferences and Deluge's system tray tooltip. 2009-06-30 18:08:50 +00:00
Charles Kerr ebfd93fe7b (trunk gtk) #1963: Use tooltip to notify user of added torrent 2009-06-11 16:17:48 +00:00
Charles Kerr 6e10ee3baa (trunk gtk) #2197: Adding a torrent from a browser sometimes doesn't work 2009-06-11 14:51:21 +00:00
Charles Kerr 7f60d9db17 (trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once 2009-04-24 01:37:04 +00:00
Charles Kerr 7936dddd57 (trunk gtk) use the RPC API for updating the blocklist and for testing the port. 2009-04-07 20:13:08 +00:00
Charles Kerr 3f9a1d090b (trunk) #1787: add support for seeding ratio limiting in libtransmission 2009-02-13 18:23:56 +00:00
Charles Kerr 91ac2ec337 janitorial: tr_handle -> tr_session 2008-10-28 19:49:33 +00:00
Charles Kerr 0c4f300f1b #1369: clarify the different torrent status & callbacks' APIs and typenames 2008-10-20 17:54:56 +00:00
Charles Kerr cc89872dd4 run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened 2008-09-23 19:11:04 +00:00
Charles Kerr c3c8006c85 (gtk) #989: add a checkbox to auto-update the blocklist once a week 2008-09-02 20:59:00 +00:00
Mukund Sivaraman 317281f87c Don't show an error when transmission is run twice
Instead, present the main window. This commit also auto-generates
the dbus bindings.
2008-08-17 12:39:26 +00:00
Charles Kerr 339fb746ff (gtk) #1090: gtk+ client crashes when a torrent is removed from clutch 2008-07-16 19:38:22 +00:00
Charles Kerr f5dbaca440 (gtk) #562: No error message when opening broken torrent file 2008-07-09 16:33:00 +00:00
Charles Kerr 106a272be8 (gtk) dead code removal: MC_HASH 2008-05-27 17:54:02 +00:00
Charles Kerr 70b395fb85 dead code removal. 2008-05-26 13:13:24 +00:00
Charles Kerr 2c79888a93 RPC/IPC redesign 2008-05-18 16:44:30 +00:00
Charles Kerr 1ae1607025 gtk/cli/daemon/remote/proxy: add command-line argument --config-dir / -g to override the default config dir 2008-04-19 00:41:32 +00:00
Charles Kerr 3e88159e9f (gtk) fix potential invalid memory read on shutdown 2008-04-17 20:35:18 +00:00
Charles Kerr d6373c9f6b (gtk) use the new libtransmission tweaks s.t. our update pulse causes less CPU load 2008-04-01 02:36:41 +00:00
Charles Kerr b6aa753f06 (gtk) add a "display options dialog" checkbox in the "open torrent" dialog. 2008-03-19 14:54:32 +00:00
Charles Kerr 0437c5f33e (gtk) try to iron out the remaining "add torrent" issues reported by wereHamster and Lacrocivous 2008-03-18 01:22:11 +00:00
Charles Kerr a11071e661 (gtk) minor: use "Folder" instead of "Directory", as per the GNOME Desktop Terms list 2008-03-06 20:55:07 +00:00
Charles Kerr 851e6ce008 (gtk) make the filename naming scheme a little more consistent. 2008-02-26 19:58:03 +00:00
Renamed from gtk/tr_core.h (Browse further)