Charles Kerr
f105c6ac81
fix: make DNS queries lowercase ( #2591 )
...
Fixes #461 .
2022-02-08 21:30:45 -06:00
Charles Kerr
318d60b72d
refactor: fix sonarcloud "use enum class" code smells ( #2590 )
...
* refactor: prefer constexpr over enum for GUI_PAD values
* refactor: prefer constexpr over enum for PrefsDialog values
* refactor: prefer constexpr over enum for StatsDialog values
* refactor: use enum class for GtrUnicode types
* refactor: prefer constexpr over enum for BT peer msg codes
* refactor: use enum class for TrMakemetaResult
* refactor: prefer constexpr over enum for BT metadata message types
* refactor: use enum class for AwaitingBt
* refactor: use enum class for EncryptionPreference
* refactor: use enum class for TrFormat in rpcimpl
* refactor: prefer constexpr over enum for QApp intervals
* refactor: prefer constexpr over enum for tr_resume bitfields
* refactor: prefer constexpr over enum for Qt/TrFileModel bitfields
* refactor: remove obsolete TODO comment in announce-list
2022-02-08 20:25:19 -06:00
Charles Kerr
a92af9193e
fixup! add labels to torrent-add rpc method ( #2539 ) ( #2589 )
...
fix potential memory leak reported by coverity
2022-02-08 19:04:29 -06:00
Charles Kerr
2bf25fbdf5
refactor: fix a pair of win32 msvc warnings in libtransmission ( #2588 )
2022-02-08 12:50:09 -06:00
Charles Kerr
ba14ffa74c
refactor: sonarcloud "use if init" statements ( #2587 )
2022-02-07 23:44:31 -06:00
Charles Kerr
ebb2ab6aee
chore: update license spdx abbreviations ( #2582 )
...
Use SPDX license list 3.0 terminology: replace deprecated identifiers
GPL-2.0" and "GPL-3.0" with "GPL-3.0-only" and "GPL-3.0-only".
2022-02-07 10:25:02 -06:00
Charles Kerr
ecef0feb0c
refactor: clang-tidy in libtransmission ( #2578 )
...
* chore: enable cppcoreguidelines-slicing warning
* chore: enable readability-named-parameter warning
* chore: enable bugprone-reserved-identifier check
* chore: enable bugprone-not-null-terminated-result check
* chore: enable bugprone-sizeof-expression check
* chore: enable bugprone-incorrect-roundings check
* chore: enable misc-misplaced-const check
* chore: enable bugprone-suspicious-include check
* chore: enable bugprone-signed-char-misuse check
* chore: enable modernize-raw-string-literal check
* chore: enable readability-static-accessed-through-instance check
* chore: enable readability-implicit-bool-conversion check
* fixup! Merge branch 'main' into refactor/clang-tidy
2022-02-06 22:28:36 -06:00
bkuhls
a8818148e2
fix cross build ( #2576 )
...
Remove redundant include, ${UTP_INCLUDE_DIRS} is included already to fix
cross build error with buildroot:
x86_64-linux-g++: ERROR: unsafe header/library path used in cross-compilation: '-isystem' '/libutp'
2022-02-06 01:17:03 -06:00
LaserEyess
5565255d85
add labels to torrent-add rpc method ( #2539 )
...
This commit adds labels to the torrent-add method, allowing RPC users to
specify labels when adding a torrent. Labels metadata is commonly known
when adding torrents, so this removes the need to send another
torrent-set call to add labels.
Additionally, transmission-remote is updated to handle labels in
torrent-add.
Co-authored-by: LaserEyess <LaserEyess@users.noreply.github.com>
2022-02-03 00:02:30 -06:00
Charles Kerr
e908193027
fix: some use-init-statement sonarcloud warnings ( #2563 )
2022-02-01 19:09:11 -06:00
Charles Kerr
878405f862
Revert "fix: sonarcloud ( #2558 )" ( #2562 )
...
This reverts commit 8b9483f7fb
2022-02-01 11:30:51 -06:00
Charles Kerr
329c4d80e1
fix: edge case file leak if error while making torrent ( #2560 )
...
found by Coverity
2022-02-01 01:11:13 -06:00
Charles Kerr
fdff2893b6
refactor: static allocation of formatter units ( #2559 )
2022-01-31 23:59:43 -06:00
Charles Kerr
8b9483f7fb
fix: sonarcloud ( #2558 )
...
* fix: add const modifier for functions
* fix: many sonarcloud use-init-statement warnings
2022-01-31 22:46:27 -06:00
Charles Kerr
cf2c32e1ce
refactor: remove raw ptr variant of tr_peerMgrCompactToPex() ( #2556 )
2022-01-31 21:11:47 -06:00
Charles Kerr
b645c4cfc5
refactor: use std::chrono not OS-specific syscalls ( #2554 )
2022-01-31 19:02:59 -06:00
Charles Kerr
5db993d348
chore: iwyu ( #2553 )
2022-01-31 17:05:35 -06:00
Charles Kerr
7bc668680e
chore: remove unused function tr_strcasestr() ( #2552 )
2022-01-31 15:59:14 -06:00
Charles Kerr
253f4fe009
chore: remove /upload endpoint from rpc-server ( #2550 )
...
It's never been documented or supported and is unused by the web client.
In the unlikely case that a 3rd party app is using it, use 'torrent-add'
instead; it's documented + supported.
2022-01-31 14:54:21 -06:00
Charles Kerr
87dfabb9d2
refactor: replace tr_thread with std::thread ( #2548 )
2022-01-31 13:34:04 -06:00
Charles Kerr
6f9cba4088
fixup! refactor: SAX-like benc parser pt. 1 ( #2490 ) ( #2544 )
2022-01-30 21:12:57 -06:00
Charles Kerr
314aa6925d
fix: sonarcloud use-init-statement warnings in new code ( #2536 )
2022-01-29 16:26:09 -06:00
Charles Kerr
52f6e80a61
test: add tr_torrent_metainfo.infoDictSize() tests ( #2535 )
2022-01-29 15:37:42 -06:00
Charles Kerr
374c24dde1
refactor: trevent use std:: tools intead of pipes ( #2520 )
2022-01-28 17:56:46 -06:00
Charles Kerr
9e264250d1
refactor: add benc::Handler::Context ( #2531 )
...
Prerequisite for using the new benc parser in tr_torrent_metainfo:
That code needs to know the span of the bencoded info dict.
2022-01-28 16:46:14 -06:00
Charles Kerr
7f60738cce
refactor: use the new benc parser in announcer-http ( #2529 )
2022-01-28 12:39:45 -06:00
Charles Kerr
b998032305
fix: paused torrents not scraped even if scrape-paused-torrents-enabled setting is true ( #2528 )
2022-01-27 22:17:11 -06:00
Charles Kerr
3c5442dd7b
test: add tests for parsing http tracker scrape responses ( #2527 )
2022-01-27 17:18:50 -06:00
Ilkka
020a9e45ae
Add more decimals for low ratios ( #2508 )
2022-01-25 10:52:22 -06:00
Charles Kerr
02e9fd6b59
fix: use libdeflate_gzip_compress in rpc-server.cc ( #2507 )
2022-01-24 23:40:01 -06:00
Charles Kerr
064ad6a436
refactor: saxlike benc pt. 2: add announce response parsing tests ( #2505 )
2022-01-24 22:25:55 -06:00
Charles Kerr
81066aae25
fixup! refactor: use C++ objects in announcer ( #2474 ) ( #2502 )
...
fix Jan 22 regression in parsing port numbers from pex
2022-01-24 20:21:35 -06:00
Charles Kerr
ac823f3cc4
fix: sonarcloud warnings in new code ( #2500 )
2022-01-24 19:05:24 -06:00
Charles Kerr
e83a57efa3
refactor: re-enable some clang-tidy rules ( #2498 )
2022-01-24 13:07:55 -06:00
Charles Kerr
5efec26a3b
refactor: SAX-like benc parser pt. 1 ( #2490 )
...
* refactor: add SAX-like benc parser
This is the first part of a series of PRs whose end goal is to avoid
the overhead of tr_variant when parsing bencoded data, e.g. when
parsing .torrent files on startup or when parsing announce/scrape
tracker responses.
This PR introduces a SAX-like benc parser, reimplements variant-benc
to use the SAX benc parser (so that we don't have two benc parsers),
and updates the benc + variant tests.
2022-01-24 00:30:00 -06:00
Charles Kerr
2329f7541f
refactor: quark's static_assert formatting ( #2489 )
...
Slight refactor to libt/quark's static asserts so that the codebase
formats the same between clang-format 12, 13, and 14.
2022-01-23 23:26:14 -06:00
Charles Kerr
43bd736eb4
fixup! [android] Use android logger ( #585 ) ( #2488 )
...
clang-format
2022-01-23 21:53:49 -06:00
Andrey
d8dfbbe2d2
[android] Use android logger ( #585 )
2022-01-23 20:44:43 -06:00
Charles Kerr
b5cbbb7f8f
refactor: clang-tidy 14 ( #2487 )
...
get transmission building cleanly with clang-tidy 14
2022-01-23 20:44:14 -06:00
Charles Kerr
26bb9f3440
fix: sonarcloud code smells ( #2486 )
2022-01-23 18:53:35 -06:00
FX Coudert
a2e30235c4
Make macOS crash reports provide more information ( #2471 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-01-23 18:10:06 -06:00
Charles Kerr
e51527203e
refactor: re-enable clang-tidy warnings ( #2485 )
2022-01-23 16:47:41 -06:00
Peter Bailey
96d9ab5abb
allow stopping torrents in verification states ( #715 )
2022-01-23 14:46:56 -06:00
Charles Kerr
c5bc3091cc
fixup! NAT-PMP private/public port and lifetime fix ( #1602 ) ( #2482 )
...
ensure the value passed to tr_timerAdd() is non-negative
2022-01-23 11:31:20 -06:00
Charles Kerr
fa3cbc3e27
fix: memory leak in upnp ( #2481 )
...
Fixes #2480
2022-01-23 11:16:36 -06:00
Esa Varemo
032e01c9d8
Add the option of automatically picking up URLs from the clipboard on window focus ( #1633 )
2022-01-23 09:57:21 -06:00
Charles Kerr
b45c831bcb
refactor: use C++ objects in announcer ( #2474 )
2022-01-22 23:41:01 -06:00
Charles Kerr
e0c3a7f3e6
docs: add CONTRIBUTING.md ( #2452 )
2022-01-21 21:34:23 -06:00
mickaelifs
6c582469fa
NAT-PMP private/public port and lifetime fix ( #1602 )
2022-01-21 18:07:24 -06:00
Charles Kerr
da4ad59290
fix: in check input before calling tr_sha1_from_string() ( #2468 )
...
Fixes #2467
2022-01-21 17:17:49 -06:00
