Commit Graph

13465 Commits

Author SHA1 Message Date
Mike Gelfand c22e687b51 Simplify `tr_ssha1_matches` logic
Gets rid of needless heap memory allocations and copying. Convert SHA1 hash
to hex in-place.

Fixes: #141
2018-01-17 01:17:50 +03:00
Mike Gelfand 1e8267d68c When building with Xcode, link against 'libcrypto.dylib' instead of 'libcrypto.0.9.8.dylib'
Fixes: #71
2018-01-17 01:14:52 +03:00
Mike Gelfand 1d04ea65d3 Don't switch trackers while announcing
Fixes: #297
2018-01-17 01:09:07 +03:00
Mike Gelfand 0994e96f31 Uncaught exception when dragging multiple items between groups (macOS)
Change group after all the torrents are retrieved from drop data to avoid
premature view item index changes.

Fixes: #51
2018-01-17 01:03:23 +03:00
Eric Petit 709ca6a4b2 Work around "error: m4_copy: won't overwrite defined macro: glib_DEFUN" on
Xenial, copied from https://github.com/Alexpux/MINGW-packages/issues/1351
2018-01-17 01:00:49 +03:00
Mike Gelfand 95109af459 Allow host whitelist control via plist on Mac
Add RPCUseHostWhitelist (maps to rpc-host-whitelist-enabled) and
RPCHostWhitelist (maps to rpc-host-whitelist) keys loading from the plist
to allow adjustment via `defaults` command.
2018-01-17 00:46:54 +03:00
Mike Gelfand 15c91ec46e Add libevent submodule (should hopefully fix Mac build) 2018-01-17 00:36:34 +03:00
Mike Gelfand aa2730d47c Switch to HTTPS links, adjust wiki links where possible
Fixes #39
2018-01-16 01:12:59 +03:00
Tavis Ormandy 440f03e9ad mitigate dns rebinding attacks against daemon 2018-01-16 01:12:56 +03:00
Robert Vehse a6ef87b92d Update all instances of the donation link. Fixes #26. 2018-01-15 23:57:46 +03:00
Mike Gelfand 7cc4cfbe7b Abort handshake if establishing DH shared secret fails
Fixes #27
2018-01-15 23:51:44 +03:00
Mike Gelfand eb5d1a79cb
Merge pull request #468 from taviso/master
CVE-2018-5702: Mitigate dns rebinding attacks against daemon
2018-01-15 23:46:32 +03:00
Tavis Ormandy cf7173df93 mitigate dns rebinding attacks against daemon 2018-01-15 23:31:25 +03:00
Mike Gelfand c8696df516
Merge pull request #440 from lasers/manual
Remove whitespace and a comma in the manuals
2017-12-08 06:12:07 +03:00
Mike Gelfand ffcca3964d Adjust test names in CMake to be in line with autoconf ones 2017-12-02 17:58:15 +03:00
Mike Gelfand fae6b40002 Fix memory leaks in subprocess test 2017-12-02 17:57:11 +03:00
Mike Gelfand 4114fe6632
Merge pull request #449 from wjt/symbolic-icon
gtk: add symbolic icon
2017-12-01 01:12:27 +03:00
Will Thompson 01ffcd5dcf
gtk: add symbolic icon
The -symbolic icon variant (if available) is used in the GNOME top bar,
and when the high contrast theme is in use.  This icon was created by
Jakub Steiner, and comes from the gnome-icons repository:

https://github.com/gnome-design-team/gnome-icons/blob/master/apps-symbolic/Adwaita/scalable/apps/transmission-symbolic.svg
https://bugzilla.redhat.com/show_bug.cgi?id=1221292

There is some confusion over whether symbolic app icons should be
installed to icons/hicolor/scalable/apps (alongside the regular scalable
icon) or to icons/hicolor/symbolic/apps. On the one hand,
https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons has
this to say:

> […] obtain a suitable symbolic style icon […] and install it to the
> hicolor prefix, the same way you would for the full color variant.
>
> cp myapp-symbolic.svg /usr/share/icons/hicolor/scalable/apps/myapp-symbolic.svg

On the other hand, the Fedora package at
https://src.fedoraproject.org/rpms/transmission/blob/master/f/transmission.spec
ships this icon in icons/hicolor/symbolic/apps:

> # Install the symbolic icon
> mkdir -p  %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps
> cp %{SOURCE1} %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps/transmission-symbolic.svg

Anecdotally, icons in scalable/ have minimum size 64×64 on openSUSE, so
symbolic/ is the safer location (given the GNOME top bar uses 32×32
icons). This has the advantage of matching the location used in the
distribution which already ships this file.

https://github.com/transmission/transmission/issues/414
2017-11-30 17:38:34 +00:00
lasers e389c3d2d3 remove whitespace and a comma in the manuals 2017-11-28 16:58:21 -06:00
Mike Gelfand 3de8b75e59
Merge pull request #387 from DevilDimon/noGrowl
Remove Growl support
2017-11-29 00:59:04 +03:00
Dmitry Serov 9632af7c25 Remove Growl support 2017-11-29 00:38:14 +03:00
Mike Gelfand edf158b509
Merge pull request #364 from futekov/patch-2
Download/upload speed typography changes for web ui
2017-11-28 22:48:10 +03:00
Mike Gelfand eed33c373c
Merge pull request #411 from dubhater/master
Qt: Show file names in tooltips in Torrent Properties
2017-11-28 22:45:48 +03:00
Mike Gelfand daeec7d9ba
Merge pull request #429 from Fish2/master
lossless compression of images
2017-11-28 22:43:45 +03:00
Mike Gelfand 30c7c05cbb Refactor completion scripts execution
There're still a few issues here and there, but overall I believe it's now
better than it was before.
2017-11-28 10:03:08 +03:00
Mike Gelfand 5b29fe1556 Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
Fish2 d92b1c6a8f lossless compression of images 2017-11-04 00:26:40 +00:00
Mike Gelfand e10c049ef9
Merge pull request #394 from Allezxandre/fix/no-visible-interface
Fix `No @interface declares "containsIndex:"`
2017-11-01 09:38:20 +03:00
Mike Gelfand ede21744d3 Fix potential NULL pointer dereference introduced by last commit 2017-10-31 10:01:06 +03:00
Mike Gelfand 474aabbbc4 Take another approach to creating intermediate dirs on *NIX
Walk up one level at a time until the directory creation succeeds, then go
back down one level at a time. This reduces the number of operations in the
most common case (when directory already exists).
2017-10-30 10:23:18 +03:00
cantabile ecefb992a1 Show file names in tooltips in Torrent Properties
File names are often too long to fit. Hovering is much easier than
resizing the column and possibly the window.
2017-09-30 20:26:49 +03:00
Alexandre Jouandin b0a05c2fd1 Fix `No @interface declares "containsIndex:"`
This fixes the `No visible @interface for NSArray declares the selector "containsIndex:"` error that prevented Xcode (9b6) from compiling.
2017-08-31 01:21:08 +03:00
Mike Gelfand 0378ee8298 Merge pull request #386 from kholia/Netdisk
Add Peer ID for Baidu Netdisk
2017-08-27 10:22:30 +03:00
Mike Gelfand 486f040be4 Fix torrent list styling issue in Chrome 59+ (patch by @kyleinprogress)
Fixes: #384
2017-08-27 09:52:02 +03:00
Dhiru Kholia 874df139e1 Add Peer ID for Baidu Netdisk
Baidu Netdisk uses Azureus-style Peer ID with "-BN" prefix.
2017-08-26 11:11:31 +05:30
Mike Gelfand 1e9b805b4d Merge pull request #371 from bobbyhopere/anti-brute
anti-brute force for RPC Server
2017-08-23 22:51:03 +03:00
Mike Gelfand c41b957b7c Merge pull request #353 from DevilDimon/master
Transition to ARC
2017-08-23 22:47:35 +03:00
Dmitry Serov bad7f5d198 Use NSInvocation to make Growl compile under ARC 2017-08-18 18:47:55 +07:00
bobbyhopere cb6047ba3c All modifications suggested by mikedld 2017-08-13 13:53:41 +02:00
bobbyhopere 5f25e3be7f anti-brute force for RPC Server 2017-08-12 16:36:43 +02:00
Mike Gelfand 38d3d5377b Merge pull request #367 from clyang/master
Disable autocomplete on torrent url field from WebUI
2017-08-11 10:50:03 +03:00
clyang f21c9109ee Disable browser to autocomplete on torrent url field
It disrupts the view and I can't come up a daily usage scenario that needs to utilize autocomplete function.
2017-08-11 00:52:40 +08:00
Mike Gelfand 6410a460ea Merge pull request #360 from clyang/master
Improving ToS on IPv6 connections
2017-08-08 18:32:44 +03:00
Alexander Futekov 660b44da70 DL/UL speed typography changes for web ui
The current icons are very hard to read at the current font size and it's not immediately visible which icon i which.

Additionally, spaces after icons are removed because upload icon is equally positioned between DL/UL speeds (like so `↓ 273 kB/s **↑** 0 kB/s`) which requires reading the whole line to make sense of which number the arrow applies to.

To further separate one type of information from another the hyphen is replaced by the slightly wider en dash.

Old vs New:
Downloading from 7 of 19 peers - ↓ 273 kB/s ↑ 167 kB/s
Downloading from 7 of 19 peers – ▼273 kB/s ▲167 kB/s
2017-08-07 06:34:00 +03:00
Mike Gelfand 30467baa87 Merge pull request #363 from kholia/Folx
Add Peer ID for Folx
2017-08-07 01:33:47 +03:00
Dmitry Serov 1a78f538ab Merge remote-tracking branch 'origin/master' 2017-08-05 18:42:15 +07:00
Dmitry Serov 488633b0dc Enforce VDKQueue destruction before closing transmission session 2017-08-05 18:41:36 +07:00
Dhiru Kholia e1c8ec41f8 Add Peer ID for Folx
Based on experiments with Folx version 5.2.1.13690 running on macOS
Sierra.

Folx uses Azureus-style Peer ID with "-FL" prefix.
2017-08-05 12:29:16 +05:30
clyang 81c9653383 Improve ToS on IPv6 connections 2017-08-03 06:30:54 +03:00
Mike Gelfand ed754f9605 Merge pull request #355 from kholia/FDM
Add Peer ID for Free Download Manager (FDM)
2017-08-02 23:10:28 +03:00