19543ba65f
fix: clang-tidy-20 warnings ( #7187 )
...
* fix: readability-math-missing-parentheses clang-tidy warnings
* chore: remove unused function tr_ctorGetSession()
* chore: remove unused function tr_ctorGetIncompleteDir()
* chore: make generatePublicKey() a lambda
* fix: readability-container-contains warnings
* fix: misc-use-internal-linkage warnings
* chore: inline generate_public_key() since it was only used once
2024-10-21 20:57:01 -05:00
a76a07ae99
chore: misc code cleanups ( #6927 )
...
* refactor: avoid repeated subscripting in `announcer-udp.cc`
* chore: remove redundant locking in global ip cache
* chore: misc code cleanup in global ip cache
* fixup! chore: misc code cleanup in global ip cache
* refactor: remove `tr_global_ip_cache::create()`
* refactor: rename `tr_global_ip_cache` to `tr_ip_cache`
* build: sync changes to xcode
2024-07-14 01:37:55 +01:00
e1c9fbde60
fix: restore loose data type parsing in RPC and `settings.json` ( #6723 )
...
* refactor: incorporate lenient parsing from `tr_variantGet*()` functions into `tr_variant`
* fix: restore loose data types in RPC and settings.json
* fix: workaround GCC defect
* fix: MSVC build
2024-03-31 14:06:36 -05:00
3e958cfbaf
feat: µTP delayed ack ( #6586 )
...
* chore: rename tr utp functions to snake_case
* refactor: make udp sockets non-blocking
* feat: rudimentary uTP delayed ACK
* chore: housekeeping
* chore: correct comment about µTP packet format
2024-03-24 20:48:23 -05:00
c14d445cf5
refactor: libtransmission Settings ( #6592 )
...
* refactor: make tr_session_settings a libtransmission::Settings
* refactor: make VariantConverter private in settings.cc
2024-02-15 11:31:09 -06:00
eeea3c540f
fix: clang-tidy-19 warnings ( #6597 )
...
* fix: readability-redundant-casting warnings in libtransmission
* fix: readability-avoid-return-with-void-value warnings in libtransmission
* fix: readability-redundant-member-init warnings in libtransmission
* fix: readability-redundant-inline-specifier warnings in libtransmission
* fix: performance-avoid-endl warnings in libtransmission
* fix: bugprone-multi-level-implicit-pointer-conversion warnings in libtransmission
* fix: bugprone-switch-missing-default-case warnings in libtransmission
* fix: readability-redundant-string-cstr warnings in libtransmission
* fixup! fix: bugprone-multi-level-implicit-pointer-conversion warnings in libtransmission
2024-02-13 10:42:19 -06:00
f06cb37c06
feat: added `sleep-per-seconds-during-verify` to settings.json ( #6572 )
...
* feat: added `sleep-per-seconds-during-verify` to settings.json
* Ensuring `sleep_per_seconds_during_verify > 0` in `verify_torrent` for better performance
* `#include` list reordered alphabetically
* fix: `[readability-inconsistent-declaration-parameter-name]` warning
2024-02-12 09:30:40 -06:00
340d0d4966
refactor: add libtransmission::Settings ( #6575 )
...
* refactor: add libtransmission::Settings
* refactor: move RPC server's settings into tr_rpc_server::Settings
* build: update project.pbxproj
---------
Co-authored-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2024-02-07 10:14:47 -06:00
4bb9eab0d0
fix: app defaults should override libtransmission defaults ( #6495 )
2024-01-06 10:10:14 -06:00
d2d7987553
refactor: allow explicitly queuing functions in session thread ( #6406 )
...
* feat: allow explicitly queuing functions in session thread
* refactor: rename `tr_session_thread`-related functions to snake_case
2023-12-24 08:32:14 -06:00
2dea0b5fa2
fix: gcc 13 warnings, pt. 1 ( #6400 )
...
* fix: nullptr dereference warnings
* fix: mixed enumerated and non-enumerated warning
* fix: -Wnull-dereference warning in qt/MainWindow.cc
* fix: -Wnull-dereference warning in TorrentFilter::countTorrentsPerMode()
* fix: -Wnull-dereference warning in VariantHelpers::change(TrackerStat&, tr_variant*)
* build: bump google-test from 1.12.1 to 1.14.0
* Revert "build: bump google-test from 1.12.1 to 1.14.0"
This reverts commit 6fdcffa5de
2023-12-17 12:49:39 -06:00
2e46bad22d
refactor: constify the inout module ( #6328 )
...
* refactor: move tr_preallocation_mode info tr_open_files
* refactor: remove unnecessary error nullptr check
* refactor: use snake_case for private method names in inout.cc
* refactor: extract-method get_fd() from read_or_write_bytes()
* refactor: make function args const where possible
* refactor: simplify read_or_write_bytes()
* refactor: make buflen a uint64_t in read_or_write_piece()
* refactor: move tr_torrentStop() logic from read_or_write_piece() to tr_ioWrite()
* refactor: make tr_ioFoo() functions take a const torrent
* refactor: make tr_cache::close_torrent_files() take a tor_id instead of a torrent
2023-12-02 14:16:36 -06:00
5d64c860ea
fix: low priority not working ( #6079 )
2023-11-27 19:59:26 -06:00
777bdfecf1
refactor: make tr_torrent::queue_position_ private ( #6301 )
2023-11-27 01:27:57 -06:00
e14806c409
refactor: c++ify libtransmission's tr_ctor struct ( #6295 )
2023-11-26 15:43:37 -06:00
a12ef941e7
refactor: make tr_torrent fields, methods private where possible ( #6293 )
2023-11-25 20:00:20 -06:00
7e8eca0e96
refactor: make tr_torrent::seconds_[seeding,downloading] private ( #6279 )
2023-11-22 23:41:12 -06:00
64d9d57363
chore: fix minor clang-tidy warnings ( #6275 )
2023-11-21 09:02:03 -06:00
65d8ae5357
refactor: add a tr_direction arg to tr_torrent::is_queued() ( #6263 )
2023-11-16 23:55:29 -06:00
f8c544397a
refactor: add private helper class CumulativeCount ( #6260 )
...
* refactor: CumulativeCounts helper class
* refactor: add private CumulativeCounts helper class for tr_torrent
2023-11-15 18:53:43 -06:00
07d96036d9
refactor: Values pt. 6 - remove deprecated API ( #6250 )
2023-11-14 17:23:51 -06:00
90e91d6284
refactor: directly check if announcers are idle instead of using a stop counter ( #6237 )
2023-11-12 21:43:43 -06:00
0e85befc0f
refactor: Values pt. 3 - use Speed in tr_session ( #6235 )
2023-11-12 12:30:37 -06:00
a575be778f
refactor: Values pt. 2 - use Speed in tr_bandwidth ( #6234 )
2023-11-10 17:12:24 -06:00
8ac323d5d6
chore: removed copyright timespans in headers ( #4850 )
2023-11-01 16:11:11 -05:00
e54b17d92e
refactor: blocklists ( #6189 )
2023-10-31 19:20:01 -04:00
f0e9f90782
refactor: move tr_session::getAllTorrents to tr_torrents ( #6179 )
2023-10-30 16:38:02 -04:00
c0e5e3a368
refactor: reduce coupling between tr_session and tr_peerMgr ( #6151 )
2023-10-23 11:34:30 -04:00
8c1291ce8a
refactor: make tr_torrent::unique_id_ private ( #6145 )
2023-10-20 21:23:14 -05:00
4bdb3066d8
refactor: decouple tr_verify_worker from tr_torrent ( #6123 )
2023-10-19 08:39:34 -05:00
2c97567370
chore: minor housekeeping for bandwidth code ( #6080 )
2023-10-06 18:30:04 -05:00
c6236c7bee
fix: reconstruct `utp_core_` when toggling utp ( #6075 )
2023-10-04 20:33:18 -05:00
51995ab63f
fix: remove redundant `tr_lpd::create()` call ( #5900 )
2023-09-25 22:46:41 -05:00
6ead147620
refactor: use new tr_variant API in tr_session ( #6006 )
2023-09-16 08:23:35 -05:00
ebb1b775af
refactor: public tr_session settings API now returns tr_variants ( #5983 )
2023-09-07 19:05:16 -05:00
fbfbfac3ae
fix: minor coverity warnings ( #5916 )
...
* fix: unchecked return value from tr_variantDictFindInt()
coverity 1541113
* fix: unchecked return value from tr_variantDictFindBool()
coverity 1541112
* fix: copy-instead-of-move in tr_strlower()
coverity 1541092
* fix: use auto& instead of auto in test
coverity 1541084
* fix: logically dead code
coverity 1541065
* fix: copy-instead-of-move in tr_announcer_impl::addTorrent()
coverity 1541062
* fix: unchecked return value of tr_variantDictFindInt()
coverity 1541061
* fix: copy-instead-of-move in FilterBar::Impl::tracker_filter_model_update()
coverity 1541058
* fix: copy-instead-of-move in gtr_window_on_close()
* fix: silence invalid resource leak warning
coverity 1520595
* fix: unchecked return value from setsockopt()
coverity 1518345
* fix: dereference after null check (FORWARD_NULL)
coverity 1517816
2023-08-21 21:59:47 -05:00
59c638c63d
refactor: replace tr_variant::is_*() with tr_variant::holds_alternative() ( #5930 )
2023-08-21 16:16:54 -05:00
5837603b6f
refactor: make tr_variant follow RAII ( #5923 )
2023-08-20 23:15:23 -05:00
eea7d4d886
refactor: re-organise `net.h` member functions ( #5878 )
2023-08-17 22:13:01 -05:00
a4d205612a
refactor: add tr_variant_serde ( #5903 )
2023-08-17 11:02:45 -05:00
a88b353576
chore: rename other publicAddress() functions ( #5873 )
2023-08-14 10:31:12 -05:00
ca4cb1a675
fix/cleanups to tr_peerMsgsImpl ( #5783 )
...
* fix: correct condition to advertise pex support in ltep handshake
1. Advertise pex support regardless of whether the peer had advertised pex support. No reason to give up an opportunity to advertise pex support just because our direct peer does not support it.
2. Check if pex is enabled in global settings as well.
2023-07-14 10:51:52 -05:00
5ec4ca550e
chore: iwyu ( #5746 )
2023-07-08 10:24:03 -05:00
c364abcb6f
chore: misc-include-cleaner (partial) ( #5738 )
2023-07-06 10:00:07 -05:00
8543555584
refactor: use `std::pair` to store socket addresses ( #5723 )
2023-07-04 20:29:12 -05:00
56b27057fd
refactor: add lightweight observable / observer for decoupling ( #5716 )
2023-07-04 15:47:18 -05:00
8183d7fddf
refactor: utils naming ( #5696 )
...
* chore: rename tr_strvContains to tr_strv_contains
* chore: rename tr_strvStartsWith to tr_strv_starts_with
* chore: rename tr_strvEndsWith to tr_strv_ends_with
* chore: rename tr_strvSep to tr_strv_sep
* chore: rename tr_strvStrip to tr_strv_strip
* chore: rename tr_strvToBuf to tr_strv_to_buf
* refactor: rename tr_saveFile() to tr_file_save()
rename tr_loadFile() to tr_file_read()
rename tr_moveFile() to tr_file_move()
* refactor: rename tr_parseNum() to tr_num_parse()
refactor: rename tr_parseNumRange() to tr_num_parse_range()
* chore: group related functions together in header
2023-06-30 09:49:58 -05:00
ce66e5c442
iwyu: remove, add std headers where used ( #5694 )
...
* chore: remove unused #include <array>
* chore: remove unused #include <chrono>
* chore: remove unused #include <set>
* chore: remove unused #include <algorithm>
* chore: remove unused #include "interned-string.h"
* chore: remove unused #include <list>
* chore: remove unused #include <optional>
* chore: iwyu <cstddef>
* chore: iwyu <ctime>
* chore: remove unused #include <cerrno>
* chore: remove unused #include <deque>
* chore: remove unused #include <vector>
* chore: remove unused #include <memory>
* chore: remove unused #include <unordered_set>
* chore: remove unused #include <array>
* chore: remove unused #include <mutex>
* chore: remove unused #include <functional>
* chore: remove unused #include <cmath>
2023-06-29 23:51:55 -05:00
280dea4e33
add support for sending the `ipv4` parameter during ltep handshake ( #5643 )
2023-06-20 10:51:07 -05:00
802619e174
fix: fixes and improvements to global IP query ( #5510 )
2023-06-11 18:27:01 -05:00
Charles Kerr