Charles Kerr
250e055c1d
fix: warnings from clang tidy sonarcloud coverity ( #4143 )
2022-11-12 09:53:09 -06:00
A Cœur
48e42ac71e
Fix NSURLConnection is deprecated - Use NSURLSession ( #4112 )
2022-11-11 21:29:48 -06:00
A Cœur
2aa46f840c
Remove std::enable_if<std::is_member_function_pointer> ( #4139 )
2022-11-11 11:18:17 -06:00
Charles Kerr
9e06cf8f2e
refactor: make DHT unblocking ( #4122 )
2022-11-11 10:09:24 -06:00
Mike Gelfand
92b74fee74
Fix issues reported by clang-tidy modernize checks (GTK client) ( #4137 )
...
* Fix `modernize-avoid-c-arrays` clang-tidy issues
* Fix `modernize-raw-string-literal` clang-tidy issues
* Fix `modernize-use-nodiscard` clang-tidy issues
* Fix `modernize-deprecated-headers` clang-tidy issues
* Fix `modernize-pass-by-value` clang-tidy issues
* Extend clang-tidy configuration
Enable all `modernize` checks except for one (use-trailing-return-type)
which is an extensive stylistic change for later.
2022-11-10 20:35:31 +01:00
Charles Kerr
d61e31c419
fix: more thread safety updates ( #4136 )
...
* fix: thread safety in tr_sessionLoadTorrents()
* refactor: use std::future in tr_sessionSet()
* refactor: use std::future in tr_sessionClose()
2022-11-10 12:04:49 -06:00
Ilkka Kallioniemi
6f43883d8b
Update building docs for Debian ( #4101 )
2022-11-10 08:28:50 -06:00
Charles Kerr
2d2270c7d9
fix: thread-sanitizer warnings in SandboxedTests ( #4131 )
2022-11-09 23:56:08 -06:00
Charles Kerr
7e817b5a43
refactor: fix thread sanitizer warnings in tr_sessionClose() ( #4130 )
2022-11-09 20:30:34 -06:00
Mike Gelfand
1e32e44f60
Bind sensitivity properties in .ui files ( #4128 )
2022-11-09 20:46:23 +00:00
Charles Kerr
8b3fea9adf
build: bump libb64 ( #4129 )
...
this fixes a libb64 FTBFS in clang-15 due to -Werror
2022-11-09 14:04:06 -06:00
Mike Gelfand
eec93de5ca
Fix issues reported by clang-tidy readability checks (GTK client) ( #4127 )
...
* Fix `readability-container-data-pointer` clang-tidy issues
* Fix `readability-container-size-empty` clang-tidy issues
* Fix `readability-isolate-declaration` clang-tidy issues
* Fix `readability-convert-member-functions-to-static` clang-tidy issues
* Fix `readability-else-after-return` clang-tidy issues
* Fix `readability-redundant-member-init` clang-tidy issues
* Fix `readability-uppercase-literal-suffix` clang-tidy issues
* Fix `readability-make-member-function-const` clang-tidy issues
* Fix `readability-simplify-boolean-expr` clang-tidy issues
* Fix `readability-qualified-auto` clang-tidy issues
* Fix `readability-avoid-const-params-in-decls` clang-tidy issues
* Fix `readability-implicit-bool-conversion` clang-tidy issues
* Fix `readability-inconsistent-declaration-parameter-name` clang-tidy issues
* Add initial .clang-tidy configuration
Currently enabling readability checks only, others to follow. Of the
four disabled readability checks, three (function-cognitive-complexity,
identifier-length, magic-numbers) require extensive refactoring and were
left for later, and one (redundant-access-specifiers) is not planned to
be fixed due to the current coding style - using extra sections to
separate methods from variables of the same visibility.
2022-11-09 16:58:36 +00:00
A Cœur
69fda72a8b
refactor: remove superfluous interface declarations ( #4110 )
2022-11-08 23:36:53 -06:00
A Cœur
3e0ca88f7d
Fix "Forwarding reference passed to std::move" ( #4114 )
...
* Fix "Forwarding reference passed to std::move"
* Missing quotes in file references
2022-11-08 22:33:28 -06:00
Charles Kerr
ab78759233
test: add libtransmission::Timer tests ( #4121 )
2022-11-08 16:20:21 -06:00
Charles Kerr
00cc28cf0b
perf: reuse existing evtimers instead of creating new ones ( #4116 )
2022-11-07 22:42:42 -06:00
Hakjoon Sim
e44a08278b
fix: inspector icon should be disabled as default ( #4093 )
2022-11-07 17:31:30 -06:00
Gary Elshaw
c32161f7ca
feat: place upload above download in macOS badge ( #4055 )
2022-11-07 13:21:49 -06:00
A Cœur
cb932ddf8d
Fix "(arm64) could not find object file symbol for symbol" ( #4031 )
2022-11-07 13:04:26 -06:00
Charles Kerr
162035a653
fix: minor recent clang warnings ( #4111 )
...
* refactor: fix modernize-use-default-member-init warning in session-thread.cc
* refactor: fix readability-named-parameter warning in session-thread.cc
* refactor: fix clang-diagnostic-unused-function warning for isSupportedSocket()
* refactor: fix clang-analyzer-deadcode.DeadStores warning in buildHandshakeMessage()
* chore: fix readability-identifier-naming warning for tr_session::session_mutex_
* chore: fix readability-identifier-naming warning for Watchdir::generic_rescan_interval_
* chore: fix readability-identifier-naming warning for __tr_current_time
2022-11-07 11:48:26 -06:00
A Cœur
d2ee0d2d08
feat: Align active filter macOS ( #3944 )
2022-11-07 11:20:15 -06:00
A Cœur
91e5cf31f6
Fix "nil passed to a callee that requires a non-null 1st parameter" ( #4084 )
2022-11-07 09:57:35 -06:00
A Cœur
69ee92113f
Fix: values above INT_MAX (68 years) are interpreted as negative values ( #4085 )
2022-11-07 08:27:51 -06:00
A Cœur
fd7bb4a287
Fix "upload/download connectivity is broken" ( #4107 )
2022-11-07 00:15:35 -06:00
Charles Kerr
4d8509c180
refactor: add libtransmission::evhelpers ( #4104 )
2022-11-06 15:11:30 -06:00
Charles Kerr
36edd516aa
refactor: replace tr_boundinfo with tr_session::BoundSocket ( #4103 )
2022-11-06 10:35:48 -06:00
Mike Gelfand
bf17a3baf1
Fix web client directory name on Windows ( #4099 )
2022-11-05 08:45:34 +00:00
Hakjoon Sim
d0ab112622
fix: some style edited for chrome ( #4095 )
...
Thanks!
2022-11-05 00:05:23 -05:00
Charles Kerr
7f1a8bafe3
build: bump fast_float from v3.5.0 to v3.6.0 ( #4098 )
2022-11-04 18:46:13 -05:00
Charles Kerr
831eb8d40f
refactor: make tr_session_thread a unique_ptr owned by tr_session ( #4069 )
2022-11-04 16:20:27 -05:00
Mike Gelfand
d5cc43355c
Bump deps versions used for Windows release builds ( #4092 )
2022-11-04 18:38:28 +00:00
Charles Kerr
e065565cd4
reafctor: use getaddrinfo() instead of evdns ( #4094 )
2022-11-04 13:29:56 -05:00
Hakjoon Sim
f116407941
fix: chrome needs vendor prefix(-webkit-) for mask ( #4056 )
2022-11-03 23:01:17 -05:00
Charles Kerr
09bb1a60f0
refactor: add more nodiscard, constexpr, and noexcept ( #4089 )
2022-11-03 18:08:02 -05:00
Charles Kerr
ee8a6bd130
refactor: simplify blocklist code ( #4086 )
2022-11-03 15:46:27 -05:00
A Cœur
8857e8c1a4
Declare TR_ETA_NOT_AVAIL as time_t ( #4065 )
2022-11-03 11:42:42 -05:00
A Cœur
84badfc66f
removing unreachable code ( #4083 )
2022-11-03 09:47:43 -05:00
Mike Gelfand
f9abbaca70
Adjust Gio::File::query_info() error handling (GTK client) ( #4079 )
...
The method never returns `nullptr`, but instead throws if an error
occurs. This regressed during the switch from GTK to GTKMM.
2022-11-02 17:17:29 +00:00
SweetPPro
94eeae203b
fix: 4.0.0-beta.1 crash when updating blocklist ( #4011 )
2022-11-02 09:41:05 -05:00
A Cœur
64b5fde8b2
fixup: silence "empty expression statement has no effect" warning ( #4074 )
2022-11-02 09:04:22 -05:00
Mike Gelfand
49a3813a23
Check for functions we use when looking for system libutp ( #4072 )
...
Since libutp provides no version information, and one readily noticeable
change between the old and the new API is the change in public function
names, check to see if the functions we use are available. Old version
won't have them, and so any old system libutp will be discarded in AUTO
mode and result in an error in ON mode for USE_SYSTEM_UTP option.
2022-11-02 11:03:57 +00:00
A Cœur
2ca095d4a8
Fix set_version "The left operand of '&' is a garbage value" ( #4064 )
2022-11-02 05:39:14 +00:00
Mike Gelfand
dd4dce36a4
Downgrade Fedora image used in GitHub Actions CI to 36 ( #4070 )
...
37 is still "rawhide" and it starts to pull in packages from 38 making
things weird.
2022-11-02 03:15:31 +00:00
A Cœur
fa7100bdef
Auto enlarge search field when editing ( #4067 )
2022-11-01 20:40:24 -05:00
Charles Kerr
611d36ac84
refactor: decouple session settings from the session class ( #4053 )
2022-11-01 19:32:26 -05:00
Hakjoon Sim
41422c357e
fix: open torrent dialog layout adjusted ( #4063 )
2022-11-01 09:14:15 -05:00
Hakjoon Sim
745c884774
chore: get rid of webpack error while creating source map ( #4058 )
2022-10-31 16:14:01 -05:00
Charles Kerr
72ab5a85be
build: update the web client build deps ( #4059 )
...
chore: rebuild transmission-app.js with new deps
2022-10-31 14:20:11 -05:00
A Cœur
46eab5f3f8
Fix "User-facing text should use localized string macro" ( #4030 )
2022-10-31 09:37:34 -05:00
Charles Kerr
d5ef1ea80a
fix: test for tr_peerIo.gotError function pointer before use ( #4051 )
2022-10-29 16:59:24 -05:00
