db3d40d0ed
Switch to clang-format for code formatting, include Mac client
2021-08-16 00:38:29 +03:00
6b0408b320
refactor: fix more sonarcloud warnings ( #1509 )
...
* chore: simplify loop logic
* refactor: simplify isValidUtf8()
* refactor: use std::make_unique in Application::Application
* refactor: avoid raw pointers in DetailsDialog
* refactor: simplify DetailsDialog::refreshPref()
* refactor: make Application methods const
* refactor: reduce cognitive complexity of buildTrackerSummary()
2020-11-08 13:54:40 -06:00
7f147c65fb
refactor: fix more sonarcloud warnings ( #1508 )
...
* refactor: const correctness
* refactor: use getpwuid_r instead of getpwuid
* chore: simplify dict walking loop logic
* refactor: remove dead store assignment in announcer
* refactor: use std::make_shared
2020-11-05 16:46:21 -06:00
19e52d8b9a
chore: sonarcloud warnings 2 ( #1496 )
...
* fix "merge nested if" sonarcloud warnings
* fix explicit constructor warnings in qt client
2020-11-01 15:47:57 -06:00
e59fe7daaf
fix: silence some sonarcloud warnings ( #1493 )
...
* refactor: add null ptr check in initPeerRow()
* refactor: add a nullptr gurad in icon_cache_get_mime_type_icon
* chore: silence two "break notreached" warnings
* chore: silence sonarcloud html warnings
* chore: silence sonarcloud uninitialized var warning
* chore: silence sonarcloud nullptr warning
2020-10-31 16:23:43 -05:00
efaa66a920
fix: resolve some lgtm warnings ( #1444 )
...
* fix: warnings found by LGTM static analyzer
2020-09-11 16:07:45 -05:00
ff8d0dbf3b
Switch from UNUSED macro to TR_UNUSED macro
...
Since there is no way to mark parameters as [potentially] unused in
standard C and when using MSVC compiler, use the widely accepted
cast-to-void approach instead.
2020-08-18 14:19:55 +03:00
677dc73eac
refactor: use GTest for running tests ( #1383 )
...
* refactor: use google-test on libtransmission tests
2020-08-11 13:11:55 -05:00
6da4a4dfad
Fix or silence gtk warnings ( #1380 )
...
* chore: disable deprecation warnings in GTK client
Yes, updating the GTK codebase is still a goal. (help welcomed!)
But there's a deluge of deprecation warnings that drown out other more
important warnings, so turn off deprecation warnings for now.
* fixup! chore: disable deprecation warnings in GTK client
* fix: gtk_tree_sortable_set_sort_column_id caller.
* fix: gtk_window_resize caller.
2020-07-30 14:45:11 -05:00
073ae6c206
chore: fix deprecation warnings of GTK_STOCK_ use. ( #1370 )
...
* chore: fix deprecation warnings of GTK_STOCK_ use.
This is just a tiny step towards getting all of the GTK code up-to-date,
but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so
let's fix them.
2020-07-27 12:49:45 -05:00
a6482b0061
GTK: behavior improvements of the torrent details window ( #892 )
...
* gtk: torrent details file-list default sort
* gtk: save torrent details window size
* gtk: torrent details window size & sort, code style
* gtk: torrent details window, conf.c dict fix
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 16:34:02 -05:00
def7634f18
fix availability not showing 100% in gtk details view ( #1181 )
...
#1180
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-26 00:07:40 -05:00
b0e33117c5
Fix some gtk warnings ( #1038 )
...
* fix gtk deprecation warning: gtk_misc_set_alignment
* fix gtk deprecation warning: gtk_alignment_new
* fix gtk deprecation warning: gtk_tree_view_set_rules_hint
* fix gtk deprecation warning: gtk_image_new_from_stock
* fixup! fix gtk deprecation warning: gtk_alignment_new
* fix gtk deprecation warning: gtk_dialog_set_alternative_button_order
* fix gtk deprecation warning: gtk_show_uri
* fix gtk deprecation warning: gtk_widget_set_margin_left
* fix gtk deprecation warning: gtk_button_set_alignment
* fix gtk deprecation warning: g_type_class_add_private
* fix gtk deprecation warning: gtk_menu_popup
* fix gtk deprecation warning: gtk_misc_set_padding
* chore: uncrustify
* fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning
Deprecaed starting in glib 2.58
* chore: uncrustify
2019-11-06 13:09:27 -06:00
a3e4919385
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 12:00:06 +03:00
d3b8982195
Uppercase the literal suffixes
...
* MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case
* MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a
literal suffix
* CERT DCL16-C. - Use "L," not "l," to indicate a long value
* CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 07:07:48 +03:00
7e6f1a8dc8
Set idle seed limit range to 1..40320 (4 weeks tops) in all clients
...
Fixes : #212
2017-07-05 21:07:16 +03:00
1e3d20422a
Reduce for loop variables scope
2017-05-14 01:38:31 +03:00
14370e5353
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 18:47:49 +03:00
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
18ea8c429a
Improve RPC performance for local sessions
...
Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
06d73853b9
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
5f2daaafb3
(trunk, gtk/qt/web) #5581 : 'Inconsistent ordering of Upload and Download speed limits' -- fixed.
2014-01-20 23:56:06 +00:00
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
28fe36f1f8
#include limits.h where we use it, and don't where we don't
2013-08-24 17:53:45 +00:00
d1571bda02
(gtk) use replace strcmp() with g_strcmp0() everywhere
2013-02-14 15:17:42 +00:00
10b96f0f12
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
2a52ebab20
(gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate
2013-01-04 16:36:52 +00:00
3c9640bb8f
make tr_info.webseedCount and tr_info.trackerCount unsigned.
2012-12-30 22:06:45 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
e0a519fe8c
(trunk, gtk) #5174 'the text field in Properties>Trackers>Edit won't resize when the dialog is resized' -- fixed.
2012-12-16 22:51:29 +00:00
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
079c78981c
(trunk) #5168 'make libtransmission's public funcs nonblocking when possible' -- first attempt.
2012-12-12 20:22:57 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
7219f26dae
(trunk, T) #5072 "In the torrent list, show how many web seeds we're downloading from" -- made the Qt, GTK+, and web client text consistent
2012-10-07 17:51:56 +00:00
cdd71c6427
(trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2
2012-07-14 19:26:55 +00:00
3398a48e57
(trunk libT) #4402 "Transmission Bandwidth allocation getting overflows" -- use gvdl's patch '4402-uint-bpsoverflow.patch'
2012-07-01 02:17:35 +00:00
e599b3a738
(trunk gtk) To improve translations, help gettext to differentiate between the gerund and verb forms of some -ing words like "Seeding" and "Downloading" -- fixed.
...
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found: https://trac.transmissionbt.com/ticket/4717#comment:6
2012-02-03 17:12:17 +00:00
631a77287d
(trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…).
2012-02-03 15:51:36 +00:00
00757d8d33
(trunk gtk) remove dead assignment
2011-11-03 04:57:45 +00:00
f9388714b7
(trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2
2011-10-11 04:11:08 +00:00
b5de483362
(trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places.
2011-08-13 21:08:53 +00:00
c00b97169c
use a gulong when remembering the return value of g_signal_connect(). we were using a guint in some places.
2011-08-13 21:03:38 +00:00
Mike Gelfand