Jordan Lee
206b1a9a5f
(trunk web) fix warnings in tr_urlIsValidTracker() and tr_urlIsValid() found by llvm's scan-build.
...
scan-build found similar warnings in these two functions relating to allowing NULL pointers to be passed as arguments to functions that don't allow NULL. So now those NULL checks are made explicit before the function calls.
2011-12-14 05:40:21 +00:00
Jordan Lee
b3d382874a
(trunk libT) #4625 "Transmission 2.42 fails to build on Solaris 10: Undefined symbol 'mkdtemp'" -- fixed.
2011-11-10 03:31:43 +00:00
Jordan Lee
9c6e686882
(trunk libT) #4556 "Transmission 2.40 fails to connect with UDP trackers on big endian systems" -- fixed.
2011-10-14 00:02:36 +00:00
Mitchell Livingston
0808bdd2fe
We now require Mac OS X 10.6 or later. Make that change and all the nice little adjustments that go with it.
2011-10-06 00:30:40 +00:00
Jordan Lee
efc306a8d3
(trunk libT) truncate the fractions when formatting KB/s speeds
2011-07-17 14:15:02 +00:00
Jordan Lee
de34a0545b
(trunk libT) minor #include cleanups
2011-07-13 03:23:37 +00:00
Jordan Lee
4ecf0d36d1
(trunk libT) use tr_malloc() instead of malloc() in tr_loadFile() and in the fallback code for tr_valloc()
2011-04-27 16:12:17 +00:00
Jordan Lee
f37da42a8c
(trunk libT) fix ABR error when parsing a URL with no path and no trailing slash after the host. Error reported by livings124
2011-04-05 22:21:18 +00:00
Jordan Lee
1e0f92ba78
(trunk libT) Use tr_strndup() instead of tr_strdup() in tr_urlParse() to avoid a couple of strlen() calls
2011-04-05 00:55:09 +00:00
Jordan Lee
a2ee9f8d50
(trunk libT) avoid an unnecessary malloc/free in tr_urlIsValidTracker() and tr_urlIsValid()
2011-04-01 03:23:55 +00:00
Jordan Lee
1101ba8d57
(trunk libT) strip trailing whitespace
2011-03-28 13:37:46 +00:00
Jordan Lee
6c845ba5f4
(trunk libT) fix memory leak in tr_utf8clean()'s utility function to_utf8()
2011-03-28 03:45:31 +00:00
Jordan Lee
1650a4730c
(trunk libT) copyediting: yes, removing more unnecessary #includes
2011-03-25 06:20:12 +00:00
Jordan Lee
1b825079be
(trunk libT) API cleanup of the tr_address functions to make them more consistent.
...
This is loosely related to #2910 , but only in the sense of laying the groundwork for #2910 's fix...
2011-03-25 05:34:26 +00:00
Jordan Lee
1304aa0079
(trunk libT) still fiddling around with #includes -- this time removing unncecessary libT includes from libT .c files
2011-03-25 01:41:57 +00:00
Jordan Lee
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
Jordan Lee
48212fa0b9
(trunk libT) tr_strtruncd() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-22 23:46:31 +00:00
Jordan Lee
14277760d7
(trunk libT) tr_set_compare() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-22 23:42:25 +00:00
Jordan Lee
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
Jordan Lee
a9f1c9a5a6
(trunk libT) tweak comments to fix inconsistent capitalization
2011-03-20 15:56:32 +00:00
Jordan Lee
b16458e038
(trunk libT) #117 "UDP tracker support" -- fix add-UDP-tracker-URL-via-RPC bug reported by johnea @ https://trac.transmissionbt.com/ticket/117#comment:79
2011-03-20 15:42:54 +00:00
Jordan Lee
6ae220dee0
(trunk libT) tr_udpParse(): default to port 80 for URLs with a udp scheme and no explicit port.
2011-03-17 21:22:58 +00:00
Jordan Lee
374ed10f3b
(trunk) it's bad form to #include so many system headers in libtransmission/utils.h...
2011-03-16 18:04:23 +00:00
Jordan Lee
4fc6c1ada2
(trunk libT) add attribution for the fallback tr_htonll() and tr_ntohll() code
2011-03-13 20:39:08 +00:00
Jordan Lee
58c084fbda
(trunk libT) better implementation of tr_htonll() and tr_ntohll()
2011-03-13 20:23:23 +00:00
Jordan Lee
075a0a8b86
(trunk libT) use libevent's portability wrapper for strcasecmp()
2011-03-13 08:21:55 +00:00
Jordan Lee
7a24257d00
(trunk libT) tweaks by werehamster
2011-03-13 05:45:34 +00:00
Jordan Lee
3cfef5eded
(trunk libT) #117 "UDP tracker protocol support" -- working implementation; needs testing and valgrinding and review.
2011-03-13 00:18:11 +00:00
Jordan Lee
020bde5ce6
(trunk libT) a bit of futzing: remove a few more unnecessary casts from void*
2011-03-03 21:51:11 +00:00
Jordan Lee
2b8124d3ad
(trunk) #4019 "Minor patch, kill useless casts in transmission source." -- fixed. patch by jlouis
...
jlouis used Coccinelle to scan transmission's source for redundant code that casts a type to its own type.
2011-02-12 17:27:47 +00:00
Jordan Lee
392df7ceb8
(trunk libT) #3969 "tr_base64_encode() has unnecessary overhead with linefeeds" -- fixed.
...
Don't add linefeeds to base64-encoded data. We don't need it and it just increases the length of the string, which is typically sent over the network to an RPC client.
2011-01-31 22:47:07 +00:00
Jordan Lee
f2f08f5469
(trunk libT) more NULL ptr safeguards
2011-01-27 18:54:25 +00:00
Jordan Lee
35515ee424
(trunk libT) NULL ptr safeguard
2011-01-27 05:00:09 +00:00
Jordan Lee
53f7fbb039
(trunk libT) #3927 "Use of libevent2 evbuffer_write on files..."
...
evbuffer_write() is intended for sockets. It works for files on Unix, but not on Windows, so we can't portably use it on files. Instead, use evbuffer_pullup() + write().
2011-01-22 13:33:05 +00:00
Jordan Lee
06884387da
(trunk) #3914 "strlsize() passes variable of incompatible type to the tr_formatter_size_B()" -- fixed.
2011-01-19 18:14:01 +00:00
Jordan Lee
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Jordan Lee
cc428376e9
(trunk libT) in deep logging, use evbuffer_write() instead of fwrite()
2011-01-06 02:33:39 +00:00
Jordan Lee
35cf5e4a32
(trunk libT) Fix posix_memalign() unused result warning. inspired by ijuxda's 08b0c5b
2011-01-06 02:17:22 +00:00
Charles Kerr
b223a33b73
(trunk libT) fix crash reported by KyleK
2011-01-03 03:01:12 +00:00
Charles Kerr
21ca9e7770
(trunk libT) since messageLevel is a global variable, giving it a unique "tr_" prefix is a nice safeguard
2010-12-31 01:30:35 +00:00
Charles Kerr
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
Charles Kerr
81cb2276c8
(trunk gtk) #3844 "error popup when adding a relative path" -- fixed. initial patch by ijuxda.
2010-12-22 07:04:11 +00:00
Charles Kerr
345b14adbc
(trunk) #3836 "libevent2 support" -- bump libevent2 requirement to 2.0.10. This will break the Mac build for a minute intil BMW applies his Mac patch
2010-12-20 02:07:51 +00:00
Charles Kerr
a16fb94756
(trunk libT) #3813 "libtransmission doesn't build on Solaris 10 because of strsep call()" -- fixed.
2010-12-08 14:57:34 +00:00
Charles Kerr
9335e02e6d
(trunk libT) add some new bugs to the code so that it will crash when vraa tries to use it
2010-11-11 15:31:11 +00:00
Charles Kerr
5725b7c922
(trunk) #3663 "clang warnings in 2.11" -- fixed.
2010-10-24 05:52:38 +00:00
Charles Kerr
2ee5b08e94
(trunk libT) #3521 "rounding issue in tr_truncd()" -- try yet again to work out all the fringe cases :)
2010-10-21 23:47:23 +00:00
Charles Kerr
f3460eaea0
(trunk libT) #3521 "rounding issue in tr_truncd()" -- this time for sure...
2010-10-17 18:27:42 +00:00
Charles Kerr
8d15c48a3f
(trunk libT) #3617 "1000+ warnings of 'inlining failed' in libtransmission when compiled with gcc 4.4.4" -- fixed.
2010-10-11 15:41:27 +00:00
Charles Kerr
de4ab85030
(trunk libT) #3521 "rounding issue in tr_truncd()" -- fixed.
2010-10-11 15:05:24 +00:00
