Charles Kerr
b8802aebb5
fix: announce LDP on listening interface ( #5875 ) ( #5896 )
2023-08-13 22:02:54 -05:00
Zhenyu Qi
daff66690a
fix: announce with query replace bug ( #5871 )
2023-08-13 19:28:35 -05:00
Cœur
03ffe42ad4
fix: -fobjc-arc with GCC ( #5632 )
2023-07-29 20:58:38 -05:00
tearfur
e8ef1f3d38
fix: disregard locale when building LDP announce message ( #5825 )
2023-07-28 10:33:25 -05:00
tearfur
264746959b
fix: clamp down harder for upload as well ( #5821 )
2023-07-25 11:57:21 -05:00
tearfur
de26f38c77
perf: reduce copying in `enforceSwarmPeerLimit()` ( #5731 )
...
* reduce copying in `enforceSwarmPeerLimit()`
* clearer comparator naming
2023-07-14 19:55:36 -05:00
Charles Kerr
14e31babbb
perf: faster Cache::write_contiguous() ( #5715 )
2023-07-02 15:24:49 -05:00
tearfur
2941005e34
perf: convert comparator functors to static constexpr ( #5687 )
2023-06-30 12:29:53 -05:00
tearfur
87388ee7c8
perf: make `CompareCacheBlockByKey` constexpr ( #5678 )
2023-06-28 11:47:46 -05:00
Geoffrey Bonneville
115a069d8d
fix: do not write log if file handler is bad ( #5675 )
2023-06-27 13:56:01 -05:00
Charles Kerr
d2200cf9ea
perf: in cache, flush biggest contiguous blocks ( #5671 )
2023-06-27 12:20:38 -05:00
Charles Kerr
b86afe185b
fixup! fix: return error when renaming into existing file ( #5563 )
2023-06-22 17:33:19 -05:00
tearfur
4343926441
encode `&key=` as fixed-width 8-digit hex ( #5652 )
2023-06-21 11:53:28 -05:00
Василий Чай
504b77b0b9
fix: return error when renaming into existing file ( #5563 )
2023-06-19 00:31:18 -05:00
Mike Gelfand
3b44fa034d
Avoid locale use in `tr_truncd()` ( #5587 )
...
`tr_parseNum<>()` is implemented with `fast_float::from_chars()`, and
the latter is documented as "expecting a locale-indepent format
equivalent to what is used by std::strtod in the default ("C") locale".
To accomodate locale independent number parsing, switch back to
locale-independent number formatting in `tr_truncd()` by both removing a
`L` format specifier from `fmt::format_to_n()` call and using a fixed
"." decimal separator when truncating the value.
2023-06-10 17:09:55 -05:00
Charles Kerr
edcddd00dd
perf: avoid extra work in read_vc() ( #5527 )
2023-05-14 15:12:28 -05:00
Charles Kerr
04b5329345
fix: avoid unintentional map insertions in ActiveRequests::count() ( #5520 )
2023-05-12 20:18:47 -05:00
Gary Elshaw
96aefb5fc3
fix: comment typos in libtransmission ( #5473 )
2023-05-09 13:45:15 -05:00
Mike Gelfand
411b66cf88
fix: use user-preferred locale ( #5444 )
...
* Use user-preferred locale
Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.
Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.
* Improve libtransmission's json-test
Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.
* Improve transmission-show test runner script
Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
2023-04-27 09:11:06 -05:00
Charles Kerr
02b8535aa1
perf: in Buffer::Iterator, defer evbuffer API calls ( #5420 )
2023-04-26 23:29:57 -05:00
Charles Kerr
2be3ecfd27
fix: bug that prevented providing the final metadata piece ( #5460 )
...
Fixes bug in implementation of BEP 9
Xref: https://www.bittorrent.org/beps/bep_0009.html
2023-04-26 23:29:07 -05:00
Charles Kerr
c37b297b25
fix: minor warnings ( #5409 )
...
* chore: fix readability-qualified-auto warnings
* chore: fix clang-analyzer-core.uninitialized.Branch warning
* fix: collision of key 'ERROR' in transmission-qt
* chore: silence -Wshadow warning
* chore: silence warning C4100: 'iter': unreferenced formal parameter
* chore: fix warning C4127: conditional expression is constant warning
2023-04-20 14:16:09 -05:00
Kyle Sanderson
256fd698d7
fix: uninitialized session_id_t values ( #5396 )
2023-04-20 14:13:51 -05:00
Charles Kerr
0e2b8d721c
fix: only torrent metainfo display-name as a fallback ( #5378 )
...
Fixes #5347 .
2023-04-12 17:26:43 -05:00
Charles Kerr
e33d9536ef
fix: return success on RPC add-torrent duplicate ( #5370 )
...
Keep Transmission 3's behavior to avoid unannounced API change
2023-04-12 13:37:04 -05:00
Cœur
91717fe91d
fix: potential NSString leak in tr_strv_convert_utf8()
2023-04-11 17:36:22 -05:00
Charles Kerr
c76cb4db51
fix: silence torrent-metainfo warnings for cross_seed_entry, uid ( #5365 )
2023-04-10 11:07:43 -05:00
tearfur
931beba56f
fix: set log level before constructing tr_session ( #5345 )
2023-04-03 15:37:28 -05:00
tearfur
e68c72daa4
fix: tr_net_hasIPv6() ( #5312 )
2023-03-28 13:41:07 -05:00
tearfur
85a00625dc
fix: intermediate fix for HTTP announce behaviour affected by `bind-address-ipv*` ( #5296 )
2023-03-28 12:59:42 -05:00
Mike Gelfand
a216bd7cec
Use locale-dependent decimal separators for user-visible numbers ( #5288 )
...
This includes percents, ratios, sizes, speeds, etc. coming from shared
formatting helpers. Previously based on sprintf-like functions using
locale, now using libfmt which doesn't use locale by default and needs
to be instructed to do it explicitly.
2023-03-23 19:48:45 -05:00
Cœur
3e97d0b9c2
fix: The right operand of '<' is a garbage value ( #5285 )
2023-03-23 12:05:11 -05:00
Charles Kerr
d63165e8a4
perf: fix wishlist cpu load regression, pt. 2 ( #5273 )
2023-03-22 10:24:10 -05:00
Charles Kerr
25f38d5ff3
fix: wrong tier value in torrent get tracker stat response ( #5274 )
2023-03-21 20:23:08 -05:00
Charles Kerr
58ce7bd437
fix: 4.0.2 wishlist CPU perf regression pt. 1 ( #5266 )
2023-03-20 21:08:16 -05:00
Cœur
c60bb5b834
fix: crash when magnet dn isn't utf-8 ( #5244 )
2023-03-19 10:36:16 -05:00
Charles Kerr
5cc3bf8a97
fix: generate peer-id on launch ( #5233 )
2023-03-15 20:53:48 -05:00
Charles Kerr
3aeefec203
chore: remove unused header includes ( #5227 )
2023-03-14 18:36:15 -05:00
Charles Kerr
a87d39f3bd
fix: filter out peers with port 1 from DHT peer lists. ( #5218 )
2023-03-13 19:27:47 -05:00
Charles Kerr
6224b60728
fix: wrong error message when writing to incomplete dir ( #5217 )
2023-03-13 16:20:39 -05:00
Colin B
59a157ebde
feat: restore support for nonstandard `path.utf-8` ( #3454 )
2023-03-13 13:58:59 -05:00
Charles Kerr
dabd29f2b2
fix: std::clamp() assertion failure in maxAvailableReqs() ( #5203 )
2023-03-11 22:25:21 -06:00
Charles Kerr
900281eb1c
fix: check tr_ctorSetFoo() return values before adding torrent via RPC ( #5202 )
2023-03-11 19:44:54 -06:00
Charles Kerr
86fd89fff4
fix: remove interest strategy code that could contribute to oscillating download speeds. ( #5176 )
2023-03-10 13:21:51 -06:00
Charles Kerr
b354337720
ci: check for clang tidy errors in libtransmission ( #5188 )
2023-03-10 00:23:22 -06:00
reardonia
9c436d87dd
fix: torrentGet.wanted RPC breaking change in [4.0.0..4.0.1] ( #5170 )
2023-03-07 19:44:25 -06:00
Charles Kerr
033d698306
fix: parsing of ipv6 tracker announce URLs ( #5174 )
2023-03-07 12:19:12 -06:00
Charles Kerr
39e3e1d87b
fix: increase priority of first and last piece of each file ( #5167 )
...
The first and last pieces of a file generally include information needed
by preview generators, so prioritizing those pieces makes life easier
for users or tools that look at files while they're being downloaded.
This worked in 3.00 but isn't present in 4.0.0.
2023-03-06 15:50:19 -06:00
reardonia
56c1bb2a9e
fix: publish 'leechers' iff it was in tracker response ( #5164 )
2023-03-06 09:22:40 -06:00
Charles Kerr
b2b0f0db39
fix: crash in curl_easy_pause() ( #5161 )
2023-03-05 23:42:52 -06:00