375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
48212fa0b9
(trunk libT) tr_strtruncd() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-22 23:46:31 +00:00
14277760d7
(trunk libT) tr_set_compare() is only used in one place, so make it a private function there instead of leaving it public in utils.h
2011-03-22 23:42:25 +00:00
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
a9f1c9a5a6
(trunk libT) tweak comments to fix inconsistent capitalization
2011-03-20 15:56:32 +00:00
b16458e038
(trunk libT) #117 "UDP tracker support" -- fix add-UDP-tracker-URL-via-RPC bug reported by johnea @ https://trac.transmissionbt.com/ticket/117#comment:79
2011-03-20 15:42:54 +00:00
6ae220dee0
(trunk libT) tr_udpParse(): default to port 80 for URLs with a udp scheme and no explicit port.
2011-03-17 21:22:58 +00:00
374ed10f3b
(trunk) it's bad form to #include so many system headers in libtransmission/utils.h...
2011-03-16 18:04:23 +00:00
4fc6c1ada2
(trunk libT) add attribution for the fallback tr_htonll() and tr_ntohll() code
2011-03-13 20:39:08 +00:00
58c084fbda
(trunk libT) better implementation of tr_htonll() and tr_ntohll()
2011-03-13 20:23:23 +00:00
075a0a8b86
(trunk libT) use libevent's portability wrapper for strcasecmp()
2011-03-13 08:21:55 +00:00
7a24257d00
(trunk libT) tweaks by werehamster
2011-03-13 05:45:34 +00:00
3cfef5eded
(trunk libT) #117 "UDP tracker protocol support" -- working implementation; needs testing and valgrinding and review.
2011-03-13 00:18:11 +00:00
020bde5ce6
(trunk libT) a bit of futzing: remove a few more unnecessary casts from void*
2011-03-03 21:51:11 +00:00
2b8124d3ad
(trunk) #4019 "Minor patch, kill useless casts in transmission source." -- fixed. patch by jlouis
...
jlouis used Coccinelle to scan transmission's source for redundant code that casts a type to its own type.
2011-02-12 17:27:47 +00:00
392df7ceb8
(trunk libT) #3969 "tr_base64_encode() has unnecessary overhead with linefeeds" -- fixed.
...
Don't add linefeeds to base64-encoded data. We don't need it and it just increases the length of the string, which is typically sent over the network to an RPC client.
2011-01-31 22:47:07 +00:00
f2f08f5469
(trunk libT) more NULL ptr safeguards
2011-01-27 18:54:25 +00:00
35515ee424
(trunk libT) NULL ptr safeguard
2011-01-27 05:00:09 +00:00
53f7fbb039
(trunk libT) #3927 "Use of libevent2 evbuffer_write on files..."
...
evbuffer_write() is intended for sockets. It works for files on Unix, but not on Windows, so we can't portably use it on files. Instead, use evbuffer_pullup() + write().
2011-01-22 13:33:05 +00:00
06884387da
(trunk) #3914 "strlsize() passes variable of incompatible type to the tr_formatter_size_B()" -- fixed.
2011-01-19 18:14:01 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
cc428376e9
(trunk libT) in deep logging, use evbuffer_write() instead of fwrite()
2011-01-06 02:33:39 +00:00
35cf5e4a32
(trunk libT) Fix posix_memalign() unused result warning. inspired by ijuxda's 08b0c5b
2011-01-06 02:17:22 +00:00
b223a33b73
(trunk libT) fix crash reported by KyleK
2011-01-03 03:01:12 +00:00
21ca9e7770
(trunk libT) since messageLevel is a global variable, giving it a unique "tr_" prefix is a nice safeguard
2010-12-31 01:30:35 +00:00
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
81cb2276c8
(trunk gtk) #3844 "error popup when adding a relative path" -- fixed. initial patch by ijuxda.
2010-12-22 07:04:11 +00:00
345b14adbc
(trunk) #3836 "libevent2 support" -- bump libevent2 requirement to 2.0.10. This will break the Mac build for a minute intil BMW applies his Mac patch
2010-12-20 02:07:51 +00:00
a16fb94756
(trunk libT) #3813 "libtransmission doesn't build on Solaris 10 because of strsep call()" -- fixed.
2010-12-08 14:57:34 +00:00
9335e02e6d
(trunk libT) add some new bugs to the code so that it will crash when vraa tries to use it
2010-11-11 15:31:11 +00:00
5725b7c922
(trunk) #3663 "clang warnings in 2.11" -- fixed.
2010-10-24 05:52:38 +00:00
2ee5b08e94
(trunk libT) #3521 "rounding issue in tr_truncd()" -- try yet again to work out all the fringe cases :)
2010-10-21 23:47:23 +00:00
f3460eaea0
(trunk libT) #3521 "rounding issue in tr_truncd()" -- this time for sure...
2010-10-17 18:27:42 +00:00
8d15c48a3f
(trunk libT) #3617 "1000+ warnings of 'inlining failed' in libtransmission when compiled with gcc 4.4.4" -- fixed.
2010-10-11 15:41:27 +00:00
de4ab85030
(trunk libT) #3521 "rounding issue in tr_truncd()" -- fixed.
2010-10-11 15:05:24 +00:00
b63d64e0e3
(trunk libT) #3521 "rounding issue in tr_truncd()" -- fixed.
2010-09-22 16:09:36 +00:00
599c5a8cc4
(trunk daemon) #3511 , part 2 of 2: get rid of the TR_DEBUG environment variable
2010-09-22 15:17:16 +00:00
4d7046fd67
(trunk) #3547 "Wrong speed display in web UI" -- fixed
2010-09-18 23:06:03 +00:00
ac53f4792f
switch trackerRemove and trackerReplace rpc calls to use tracker id instead of announce urls as identifiers
2010-09-14 06:23:48 +00:00
2d5ac5b150
(trunk libT) add a string length argument to tr_urlIsValid()
2010-08-21 12:47:28 +00:00
230193053e
(trunk libT) #3449 "overflow error in tr_truncd()" -- fixed.
2010-07-24 17:09:39 +00:00
9ea1cff367
(trunk libT) disable some more unnecessary debug messages
2010-07-17 22:37:13 +00:00
38c25a5890
(trunk libT) fix minor "comparison between signed and unsigned" warning in tr_moveFile()
2010-07-13 13:23:51 +00:00
6f5c9dcafb
(trunk libt) rename tr_date() as tr_time_msec() for clarity
2010-07-11 20:49:19 +00:00
71cadc02b6
(trunk web) #3413 "download speed bad format in web interface" -- fixed.
2010-07-10 02:05:25 +00:00
52c04a0d06
(trunk) some units formatter cleanup.
2010-07-09 20:53:38 +00:00
098117c987
(trunk libT) use the Mac client's speed formatter
2010-07-08 03:20:07 +00:00
91d8cbc383
(2.0x trunk) #3397 "checksum errors when downloading files whose names are encoded in iso-8859-1" -- fixed
2010-07-07 16:48:23 +00:00
88c61f8cc2
(trunk) #3045 fix oops from last commit
2010-07-06 20:52:54 +00:00
610061f79a
(trunk T) #3045 "units" -- modify the formatter functions based on feedback from BMW
2010-07-06 20:25:54 +00:00
6e5af03d78
(trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings
2010-07-04 06:07:21 +00:00
cdcc4705aa
(trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while.
2010-07-03 00:25:22 +00:00
5a8c94cfe4
(trunk libT) #3382 "2.01+ (10919) hangs after launch" -- fixed.
2010-07-01 16:09:47 +00:00
a5a1f38393
(trunk libT) fix more issues found by -Wconversion
2010-07-01 05:14:34 +00:00
4a9e36e842
(trunk libT) #3381 "replace calls to usleep() with calls to nanosleep()" -- done.
2010-07-01 03:59:06 +00:00
254a1f15cb
(trunk libT) down the rabbit hole: various minor type correctness changes unearthed by -Wconversion
2010-06-30 16:40:19 +00:00
77a2cf02f1
(trunk libT) fix a couple of minor warnings found by -Wfloat-equal
2010-06-30 15:05:43 +00:00
d9e4ca49b5
(trunk) avoid a few unnecessary type conversions. remove a few unnecessary mutex locks.
2010-06-30 06:03:55 +00:00
1f3ead026d
(trunk) #3311 "MingW build of Transmission" -- modify tr_strip_positional_args() to strip out the ' printf flag. Platforms not supporting $ tend to not support ' either
2010-06-25 01:13:35 +00:00
bcb53a8937
(2.0x) #3340 "tr_moveFile() can be faster" -- fixed for 2.01
2010-06-24 17:34:56 +00:00
075169b409
(trunk libT) formatter_get_size_str() -- we don't need decimal places when displaying bytes :)
2010-06-23 20:14:30 +00:00
bbe9e9843a
#3298:Prettier formating of percentages
2010-06-22 22:30:58 +00:00
e6cf296a68
(trunk libT) add an accessor for the formatter unit strings
2010-06-22 13:34:46 +00:00
1d63aa4cda
(trunk) add tr_formatter_size() and tr_formatter_speed() so that all the client apps don't have to reinvent the wheel
2010-06-22 04:34:16 +00:00
08628333d1
(trunk libT) part of rb07's win32 portability patches from ticket #3311
2010-06-21 16:44:35 +00:00
eda211e5ce
(trunk) #2983 : add command-line utilities for creating .torrent files, for editing passkeys, for adding/removing trackers, etc.
2010-06-16 14:27:24 +00:00
0ad06c50e8
(trunk) #3262 "problems with '.' as the first character in a .torrent's filename" -- fixed in trunk for 2.00
2010-06-07 14:25:31 +00:00
af2ae0eac4
reverting r9177: pow() is a basic math function and should be used instead of a hack
2010-05-31 13:43:33 +00:00
fe3d9ed95a
(trunk) one of the least interesting commits ever: remove trailing spaces from source code lines...
2010-03-17 17:07:40 +00:00
7d7529eb94
(trunk libT) make tr_updateTime() inlined
2010-03-12 19:24:45 +00:00
3e79f4b3fe
(trunk libT) fix BSD build issue
2010-03-06 19:33:04 +00:00
6d639f354b
(trunk libT) use tr_valloc() in a couple of places where we allocate largish, short-term buffers
2010-02-23 07:29:21 +00:00
5667b80ba6
(trunk libT) try to make the posix_memalign() #includes work right on Darwin too
2010-02-23 06:15:47 +00:00
c615514944
(trunk libT) add a wrapper function tr_valloc() to try posix_memalign(), getpagesize(), valloc() etc
2010-02-23 06:06:45 +00:00
5a9a07b71e
(trunk) #2938 "crash when adding a torrent by URL from an ftp source over RPC" -- fixed in trunk for 1.91
2010-02-20 15:57:05 +00:00
0ea501355e
(trunk daemon) #2877 "Don't let the daemon launch if settings.json is corrupt" -- implemented in trunk for 1.90
2010-02-07 22:17:42 +00:00
205b21dca3
add a convenience function for determining if an address is an IP address, and when picking a favicon in the Mac UI's tracker tab, use the full IP address when applicable
2010-02-01 23:52:46 +00:00
70e3e7156c
(trunk libT) #2833 "LP64 bug on OpenBSD" -- fixed in trunk for 1.90
2010-01-29 18:07:21 +00:00
e26a1783c6
(trunk libT) #2777 "some magnet links get misparsed" -- fixed in trunk for 1.81
2010-01-21 05:10:00 +00:00
182cbb8b90
(trunk) one of the less-interesting commits in a while: remove trailing spaces from lines
2010-01-05 23:47:50 +00:00
5c26afdb52
happy new year!
2010-01-04 21:00:47 +00:00
283b6d6a36
(trunk libT) rename tr_wait() tr_wait_msec()
2010-01-01 22:30:36 +00:00
6b8fb48d64
(trunk libT) replace the TR_INLINE macro with the standard "inline" keyword, since we require inline functions anyway
2010-01-01 22:26:35 +00:00
ac202f13bb
(trunk libT) remove dead code -- tr_assert()
2009-12-28 23:11:26 +00:00
ed1df8beac
(trunk libT) removed dead code: tr_isTimeval(), tr_timevalMsec(), tr_timevalSet()
2009-12-12 01:05:29 +00:00
0f14f62ac1
(trunk libT) new utility function tr_timerAddMsec()
2009-12-10 19:04:10 +00:00
cd0de2ebe5
(trunk libT) fix errors in tr_httpParseURL()
2009-12-10 09:13:08 +00:00
f73f223540
(trunk libT) #2653 "transmission-remote-dotnet makes transmission-daemon segfault" -- fixed for 1.80
2009-12-09 12:44:23 +00:00
78ead8c3dd
(trunk) update the copyright notices
2009-12-05 02:19:24 +00:00
5fb643431e
decrease the size of the buffer for logging
2009-12-05 01:28:42 +00:00
8efe3f7cce
remove a redundant level check in tr_msg()
2009-12-05 01:02:37 +00:00
ad06c660c8
cap libT's message log
2009-12-01 23:20:00 +00:00
0563580dda
inline tr_removeElementFromArray()
2009-11-30 01:31:05 +00:00
87823ba99c
set two blank functions as inline
2009-11-28 22:29:41 +00:00
2021706c6e
remove an unneeded static variable
2009-11-27 18:13:36 +00:00
8214c797c6
trivial cleanup in the logging code
2009-11-27 17:55:09 +00:00
8e7d08fc83
(trunk libT) remove unnecessary calls to tr_msgInit(). Suggested by BentMyWookie.
2009-11-27 15:32:11 +00:00
c7f061cafc
(trunk libT) make tr_msgLoggingIsActive() an inlined function. suggested by BentMyWookie
2009-11-27 15:25:14 +00:00
e1c6b792aa
(trunk libT) #2610 "avoid unnecessary calls to time(NULL)"
2009-11-26 18:47:08 +00:00
931afc7d2a
(trunk libT) fix variable name oops
2009-11-26 16:53:45 +00:00
cf69b11031
(trunk libT) #2595 : "file too large error?" -- this can generate an EFBIG warning sparse preallocation is on and the peer makes an invalid request. At worst this kind of oddball case should generate a debug message notice, not a torrent error. Reported by Waldorf.
2009-11-25 19:26:30 +00:00
f69e335291
(trunk) #2096 : Magnet, BEP #9 support
2009-11-24 02:16:31 +00:00
9383a6abfd
(trunk libT) #2096 : add code magnet URL parser and unit tests
2009-11-20 04:38:19 +00:00
48227fdfe1
eliminate setting an unnecessary null character
2009-11-09 05:08:59 +00:00
37dda955a1
(trunk libT) use __attribute__((nonnull)) where appropriate. remove two unused functions tr_int2ptr(), tr_ptr2int()
2009-11-01 01:35:06 +00:00
060bd2f722
(trunk libT) #2547 : fix tr_lowerBound()
2009-10-31 22:16:06 +00:00
08e936704c
(trunk libT) fix signed/unsigned comparison warnings on amd64
2009-10-30 14:53:17 +00:00
f5b97d43c9
(trunk libT) portability improvements to tr_moveFile()
2009-10-30 03:53:41 +00:00
22e3f1175a
(trunk libT) #2531 : when the user moves a torrent from one location to another, we don't need to reverify if the files are just rename()d
2009-10-27 23:00:34 +00:00
73222ce7aa
(trunk libT) revert r9345, because all our .torrent and .resume files' hex letters are in lowercase
2009-10-22 18:48:26 +00:00
adfb6f70a1
(trunk libT) show sha1's hex letters in uppercase, as suggested by waldorf
2009-10-21 16:24:58 +00:00
d7c4537f2a
(trunk, libT) #2379 : infinite ratio shows as nan, invalid json
2009-09-26 04:24:45 +00:00
306d26a97c
(trunk libT) very minor tweak: tr_httpIsValidURL() should return a tr_bool, not an int.
2009-08-12 19:44:32 +00:00
cb79214854
(trunk) remove trailing spaces
2009-08-10 20:04:08 +00:00
e5ff7d8f3e
(trunk) #2271 : rounding problem in printf()
2009-07-14 20:09:46 +00:00
057638c4e9
(trunk libT) #2240 : Cryptic information messages on startup
2009-06-23 14:43:09 +00:00
1be7f51b3d
(trunk libT) simplify the evtimer / struct timeval code a little
2009-06-15 03:24:40 +00:00
8e676171d4
(trunk libT) move tr_bitfield into its own, package-visible source files. this may break the mac build temporarily until the xcode file gets synced
2009-06-15 00:11:06 +00:00
d8360f9a26
(trunk libT) avoid an unnecessary malloc/free in tr_strdup_printf()
2009-06-14 01:01:46 +00:00
ef21704b58
(trunk libT) remove the last calls to tr_getBuffer() and tr_releaseBuffer()
2009-06-14 01:00:36 +00:00
a2b9fcc592
(trunk libT) possible fix for #2078 : Assertion failed: (tv->tv_usec >= 0)
2009-06-12 23:01:35 +00:00
9513fcbe66
(trunk libT) add a bunch of comments denoting where the libevent 2.0 changes will go
2009-06-02 18:21:23 +00:00
66da41e517
(trunk) dht seems to be crashing in bcmp() on the mac, so I suspect the homegrown implementation of memmem() is buggy... test this out by replacing memmem()'s implementation
2009-05-22 05:35:51 +00:00
d0a84bcf09
boring tr_memmem tweaks
2009-05-20 04:30:55 +00:00
af213891f9
(trunk libT) make tr_memmem() more readable
2009-05-20 04:25:45 +00:00
dc02274d4c
(trunk libT) silence a compiler warning
2009-05-19 15:53:34 +00:00
ed710be223
(trunk libT) expose tr_memmem() so it can be used by client code. use the OS' implementation if that's available.
2009-05-19 04:48:33 +00:00
29b1d3e2cc
(trunk) #920 : add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
54b7f9ccab
(trunk libT) #2030 : revert false alarm r8361 as per this suggestion http://trac.transmissionbt.com/ticket/2030#comment:45
2009-05-08 20:52:12 +00:00
a0597ec8fb
(trunk libT) clean up the debugging messages added to smoke out #2030
2009-05-07 13:03:39 +00:00
7fcf0a294b
(trunk libT) add some testing messages for #2030... this dumps a lot of junk to the terminal and will be taken out as soon as there's some meaningful feedback in #2030
2009-05-07 01:05:10 +00:00
acb3b443f7
(trunk libT) silently add a \0 after the end of files read by tr_loadFile() so that text files can be handled directly as ascii strings
2009-04-28 20:42:55 +00:00
698aa192aa
(trunk libT) convert tr_open_file_for_scanning() and tr_close_file() to use file descriptors instead of file pointers so that we don't have to mix and match between them
2009-04-26 20:44:18 +00:00
13a0a0556c
(trunk libT) make tr_loadFile() use tr_open_file_for_scanning()
2009-04-26 07:59:36 +00:00
54e2e8ca2f
(trunk libT) avoid unnecessary malloc()s & free()s in tr_utf8clean()
2009-04-16 21:00:48 +00:00
5df2570fdf
(trunk libT) make tr_localtime_r() a public function
2009-03-25 18:42:39 +00:00
9d335e391e
(trunk libT) #1906 : Huge ratio precision (too many decimal places)
2009-03-09 23:51:58 +00:00
93b3d1ad7e
(trunk) #1881 : promote tr_strratio() to libtransmission, so that its code doesn't have to be repeated in all the clients
2009-03-04 16:16:02 +00:00
fce040eb84
(trunk libT) #1828 : timestamp for log/debug output
2009-02-18 05:09:28 +00:00
65bba3fdfb
(trunk libT) #1671 : transmission-remote --get option not including all files
2009-02-09 17:25:48 +00:00
29661cf245
(trunk libT) new macro, tr_assert(). use it to help smoke out #1749
2009-01-25 16:14:11 +00:00
4d228289ce
(trunk libT) prefer `int' over `ssize_t'
2009-01-19 14:05:43 +00:00
b6588f442b
(trunk libT) have tr_strndup() take an ssize_t instead of an int
2009-01-18 15:15:41 +00:00
92ee6566db
(trunk libT) #1675 : better utf8 validation of metainfo name, creator, and comment fields
2009-01-10 22:48:58 +00:00
141847b902
(trunk libT) update the copyrights on some files that no longer have old code in them
2009-01-07 06:53:29 +00:00
2eb1faa5e8
(trunk libT) minor speedup tweaks in peer-request hotspots
2009-01-04 18:01:15 +00:00
51e68d6e56
(trunk libT) new peer request fifo queue with log(N) search time. new unit tests for the queue. new utility tr_lowerBound()
2009-01-04 16:29:44 +00:00
5afd327b15
(trunk libT) use ssize_t where appropriate in tr_peerIoFlush()
2009-01-03 04:57:40 +00:00
dfa0622a6c
(trunk libT) add "deep log" message to help track down freeze reported by the|Navigator. also, small + cheap speedup in tr_deepLoggingIsActive()
2009-01-03 02:43:17 +00:00
5e9af46612
(trunk libT) make the tr_bandwidth macros into safer inline funcs. inline utils' one-liners.
2009-01-02 20:12:23 +00:00
Jordan Lee