Charles Kerr
ac202f13bb
(trunk libT) remove dead code -- tr_assert()
2009-12-28 23:11:26 +00:00
Charles Kerr
4e44e9c2cb
(trunk libT) https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/500625
2009-12-28 00:35:29 +00:00
Charles Kerr
bc86c0b364
(trunk libT) #2416 "crash in event_queue_insert" -- maybe this will finally fix it...
2009-12-26 23:57:25 +00:00
Charles Kerr
8bc90ca644
(trunk libT) fix crash in tr_fdSocketClose() reported by agsystem in the forums @ http://forum.transmissionbt.com/viewtopic.php?p=42993&f=1#p42993
2009-12-26 23:52:59 +00:00
Mitchell Livingston
f6a5117ef9
calculate proper file progress for 0-byte files ( fixes #2689 )
2009-12-25 16:56:33 +00:00
Mitchell Livingston
8dbfb708f5
#2696 posix_fadv_dontneed undeclared
2009-12-25 15:48:41 +00:00
Charles Kerr
8903e1b4e3
(trunk libT) #2416 "crash in event_queue_insert" -- another experimental commit. /as an experiment/ let's just leak that event struct and see if that makes the crash go away. Obviously leaking those objects is not a long term fix but this will help point the way towards the real fix.
2009-12-24 18:50:34 +00:00
Charles Kerr
3e2269e5e3
(trunk libT) #2632 "Add streaming capability to libtransmission (but not the Transmission GUI clients)" -- revert this feature due to pushback from devs and users and the 1.80 freeze
2009-12-24 18:01:48 +00:00
Charles Kerr
12ffdb7d87
(trunk libT) #2632 "Add streaming capability to libtransmission (but not the Transmission GUI clients)" -- implemented
2009-12-24 01:02:54 +00:00
Charles Kerr
b8d7e76750
(trunk libT) #2416 "crash in event_queue_insert" -- possible fix. it looks like the kqueue client is accessing the event after the callback and after event_del() is being called. *If* that's the case I don't know if it's a libevent bug or if libtransmission is making assumptions it shouldn't've... but it's easy enough to keep the memory in a pool and free it later when it's safer to do so.
2009-12-23 16:12:18 +00:00
Mitchell Livingston
a7245651f2
avoid an extra comparison caused by macro expansion
2009-12-21 22:03:19 +00:00
Mitchell Livingston
25a023023f
eliminate the clamp function for now, allow peer connections once again
2009-12-21 14:30:43 +00:00
Charles Kerr
ef650d0398
(trunk libT) it certainly smells like we're using freed memory in the libcurl + libevent code in web.c... let's trash the structures right before free()ing them
2009-12-18 17:32:16 +00:00
Charles Kerr
a653d37225
(trunk libT) possibly reduce the frequency of the "too many open files" errors
2009-12-18 07:05:36 +00:00
Charles Kerr
2ff810d18f
(trunk) use AC_ARG_VAR for some autoconf variables s.t. their values will persist between reconfs
2009-12-18 05:02:48 +00:00
Charles Kerr
d9369718b3
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
Eric Petit
a91c5e44e3
build fix
2009-12-16 07:47:04 +00:00
Charles Kerr
122d69d013
(trunk libT) try not to cache file data read in during verification
2009-12-16 06:34:17 +00:00
Charles Kerr
22e61e68ed
(trunk libT) fix call to updateDesiredRequestCount() reported by sadface
2009-12-16 01:32:23 +00:00
Charles Kerr
d6f7df8c9a
(trunk libT) #2508 "atom->port never updated" -- (1) fix r9434 bug that used the wrong byte ordering scheme for port numbers. This is why most of the .resume file's peers are worthless in betas 1 and 2. :( (2) in the resume file, change the dictionary key for peers so that the worthless peers won't be reloaded on startup in beta 3.
2009-12-16 00:45:18 +00:00
Charles Kerr
f3e8a29e0f
(trunk libT) #2548 "T's request queue can send out too many duplicate requests" -- fix off-by-one when counting how many peers we'll send a given block request to during endgame
2009-12-15 21:33:24 +00:00
Charles Kerr
22e33f784b
(trunk libT) #2548 "T's request queue can send out too many duplicate requests" -- experimental revision to r9465 to address further overdownloading issues
2009-12-15 20:13:34 +00:00
Charles Kerr
c789454dba
(trunk libT) #2667 "Ignore martian addresses" -- apply jch's 0001-Simplify-martian-address-detection.patch cleanup patch from http://trac.transmissionbt.com/ticket/2667#comment:8
2009-12-15 20:06:48 +00:00
Charles Kerr
33c6b0d9ec
(trunk libT) #2667 "ignore martian addresses" -- revise the tests to tr_isValidPeerAddr() base
...
d on feedback from jch @ http://trac.transmissionbt.com/ticket/2667#comment:6
2009-12-15 19:39:01 +00:00
Charles Kerr
c819d6dca6
(trunk libT) #2671 "downloading from too many peers" -- address a smaller aspect of this ticket, by reducing the minimum number of blocks we request from a peer, as noted by jch's comment @ http://trac.transmissionbt.com/ticket/2671#comment:2
2009-12-15 18:11:20 +00:00
Charles Kerr
f4c744266f
(trunk libT) #2667 "ignore martian addresses" -- modified this ticket. previously we ignored them from LTEP; now we ignore them regardless of the source. this commit implements this filtering change.
2009-12-15 17:39:19 +00:00
Charles Kerr
de9498f1ab
(trunk libT) #2669 "Apply IPV6_V6ONLY to the IPv6 DHT socket" -- committed jch's patch for 1.80
2009-12-15 16:48:26 +00:00
Charles Kerr
c17932f533
(trunk libT) #2673 "crash in tr_torrentGetMetadataPiece" -- add safeguards against small sizes
2009-12-15 16:34:12 +00:00
Eric Petit
5fb945653f
#2673 crash in tr_torrentGetMetadataPiece
2009-12-15 15:19:08 +00:00
Charles Kerr
ed6e95eef3
(trunk) add #include guards to prevent non-libtransmission files from #including implementation headers
2009-12-15 00:51:39 +00:00
Charles Kerr
e7baa2b480
(trunk libT) maybe fix that blocklist crash John_Clay reports about once a month
2009-12-14 18:47:45 +00:00
Charles Kerr
0601442f58
(trunk libT) #2416 "crash in event_queue_insert" -- another stab at fixing this. yay
2009-12-14 18:24:26 +00:00
Charles Kerr
8cee197cac
(trunk libT) fix minor memory leak in libtransmission/tr-dht.c, found by valgrind
2009-12-14 17:46:00 +00:00
Charles Kerr
87aefaf5ff
(trunk libT) #1699 "announce to multiple trackers at once" -- fix minor bug in reporting scrape results when an announce returns enough information that a separate scrape isn't necessary.
2009-12-14 17:17:05 +00:00
Charles Kerr
ee0de4b06c
(trunk libT) keep simplifying web.c... is there anything left to strip out?
2009-12-14 14:25:22 +00:00
Charles Kerr
c33aef7e2d
(trunk libT) more web.c simplification + handle an unhandled case CURL_POLL_NONE in the socket callback.
2009-12-14 12:54:30 +00:00
Charles Kerr
2653cd5153
(trunk libT) keep simplifying web.c. also, fix an improbable FMR at shutdown
2009-12-14 05:11:33 +00:00
Charles Kerr
3fe5db7113
(trunk libT) #2667 "Ignore martian addresses in LTEP messages" -- implemented for 1.80
2009-12-14 02:07:47 +00:00
Charles Kerr
6d9e6ececc
(trunk libT) remove some more obsolete debug messages and other cruft from web.c
2009-12-13 19:33:02 +00:00
Charles Kerr
485b64a5e3
(trunk libT) it never ends
2009-12-13 17:54:01 +00:00
Mitchell Livingston
bdf3144376
remove unnecessary asserts
2009-12-12 21:37:36 +00:00
Charles Kerr
2d1b6748ec
(trunk libT) #2661 "better torrent prioritization when making outbound peer connection attempts" -- implemented for 1.80
2009-12-12 17:05:31 +00:00
Charles Kerr
20a4560198
(trunk libT) remove the test for duplicate trackers in the announce list.
2009-12-12 04:12:04 +00:00
Charles Kerr
196a7ccbb9
(trunk libT) #2658 "encryption improvements" - patch by sadface to make DH handshake ~2x faster. yay!
2009-12-12 03:51:36 +00:00
Charles Kerr
ed1df8beac
(trunk libT) removed dead code: tr_isTimeval(), tr_timevalMsec(), tr_timevalSet()
2009-12-12 01:05:29 +00:00
Charles Kerr
1f320b2ddd
(trunk) fix a couple of cases where we don't use the tr_snprintf() portability wrapper
2009-12-11 20:26:40 +00:00
Charles Kerr
a89d2217af
(trunk libT) #2416 "crash in event_queue_insert()"
2009-12-11 15:41:34 +00:00
Charles Kerr
5f1f2b1e85
(trunk libT) use curl_multi_socket_action(), even on OS X.
2009-12-10 19:05:21 +00:00
Charles Kerr
0f14f62ac1
(trunk libT) new utility function tr_timerAddMsec()
2009-12-10 19:04:10 +00:00
Charles Kerr
a1ccd10f89
(trunk libT) add simple tr_http_unescape() unit test
2009-12-10 10:44:06 +00:00
Charles Kerr
cd0de2ebe5
(trunk libT) fix errors in tr_httpParseURL()
2009-12-10 09:13:08 +00:00
Charles Kerr
1c772bd1fe
(trunk libT) finally get rid of the last remnants of tr_timer
2009-12-10 05:52:46 +00:00
Charles Kerr
9fb6c5b1c4
(trunk libT) #2655 : "1.80b1 crash in peer-mgr.c's getPeersToClose()" -- fixed
2009-12-10 04:54:48 +00:00
Charles Kerr
f73f223540
(trunk libT) #2653 "transmission-remote-dotnet makes transmission-daemon segfault" -- fixed for 1.80
2009-12-09 12:44:23 +00:00
Charles Kerr
02f4038f67
(trunk libT) #2641 "a magnetic-induced crash because of malformed url" -- fixed in trunk for 1.80b2
2009-12-09 04:28:53 +00:00
Charles Kerr
4b3b5dcd8a
(trunk libT) by request, remove a clientData argument from tr_torrentDeleteLocalData() (reverts r9690)
2009-12-09 03:51:21 +00:00
Charles Kerr
5f9f97ee2a
(trunk libT) by request, add a clientData argument to tr_torrentDeleteLocalData()
2009-12-09 03:40:35 +00:00
Charles Kerr
c5af8965e0
(trunk libT) the deleteFunc passed in as the second argument to tr_torrentDeleteLocalData() should /not/ be called unless the file being passed to it actually exists. Reported by livings124
2009-12-09 03:00:20 +00:00
Charles Kerr
bcd01fda3b
(trunk libT) #2651 : "missing errmsg in RPC torrentSet" -- reported & patched by elbandi
2009-12-09 01:36:31 +00:00
Charles Kerr
857e37bf77
(trunk libT) #2643 "Total UL/DL ratio reset when quitting abnormally" -- fixed.
2009-12-08 20:51:45 +00:00
Charles Kerr
907c67ba78
(trunk libT) remove unnecessary #includes
2009-12-07 03:57:55 +00:00
Eric Petit
769629499e
The IPv6 check could always fail because we did not specify a port when
...
trying to set up the UDP socket (was reproducible here on 10.6 at least)
2009-12-06 16:21:29 +00:00
Charles Kerr
d370222113
(trunk libT) #2551 "when uploading to peers, prefetch local data from disk" -- prefetching performance tweak described in http://trac.transmissionbt.com/ticket/2551#comment:22 -- instead of prefetching [8..12] blocks, always prefetch 12 blocks
2009-12-05 19:30:15 +00:00
Charles Kerr
78ead8c3dd
(trunk) update the copyright notices
2009-12-05 02:19:24 +00:00
Mitchell Livingston
5fb643431e
decrease the size of the buffer for logging
2009-12-05 01:28:42 +00:00
Mitchell Livingston
8efe3f7cce
remove a redundant level check in tr_msg()
2009-12-05 01:02:37 +00:00
Charles Kerr
31a3ed1684
(trunk, qt) #2096 "magnet links" -- Add the "Copy Magnet Link to Clipboard" feature to Qt client
2009-12-03 15:23:43 +00:00
Charles Kerr
79154bac8a
(trunk) #2096 "magnet links" -- fix RPC typo introduced in r9655 and reported by KyleK
2009-12-03 12:40:23 +00:00
Charles Kerr
7537f02589
(trunk libT) #2636 : "wrong peer progress update" -- possible fix as described in comment:2
2009-12-03 03:11:22 +00:00
Charles Kerr
bb44a31423
(trunk) #2096 "Magnet Links - Extension for Peers to Send Metadata Files (BEP #9 )" -- publish tr_stat.metadataPecentComplete in the RPC so that kjg can use it in the web client
2009-12-02 20:05:19 +00:00
Charles Kerr
d1935a4812
(trunk libT)
...
11:59 < klapaucjusz> charles: net.c line 314.
11:59 < klapaucjusz> Please change the value to 8192.
12:00 < charles> okay but why?
12:00 < klapaucjusz> I'm not sure it will trigger, but having space for 4 full-sized segments is always a good idea.
12:01 < klapaucjusz> It means you have a better chance of recovering from a lost segment
2009-12-02 20:03:27 +00:00
Charles Kerr
560ecbe9bb
(trunk libT) fix implicit pointer conversion error when #included in C++
2009-12-02 19:44:01 +00:00
Charles Kerr
6d008257c8
(trunk libT) minor tweaks: make bencode's int parser code more consistent; make some comments more readable
2009-12-02 15:16:29 +00:00
Charles Kerr
6eec59008c
(trunk libT) experimental: Reduce SO_SNDBUF and SO_RCVBUF for tracker announce/scrape messages. Reduce SO_RCVBUF for outgoing peer connections on seeding torrents.
2009-12-02 05:30:46 +00:00
Mitchell Livingston
5392b262d7
10,000 log messages is enough for anyone
2009-12-02 01:55:09 +00:00
Mitchell Livingston
ad06c660c8
cap libT's message log
2009-12-01 23:20:00 +00:00
Charles Kerr
9f347f8df1
(trunk) #2119 "daemon should reload settings.json on SIGHUP" -- reload the blocklists, too. Suggested by nano- in irc.
2009-12-01 00:07:18 +00:00
Charles Kerr
12bfde0c2b
(trunk) #1663 "crashes on shutdown if libevent loop doesn't exit soon enough" -- maybe crash less frequently now.
2009-11-30 04:58:03 +00:00
Mitchell Livingston
0563580dda
inline tr_removeElementFromArray()
2009-11-30 01:31:05 +00:00
Charles Kerr
03351e9a4e
(trunk libT) #2607 "avoid unnecessary calls to getPeerCandidates(), wasted cycles in peerIsInUse()"
2009-11-29 18:35:02 +00:00
Charles Kerr
33658647d6
(trunk libT) #2576 "IPv6 support for DHT (BEP #32 )" -- silence message "IPv6 DHT not ready." Reported by KyleK; fixed by jch
2009-11-29 18:31:36 +00:00
Charles Kerr
5c3fd1b5cc
(trunk libT) #2631 "Add webseed support to magnet links"
2009-11-29 17:49:58 +00:00
Charles Kerr
da7ab27ae2
(trunk libT) add SO_SNDBUF, SO_RCVBUF logging messages
2009-11-29 08:53:14 +00:00
Charles Kerr
a38fb59c6f
(trunk libT, gtk) #2625 "ability to create a magnet link" -- add hook for generating a magnet link from a tr_torrent, and use it in the Torrent Properties dialog in the GTK+ client
2009-11-29 08:27:55 +00:00
Charles Kerr
63027e1d5a
(trunk libT) resolve "noslashes" vs "keep_slashes" variable name inconsistency between the declaration and the definition of tr_http_escape()
2009-11-29 08:05:47 +00:00
Mitchell Livingston
4e615c55a0
trivial change to array size
2009-11-29 00:04:29 +00:00
Mitchell Livingston
87823ba99c
set two blank functions as inline
2009-11-28 22:29:41 +00:00
Charles Kerr
de0d6af06b
(trunk libT) remove unnecessary code
2009-11-28 16:25:05 +00:00
Charles Kerr
d1f9b8ddee
(trunk libT) performance improvements to peer-mgr.c's peerIsInUse()
2009-11-28 07:15:31 +00:00
Mitchell Livingston
2021706c6e
remove an unneeded static variable
2009-11-27 18:13:36 +00:00
Mitchell Livingston
8214c797c6
trivial cleanup in the logging code
2009-11-27 17:55:09 +00:00
Charles Kerr
8e7d08fc83
(trunk libT) remove unnecessary calls to tr_msgInit(). Suggested by BentMyWookie.
2009-11-27 15:32:11 +00:00
Charles Kerr
c7f061cafc
(trunk libT) make tr_msgLoggingIsActive() an inlined function. suggested by BentMyWookie
2009-11-27 15:25:14 +00:00
Charles Kerr
864ae61a70
(trunk libT) tweak the debugging message for the atom manager
2009-11-27 14:27:44 +00:00
Charles Kerr
fc0a8b7c93
(trunk) #2614 : "incorrect memory usage when not using IPv6" -- accepted dht.c + tr-dht.c patches
2009-11-27 14:18:32 +00:00
Charles Kerr
47c6ec5efa
(trunk libT) #2551 : "when uploading to peers, prefetch local data from disk" -- fix peer-msgs.c NULL pointer dereference introduced in r9514 for this ticket. Reported by Waldorf
2009-11-27 03:21:21 +00:00
Charles Kerr
d7d5bb6db7
(trunk libT) #2610 "avoid unnecessary calls to time(NULL)" -- fix new assertion error reported by John Clay and tstevens
2009-11-27 02:24:48 +00:00
Charles Kerr
e1c6b792aa
(trunk libT) #2610 "avoid unnecessary calls to time(NULL)"
2009-11-26 18:47:08 +00:00
Charles Kerr
d096b39f4b
(trunk libT) #2430 "peer atom pool grows too large" -- tweak the default atom shelf lives based on discussion in the ticket's comments section
2009-11-26 18:38:37 +00:00
Charles Kerr
cebcc3b6ef
(trunk libT) #2096 "magnet links" -- add a callback for clients to know when a magnet torrent's metainfo is finished downloading.
2009-11-26 17:58:44 +00:00