refactor: rename `mcast_socket_` to `mcast_sockets_`

refactor: dedupe `if_nametoindex()` call
chore: housekeeping
2024-04-24 10:42:59 +08:00 · 2024-04-24 10:42:59 +08:00 · 2024-04-24 10:42:59 +08:00 · 2024-04-24 10:42:59 +08:00 · 2024-04-24 10:42:59 +08:00 · 2024-04-24 10:42:59 +08:00
3 changed files with 3 additions and 3 deletions
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -41,7 +41,7 @@ On macOS, Transmission is usually built with Xcode. Everywhere else, it's CMake
 - Prefer `enum class` over `enum`
 - Prefer new-style headers, e.g. `<cstring>` over `<string.h>`
 - Fix any warnings in new code before merging
- Run `./code-style.sh` on your code to ensure the whole codebase has consistent indentation.
+- Run `./code_style.sh` on your code to ensure the whole codebase has consistent indentation.

 Note that Transmission existed in C for over a decade and those idioms don't change overnight. "Follow the C++ core guidelines" can be difficult when working with older code, and the maintainers will understand that when reviewing your PRs. :smiley:

--- a/libtransmission/net.h
+++ b/libtransmission/net.h
@ -409,7 +409,7 @@ struct tr_socket_address
 };

 template<>
-class std::hash<tr_socket_address>
+struct std::hash<tr_socket_address>
 {
 public:
    std::size_t operator()(tr_socket_address const& socket_address) const noexcept
--- a/utils/transmission-remote.1
+++ b/utils/transmission-remote.1
@ -150,7 +150,7 @@ Get a file list for the current torrent(s)
 .It Fl g Fl -get Ar all | file-index | files
 Mark file(s) for download.
 .Ar all
-marks all all of the torrent's files for downloading,
+marks all of the torrent's files for downloading,
 .Ar file-index
 adds a single file to the download list, and
 .Ar files
Author	SHA1	Message	Date
Yat Ho	3cc9711ab4	refactor: rename `mcast_socket_` to `mcast_sockets_`	2024-04-24 10:42:59 +08:00
Yat Ho	5e8ab62de5	refactor: dedupe `if_nametoindex()` call	2024-04-24 10:42:59 +08:00
Yat Ho	8de4269047	chore: housekeeping	2024-04-24 10:42:59 +08:00
Yat Ho	83d2dc991d	fix: enable multicast loop	2024-04-24 10:42:59 +08:00
Yat Ho	3fe87979a1	refactor: use `tr_socket_address::from_string()`	2024-04-24 10:42:59 +08:00
Yat Ho	b4ad1f78fc	feat: find interface index from ip address	2024-04-24 10:42:59 +08:00
Yat Ho	9bcb86ebb0	feat: ipv6 lpd	2024-04-24 10:42:59 +08:00
Pooyan Khanjankhani	821a6816ef	doc: fix typo (#6790 )	2024-04-21 18:21:17 -05:00
Dzmitry Neviadomski	ef18816b7f	Fix code style script path in CONTRIBUTING.md (#6787 ) Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>	2024-04-21 07:36:13 -05:00
Dzmitry Neviadomski	0e25584e78	Make std::hash specialization for tr_socket_address a struct (#6788 ) To be in line with std::hash declaration See https://en.cppreference.com/w/cpp/utility/hash Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>	2024-04-20 21:01:47 -05:00