refactor: remove `UpnpState::Failed`

fix: recover from failed UPnP discovery
code review: explicitly list all states to start discovering from
2024-04-24 10:04:06 +08:00 · 2024-04-24 10:04:06 +08:00 · 2024-04-24 10:04:06 +08:00 · 2024-04-24 10:04:06 +08:00 · 2024-04-24 10:04:06 +08:00 · 2024-04-24 10:04:06 +08:00
4 changed files with 4 additions and 4 deletions
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -41,7 +41,7 @@ On macOS, Transmission is usually built with Xcode. Everywhere else, it's CMake
 - Prefer `enum class` over `enum`
 - Prefer new-style headers, e.g. `<cstring>` over `<string.h>`
 - Fix any warnings in new code before merging
- Run `./code-style.sh` on your code to ensure the whole codebase has consistent indentation.
+- Run `./code_style.sh` on your code to ensure the whole codebase has consistent indentation.

 Note that Transmission existed in C for over a decade and those idioms don't change overnight. "Follow the C++ core guidelines" can be difficult when working with older code, and the maintainers will understand that when reviewing your PRs. :smiley:

--- a/libtransmission/net.h
+++ b/libtransmission/net.h
@ -404,7 +404,7 @@ struct tr_socket_address
 };

 template<>
-class std::hash<tr_socket_address>
+struct std::hash<tr_socket_address>
 {
 public:
    std::size_t operator()(tr_socket_address const& socket_address) const noexcept
--- a/libtransmission/rpc-server.cc
+++ b/libtransmission/rpc-server.cc
@ -74,7 +74,7 @@ auto constexpr TrUnixSocketPrefix = "unix:"sv;
 #ifdef _WIN32
 auto inline constexpr TrUnixAddrStrLen = size_t{ INET6_ADDRSTRLEN };
 #else
-auto inline constexpr TrUnixAddrStrLen = size_t{ sizeof(((struct sockaddr_un*)nullptr)->sun_path) +
+auto inline constexpr TrUnixAddrStrLen = size_t{ sizeof(std::declval<struct sockaddr_un>().sun_path) +
                                                 std::size(TrUnixSocketPrefix) };
 #endif

--- a/utils/transmission-remote.1
+++ b/utils/transmission-remote.1
@ -150,7 +150,7 @@ Get a file list for the current torrent(s)
 .It Fl g Fl -get Ar all | file-index | files
 Mark file(s) for download.
 .Ar all
-marks all all of the torrent's files for downloading,
+marks all of the torrent's files for downloading,
 .Ar file-index
 adds a single file to the download list, and
 .Ar files
Author	SHA1	Message	Date
Yat Ho	74ad24b410	refactor: remove `UpnpState::Failed`	2024-04-24 10:04:06 +08:00
Yat Ho	9dfc4bbfde	fix: recover from failed UPnP discovery	2024-04-24 10:04:06 +08:00
Yat Ho	4f4831a82b	code review: explicitly list all states to start discovering from	2024-04-24 10:04:06 +08:00
Yat Ho	effc776e1a	chore: housekeeping	2024-04-24 10:04:06 +08:00
Yat Ho	1a5671efbd	feat: allow natpmp to recover from errors	2024-04-24 10:04:06 +08:00
Yat Ho	62c8062bba	feat: allow upnp to recover from errors	2024-04-24 10:04:06 +08:00
Pooyan Khanjankhani	821a6816ef	doc: fix typo (#6790 )	2024-04-21 18:21:17 -05:00
Dzmitry Neviadomski	ef18816b7f	Fix code style script path in CONTRIBUTING.md (#6787 ) Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>	2024-04-21 07:36:13 -05:00
Dzmitry Neviadomski	0e25584e78	Make std::hash specialization for tr_socket_address a struct (#6788 ) To be in line with std::hash declaration See https://en.cppreference.com/w/cpp/utility/hash Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>	2024-04-20 21:01:47 -05:00
Dzmitry Neviadomski	bd0b74fccb	Use std::declval instead of nullptr cast trick (#6785 ) Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>	2024-04-15 15:18:43 -05:00