309d97c578
* Silence coverity CHECKED_RETURN on added.f load
The existing code behaved alright since added.f is optional.
However, by testing for success we can both silence the warning
and prevent a useless initialization of NULL/0 to added_f and
added_f_length.
* Silence coverity CHECKED_RETURN on added6.f load
ipv6 variant of previous commit.
* Silence coverity CHECKED_RETURN writing benc strs
saveStringFunc() gets the target string by calling tr_variantGetStr().
It previously didn't check to see if this function succeeded because
saveStringFunc() isn't reached without the type already being known.
However, checking the return value costs nothing and makes Coverity happy.
* Silence coverity CHECKED_RETURN on ut metadata
Like earlier few Coverity commits in this PR, we're handling optional
values by declaring stack locals set to the default (e.g. -1) and then
trying to read the variant.
Unlike the earlier commits, there is a two-part step to thise read:
checking for the metadata, then checking for the individual fields.
The earlier fixes' aproach -- e.g. initializing to -1 only if the reads
failed -- would involve new nested conditionals. I find the new complexity
to outweigh the benefit of removing the dead store, so in this case I'm
casting the return value to `(void)` to tell Coverity to shush.
* Silence coverity CHECKED_RETURN on scrape
Check the return value of tr_variantGetInt() when showing
seeder and leecher counts in transmission-show.
* Silence CHECKED_RETURN on rpc recently-active
When building a list of removed torrent IDs from variants, confirm that
we can read the IDs from the variants before adding them to the list.
I don't _think_ this would have failed before, but Coverity's right that
it's reasonable to add a safeguard here.
* fix: better fix to serializing benc strings
The approach in
|
||
|---|---|---|
| .tx | ||
| Transmission.xcodeproj | ||
| cli | ||
| cmake | ||
| daemon | ||
| dist/msi | ||
| extras | ||
| gtk | ||
| libtransmission | ||
| m4 | ||
| macosx | ||
| po | ||
| qt | ||
| third-party | ||
| utils | ||
| web | ||
| .gitignore | ||
| .gitmodules | ||
| .jsbeautifyrc | ||
| AUTHORS | ||
| CMakeLists.txt | ||
| COPYING | ||
| ChangeLog | ||
| Makefile.am | ||
| NEWS | ||
| README.md | ||
| autogen.sh | ||
| configure.ac | ||
| transmission-gtk.spec.in | ||
| uncrustify.cfg | ||
| update-version-h.sh | ||
README.md
About
Transmission is a fast, easy, and free BitTorrent client. It comes in several flavors:
- A native Mac OS X GUI application
- GTK+ and Qt GUI applications for Linux, BSD, etc.
- A headless daemon for servers and routers
- A web UI for remote controlling any of the above
Visit https://transmissionbt.com/ for more information.
Command line interface notes
Transmission is fully supported in transmission-remote, the preferred cli client.
Three standalone tools to examine, create, and edit .torrent files exist: transmission-show, transmission-create, and transmission-edit, respectively.
Prior to development of transmission-remote, the standalone client transmission-cli was created. Limited to a single torrent at a time, transmission-cli is deprecated and exists primarily to support older hardware dependent upon it. In almost all instances, transmission-remote should be used instead.
Different distributions may choose to package any or all of these tools in one or more separate packages.
Building
Transmission has an Xcode project file (Transmission.xcodeproj) for building in Xcode.
For a more detailed description, and dependencies, visit: https://github.com/transmission/transmission/wiki
Building a Transmission release from the command line
$ tar xf transmission-2.92.tar.xz
$ cd transmission-2.92
$ mkdir build
$ cd build
$ cmake ..
$ make
$ sudo make install
Building Transmission from the nightly builds
Download a tarball from https://build.transmissionbt.com/job/trunk-linux/ and follow the steps from the previous section.
If you're new to building programs from source code, this is typically easier than building from Git.
Building Transmission from Git (first time)
$ git clone https://github.com/transmission/transmission Transmission
$ cd Transmission
$ git submodule update --init
$ mkdir build
$ cd build
$ cmake ..
$ make
$ sudo make install
Building Transmission from Git (updating)
$ cd Transmission/build
$ make clean
$ git pull --rebase --prune
$ git submodule update
$ cmake ..
$ make
$ sudo make install