mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity
transmission/libtransmission
History
Dmytro Lytovchenko 312d18281d
C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 
* C++ modernize: Replace MIN/MAX with type safe std::min/std::max

* Template std::min/max invocations now explicitly use largest integer type

* torrent.cc did not have <algorithm> included

* MIN/MAX Changes for subprocess-win32.cc

* Using type{} style cast instead of template parameter in std::min/max

* 32-bit type cast errors with uint64_t versus size_t

* 32-bit type cast errors inout.cc and file.cc

* Missing include in windows code; Type cast error fixed

* Missing macro in win32 daemon; Replaced MIN in commented code with std::min

* Update libtransmission/tr-getopt.cc

Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>

* Update libtransmission/file-posix.cc

Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>

* Update tests/libtransmission/copy-test.cc

Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>

* Update libtransmission/peer-mgr.cc

Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>

* Strlen returns size_t, remove cast

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
 		2021-09-19 15:41:35 -05:00
..
CMakeLists.txt refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
ConvertUTF.c #6064: Merge ConvertUTF.c fixes from LLVM (?) 2016-02-06 22:05:22 +00:00
ConvertUTF.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
README.md refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
announcer-common.h perf: prioritize announces based on scrape stats (#1782) 2021-09-09 19:28:22 -05:00
announcer-http.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
announcer-udp.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
announcer.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
announcer.h perf: use scrape to know when a private swarm is all-seeds (#1780) 2021-09-09 15:25:30 -05:00
bandwidth.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
bandwidth.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
bitfield.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
bitfield.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
blocklist.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
blocklist.h refactor: use GTest for running tests (#1383) 2020-08-11 13:11:55 -05:00
cache.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
cache.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
clients.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
clients.h refactor: use GTest for running tests (#1383) 2020-08-11 13:11:55 -05:00
completion.cc refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
completion.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
crypto-utils-cyassl.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto-utils-fallback.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto-utils-openssl.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto-utils-polarssl.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto-utils.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto-utils.h Switch to a standalone ARC4 implementation (#1788) 2021-09-12 06:47:29 +03:00
crypto.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
crypto.h Switch to a standalone ARC4 implementation (#1788) 2021-09-12 06:47:29 +03:00
error-types.h Adjust uncrustify config, reformat all but Mac client 2017-04-20 10:01:22 +03:00
error.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
error.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
fdlimit.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
fdlimit.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
file-posix.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
file-win32.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
file.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
file.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
handshake.cc fix: dead store warning in handshake.cc (#1803) 2021-09-14 21:23:53 -05:00
handshake.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
history.cc refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
history.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
inout.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
inout.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
jsonsl.c chore: update jsonsl parser snapshot (#1050) 2019-11-09 18:06:36 -06:00
jsonsl.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
libt.dox (trunk libT) re-start work on making libT doxygen friendly. still a long ways to go on this. 2009-05-29 19:17:12 +00:00
list.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
list.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
log.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
log.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
magnet.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
magnet.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
makemeta.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
makemeta.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
metainfo.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
metainfo.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
mime-types.cc refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
mime-types.h feat: add torrent-get 'primary-mime-type' to RPC. (#1464) 2020-10-13 10:33:56 -05:00
mime-types.js feat: add torrent-get 'primary-mime-type' to RPC. (#1464) 2020-10-13 10:33:56 -05:00
natpmp.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
natpmp_local.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
net.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
net.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
peer-common.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
peer-io.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
peer-io.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
peer-mgr.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
peer-mgr.h perf: use scrape to know when a private swarm is all-seeds (#1780) 2021-09-09 15:25:30 -05:00
peer-msgs.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
peer-msgs.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
peer-socket.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
platform-quota.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
platform-quota.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
platform.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
platform.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
port-forwarding.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
port-forwarding.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
ptrarray.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
ptrarray.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
quark.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
quark.h configure anti brute force (#1447) 2020-11-14 12:43:42 -06:00
resume.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
resume.h refactor: use GTest for running tests (#1383) 2020-08-11 13:11:55 -05:00
rpc-server.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
rpc-server.h configure anti brute force (#1447) 2020-11-14 12:43:42 -06:00
rpcimpl.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
rpcimpl.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
session-id.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
session-id.h refactor: use GTest for running tests (#1383) 2020-08-11 13:11:55 -05:00
session.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
session.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
stats.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
stats.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
subprocess-posix.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
subprocess-win32.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
subprocess.h refactor: use GTest for running tests (#1383) 2020-08-11 13:11:55 -05:00
torrent-ctor.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
torrent-magnet.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
torrent-magnet.h fix: 'enumerated and non-enumerated type' warnings (#1810) 2021-09-16 11:22:33 -05:00
torrent.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
torrent.h C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
tr-assert.cc refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
tr-assert.h Move generic macros to a separate tr-macros.h file 2017-06-18 17:11:20 +03:00
tr-dht.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
tr-dht.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
tr-getopt.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
tr-getopt.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
tr-lpd.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
tr-lpd.h chore: fix compiler warnings (#1412) 2020-08-27 18:41:26 -05:00
tr-macros.h C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
tr-udp.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
tr-udp.h Align type qualifiers to the right (code style) 2017-04-20 19:53:20 +03:00
tr-utp.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
tr-utp.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
transmission.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
trevent.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
trevent.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
upnp.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
upnp.h refactor: port libtransmission to C++ (#1787) 2021-09-12 12:41:49 -05:00
utils.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
utils.h refactor: tr_quickfindFirstK --> std::partial_sort (#1794) 2021-09-15 09:32:07 -05:00
variant-benc.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
variant-common.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
variant-json.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
variant.cc refactor: variant fixups (#1811) 2021-09-15 17:11:00 -05:00
variant.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
verify.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
verify.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
version.h.in Adjust CFBundleVersion format to fix Sparkle update check 2018-04-17 13:25:49 +03:00
watchdir-common.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
watchdir-generic.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
watchdir-inotify.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
watchdir-kqueue.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
watchdir-win32.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
watchdir.cc C++ modernization: Replace NULLs with typesafe nullptrs (#1799) 2021-09-14 19:18:09 -05:00
watchdir.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
web.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
web.h Switch to clang-format for code formatting, include Mac client 2021-08-16 00:38:29 +03:00
webseed.cc C++ modernize: Replace MIN/MAX with type safe std::min/std::max (#1806) 2021-09-19 15:41:35 -05:00
webseed.h Ensure include guard is the first non-comment line 2017-11-14 23:21:28 +03:00
wildmat.c Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00

README.md

Notes on the C-to-C++ Conversion

  • libtransmission was written in C for fifteen years, so eliminating all Cisms is nearly impossible. Modernization patches are welcomed but it won't all happen overnight. tr_strdup() and constexpr wil exist side-by-side in the codebase for the forseeable future.

  • It's so tempting to refactor all the things! Please keep modernization patches reasonably focused so that they will be easy to review.

  • Prefer std:: tools over bespoke ones. For example, use std::vector instead of tr_ptrArray. Redundant bespoke code should be removed.

  • Consider ripple effects before adding C++ into public headers. Will it break C code that #includes that header?