1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-31 03:12:44 +00:00
transmission/qt/TorrentDelegate.h
Charles Kerr c2fb393390
chore: fix clang-tidy-11 warnings (#1436)
* refactor: mark subclass' destructors as override.

* refactor: use QUrl to parse announce URL strings.

The prompt for this was to work around a clang-tidy issue where
"char* host = nullptr;" triggers a "don't use varargs" warning,
but on the other hand it's also terser / cleaner.

* refactor: make the TorrentDelegate brushes const.

* refactor: s/auto/auto const*/ where appropriate

* chore: add some nonconst global warning exemptions

* chore: turn off warnings in GTest

* refactor: just disable the clang-tidy warning.

Apparently a std::array<T>::iterator is a T* on clang, since clang-tidy's
readability warning says we should use 'auto*' instead of 'auto'. However
adding that annotation fails on MSVC, where the is apparently _not_ a raw
pointer.

Since there's not a way to satisfy both of them at the same time, disable
the warning.
2020-09-09 09:24:39 -05:00

61 lines
1.7 KiB
C++

/*
* This file Copyright (C) 2009-2015 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
* or any future license endorsed by Mnemosyne LLC.
*
*/
#pragma once
#include <optional>
#include <QStyledItemDelegate>
#include "Macros.h"
class QStyle;
class QStyleOptionProgressBar;
class Torrent;
class TorrentDelegate : public QStyledItemDelegate
{
Q_OBJECT
TR_DISABLE_COPY_MOVE(TorrentDelegate)
public:
explicit TorrentDelegate(QObject* parent = nullptr);
// QAbstractItemDelegate
QSize sizeHint(QStyleOptionViewItem const& option, QModelIndex const& index) const override;
void paint(QPainter* painter, QStyleOptionViewItem const& option, QModelIndex const& index) const override;
protected:
QSize margin(QStyle const& style) const;
void setProgressBarPercentDone(QStyleOptionViewItem const& option, Torrent const&) const;
QIcon& getWarningEmblem() const;
// Our own overridables
virtual QSize sizeHint(QStyleOptionViewItem const&, Torrent const&) const;
virtual void drawTorrent(QPainter* painter, QStyleOptionViewItem const& option, Torrent const&) const;
static QString statusString(Torrent const& tor);
static QString progressString(Torrent const& tor);
static QString shortStatusString(Torrent const& tor);
static QString shortTransferString(Torrent const& tor);
QColor const blue_back;
QColor const blue_brush;
QColor const green_back;
QColor const green_brush;
QColor const silver_back;
QColor const silver_brush;
mutable QStyleOptionProgressBar progress_bar_style_ = {};
private:
mutable std::optional<int> height_hint_;
mutable QFont height_font_;
mutable QIcon warning_emblem_;
};