1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-13 23:48:49 +00:00
transmission/gtk/Dialogs.cc
Dzmitry Neviadomski 7e87adcd91
Fix building transmission with C++23 (#6832)
* fix: operator== should return bool in tr_strbuf

Fixes build error with C++20/C++23

error: return type 'auto' of selected 'operator==' function for rewritten '!=' comparison is not 'bool'

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: explicitly specify Blocklist::size() return type as size_t

Fixes building with C++20/C++23
error: no matching function for call to 'size'
function 'size' with deduced return type cannot be used before it is defined

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: wrap runtime format strings with fmt::runtime in library, daemon and cli

fmt::format_string ctor is consteval with C++20
See https://github.com/fmtlib/fmt/issues/2438

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: wrap runtime format strings with fmt::runtime for GTK client

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: allow to override C and CXX standard via cmdline or env

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: add job to check if transmission compiles with C++23

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* Address code review by mikedld

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix new found fmt build errors

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* Address code review by tearfur

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

* fix: make tr_net_init_mgr singleton buildable with C++23

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>

---------

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-03-10 13:08:57 -05:00

139 lines
3.7 KiB
C++

// This file Copyright © Transmission authors and contributors.
// It may be used under the MIT (SPDX: MIT) license.
// License text can be found in the licenses/ folder.
#include "Dialogs.h"
#include "GtkCompat.h"
#include "Session.h"
#include "Utils.h"
#include <glibmm/i18n.h>
#include <glibmm/ustring.h>
#include <gtkmm/messagedialog.h>
#include <fmt/core.h>
#include <memory>
#include <vector>
/***
****
***/
void gtr_confirm_remove(
Gtk::Window& parent,
Glib::RefPtr<Session> const& core,
std::vector<tr_torrent_id_t> const& torrent_ids,
bool delete_files)
{
int connected = 0;
int incomplete = 0;
int const count = torrent_ids.size();
if (count == 0)
{
return;
}
for (auto const id : torrent_ids)
{
tr_torrent* tor = core->find_torrent(id);
tr_stat const* stat = tr_torrentStat(tor);
if (stat->leftUntilDone != 0)
{
++incomplete;
}
if (stat->peersConnected != 0)
{
++connected;
}
}
auto const primary_text = fmt::format(
fmt::runtime(
!delete_files ? ngettext("Remove torrent?", "Remove {count:L} torrents?", count) :
ngettext(
"Delete this torrent's downloaded files?",
"Delete these {count:L} torrents' downloaded files?",
count)),
fmt::arg("count", count));
Glib::ustring secondary_text;
if (incomplete == 0 && connected == 0)
{
secondary_text = ngettext(
"Once removed, continuing the transfer will require the torrent file or magnet link.",
"Once removed, continuing the transfers will require the torrent files or magnet links.",
count);
}
else if (count == incomplete)
{
secondary_text = ngettext(
"This torrent has not finished downloading.",
"These torrents have not finished downloading.",
count);
}
else if (count == connected)
{
secondary_text = ngettext("This torrent is connected to peers.", "These torrents are connected to peers.", count);
}
else
{
if (connected != 0)
{
secondary_text += ngettext(
"One of these torrents is connected to peers.",
"Some of these torrents are connected to peers.",
connected);
}
if (connected != 0 && incomplete != 0)
{
secondary_text += "\n";
}
if (incomplete != 0)
{
secondary_text += ngettext(
"One of these torrents has not finished downloading.",
"Some of these torrents have not finished downloading.",
incomplete);
}
}
auto d = std::make_shared<Gtk::MessageDialog>(
parent,
fmt::format("<big><b>{}</b></big>", primary_text),
true /*use_markup*/,
TR_GTK_MESSAGE_TYPE(WARNING),
TR_GTK_BUTTONS_TYPE(NONE),
true /*modal*/);
if (!secondary_text.empty())
{
d->set_secondary_text(secondary_text, true);
}
d->add_button(_("_Cancel"), TR_GTK_RESPONSE_TYPE(CANCEL));
d->add_button(delete_files ? _("_Delete") : _("_Remove"), TR_GTK_RESPONSE_TYPE(ACCEPT));
d->set_default_response(TR_GTK_RESPONSE_TYPE(CANCEL));
d->signal_response().connect(
[d, core, torrent_ids, delete_files](int response) mutable
{
if (response == TR_GTK_RESPONSE_TYPE(ACCEPT))
{
for (auto const id : torrent_ids)
{
core->remove_torrent(id, delete_files);
}
}
d.reset();
});
d->show();
}