mirror of
https://github.com/transmission/transmission
synced 2024-12-27 18:18:10 +00:00
be74cb6356
* Bump minimum Qt version to 5.6 * Switch from QRegExp to QRegularExpression While still available, QRegExp has been moved to Qt6::Core5Compat module and is not part of Qt6::Core. * Use qIsEffectiveTLD instead of QUrl::topLevelDomain The latter is not part of Qt6::Core. The former is a private utility in Qt6::Network; using it for now, until (and if) we switch to something non-Qt-specific. * Use QStyle::State_Horizontal state when drawing progress bars Although available for a long time, this state either didn't apply to progress bars before Qt 6, or was deduced based on bar size. With Qt 6, failing to specify it results in bad rendering. * Don't use QStringRef (and associated methods) While still available, QStringRef has been moved to Qt6::Core5Compat module and is not part of Qt6::Core. Related method (e.g. QString::midRef) have been removed in Qt 6. * Use Qt::ItemIsAutoTristate instead of Qt::ItemIsTristate The latter was deprecated and replaced with the former in Qt 5.6. * Don't use QApplication::globalStrut This property has been deprecated in Qt 5.15 and removed in Qt 6. * Use QImage::fromHICON instead of QtWin::fromHICON WinExtras module (providind the latter helper) has been removed in Qt 6. * Use QStringDecoder instead of QTextCodec While still available, QTextCodec has been moved to Qt6::Core5Compat module and is not part of Qt6::Core. * Don't forward-declare QStringList Instead of being a standalone class, its definition has changed to QList<QString> template specialization in Qt 6. * Use explicit (since Qt 6) QFileInfo constructor * Use QDateTime's {to,from}SecsSinceEpoch instead of {to,from}Time_t The latter was deprecated in Qt 5.8 and removed in Qt 6. * Don't use QFuture<>'s operator== It has been removed in Qt 6. Since the original issue this code was solving was caused by future reuse, just don't reuse futures and create new finished ones when necessary. * Use std::vector<> instead of QVector<> The latter has been changed to a typedef for QList<>, which might not be what one wants, and which also changed behavior a bit leading to compilation errors. * Don't use + for flags, cast to int explicitly Operator+ for enum values has been deleted in Qt 6, so using operator| instead. Then, there's no conversion from QFlags<> to QVariant, so need to cast to int. * Support Qt 6 in CMake and for MSI packaging * Remove extra (empty) CMake variable use when constructing Qt target names * Simplify logic in tr_qt_add_translation CMake helper Co-authored-by: Charles Kerr <charles@charleskerr.com>
222 lines
8.3 KiB
CMake
222 lines
8.3 KiB
CMake
macro(tr_auto_option_changed NAME ACC VAL FIL STK)
|
|
if(NOT ("${VAL}" STREQUAL "AUTO" OR "${VAL}" STREQUAL "ON" OR "${VAL}" STREQUAL "OFF"))
|
|
if("${VAL}" STREQUAL "0" OR "${VAL}" STREQUAL "NO" OR "${VAL}" STREQUAL "FALSE" OR "${VAL}" STREQUAL "N")
|
|
set_property(CACHE ${NAME} PROPERTY VALUE OFF)
|
|
elseif("${VAL}" MATCHES "^[-+]?[0-9]+$" OR "${VAL}" STREQUAL "YES" OR "${VAL}" STREQUAL "TRUE" OR "${VAL}" STREQUAL "Y")
|
|
set_property(CACHE ${NAME} PROPERTY VALUE ON)
|
|
else()
|
|
message(FATAL_ERROR "Option '${NAME}' set to unrecognized value '${VAL}'. Should be boolean or 'AUTO'.")
|
|
endif()
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(tr_auto_option NAME DESC VAL)
|
|
set(${NAME} "${VAL}" CACHE STRING "${DESC}")
|
|
set_property(CACHE ${NAME} PROPERTY STRINGS "AUTO;ON;OFF")
|
|
variable_watch(${NAME} tr_auto_option_changed)
|
|
endmacro()
|
|
|
|
macro(tr_fixup_auto_option NAME ISFOUND ISREQ)
|
|
if(${ISFOUND})
|
|
set_property(CACHE ${NAME} PROPERTY VALUE ON)
|
|
elseif(NOT (${ISREQ}))
|
|
set_property(CACHE ${NAME} PROPERTY VALUE OFF)
|
|
endif()
|
|
endmacro()
|
|
|
|
function(tr_list_option_changed NAME ACC VAL FIL STK)
|
|
get_property(VAR_STRINGS CACHE ${NAME} PROPERTY STRINGS)
|
|
string(TOUPPER "${VAL}" VAL_UPCASE)
|
|
foreach(X ${VAR_STRINGS})
|
|
string(TOUPPER "${X}" X_UPCASE)
|
|
if("${VAL_UPCASE}" STREQUAL "${X_UPCASE}")
|
|
if(NOT "${VAL}" STREQUAL "${X}")
|
|
set_property(CACHE ${NAME} PROPERTY VALUE "${X}")
|
|
message(STATUS ">>> (list) ${NAME} -> ${X}")
|
|
endif()
|
|
return()
|
|
endif()
|
|
endforeach()
|
|
string(REPLACE ";" "', '" VAR_STRINGS "${VAR_STRINGS}")
|
|
message(FATAL_ERROR "Option '${NAME}' set to unrecognized value '${VAL}'. Should be one of '${VAR_STRINGS}'.")
|
|
endfunction()
|
|
|
|
macro(tr_list_option NAME DESC VAL)
|
|
set(${NAME} "${VAL}" CACHE STRING "${DESC}")
|
|
set_property(CACHE ${NAME} PROPERTY STRINGS "${VAL};${ARGN}")
|
|
variable_watch(${NAME} tr_list_option_changed)
|
|
endmacro()
|
|
|
|
macro(tr_fixup_list_option NAME FVAL ISFOUND RVAL ISREQ)
|
|
if(${ISFOUND})
|
|
set_property(CACHE ${NAME} PROPERTY VALUE "${FVAL}")
|
|
elseif(NOT (${ISREQ}))
|
|
set_property(CACHE ${NAME} PROPERTY VALUE "${RVAL}")
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(tr_get_required_flag IVAR OVAR)
|
|
set(${OVAR})
|
|
if (${IVAR} AND NOT ${IVAR} STREQUAL "AUTO")
|
|
set(${OVAR} REQUIRED)
|
|
endif()
|
|
endmacro()
|
|
|
|
function(tr_make_id INPUT OVAR)
|
|
string(TOUPPER "${INPUT}" ID)
|
|
string(REGEX REPLACE "[^A-Z0-9]+" "_" ID "${ID}")
|
|
# string(REGEX REPLACE "^_+|_+$" "" ID "${ID}")
|
|
set(${OVAR} "${ID}" PARENT_SCOPE)
|
|
endfunction()
|
|
|
|
macro(tr_add_external_auto_library ID DIRNAME LIBNAME)
|
|
if(USE_SYSTEM_${ID})
|
|
tr_get_required_flag(USE_SYSTEM_${ID} SYSTEM_${ID}_IS_REQUIRED)
|
|
find_package(${ID} ${${ID}_MINIMUM} ${SYSTEM_${ID}_IS_REQUIRED})
|
|
tr_fixup_auto_option(USE_SYSTEM_${ID} ${ID}_FOUND SYSTEM_${ID}_IS_REQUIRED)
|
|
endif()
|
|
|
|
if(USE_SYSTEM_${ID})
|
|
unset(${ID}_UPSTREAM_TARGET)
|
|
else()
|
|
set(${ID}_UPSTREAM_TARGET ${LIBNAME})
|
|
set(${ID}_PREFIX "${CMAKE_BINARY_DIR}/third-party/${${ID}_UPSTREAM_TARGET}")
|
|
|
|
set(${ID}_INCLUDE_DIR "${${ID}_PREFIX}/include" CACHE INTERNAL "")
|
|
set(${ID}_LIBRARY "${${ID}_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${LIBNAME}${CMAKE_STATIC_LIBRARY_SUFFIX}" CACHE INTERNAL "")
|
|
|
|
set(${ID}_INCLUDE_DIRS ${${ID}_INCLUDE_DIR})
|
|
set(${ID}_LIBRARIES ${${ID}_LIBRARY})
|
|
|
|
set(${ID}_EXT_PROJ_CMAKE_ARGS)
|
|
if(APPLE)
|
|
string(REPLACE ";" "$<SEMICOLON>" ${ID}_CMAKE_OSX_ARCHITECTURES "${CMAKE_OSX_ARCHITECTURES}")
|
|
list(APPEND ${ID}_EXT_PROJ_CMAKE_ARGS
|
|
"-DCMAKE_OSX_ARCHITECTURES:STRING=${${ID}_CMAKE_OSX_ARCHITECTURES}"
|
|
"-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${CMAKE_OSX_DEPLOYMENT_TARGET}"
|
|
"-DCMAKE_OSX_SYSROOT:PATH=${CMAKE_OSX_SYSROOT}")
|
|
endif()
|
|
|
|
ExternalProject_Add(
|
|
${${ID}_UPSTREAM_TARGET}
|
|
URL "${CMAKE_SOURCE_DIR}/third-party/${DIRNAME}"
|
|
${ARGN}
|
|
PREFIX "${${ID}_PREFIX}"
|
|
CMAKE_ARGS
|
|
-Wno-dev # We don't want to be warned over unused variables
|
|
"-DCMAKE_TOOLCHAIN_FILE:PATH=${CMAKE_TOOLCHAIN_FILE}"
|
|
"-DCMAKE_USER_MAKE_RULES_OVERRIDE=${CMAKE_USER_MAKE_RULES_OVERRIDE}"
|
|
"-DCMAKE_C_FLAGS:STRING=${CMAKE_C_FLAGS}"
|
|
"-DCMAKE_CXX_FLAGS:STRING=${CMAKE_CXX_FLAGS}"
|
|
"-DCMAKE_BUILD_TYPE:STRING=${CMAKE_BUILD_TYPE}"
|
|
"-DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>"
|
|
${${ID}_EXT_PROJ_CMAKE_ARGS}
|
|
BUILD_BYPRODUCTS "${${ID}_LIBRARY}"
|
|
)
|
|
|
|
set_property(TARGET ${${ID}_UPSTREAM_TARGET} PROPERTY FOLDER "ThirdParty")
|
|
endif()
|
|
endmacro()
|
|
|
|
function(tr_append_target_property TGT PROP VAL)
|
|
get_target_property(OVAL ${TGT} ${PROP})
|
|
if(OVAL)
|
|
set(VAL "${OVAL} ${VAL}")
|
|
endif()
|
|
set_target_properties(${TGT} PROPERTIES ${PROP} "${VAL}")
|
|
endfunction()
|
|
|
|
function(tr_win32_app_info OVAR DESCR INTNAME ORIGFNAME)
|
|
if(NOT WIN32)
|
|
return()
|
|
endif()
|
|
|
|
set(TR_FILE_DESCRIPTION "${DESCR}")
|
|
set(TR_INTERNAL_NAME "${INTNAME}")
|
|
set(TR_ORIGINAL_FILENAME "${ORIGFNAME}")
|
|
if(ARGN)
|
|
set(TR_MAIN_ICON "${ARGN}")
|
|
endif()
|
|
|
|
configure_file("${CMAKE_SOURCE_DIR}/cmake/Transmission.rc.in" "${INTNAME}-app-info.rc")
|
|
|
|
set(${OVAR} "${CMAKE_CURRENT_BINARY_DIR}/${INTNAME}-app-info.rc" PARENT_SCOPE)
|
|
endfunction()
|
|
|
|
function(tr_select_library LIBNAMES FUNCNAME DIRS OVAR)
|
|
set(LIBNAME)
|
|
foreach(X ${LIBNAMES})
|
|
set(VAR_NAME "HAVE_${FUNCNAME}_IN_LIB${X}")
|
|
string(TOUPPER "${VAR_NAME}" VAR_NAME)
|
|
check_library_exists("${X}" "${FUNCNAME}" "${DIRS}" ${VAR_NAME})
|
|
if(${VAR_NAME})
|
|
set(LIBNAME "${X}")
|
|
break()
|
|
endif()
|
|
endforeach()
|
|
set(${OVAR} "${LIBNAME}" PARENT_SCOPE)
|
|
endfunction()
|
|
|
|
function(tr_fixup_bundle_item BUNDLE_DIR BUNDLE_ITEMS DEP_DIRS)
|
|
while(BUNDLE_ITEMS)
|
|
list(GET BUNDLE_ITEMS 0 ITEM)
|
|
list(REMOVE_AT BUNDLE_ITEMS 0)
|
|
|
|
set(ITEM_FULL_BUNDLE_PATH "${BUNDLE_DIR}/${ITEM}")
|
|
get_filename_component(ITEM_FULL_BUNDLE_DIR "${ITEM_FULL_BUNDLE_PATH}" PATH)
|
|
|
|
unset(ITEM_DEPS)
|
|
get_prerequisites("${ITEM_FULL_BUNDLE_PATH}" ITEM_DEPS 1 0 "${ITEM_FULL_BUNDLE_PATH}" "${DEP_DIRS}")
|
|
|
|
foreach(DEP IN LISTS ITEM_DEPS)
|
|
gp_resolve_item("${ITEM_FULL_BUNDLE_PATH}" "${DEP}" "${ITEM_FULL_BUNDLE_DIR}" "${DEP_DIRS}" DEP_FULL_PATH)
|
|
|
|
if(DEP_FULL_PATH MATCHES "[.]dylib$")
|
|
get_filename_component(DEP_NAME "${DEP_FULL_PATH}" NAME)
|
|
file(COPY "${DEP_FULL_PATH}" DESTINATION "${BUNDLE_DIR}/Contents/MacOS/")
|
|
set(DEP_BUNDLE_PATH "Contents/MacOS/${DEP_NAME}")
|
|
elseif(DEP_FULL_PATH MATCHES "^(.+)/(([^/]+[.]framework)/.+)$")
|
|
set(DEP_NAME "${CMAKE_MATCH_2}")
|
|
file(COPY "${CMAKE_MATCH_1}/${CMAKE_MATCH_3}" DESTINATION "${BUNDLE_DIR}/Contents/Frameworks/" PATTERN "Headers" EXCLUDE)
|
|
set(DEP_BUNDLE_PATH "Contents/Frameworks/${DEP_NAME}")
|
|
else()
|
|
message(FATAL_ERROR "Don't know how to fixup '${DEP_FULL_PATH}'")
|
|
endif()
|
|
|
|
execute_process(COMMAND install_name_tool -change "${DEP}" "@rpath/${DEP_NAME}" "${ITEM_FULL_BUNDLE_PATH}")
|
|
|
|
set(DEP_FULL_BUNDLE_PATH "${BUNDLE_DIR}/${DEP_BUNDLE_PATH}")
|
|
execute_process(COMMAND chmod u+w "${DEP_FULL_BUNDLE_PATH}")
|
|
execute_process(COMMAND install_name_tool -id "@rpath/${DEP_NAME}" "${DEP_FULL_BUNDLE_PATH}")
|
|
|
|
list(REMOVE_ITEM BUNDLE_ITEMS "${DEP_BUNDLE_PATH}")
|
|
list(APPEND BUNDLE_ITEMS "${DEP_BUNDLE_PATH}")
|
|
endforeach()
|
|
endwhile()
|
|
endfunction()
|
|
|
|
macro(tr_qt_wrap_ui)
|
|
if(Qt_VERSION_MAJOR EQUAL 6)
|
|
qt6_wrap_ui(${ARGN})
|
|
else()
|
|
qt5_wrap_ui(${ARGN})
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(tr_qt_add_resources)
|
|
if(Qt_VERSION_MAJOR EQUAL 6)
|
|
qt6_add_resources(${ARGN})
|
|
else()
|
|
qt5_add_resources(${ARGN})
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(tr_qt_add_translation)
|
|
if(Qt_VERSION_MAJOR EQUAL 6)
|
|
qt6_add_translation(${ARGN} OPTIONS -silent)
|
|
elseif(Qt_VERSION GREATER_EQUAL 5.11)
|
|
qt5_add_translation(${ARGN} OPTIONS -silent)
|
|
else()
|
|
qt5_add_translation(${ARGN})
|
|
endif()
|
|
endmacro()
|