1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-12 07:03:44 +00:00
transmission/libtransmission
Charles Kerr a822a46e47
refactor: add fetch options object to tr_webRun() (#2620)
* refactor: add fetch options object to tr_webRun()

Fold `tr_webRun()`, `tr_webRunWithCookies()`, and `tr_webRunWebseed()`
into a single API that takes an options argument that callers can
customize to their needs.

Also does a surface cleanup pass to the tr_webseed and tr_web internal
structures, e.g. making fields const where possible, not using raw
pointers, and making some fields private.

This revision is still full of code smells. Refactoring the entire
system is overwhelming, so instead I'm doing it in incremental steps.
2022-02-13 20:09:56 -06:00
..
.clang-tidy refactor: clang-tidy in libtransmission (#2578) 2022-02-06 22:28:36 -06:00
announce-list.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
announce-list.h refactor: fix sonarcloud "use enum class" code smells (#2590) 2022-02-08 20:25:19 -06:00
announcer-common.h chore: iwyu (#2553) 2022-01-31 17:05:35 -06:00
announcer-http.cc refactor: add fetch options object to tr_webRun() (#2620) 2022-02-13 20:09:56 -06:00
announcer-udp.cc fix: make DNS queries lowercase (#2591) 2022-02-08 21:30:45 -06:00
announcer.cc feat: use libpsl (#2575) 2022-02-12 11:30:27 -06:00
announcer.h refactor: use C++ objects in announcer (#2474) 2022-01-22 23:41:01 -06:00
bandwidth.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
bandwidth.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
benc.h chore: iwyu (#2553) 2022-01-31 17:05:35 -06:00
bitfield.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
bitfield.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
block-info.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
block-info.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
blocklist.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
blocklist.h Revert "fix: sonarcloud (#2558)" (#2562) 2022-02-01 11:30:51 -06:00
cache.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
cache.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
clients.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
clients.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
CMakeLists.txt feat: use libpsl (#2575) 2022-02-12 11:30:27 -06:00
completion.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
completion.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
crypto-utils-ccrypto.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto-utils-cyassl.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto-utils-fallback.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto-utils-openssl.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto-utils-polarssl.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto-utils.cc feat: add support for adding torrents by raw hash values (#2608) 2022-02-12 22:16:55 -06:00
crypto-utils.h feat: add support for adding torrents by raw hash values (#2608) 2022-02-12 22:16:55 -06:00
crypto.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
crypto.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
error-types.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
error.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
error.h refactor: add benc::Handler::Context (#2531) 2022-01-28 16:46:14 -06:00
fdlimit.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
fdlimit.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
file-piece-map.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
file-piece-map.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
file-posix.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
file-win32.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
file.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
file.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
foo refactor: add tr_interned_string (#2332) 2021-12-23 11:16:05 -06:00
handshake.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
handshake.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
history.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
inout.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
inout.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
interned-string.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
jsonsl.c chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
jsonsl.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
libt.dox
log.cc refactor: fix a pair of win32 msvc warnings in libtransmission (#2588) 2022-02-08 12:50:09 -06:00
log.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
magnet-metainfo.cc feat: add support for adding torrents by raw hash values (#2608) 2022-02-12 22:16:55 -06:00
magnet-metainfo.h feat: add support for adding torrents by raw hash values (#2608) 2022-02-12 22:16:55 -06:00
makemeta.cc feat: support webseeds in transmission-create (#2611) 2022-02-12 12:50:47 -06:00
makemeta.h feat: support webseeds in transmission-create (#2611) 2022-02-12 12:50:47 -06:00
mime-types.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
mime-types.js chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
natpmp.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
natpmp_local.h NAT-PMP private/public port and lifetime fix (#1602) 2022-01-21 18:07:24 -06:00
net.cc feat: support dscp classes in socket iptos (#2594) 2022-02-10 15:35:28 -06:00
net.h feat: support dscp classes in socket iptos (#2594) 2022-02-10 15:35:28 -06:00
peer-common.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
peer-io.cc feat: support dscp classes in socket iptos (#2594) 2022-02-10 15:35:28 -06:00
peer-io.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
peer-mgr-active-requests.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
peer-mgr-active-requests.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
peer-mgr-wishlist.cc refactor: tr_webseed simplification (#2613) 2022-02-12 16:52:40 -06:00
peer-mgr-wishlist.h refactor: re-enable clang-tidy warnings (#2485) 2022-01-23 16:47:41 -06:00
peer-mgr.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
peer-mgr.h refactor: remove raw ptr variant of tr_peerMgrCompactToPex() (#2556) 2022-01-31 21:11:47 -06:00
peer-msgs.cc refactor: fix sonarcloud "use enum class" code smells (#2590) 2022-02-08 20:25:19 -06:00
peer-msgs.h Revert "fix: sonarcloud (#2558)" (#2562) 2022-02-01 11:30:51 -06:00
peer-socket.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
platform-quota.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
platform-quota.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
platform.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
platform.h refactor: replace tr_thread with std::thread (#2548) 2022-01-31 13:34:04 -06:00
port-forwarding.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
port-forwarding.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
ptrarray.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
ptrarray.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
quark.cc Add support for torrent-get calls with the key percentComplete (#2615) 2022-02-13 01:27:47 -06:00
quark.h Add support for torrent-get calls with the key percentComplete (#2615) 2022-02-13 01:27:47 -06:00
resume.cc refactor: fix sonarcloud "use enum class" code smells (#2590) 2022-02-08 20:25:19 -06:00
resume.h refactor: fix sonarcloud "use enum class" code smells (#2590) 2022-02-08 20:25:19 -06:00
rpc-server.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
rpc-server.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
rpcimpl.cc refactor: add fetch options object to tr_webRun() (#2620) 2022-02-13 20:09:56 -06:00
rpcimpl.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
session-id.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
session-id.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
session.cc feat: add support for adding torrents by raw hash values (#2608) 2022-02-12 22:16:55 -06:00
session.h feat: support dscp classes in socket iptos (#2594) 2022-02-10 15:35:28 -06:00
stats.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
stats.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
subprocess-posix.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
subprocess-win32.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
subprocess.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
torrent-ctor.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
torrent-magnet.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
torrent-magnet.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
torrent-metainfo.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
torrent-metainfo.h test: add tr_torrent_metainfo.infoDictSize() tests (#2535) 2022-01-29 15:37:42 -06:00
torrent.cc feat: expose downloaded byte count to done script (#2619) 2022-02-13 11:04:34 -06:00
torrent.h add labels to torrent-add rpc method (#2539) 2022-02-03 00:02:30 -06:00
tr-assert.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
tr-assert.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
tr-assert.mm Make macOS crash reports provide more information (#2471) 2022-01-23 18:10:06 -06:00
tr-dht.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
tr-dht.h Revert "fix: sonarcloud (#2558)" (#2562) 2022-02-01 11:30:51 -06:00
tr-getopt.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
tr-getopt.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
tr-lpd.cc refactor: clang-tidy in libtransmission (#2578) 2022-02-06 22:28:36 -06:00
tr-lpd.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
tr-macros.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
tr-udp.cc feat: support dscp classes in socket iptos (#2594) 2022-02-10 15:35:28 -06:00
tr-udp.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
tr-utp.cc refactor: clang-tidy in libtransmission (#2578) 2022-02-06 22:28:36 -06:00
tr-utp.h refactor: clang-tidy in libtransmission (#2578) 2022-02-06 22:28:36 -06:00
transmission.h feat: use libpsl (#2575) 2022-02-12 11:30:27 -06:00
trevent.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
trevent.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
upnp.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
upnp.h Add bind-address-ipv4 to upnp (#845) 2022-01-21 09:44:45 -06:00
utils.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
utils.h Revert "fix: sonarcloud (#2558)" (#2562) 2022-02-01 11:30:51 -06:00
variant-benc.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
variant-common.h refactor: SAX-like benc parser pt. 1 (#2490) 2022-01-24 00:30:00 -06:00
variant-json.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
variant.cc refactor: sonarcloud "use if init" statements (#2587) 2022-02-07 23:44:31 -06:00
variant.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
verify.cc test: fix race condition in rename-test (#2612) 2022-02-12 13:51:43 -06:00
verify.h refactor: remove callback from tr_torrentVerify() public API (#2592) 2022-02-09 12:02:59 -06:00
version.h.in Adjust CFBundleVersion format to fix Sparkle update check 2018-04-17 13:25:49 +03:00
watchdir-common.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
watchdir-generic.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
watchdir-inotify.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
watchdir-kqueue.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
watchdir-win32.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
watchdir.cc chore: update license spdx abbreviations (#2582) 2022-02-07 10:25:02 -06:00
watchdir.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
web-utils.cc feat: use libpsl (#2575) 2022-02-12 11:30:27 -06:00
web-utils.h feat: use libpsl (#2575) 2022-02-12 11:30:27 -06:00
web.cc refactor: add fetch options object to tr_webRun() (#2620) 2022-02-13 20:09:56 -06:00
web.h refactor: add fetch options object to tr_webRun() (#2620) 2022-02-13 20:09:56 -06:00
webseed.cc refactor: add fetch options object to tr_webRun() (#2620) 2022-02-13 20:09:56 -06:00
webseed.h chore: update copyright years, make notices consistent (#2463) 2022-01-20 12:27:56 -06:00
wildmat.c refactor: tr_parseNumberRange returns std::vector. (#1838) 2021-09-25 14:37:28 -05:00