mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity
transmission/libtransmission
History
Robin Seth Ekman 0279f37377
fix: silence bugprone-unchecked-optional-access warnings (#6990) 
* fix: silence bugprone-unchecked-optional-access warnings

clang-tidy emits bugprone-unchecked-optional-access warning for
`tr_sys_file_lock`. however, this is a false positive: the lines
warned about cannot be reached if the optional does not contain a value.
adding an `assert` silences these warnings.

* Apply suggestions from code review
 		2024-08-13 01:51:05 +01:00
..
.clang-tidy refactor: libtransmission Settings (#6592) 2024-02-15 11:31:09 -06:00
CMakeLists.txt chore: misc code cleanups (#6927) 2024-07-14 01:37:55 +01:00
announce-list.cc fix: misc-include-cleaner clang-tidy warnings (#6502) 2024-01-07 14:21:05 -06:00
announce-list.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
announcer-common.h feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
announcer-http.cc feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
announcer-udp.cc chore: misc formatting updates and fixes (#7049) 2024-08-13 00:44:39 +01:00
announcer.cc feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
announcer.h feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
bandwidth.cc fix: always use location of selected torrents in WebUI set location dialogue (#6337) 2023-12-06 10:10:28 -06:00
bandwidth.h chore: minor bandwidth code housekeeping (#6306) 2023-11-28 10:18:38 -06:00
benc.h refactor: remove the tr_error** idiom (#6198) 2023-11-04 11:39:41 -05:00
bitfield.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
bitfield.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
block-info.cc fix: implicit conversion loses integer precision (#6466) 2023-12-31 14:04:26 -06:00
block-info.h build: fix building on macOS 10.14.6, 10.15.7 and 11.7 (#6590) 2024-03-09 10:27:20 -06:00
blocklist.cc fix: misc net.cc and blocklist.cc fixes (#6717) 2024-03-24 17:09:51 -05:00
blocklist.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
cache.cc perf: avoid `std::advance` in cache.cc (#7025) 2024-08-13 01:03:02 +01:00
cache.h fix: sonarcloud warnings (#6615) 2024-02-17 22:43:24 -06:00
clients.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
clients.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
completion.cc refactor: remove torrent_view virtual class (#6738) 2024-03-30 14:45:00 -05:00
completion.h refactor: remove torrent_view virtual class (#6738) 2024-03-30 14:45:00 -05:00
crypto-utils-ccrypto.cc refactor: aggregate crypto handles when computing digests (#6662) 2024-03-04 16:59:51 -06:00
crypto-utils-fallback.cc chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
crypto-utils-mbedtls.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
crypto-utils-openssl.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
crypto-utils-wolfssl.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
crypto-utils.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
crypto-utils.h chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
error-types.h Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
error.cc refactor: remove the tr_error** idiom (#6198) 2023-11-04 11:39:41 -05:00
error.h perf: fewer temporary strings (#6325) 2023-12-01 16:48:16 -06:00
favicon-cache.h fix compatibility with clang-format 18 (#6690) 2024-03-15 00:17:10 -05:00
file-capacity.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
file-piece-map.cc chore: fix reference to temporary (#6484) 2024-01-04 08:52:08 -06:00
file-piece-map.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
file-posix.cc fix: silence bugprone-unchecked-optional-access warnings (#6990) 2024-08-13 01:51:05 +01:00
file-win32.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
file.cc refactor: replace tr_sys_file_write_line() with fmt::print("...\n") (#6619) 2024-02-25 16:12:08 -06:00
file.h refactor: remove tr_sys_file_flush() (#6647) 2024-03-03 23:29:38 -06:00
handshake.cc refactor: clarify MSE crypto algo. this is a per-algorithm key, not for crypto generally (#6957) 2024-07-06 23:25:15 -05:00
handshake.h refactor: clarify MSE crypto algo. this is a per-algorithm key, not for crypto generally (#6957) 2024-07-06 23:25:15 -05:00
history.h Update outdated Doxygen params refs for tr_recentHistory (#6791) 2024-05-24 10:31:50 -05:00
inout.cc refactor: aggregate crypto handles when computing digests (#6662) 2024-03-04 16:59:51 -06:00
inout.h refactor: remove prefetch (#6332) 2023-12-04 11:45:37 -06:00
interned-string.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
ip-cache.cc chore: misc code cleanups (#6927) 2024-07-14 01:37:55 +01:00
ip-cache.h chore: misc code cleanups (#6927) 2024-07-14 01:37:55 +01:00
libt.dox
…
log.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
log.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
lru-cache.h fix: sonarcloud warnings (#6615) 2024-02-17 22:43:24 -06:00
magnet-metainfo.cc refactor: convert `tr_peerMsgsImpl` helper functions to class methods (#6580) 2024-03-15 19:52:09 -05:00
magnet-metainfo.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
makemeta.cc fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
makemeta.h fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
mime-types.h libtransmission: fix copyright header generation (#6874) 2024-06-01 15:39:33 +01:00
mime-types.js libtransmission: fix copyright header generation (#6874) 2024-06-01 15:39:33 +01:00
net.cc fix: don't call `tr_logAddTraceIo` before `tr_peerIo::set_socket()` (#6881) 2024-06-01 16:23:46 +01:00
net.h chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
observable.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
open-files.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
open-files.h refactor: constify the inout module (#6328) 2023-12-02 14:16:36 -06:00
peer-common.h refactor: convert `tr_peerMsgsImpl` helper functions to class methods (#6580) 2024-03-15 19:52:09 -05:00
peer-io.cc fix: don't call `tr_logAddTraceIo` before `tr_peerIo::set_socket()` (#6881) 2024-06-01 16:23:46 +01:00
peer-io.h fix: implement proper download limit for uTP (#6416) 2024-01-02 00:33:53 -06:00
peer-mgr-active-requests.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
peer-mgr-active-requests.h refactor: convert `tr_peerMsgsImpl` helper functions to class methods (#6580) 2024-03-15 19:52:09 -05:00
peer-mgr-wishlist.cc fix: sonarcloud warnings (#6615) 2024-02-17 22:43:24 -06:00
peer-mgr-wishlist.h perf: followup improvements to `3.00` Wishlist (#6589) 2024-02-11 21:13:59 -06:00
peer-mgr.cc fix: reset wishlist when stopping torrent (#6869) 2024-05-29 14:35:07 -05:00
peer-mgr.h perf: restore 3.00 peer info (atom) pool pruning (#6712) 2024-05-26 16:34:26 -05:00
peer-mse.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
peer-mse.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
peer-msgs.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
peer-msgs.h refactor: store peer info objects in shared pointers (#6614) 2024-05-25 19:13:15 -05:00
peer-socket.cc fix: implement proper download limit for uTP (#6416) 2024-01-02 00:33:53 -06:00
peer-socket.h refactor: remove the tr_error** idiom (#6198) 2023-11-04 11:39:41 -05:00
platform.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
platform.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
port-forwarding-natpmp.cc feat: allow port forwarding state to recover from error (#6718) 2024-05-25 17:08:16 -05:00
port-forwarding-natpmp.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
port-forwarding-upnp.cc bump miniupnpc to 2.2.8 (#6907) 2024-06-15 00:24:06 +01:00
port-forwarding-upnp.h feat: support different internal and external port for UPnP (#6672) 2024-03-31 18:49:19 -05:00
port-forwarding.cc feat: support different internal and external port for UPnP (#6672) 2024-03-31 18:49:19 -05:00
port-forwarding.h feat: support different internal and external port for UPnP (#6672) 2024-03-31 18:49:19 -05:00
quark.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
quark.h Add start_paused to settings file and daemon (#6728) 2024-03-30 16:39:44 -05:00
resume.cc fix: loading `2.20-3.00` progress from resume (#6896) 2024-07-14 08:37:43 +01:00
resume.h fix: save sequential download across sessions (#6746) 2024-03-31 15:01:05 -05:00
rpc-server.cc Use std::declval instead of nullptr cast trick (#6785) 2024-04-15 15:18:43 -05:00
rpc-server.h fix: sonarcloud warnings (#6615) 2024-02-17 22:43:24 -06:00
rpcimpl.cc fix: restore loose data type parsing in RPC and `settings.json` (#6723) 2024-03-31 14:06:36 -05:00
rpcimpl.h refactor: use new tr_variant API in rpcimpl (#6456) 2024-01-02 22:14:43 -06:00
session-alt-speeds.cc fix: apply alt speed settings on load (#6937) 2024-07-11 00:55:34 +01:00
session-alt-speeds.h fix: apply alt speed settings on load (#6937) 2024-07-11 00:55:34 +01:00
session-id.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
session-id.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
session-thread.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
session-thread.h Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
session.cc chore: misc code cleanups (#6927) 2024-07-14 01:37:55 +01:00
session.h fix: `settings.json` default value and docs (#7044) 2024-08-13 00:47:34 +01:00
settings.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
settings.h refactor: add virtual destructor to the polymorphic Settings class (#6786) 2024-05-25 15:20:40 -05:00
stats.cc chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
stats.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
subprocess-posix.cc refactor: fix cppcoreguidelines-avoid-do-while warnings (#6527) 2024-01-20 16:56:42 -06:00
subprocess-win32.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
subprocess.h refactor: remove the tr_error** idiom (#6198) 2023-11-04 11:39:41 -05:00
timer-ev.cc chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
timer-ev.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
timer.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
torrent-ctor.cc fix: clang-tidy-19 warnings (#6597) 2024-02-13 10:42:19 -06:00
torrent-ctor.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
torrent-files.cc fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
torrent-files.h fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
torrent-magnet.cc fix: possible heap-use-after-free with magnet links (#6815) 2024-05-24 15:50:01 -05:00
torrent-magnet.h chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
torrent-metainfo.cc fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
torrent-metainfo.h fix: restore portable file path check (#6853) 2024-05-25 10:08:53 -05:00
torrent.cc fix: crash in `tr_torrent::VerifyMediator::on_verify_done()` (#6918) 2024-07-10 23:48:54 +01:00
torrent.h fix: update partial file suffix after verifying torrent (#6871) 2024-06-01 19:44:01 -05:00
torrents.cc perf: prefer small containers (#6542) 2024-01-27 09:33:12 -06:00
torrents.h feat: support creating 0 byte files (#6232) 2023-11-28 10:51:13 -06:00
tr-arc4.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-assert.cc fix: clang-tidy-19 warnings (#6597) 2024-02-13 10:42:19 -06:00
tr-assert.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-buffer.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
tr-dht.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
tr-dht.h fix: various DHT bugs (#6569) 2024-02-04 12:18:01 -06:00
tr-getopt.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
tr-getopt.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-lpd.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
tr-lpd.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-macros.h refactor: remove TR_PATH_DELIMITER (#6618) 2024-02-18 01:47:12 -06:00
tr-popcount.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-strbuf.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
tr-udp.cc fix: misc µTP trace log fixes (#6929) 2024-07-14 11:55:37 +01:00
tr-utp.cc fix: misc µTP trace log fixes (#6929) 2024-07-14 11:55:37 +01:00
tr-utp.h feat: µTP delayed ack (#6586) 2024-03-24 20:48:23 -05:00
transmission.h fix: app defaults should override libtransmission defaults (#6495) 2024-01-06 10:10:14 -06:00
utils-ev.cc chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
utils-ev.h chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
utils.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
utils.h refactor: remove tr_strlcpy() (#6433) 2023-12-24 13:33:33 -06:00
utils.mm chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
values.h refactor: reduce utils.h includes (#6431) 2023-12-24 11:02:54 -06:00
variant-benc.cc chore: fix minor clang-tidy warnings (#6275) 2023-11-21 09:02:03 -06:00
variant-json.cc fix: `tr_variant_serde::parse_json()` bug fixes (#6901) 2024-07-17 02:34:13 +01:00
variant.cc fix: crash in printTorrentList() (#6819) 2024-05-05 15:26:41 -05:00
variant.h fix: restore loose data type parsing in RPC and `settings.json` (#6723) 2024-03-31 14:06:36 -05:00
verify.cc refactor: aggregate crypto handles when computing digests (#6662) 2024-03-04 16:59:51 -06:00
verify.h Default initialize sleep callback duration in tr_verify_worker (#6789) 2024-05-24 15:51:16 -05:00
version.h.in fix: Sparkle Version Comparator (#5263) 2024-03-17 16:23:39 -05:00
watchdir-base.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
watchdir-generic.cc chore: removed copyright timespans in headers (#4850) 2023-11-01 16:11:11 -05:00
watchdir-inotify.cc fix: clang-tidy-19 warnings (#6597) 2024-02-13 10:42:19 -06:00
watchdir-kqueue.cc chore: iwyu (#6864) 2024-05-27 17:36:02 -05:00
watchdir-win32.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
watchdir.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
watchdir.h chore: iwyu (#6201) 2023-11-03 12:03:26 -05:00
web-utils.cc feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
web-utils.h feat: dual stack udp tracker support (#6687) 2024-05-26 15:43:55 -05:00
web.cc Add CI configuration for clang-tidy on Windows (#6997) 2024-07-16 22:13:29 +01:00
web.h refactor: RPC `port-test` improvements (#6274) 2023-11-22 23:02:21 -06:00
webseed.cc refactor: convert `tr_webseed` to C++ interface (#6708) 2024-04-02 09:31:20 -05:00
webseed.h refactor: convert `tr_webseed` to C++ interface (#6708) 2024-04-02 09:31:20 -05:00