1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-31 20:16:57 +00:00
transmission/qt/Application.h
Charles Kerr c2fb393390
chore: fix clang-tidy-11 warnings (#1436)
* refactor: mark subclass' destructors as override.

* refactor: use QUrl to parse announce URL strings.

The prompt for this was to work around a clang-tidy issue where
"char* host = nullptr;" triggers a "don't use varargs" warning,
but on the other hand it's also terser / cleaner.

* refactor: make the TorrentDelegate brushes const.

* refactor: s/auto/auto const*/ where appropriate

* chore: add some nonconst global warning exemptions

* chore: turn off warnings in GTest

* refactor: just disable the clang-tidy warning.

Apparently a std::array<T>::iterator is a T* on clang, since clang-tidy's
readability warning says we should use 'auto*' instead of 'auto'. However
adding that annotation fails on MSVC, where the is apparently _not_ a raw
pointer.

Since there's not a way to satisfy both of them at the same time, disable
the warning.
2020-09-09 09:24:39 -05:00

84 lines
2 KiB
C++

/*
* This file Copyright (C) 2009-2015 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
* or any future license endorsed by Mnemosyne LLC.
*
*/
#pragma once
#include <unordered_set>
#include <QApplication>
#include <QTimer>
#include <QTranslator>
#include "FaviconCache.h"
#include "Macros.h"
#include "Typedefs.h"
#include "Utils.h" // std::hash<QString>
class AddData;
class Prefs;
class Session;
class Torrent;
class TorrentModel;
class MainWindow;
class WatchDir;
class Application : public QApplication
{
Q_OBJECT
TR_DISABLE_COPY_MOVE(Application)
public:
Application(int& argc, char** argv);
~Application() override;
void raise();
bool notifyApp(QString const& title, QString const& body) const;
QString const& intern(QString const& in) { return *interned_strings_.insert(in).first; }
FaviconCache& faviconCache();
public slots:
void addTorrent(AddData const&);
private slots:
void consentGiven(int result);
void onSessionSourceChanged();
void onTorrentsAdded(torrent_ids_t const& torrents);
void onTorrentsCompleted(torrent_ids_t const& torrents);
void onTorrentsEdited(torrent_ids_t const& torrents);
void onTorrentsNeedInfo(torrent_ids_t const& torrents);
void refreshPref(int key);
void refreshTorrents();
private:
void maybeUpdateBlocklist();
void loadTranslations();
QStringList getNames(torrent_ids_t const& ids) const;
void quitLater();
Prefs* prefs_ = {};
Session* session_ = {};
TorrentModel* model_ = {};
MainWindow* window_ = {};
WatchDir* watch_dir_ = {};
QTimer model_timer_;
QTimer stats_timer_;
QTimer session_timer_;
time_t last_full_update_time_ = {};
QTranslator qt_translator_;
QTranslator app_translator_;
FaviconCache favicons_;
QString const config_name_;
QString const display_name_;
std::unordered_set<QString> interned_strings_;
};
#undef qApp
#define qApp static_cast<Application*>(Application::instance())