1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-24 16:52:39 +00:00
transmission/gtk/PrefsDialog.cc
Mike Gelfand 2bd6c8aff4
Fix issues reported by clang-tidy cert checks (GTK client) (#4174)
* Fix `cert-err33-c` clang-tidy issues

* Fix `cert-str34-c` clang-tidy issues

* Fold free-standing functions into `FilterBar::Impl`

This is in preparation to next commit fixing `cert-err58-cpp`.

* Fix `cert-err58-cpp` clang-tidy issues

* Extend clang-tidy configuration
2022-11-15 00:53:12 +00:00

1087 lines
35 KiB
C++

// This file Copyright © 2007-2022 Mnemosyne LLC.
// It may be used under GPLv2 (SPDX: GPL-2.0-only), GPLv3 (SPDX: GPL-3.0-only),
// or any future license endorsed by Mnemosyne LLC.
// License text can be found in the licenses/ folder.
#include <limits>
#include <map>
#include <memory>
#include <sstream>
#include <string>
#include <glibmm.h>
#include <glibmm/i18n.h>
#include <fmt/core.h>
#include <libtransmission/transmission.h>
#include <libtransmission/version.h>
#include <libtransmission/web-utils.h>
#include "FreeSpaceLabel.h"
#include "PathButton.h"
#include "Prefs.h"
#include "PrefsDialog.h"
#include "Session.h"
#include "SystemTrayIcon.h"
#include "Utils.h"
/**
***
**/
class PrefsDialog::Impl
{
public:
Impl(PrefsDialog& dialog, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~Impl() = default;
TR_DISABLE_COPY_MOVE(Impl)
private:
void response_cb(int response);
private:
PrefsDialog& dialog_;
Glib::RefPtr<Session> const core_;
};
/**
***
**/
void PrefsDialog::Impl::response_cb(int response)
{
if (response == TR_GTK_RESPONSE_TYPE(HELP))
{
gtr_open_uri(gtr_get_help_uri() + "/html/preferences.html");
}
if (response == TR_GTK_RESPONSE_TYPE(CLOSE))
{
dialog_.close();
}
}
namespace
{
class PageBase : public Gtk::Box
{
public:
PageBase(BaseObjectType* cast_item, Glib::RefPtr<Session> const& core);
~PageBase() override;
TR_DISABLE_COPY_MOVE(PageBase)
void init_check_button(Gtk::CheckButton& button, tr_quark key);
void init_spin_button(Gtk::SpinButton& button, tr_quark key, int low, int high, int step);
void init_spin_button_double(Gtk::SpinButton& button, tr_quark key, double low, double high, double step);
void init_entry(Gtk::Entry& entry, tr_quark key);
void init_text_view(Gtk::TextView& view, tr_quark key);
void init_chooser_button(PathButton& button, tr_quark key);
void init_encryption_combo(Gtk::ComboBox& combo, tr_quark key);
void init_time_combo(Gtk::ComboBox& combo, tr_quark key);
void init_week_combo(Gtk::ComboBox& combo, tr_quark key);
private:
bool spun_cb_idle(Gtk::SpinButton& spin, tr_quark key, bool isDouble);
void spun_cb(Gtk::SpinButton& w, tr_quark key, bool isDouble);
void entry_changed_cb(Gtk::Entry& w, tr_quark key);
void chosen_cb(PathButton& w, tr_quark key);
void onIntComboChanged(Gtk::ComboBox& combo_box, tr_quark key);
static auto get_weekday_string(Glib::Date::Weekday weekday);
private:
Glib::RefPtr<Session> const core_;
std::map<tr_quark, std::pair<std::unique_ptr<Glib::Timer>, sigc::connection>> spin_timers_;
};
PageBase::PageBase(BaseObjectType* cast_item, Glib::RefPtr<Session> const& core)
: Gtk::Box(cast_item)
, core_(core)
{
}
PageBase::~PageBase()
{
for (auto& [key, info] : spin_timers_)
{
info.second.disconnect();
}
}
void PageBase::init_check_button(Gtk::CheckButton& button, tr_quark const key)
{
button.set_active(gtr_pref_flag_get(key));
button.signal_toggled().connect([this, &button, key]() { core_->set_pref(key, button.get_active()); });
}
bool PageBase::spun_cb_idle(Gtk::SpinButton& spin, tr_quark const key, bool isDouble)
{
auto const last_change_it = spin_timers_.find(key);
g_assert(last_change_it != spin_timers_.end());
/* has the user stopped making changes? */
if (last_change_it->second.first->elapsed() < 0.33)
{
return true;
}
/* update the core */
if (isDouble)
{
core_->set_pref(key, spin.get_value());
}
else
{
core_->set_pref(key, spin.get_value_as_int());
}
/* cleanup */
spin_timers_.erase(last_change_it);
return false;
}
void PageBase::spun_cb(Gtk::SpinButton& w, tr_quark const key, bool isDouble)
{
/* user may be spinning through many values, so let's hold off
for a moment to keep from flooding the core with changes */
auto last_change_it = spin_timers_.find(key);
if (last_change_it == spin_timers_.end())
{
auto timeout_tag = Glib::signal_timeout().connect_seconds(
[this, &w, key, isDouble]() { return spun_cb_idle(w, key, isDouble); },
1);
last_change_it = spin_timers_.emplace(key, std::pair(std::make_unique<Glib::Timer>(), timeout_tag)).first;
}
last_change_it->second.first->start();
}
void PageBase::init_spin_button(Gtk::SpinButton& button, tr_quark const key, int low, int high, int step)
{
button.set_adjustment(Gtk::Adjustment::create(gtr_pref_int_get(key), low, high, step));
button.set_digits(0);
button.signal_value_changed().connect([this, &button, key]() { spun_cb(button, key, false); });
}
void PageBase::init_spin_button_double(Gtk::SpinButton& button, tr_quark const key, double low, double high, double step)
{
button.set_adjustment(Gtk::Adjustment::create(gtr_pref_double_get(key), low, high, step));
button.set_digits(2);
button.signal_value_changed().connect([this, &button, key]() { spun_cb(button, key, true); });
}
void PageBase::entry_changed_cb(Gtk::Entry& w, tr_quark const key)
{
core_->set_pref(key, w.get_text());
}
void PageBase::init_entry(Gtk::Entry& entry, tr_quark const key)
{
if (auto const value = gtr_pref_string_get(key); !value.empty())
{
entry.set_text(value);
}
entry.signal_changed().connect([this, &entry, key]() { entry_changed_cb(entry, key); });
}
void PageBase::init_text_view(Gtk::TextView& view, tr_quark const key)
{
auto buffer = view.get_buffer();
buffer->set_text(gtr_pref_string_get(key));
auto const save_buffer = [this, buffer, key]()
{
core_->set_pref(key, buffer->get_text());
};
#if GTKMM_CHECK_VERSION(4, 0, 0)
auto focus_controller = Gtk::EventControllerFocus::create();
focus_controller->signal_leave().connect(save_buffer);
view.add_controller(focus_controller);
#else
view.add_events(Gdk::FOCUS_CHANGE_MASK);
view.signal_focus_out_event().connect_notify(sigc::hide<0>(save_buffer));
#endif
}
void PageBase::chosen_cb(PathButton& w, tr_quark const key)
{
core_->set_pref(key, w.get_filename());
}
void PageBase::init_chooser_button(PathButton& button, tr_quark const key)
{
if (auto const path = gtr_pref_string_get(key); !path.empty())
{
button.set_filename(path);
}
button.signal_selection_changed().connect([this, &button, key]() { chosen_cb(button, key); });
}
void PageBase::onIntComboChanged(Gtk::ComboBox& combo_box, tr_quark const key)
{
core_->set_pref(key, gtr_combo_box_get_active_enum(combo_box));
}
void PageBase::init_encryption_combo(Gtk::ComboBox& combo, tr_quark const key)
{
gtr_combo_box_set_enum(
combo,
{
{ _("Allow encryption"), TR_CLEAR_PREFERRED },
{ _("Prefer encryption"), TR_ENCRYPTION_PREFERRED },
{ _("Require encryption"), TR_ENCRYPTION_REQUIRED },
});
gtr_combo_box_set_active_enum(combo, gtr_pref_int_get(key));
combo.signal_changed().connect([this, &combo, key]() { onIntComboChanged(combo, key); });
}
void PageBase::init_time_combo(Gtk::ComboBox& combo, tr_quark const key)
{
class TimeModelColumns : public Gtk::TreeModelColumnRecord
{
public:
TimeModelColumns() noexcept
{
add(offset);
add(title);
}
Gtk::TreeModelColumn<int> offset;
Gtk::TreeModelColumn<Glib::ustring> title;
};
static TimeModelColumns const time_cols;
/* build a store at 15 minute intervals */
auto store = Gtk::ListStore::create(time_cols);
for (int i = 0; i < 60 * 24; i += 15)
{
auto const iter = store->append();
(*iter)[time_cols.offset] = i;
(*iter)[time_cols.title] = fmt::format("{:02}:{:02}", i / 60, i % 60);
}
/* build the widget */
combo.set_model(store);
auto* r = Gtk::make_managed<Gtk::CellRendererText>();
combo.pack_start(*r, true);
combo.add_attribute(r->property_text(), time_cols.title);
combo.set_active(gtr_pref_int_get(key) / 15);
combo.signal_changed().connect(
[this, &combo, key]()
{
if (auto const iter = combo.get_active(); iter)
{
core_->set_pref(key, iter->get_value(time_cols.offset));
}
});
}
auto PageBase::get_weekday_string(Glib::Date::Weekday weekday)
{
auto date = Glib::Date{};
date.set_time_current();
date.add_days(static_cast<int>(weekday) - static_cast<int>(date.get_weekday()));
return date.format_string("%A");
}
void PageBase::init_week_combo(Gtk::ComboBox& combo, tr_quark const key)
{
gtr_combo_box_set_enum(
combo,
{
{ _("Every Day"), TR_SCHED_ALL },
{ _("Weekdays"), TR_SCHED_WEEKDAY },
{ _("Weekends"), TR_SCHED_WEEKEND },
{ get_weekday_string(Glib::Date::Weekday::MONDAY), TR_SCHED_MON },
{ get_weekday_string(Glib::Date::Weekday::TUESDAY), TR_SCHED_TUES },
{ get_weekday_string(Glib::Date::Weekday::WEDNESDAY), TR_SCHED_WED },
{ get_weekday_string(Glib::Date::Weekday::THURSDAY), TR_SCHED_THURS },
{ get_weekday_string(Glib::Date::Weekday::FRIDAY), TR_SCHED_FRI },
{ get_weekday_string(Glib::Date::Weekday::SATURDAY), TR_SCHED_SAT },
{ get_weekday_string(Glib::Date::Weekday::SUNDAY), TR_SCHED_SUN },
});
gtr_combo_box_set_active_enum(combo, gtr_pref_int_get(key));
combo.signal_changed().connect([this, &combo, key]() { onIntComboChanged(combo, key); });
}
/****
***** Download Tab
****/
class DownloadingPage : public PageBase
{
public:
DownloadingPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~DownloadingPage() override;
TR_DISABLE_COPY_MOVE(DownloadingPage)
private:
void on_core_prefs_changed(tr_quark key);
private:
Glib::RefPtr<Session> const core_;
FreeSpaceLabel* freespace_label_ = nullptr;
sigc::connection core_prefs_tag_;
};
void DownloadingPage::on_core_prefs_changed(tr_quark const key)
{
if (key == TR_KEY_download_dir)
{
char const* downloadDir = tr_sessionGetDownloadDir(core_->get_session());
freespace_label_->set_dir(downloadDir);
}
}
DownloadingPage::~DownloadingPage()
{
if (core_prefs_tag_.connected())
{
core_prefs_tag_.disconnect();
}
}
DownloadingPage::DownloadingPage(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
, core_(core)
, freespace_label_(gtr_get_widget_derived<FreeSpaceLabel>(builder, "download_dir_stats_label", core))
{
core_prefs_tag_ = core_->signal_prefs_changed().connect(sigc::mem_fun(*this, &DownloadingPage::on_core_prefs_changed));
{
auto* l = gtr_get_widget<Gtk::CheckButton>(builder, "watch_dir_check");
init_check_button(*l, TR_KEY_watch_dir_enabled);
auto* w = gtr_get_widget_derived<PathButton>(builder, "watch_dir_chooser");
init_chooser_button(*w, TR_KEY_watch_dir);
}
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "show_options_dialog_check"), TR_KEY_show_options_window);
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "start_on_add_check"), TR_KEY_start_added_torrents);
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "trash_on_add_check"), TR_KEY_trash_original_torrent_files);
init_chooser_button(*gtr_get_widget_derived<PathButton>(builder, "download_dir_chooser"), TR_KEY_download_dir);
init_spin_button(
*gtr_get_widget<Gtk::SpinButton>(builder, "max_active_downloads_spin"),
TR_KEY_download_queue_size,
0,
std::numeric_limits<int>::max(),
1);
init_spin_button(
*gtr_get_widget<Gtk::SpinButton>(builder, "max_inactive_time_spin"),
TR_KEY_queue_stalled_minutes,
1,
std::numeric_limits<int>::max(),
15);
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "append_suffix_to_incomplete_check"),
TR_KEY_rename_partial_files);
{
auto* l = gtr_get_widget<Gtk::CheckButton>(builder, "incomplete_dir_check");
init_check_button(*l, TR_KEY_incomplete_dir_enabled);
auto* w = gtr_get_widget_derived<PathButton>(builder, "incomplete_dir_chooser");
init_chooser_button(*w, TR_KEY_incomplete_dir);
}
{
auto* l = gtr_get_widget<Gtk::CheckButton>(builder, "download_done_script_check");
init_check_button(*l, TR_KEY_script_torrent_done_enabled);
auto* w = gtr_get_widget_derived<PathButton>(builder, "download_done_script_chooser");
init_chooser_button(*w, TR_KEY_script_torrent_done_filename);
}
on_core_prefs_changed(TR_KEY_download_dir);
}
/****
***** Torrent Tab
****/
class SeedingPage : public PageBase
{
public:
SeedingPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~SeedingPage() override = default;
TR_DISABLE_COPY_MOVE(SeedingPage)
};
SeedingPage::SeedingPage(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
{
{
auto* w = gtr_get_widget<Gtk::CheckButton>(builder, "stop_seeding_ratio_check");
init_check_button(*w, TR_KEY_ratio_limit_enabled);
auto* w2 = gtr_get_widget<Gtk::SpinButton>(builder, "stop_seeding_ratio_spin");
init_spin_button_double(*w2, TR_KEY_ratio_limit, 0, 1000, .05);
}
{
auto* w = gtr_get_widget<Gtk::CheckButton>(builder, "stop_seeding_timeout_check");
init_check_button(*w, TR_KEY_idle_seeding_limit_enabled);
auto* w2 = gtr_get_widget<Gtk::SpinButton>(builder, "stop_seeding_timeout_spin");
init_spin_button(*w2, TR_KEY_idle_seeding_limit, 1, 40320, 5);
}
{
auto* l = gtr_get_widget<Gtk::CheckButton>(builder, "seeding_done_script_check");
init_check_button(*l, TR_KEY_script_torrent_done_seeding_enabled);
auto* w = gtr_get_widget_derived<PathButton>(builder, "seeding_done_script_chooser");
init_chooser_button(*w, TR_KEY_script_torrent_done_seeding_filename);
}
}
/****
***** Desktop Tab
****/
class DesktopPage : public PageBase
{
public:
DesktopPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~DesktopPage() override = default;
TR_DISABLE_COPY_MOVE(DesktopPage)
};
DesktopPage::DesktopPage(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
{
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "inhibit_hibernation_check"),
TR_KEY_inhibit_desktop_hibernation);
if (auto* const show_systray_icon_check = gtr_get_widget<Gtk::CheckButton>(builder, "show_systray_icon_check");
SystemTrayIcon::is_available())
{
init_check_button(*show_systray_icon_check, TR_KEY_show_notification_area_icon);
}
else
{
show_systray_icon_check->hide();
}
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "notify_on_torrent_add_check"),
TR_KEY_torrent_added_notification_enabled);
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "notify_on_torrent_finish_check"),
TR_KEY_torrent_complete_notification_enabled);
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "ding_no_torrent_finish_check"),
TR_KEY_torrent_complete_sound_enabled);
}
/****
***** Peer Tab
****/
class PrivacyPage : public PageBase
{
public:
PrivacyPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~PrivacyPage() override;
TR_DISABLE_COPY_MOVE(PrivacyPage)
private:
void updateBlocklistText();
void onBlocklistUpdateResponse();
void onBlocklistUpdated(int n);
void onBlocklistUpdate();
void on_blocklist_url_changed(Gtk::Editable* e);
private:
Glib::RefPtr<Session> core_;
Gtk::Button* updateBlocklistButton_ = nullptr;
Gtk::Label* label_ = nullptr;
Gtk::CheckButton* check_ = nullptr;
sigc::connection updateBlocklistTag_;
std::unique_ptr<Gtk::MessageDialog> updateBlocklistDialog_;
};
void PrivacyPage::updateBlocklistText()
{
int const n = tr_blocklistGetRuleCount(core_->get_session());
auto const msg = fmt::format(
ngettext("Blocklist has {count:L} entry", "Blocklist has {count:L} entries", n),
fmt::arg("count", n));
label_->set_markup(fmt::format(FMT_STRING("<i>{:s}</i>"), msg));
}
/* prefs dialog is being destroyed, so stop listening to blocklist updates */
PrivacyPage::~PrivacyPage()
{
if (updateBlocklistTag_.connected())
{
updateBlocklistTag_.disconnect();
}
}
/* user hit "close" in the blocklist-update dialog */
void PrivacyPage::onBlocklistUpdateResponse()
{
updateBlocklistButton_->set_sensitive(true);
updateBlocklistDialog_.reset();
updateBlocklistTag_.disconnect();
}
/* core says the blocklist was updated */
void PrivacyPage::onBlocklistUpdated(int n)
{
bool const success = n >= 0;
int const count = n >= 0 ? n : tr_blocklistGetRuleCount(core_->get_session());
auto const msg = fmt::format(
ngettext("Blocklist has {count:L} entry", "Blocklist has {count:L} entries", count),
fmt::arg("count", count));
updateBlocklistButton_->set_sensitive(true);
updateBlocklistDialog_->set_message(
fmt::format(FMT_STRING("<b>{:s}</b>"), success ? _("Blocklist updated!") : _("Couldn't update blocklist")),
true);
updateBlocklistDialog_->set_secondary_text(msg);
updateBlocklistText();
}
/* user pushed a button to update the blocklist */
void PrivacyPage::onBlocklistUpdate()
{
updateBlocklistDialog_ = std::make_unique<Gtk::MessageDialog>(
gtr_widget_get_window(*this),
_("Update Blocklist"),
false,
TR_GTK_MESSAGE_TYPE(INFO),
TR_GTK_BUTTONS_TYPE(CLOSE));
updateBlocklistButton_->set_sensitive(false);
updateBlocklistDialog_->set_secondary_text(_("Getting new blocklist…"));
updateBlocklistDialog_->signal_response().connect([this](int /*response*/) { onBlocklistUpdateResponse(); });
updateBlocklistDialog_->show();
core_->blocklist_update();
updateBlocklistTag_ = core_->signal_blocklist_updated().connect([this](auto n) { onBlocklistUpdated(n); });
}
void PrivacyPage::on_blocklist_url_changed(Gtk::Editable* e)
{
auto const url = e->get_chars(0, -1);
updateBlocklistButton_->set_sensitive(tr_urlIsValid(url.c_str()));
}
PrivacyPage::PrivacyPage(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
, core_(core)
, updateBlocklistButton_(gtr_get_widget<Gtk::Button>(builder, "update_blocklist_button"))
, label_(gtr_get_widget<Gtk::Label>(builder, "blocklist_stats_label"))
, check_(gtr_get_widget<Gtk::CheckButton>(builder, "blocklist_check"))
{
init_encryption_combo(*gtr_get_widget<Gtk::ComboBox>(builder, "encryption_mode_combo"), TR_KEY_encryption);
init_check_button(*check_, TR_KEY_blocklist_enabled);
auto* const e = gtr_get_widget<Gtk::Entry>(builder, "blocklist_url_entry");
init_entry(*e, TR_KEY_blocklist_url);
updateBlocklistText();
updateBlocklistButton_->set_data("session", core_->get_session());
updateBlocklistButton_->signal_clicked().connect([this]() { onBlocklistUpdate(); });
updateBlocklistButton_->set_sensitive(check_->get_active());
e->signal_changed().connect([this, e]() { on_blocklist_url_changed(e); });
on_blocklist_url_changed(e);
auto* update_check = gtr_get_widget<Gtk::CheckButton>(builder, "blocklist_autoupdate_check");
init_check_button(*update_check, TR_KEY_blocklist_updates_enabled);
}
/****
***** Remote Tab
****/
class RemotePage : public PageBase
{
class WhitelistModelColumns : public Gtk::TreeModelColumnRecord
{
public:
WhitelistModelColumns() noexcept
{
add(address);
}
Gtk::TreeModelColumn<Glib::ustring> address;
};
static WhitelistModelColumns const whitelist_cols;
public:
RemotePage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~RemotePage() override = default;
TR_DISABLE_COPY_MOVE(RemotePage)
private:
void refreshWhitelist();
void onAddressEdited(Glib::ustring const& path, Glib::ustring const& address);
void onAddWhitelistClicked();
void onRemoveWhitelistClicked();
void refreshRPCSensitivity();
static void onLaunchClutchCB();
static Glib::RefPtr<Gtk::ListStore> whitelist_tree_model_new(std::string const& whitelist);
private:
Glib::RefPtr<Session> core_;
Gtk::TreeView* view_;
Gtk::Button* remove_button_;
Gtk::CheckButton* rpc_tb_;
Gtk::CheckButton* auth_tb_;
Gtk::CheckButton* whitelist_tb_;
Glib::RefPtr<Gtk::ListStore> store_;
std::vector<Gtk::Widget*> auth_widgets_;
std::vector<Gtk::Widget*> whitelist_widgets_;
};
RemotePage::WhitelistModelColumns const RemotePage::whitelist_cols;
Glib::RefPtr<Gtk::ListStore> RemotePage::whitelist_tree_model_new(std::string const& whitelist)
{
auto store = Gtk::ListStore::create(whitelist_cols);
std::istringstream stream(whitelist);
std::string s;
while (std::getline(stream, s, ','))
{
s = gtr_str_strip(s);
if (s.empty())
{
continue;
}
auto const iter = store->append();
(*iter)[whitelist_cols.address] = s;
}
return store;
}
void RemotePage::refreshWhitelist()
{
std::ostringstream gstr;
for (auto const& row : store_->children())
{
gstr << row.get_value(whitelist_cols.address) << ",";
}
auto str = gstr.str();
if (!str.empty())
{
str.resize(str.size() - 1); /* remove the trailing comma */
}
core_->set_pref(TR_KEY_rpc_whitelist, str);
}
void RemotePage::onAddressEdited(Glib::ustring const& path, Glib::ustring const& address)
{
if (auto const iter = store_->get_iter(path); iter)
{
(*iter)[whitelist_cols.address] = address;
}
refreshWhitelist();
}
void RemotePage::onAddWhitelistClicked()
{
auto const iter = store_->append();
(*iter)[whitelist_cols.address] = "0.0.0.0";
view_->set_cursor(store_->get_path(iter), *view_->get_column(0), true);
}
void RemotePage::onRemoveWhitelistClicked()
{
auto const sel = view_->get_selection();
if (auto const iter = sel->get_selected(); iter)
{
store_->erase(iter);
refreshWhitelist();
}
}
void RemotePage::refreshRPCSensitivity()
{
bool const rpc_active = rpc_tb_->get_active();
bool const auth_active = auth_tb_->get_active();
bool const whitelist_active = whitelist_tb_->get_active();
auto const sel = view_->get_selection();
auto const have_addr = sel->get_selected();
auto const n_rules = store_->children().size();
for (auto* const widget : auth_widgets_)
{
widget->set_sensitive(rpc_active && auth_active);
}
for (auto* const widget : whitelist_widgets_)
{
widget->set_sensitive(rpc_active && whitelist_active);
}
remove_button_->set_sensitive(rpc_active && whitelist_active && have_addr && n_rules > 1);
}
void RemotePage::onLaunchClutchCB()
{
gtr_open_uri(fmt::format("http://localhost:{}/", gtr_pref_int_get(TR_KEY_rpc_port)));
}
RemotePage::RemotePage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
, core_(core)
, view_(gtr_get_widget<Gtk::TreeView>(builder, "rpc_whitelist_view"))
, remove_button_(gtr_get_widget<Gtk::Button>(builder, "remove_from_rpc_whistlist_button"))
, rpc_tb_(gtr_get_widget<Gtk::CheckButton>(builder, "enable_rpc_check"))
, auth_tb_(gtr_get_widget<Gtk::CheckButton>(builder, "enable_rpc_auth_check"))
, whitelist_tb_(gtr_get_widget<Gtk::CheckButton>(builder, "rpc_whitelist_check"))
{
/* "enabled" checkbutton */
init_check_button(*rpc_tb_, TR_KEY_rpc_enabled);
rpc_tb_->signal_toggled().connect([this]() { refreshRPCSensitivity(); });
auto* const open_button = gtr_get_widget<Gtk::Button>(builder, "open_web_client_button");
open_button->signal_clicked().connect(&RemotePage::onLaunchClutchCB);
/* port */
auto* port_spin = gtr_get_widget<Gtk::SpinButton>(builder, "rpc_port_spin");
init_spin_button(*port_spin, TR_KEY_rpc_port, 0, std::numeric_limits<uint16_t>::max(), 1);
/* require authentication */
init_check_button(*auth_tb_, TR_KEY_rpc_authentication_required);
auth_tb_->signal_toggled().connect([this]() { refreshRPCSensitivity(); });
/* username */
auto* username_entry = gtr_get_widget<Gtk::Entry>(builder, "rpc_username_entry");
init_entry(*username_entry, TR_KEY_rpc_username);
auth_widgets_.push_back(username_entry);
auth_widgets_.push_back(gtr_get_widget<Gtk::Label>(builder, "rpc_username_label"));
/* password */
auto* password_entry = gtr_get_widget<Gtk::Entry>(builder, "rpc_password_entry");
init_entry(*password_entry, TR_KEY_rpc_password);
auth_widgets_.push_back(password_entry);
auth_widgets_.push_back(gtr_get_widget<Gtk::Label>(builder, "rpc_password_label"));
/* require authentication */
init_check_button(*whitelist_tb_, TR_KEY_rpc_whitelist_enabled);
whitelist_tb_->signal_toggled().connect([this]() { refreshRPCSensitivity(); });
/* access control list */
{
store_ = whitelist_tree_model_new(gtr_pref_string_get(TR_KEY_rpc_whitelist));
view_->set_model(store_);
setup_tree_view_button_event_handling(
*view_,
{},
[this](double view_x, double view_y) { return on_tree_view_button_released(*view_, view_x, view_y); });
whitelist_widgets_.push_back(view_);
auto const sel = view_->get_selection();
sel->signal_changed().connect([this]() { refreshRPCSensitivity(); });
/* ip address column */
auto* r = Gtk::make_managed<Gtk::CellRendererText>();
r->signal_edited().connect([this](auto const& path, auto const& new_text) { onAddressEdited(path, new_text); });
r->property_editable() = true;
auto* c = Gtk::make_managed<Gtk::TreeViewColumn>("", *r);
c->add_attribute(r->property_text(), whitelist_cols.address);
c->set_expand(true);
view_->append_column(*c);
whitelist_widgets_.push_back(gtr_get_widget<Gtk::Label>(builder, "rpc_whitelist_label"));
remove_button_->signal_clicked().connect([this]() { onRemoveWhitelistClicked(); });
refreshRPCSensitivity();
auto* add_button = gtr_get_widget<Gtk::Button>(builder, "add_to_rpc_whitelist_button");
whitelist_widgets_.push_back(add_button);
add_button->signal_clicked().connect([this]() { onAddWhitelistClicked(); });
}
refreshRPCSensitivity();
}
/****
***** Bandwidth Tab
****/
class SpeedPage : public PageBase
{
public:
SpeedPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~SpeedPage() override = default;
TR_DISABLE_COPY_MOVE(SpeedPage)
};
SpeedPage::SpeedPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
{
{
auto* const w = gtr_get_widget<Gtk::CheckButton>(builder, "upload_limit_check");
init_check_button(*w, TR_KEY_speed_limit_up_enabled);
w->set_label(fmt::format(w->get_label().raw(), fmt::arg("speed_units", speed_K_str)));
auto* const w2 = gtr_get_widget<Gtk::SpinButton>(builder, "upload_limit_spin");
init_spin_button(*w2, TR_KEY_speed_limit_up, 0, std::numeric_limits<int>::max(), 5);
}
{
auto* const w = gtr_get_widget<Gtk::CheckButton>(builder, "download_limit_check");
init_check_button(*w, TR_KEY_speed_limit_down_enabled);
w->set_label(fmt::format(w->get_label().raw(), fmt::arg("speed_units", speed_K_str)));
auto* const w2 = gtr_get_widget<Gtk::SpinButton>(builder, "download_limit_spin");
init_spin_button(*w2, TR_KEY_speed_limit_down, 0, std::numeric_limits<int>::max(), 5);
}
{
auto* const w = gtr_get_widget<Gtk::Label>(builder, "alt_upload_limit_label");
w->set_label(fmt::format(w->get_label().raw(), fmt::arg("speed_units", speed_K_str)));
auto* const w2 = gtr_get_widget<Gtk::SpinButton>(builder, "alt_upload_limit_spin");
init_spin_button(*w2, TR_KEY_alt_speed_up, 0, std::numeric_limits<int>::max(), 5);
}
{
auto* const w = gtr_get_widget<Gtk::Label>(builder, "alt_download_limit_label");
w->set_label(fmt::format(w->get_label().raw(), fmt::arg("speed_units", speed_K_str)));
auto* const w2 = gtr_get_widget<Gtk::SpinButton>(builder, "alt_download_limit_spin");
init_spin_button(*w2, TR_KEY_alt_speed_down, 0, std::numeric_limits<int>::max(), 5);
}
{
auto* start_combo = gtr_get_widget<Gtk::ComboBox>(builder, "alt_speed_start_time_combo");
init_time_combo(*start_combo, TR_KEY_alt_speed_time_begin);
auto* end_combo = gtr_get_widget<Gtk::ComboBox>(builder, "alt_speed_end_time_combo");
init_time_combo(*end_combo, TR_KEY_alt_speed_time_end);
auto* w = gtr_get_widget<Gtk::CheckButton>(builder, "alt_schedule_time_check");
init_check_button(*w, TR_KEY_alt_speed_time_enabled);
}
auto* week_combo = gtr_get_widget<Gtk::ComboBox>(builder, "alt_speed_days_combo");
init_week_combo(*week_combo, TR_KEY_alt_speed_time_day);
}
/****
***** Network Tab
****/
class NetworkPage : public PageBase
{
public:
NetworkPage(BaseObjectType* cast_item, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core);
~NetworkPage() override;
TR_DISABLE_COPY_MOVE(NetworkPage)
private:
void onCorePrefsChanged(tr_quark key);
void onPortTested(bool isOpen);
void onPortTest();
private:
Glib::RefPtr<Session> core_;
Gtk::Label* portLabel_ = nullptr;
Gtk::Button* portButton_ = nullptr;
Gtk::SpinButton* portSpin_ = nullptr;
sigc::connection portTag_;
sigc::connection prefsTag_;
};
void NetworkPage::onCorePrefsChanged(tr_quark const key)
{
if (key == TR_KEY_peer_port)
{
gtr_label_set_text(*portLabel_, _("Status unknown"));
portButton_->set_sensitive(true);
portSpin_->set_sensitive(true);
}
}
NetworkPage::~NetworkPage()
{
if (prefsTag_.connected())
{
prefsTag_.disconnect();
}
if (portTag_.connected())
{
portTag_.disconnect();
}
}
void NetworkPage::onPortTested(bool isOpen)
{
portLabel_->set_markup(fmt::format(
isOpen ? _("Port is {markup_begin}open{markup_end}") : _("Port is {markup_begin}closed{markup_end}"),
fmt::arg("markup_begin", "<b>"),
fmt::arg("markup_end", "</b>")));
portButton_->set_sensitive(true);
portSpin_->set_sensitive(true);
}
void NetworkPage::onPortTest()
{
portButton_->set_sensitive(false);
portSpin_->set_sensitive(false);
portLabel_->set_text(_("Testing TCP port…"));
if (!portTag_.connected())
{
portTag_ = core_->signal_port_tested().connect([this](bool is_open) { onPortTested(is_open); });
}
core_->port_test();
}
NetworkPage::NetworkPage(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Glib::RefPtr<Session> const& core)
: PageBase(cast_item, core)
, core_(core)
, portLabel_(gtr_get_widget<Gtk::Label>(builder, "listening_port_status_label"))
, portButton_(gtr_get_widget<Gtk::Button>(builder, "test_listening_port_button"))
, portSpin_(gtr_get_widget<Gtk::SpinButton>(builder, "listening_port_spin"))
{
init_spin_button(*portSpin_, TR_KEY_peer_port, 1, std::numeric_limits<uint16_t>::max(), 1);
portButton_->signal_clicked().connect([this]() { onPortTest(); });
prefsTag_ = core_->signal_prefs_changed().connect([this](auto key) { onCorePrefsChanged(key); });
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "pick_random_listening_port_at_start_check"),
TR_KEY_peer_port_random_on_start);
init_check_button(
*gtr_get_widget<Gtk::CheckButton>(builder, "enable_listening_port_forwarding_check"),
TR_KEY_port_forwarding_enabled);
init_spin_button(
*gtr_get_widget<Gtk::SpinButton>(builder, "max_torrent_peers_spin"),
TR_KEY_peer_limit_per_torrent,
1,
FD_SETSIZE,
5);
init_spin_button(
*gtr_get_widget<Gtk::SpinButton>(builder, "max_total_peers_spin"),
TR_KEY_peer_limit_global,
1,
FD_SETSIZE,
5);
#ifdef WITH_UTP
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "enable_utp_check"), TR_KEY_utp_enabled);
#else
gtr_get_widget<Gtk::CheckButton>(builder, "enable_utp_check")->hide();
#endif
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "enable_pex_check"), TR_KEY_pex_enabled);
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "enable_dht_check"), TR_KEY_dht_enabled);
init_check_button(*gtr_get_widget<Gtk::CheckButton>(builder, "enable_lpd_check"), TR_KEY_lpd_enabled);
init_text_view(*gtr_get_widget<Gtk::TextView>(builder, "default_trackers_view"), TR_KEY_default_trackers);
}
} // namespace
/****
*****
****/
std::unique_ptr<PrefsDialog> PrefsDialog::create(Gtk::Window& parent, Glib::RefPtr<Session> const& core)
{
auto const builder = Gtk::Builder::create_from_resource(gtr_get_full_resource_path("PrefsDialog.ui"));
return std::unique_ptr<PrefsDialog>(gtr_get_widget_derived<PrefsDialog>(builder, "PrefsDialog", parent, core));
}
PrefsDialog::PrefsDialog(
BaseObjectType* cast_item,
Glib::RefPtr<Gtk::Builder> const& builder,
Gtk::Window& parent,
Glib::RefPtr<Session> const& core)
: Gtk::Dialog(cast_item)
, impl_(std::make_unique<Impl>(*this, builder, core))
{
set_transient_for(parent);
}
PrefsDialog::~PrefsDialog() = default;
PrefsDialog::Impl::Impl(PrefsDialog& dialog, Glib::RefPtr<Gtk::Builder> const& builder, Glib::RefPtr<Session> const& core)
: dialog_(dialog)
, core_(core)
{
gtr_get_widget_derived<SpeedPage>(builder, "speed_page_layout", core_);
gtr_get_widget_derived<DownloadingPage>(builder, "downloading_page_layout", core_);
gtr_get_widget_derived<SeedingPage>(builder, "seeding_page_layout", core_);
gtr_get_widget_derived<PrivacyPage>(builder, "privacy_page_layout", core_);
gtr_get_widget_derived<NetworkPage>(builder, "network_page_layout", core_);
gtr_get_widget_derived<DesktopPage>(builder, "desktop_page_layout", core_);
gtr_get_widget_derived<RemotePage>(builder, "remote_page_layout", core_);
dialog_.signal_response().connect(sigc::mem_fun(*this, &Impl::response_cb));
}