mirror of
https://github.com/transmission/transmission
synced 2024-12-27 18:18:10 +00:00
49ce12ce38
* Fix `cppcoreguidelines-pro-type-cstyle-cast` clang-tidy issues * Fix `cppcoreguidelines-pro-type-member-init` clang-tidy issues * Fix `cppcoreguidelines-prefer-member-initializer` clang-tidy issues * Introduce `PageBase` for `PrefsDialog` pages This is in preparation for next PR fixing `Glib::Timer` memory management. * Fix `cppcoreguidelines-owning-memory` clang-tidy issues * Fix `cppcoreguidelines-pro-bounds-array-to-pointer-decay` clang-tidy issues * Fix `cppcoreguidelines-special-member-functions` clang-tidy issues * Fix `cppcoreguidelines-init-variables` clang-tidy issues * Fix `cppcoreguidelines-macro-usage` clang-tidy issues * Fix `cppcoreguidelines-pro-bounds-constant-array-index` clang-tidy issues * Fix `cppcoreguidelines-non-private-member-variables-in-classes` clang-tidy issues * Fix `cppcoreguidelines-pro-type-vararg` clang-tidy issues * Fix `cppcoreguidelines-pro-bounds-pointer-arithmetic` clang-tidy issue * Fix `cppcoreguidelines-pro-type-reinterpret-cast` clang-tidy issues * Fix `cppcoreguidelines-pro-type-static-cast-downcast` clang-tidy issues * Extend clang-tidy configuration Enable all `cppcoreguidelines` checks except for three (`avoid-magic- numbers`, `avoid-non-const-global-variables`, `narrowing-conversions`) which require [more] extensive refactoring and were left for later.
208 lines
5.1 KiB
C++
208 lines
5.1 KiB
C++
// This file Copyright © 2007-2022 Mnemosyne LLC.
|
|
// It may be used under GPLv2 (SPDX: GPL-2.0-only), GPLv3 (SPDX: GPL-3.0-only),
|
|
// or any future license endorsed by Mnemosyne LLC.
|
|
// License text can be found in the licenses/ folder.
|
|
|
|
// _AppIndicatorClass::{fallback,unfallback} use deprecated GtkStatusIcon
|
|
#undef GTK_DISABLE_DEPRECATED
|
|
// We're using deprecated Gtk::StatusItem ourselves as well
|
|
#undef GTKMM_DISABLE_DEPRECATED
|
|
|
|
#include <string>
|
|
|
|
#include <glibmm.h>
|
|
#include <glibmm/i18n.h>
|
|
|
|
#ifdef HAVE_APPINDICATOR
|
|
#ifdef APPINDICATOR_IS_AYATANA
|
|
#include <libayatana-appindicator/app-indicator.h>
|
|
#else
|
|
#include <libappindicator/app-indicator.h>
|
|
#endif
|
|
#endif
|
|
|
|
#include <libtransmission/transmission.h>
|
|
#include <libtransmission/utils.h>
|
|
|
|
#include "Actions.h"
|
|
#include "Session.h"
|
|
#include "SystemTrayIcon.h"
|
|
#include "Utils.h"
|
|
|
|
#ifdef HAVE_APPINDICATOR
|
|
#define TR_SYS_TRAY_IMPL_APPINDICATOR
|
|
#elif !GTKMM_CHECK_VERSION(4, 0, 0)
|
|
#define TR_SYS_TRAY_IMPL_STATUS_ICON
|
|
#else
|
|
#define TR_SYS_TRAY_IMPL_NONE
|
|
#endif
|
|
|
|
using namespace std::literals;
|
|
|
|
namespace
|
|
{
|
|
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
auto const TrayIconName = Glib::ustring("transmission-tray-icon"s);
|
|
auto const AppIconName = Glib::ustring("transmission"s);
|
|
#endif
|
|
|
|
#if defined(TR_SYS_TRAY_IMPL_APPINDICATOR)
|
|
auto const AppName = Glib::ustring("transmission-gtk"s);
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
class SystemTrayIcon::Impl
|
|
{
|
|
public:
|
|
Impl(Gtk::Window& main_window, Glib::RefPtr<Session> const& core);
|
|
~Impl();
|
|
|
|
TR_DISABLE_COPY_MOVE(Impl)
|
|
|
|
void refresh();
|
|
|
|
private:
|
|
void activated();
|
|
void popup(guint button, guint when);
|
|
|
|
[[nodiscard]] std::string make_tooltip_text() const;
|
|
|
|
private:
|
|
Glib::RefPtr<Session> const core_;
|
|
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
Gtk::Menu* menu_;
|
|
#endif
|
|
|
|
#if defined(TR_SYS_TRAY_IMPL_APPINDICATOR)
|
|
AppIndicator* indicator_;
|
|
#elif defined(TR_SYS_TRAY_IMPL_STATUS_ICON)
|
|
Glib::RefPtr<Gtk::StatusIcon> icon_;
|
|
#endif
|
|
};
|
|
|
|
#if defined(TR_SYS_TRAY_IMPL_APPINDICATOR)
|
|
|
|
SystemTrayIcon::Impl::~Impl()
|
|
{
|
|
g_object_unref(indicator_);
|
|
}
|
|
|
|
void SystemTrayIcon::Impl::refresh()
|
|
{
|
|
}
|
|
|
|
#elif defined(TR_SYS_TRAY_IMPL_STATUS_ICON)
|
|
|
|
SystemTrayIcon::Impl::~Impl() = default;
|
|
|
|
void SystemTrayIcon::Impl::activated()
|
|
{
|
|
gtr_action_activate("toggle-main-window");
|
|
}
|
|
|
|
void SystemTrayIcon::Impl::popup(guint /*button*/, guint /*when*/)
|
|
{
|
|
menu_->popup_at_pointer(nullptr);
|
|
}
|
|
|
|
void SystemTrayIcon::Impl::refresh()
|
|
{
|
|
icon_->set_tooltip_text(make_tooltip_text());
|
|
}
|
|
|
|
#else
|
|
|
|
SystemTrayIcon::Impl::~Impl() = default;
|
|
|
|
#endif
|
|
|
|
namespace
|
|
{
|
|
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
|
|
Glib::ustring getIconName()
|
|
{
|
|
Glib::ustring icon_name;
|
|
|
|
// if the tray's icon is a 48x48 file, use it.
|
|
// otherwise, use the fallback builtin icon.
|
|
if (auto theme = Gtk::IconTheme::get_default(); !theme->has_icon(TrayIconName))
|
|
{
|
|
icon_name = AppIconName;
|
|
}
|
|
else
|
|
{
|
|
auto const icon_info = theme->lookup_icon(TrayIconName, 48, Gtk::ICON_LOOKUP_USE_BUILTIN);
|
|
bool const icon_is_builtin = icon_info.get_filename().empty();
|
|
|
|
icon_name = icon_is_builtin ? AppIconName : TrayIconName;
|
|
}
|
|
|
|
return icon_name;
|
|
}
|
|
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
SystemTrayIcon::SystemTrayIcon(Gtk::Window& main_window, Glib::RefPtr<Session> const& core)
|
|
: impl_(std::make_unique<Impl>(main_window, core))
|
|
{
|
|
}
|
|
|
|
SystemTrayIcon::~SystemTrayIcon() = default;
|
|
|
|
void SystemTrayIcon::refresh()
|
|
{
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
impl_->refresh();
|
|
#endif
|
|
}
|
|
|
|
bool SystemTrayIcon::is_available()
|
|
{
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
return true;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
std::unique_ptr<SystemTrayIcon> SystemTrayIcon::create(Gtk::Window& main_window, Glib::RefPtr<Session> const& core)
|
|
{
|
|
return is_available() ? std::make_unique<SystemTrayIcon>(main_window, core) : nullptr;
|
|
}
|
|
|
|
SystemTrayIcon::Impl::Impl([[maybe_unused]] Gtk::Window& main_window, Glib::RefPtr<Session> const& core)
|
|
: core_(core)
|
|
{
|
|
#if !defined(TR_SYS_TRAY_IMPL_NONE)
|
|
auto const icon_name = getIconName();
|
|
menu_ = Gtk::make_managed<Gtk::Menu>(gtr_action_get_object<Gio::Menu>("icon-popup"));
|
|
menu_->attach_to_widget(main_window);
|
|
#endif
|
|
|
|
#if defined(TR_SYS_TRAY_IMPL_APPINDICATOR)
|
|
indicator_ = app_indicator_new(AppName.c_str(), icon_name.c_str(), APP_INDICATOR_CATEGORY_SYSTEM_SERVICES);
|
|
app_indicator_set_status(indicator_, APP_INDICATOR_STATUS_ACTIVE);
|
|
app_indicator_set_menu(indicator_, Glib::unwrap(menu_));
|
|
app_indicator_set_title(indicator_, Glib::get_application_name().c_str());
|
|
#elif defined(TR_SYS_TRAY_IMPL_STATUS_ICON)
|
|
icon_ = Gtk::StatusIcon::create(icon_name);
|
|
icon_->signal_activate().connect(sigc::mem_fun(*this, &Impl::activated));
|
|
icon_->signal_popup_menu().connect(sigc::mem_fun(*this, &Impl::popup));
|
|
#endif
|
|
}
|
|
|
|
std::string SystemTrayIcon::Impl::make_tooltip_text() const
|
|
{
|
|
auto const* const session = core_->get_session();
|
|
return fmt::format(
|
|
_("{upload_speed} ▲ {download_speed} ▼"),
|
|
fmt::arg("upload_speed", tr_formatter_speed_KBps(tr_sessionGetRawSpeed_KBps(session, TR_UP))),
|
|
fmt::arg("download_speed", tr_formatter_speed_KBps(tr_sessionGetRawSpeed_KBps(session, TR_DOWN))));
|
|
}
|