1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-26 09:37:56 +00:00
transmission/gtk/OptionsDialog.h
Mike Gelfand 3e072f9bd4
Fix most of critical issues reported by Sonar (GTK client) (#2309)
* (C++) Macros should not be used to define constants

* (C++) Memory should not be managed manually

* (C++) "void*" should not be used in typedefs, member variables, function parameters or return type

* (C++) When the "Rule-of-Zero" is not applicable, the "Rule-of-Five" should be followed

* (C++) "switch" statements should have "default" clauses

* (C++) "explicit" should be used on single-parameter constructors and conversiosn operators

* (C++) Non-const global variables should not be used
2021-12-14 11:43:27 +03:00

66 lines
1.6 KiB
C++

/*
* This file Copyright (C) 2010-2021 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
* or any future license endorsed by Mnemosyne LLC.
*
*/
#pragma once
#include <memory>
#include <gtkmm.h>
#include <libtransmission/tr-macros.h>
class Session;
typedef struct tr_ctor tr_ctor;
class TorrentUrlChooserDialog : public Gtk::Dialog
{
public:
TR_DISABLE_COPY_MOVE(TorrentUrlChooserDialog)
static std::unique_ptr<TorrentUrlChooserDialog> create(Gtk::Window& parent, Glib::RefPtr<Session> const& core);
protected:
TorrentUrlChooserDialog(Gtk::Window& parent, Glib::RefPtr<Session> const& core);
private:
void onOpenURLResponse(int response, Glib::RefPtr<Session> const& core);
};
class TorrentFileChooserDialog : public Gtk::FileChooserDialog
{
public:
TR_DISABLE_COPY_MOVE(TorrentFileChooserDialog)
static std::unique_ptr<TorrentFileChooserDialog> create(Gtk::Window& parent, Glib::RefPtr<Session> const& core);
protected:
TorrentFileChooserDialog(Gtk::Window& parent, Glib::RefPtr<Session> const& core);
private:
void onOpenDialogResponse(int response, Glib::RefPtr<Session> const& core);
};
class OptionsDialog : public Gtk::Dialog
{
public:
~OptionsDialog() override;
TR_DISABLE_COPY_MOVE(OptionsDialog)
static std::unique_ptr<OptionsDialog> create(
Gtk::Window& parent,
Glib::RefPtr<Session> const& core,
std::unique_ptr<tr_ctor, void (*)(tr_ctor*)> ctor);
protected:
OptionsDialog(Gtk::Window& parent, Glib::RefPtr<Session> const& core, std::unique_ptr<tr_ctor, void (*)(tr_ctor*)> ctor);
private:
class Impl;
std::unique_ptr<Impl> const impl_;
};