1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-26 09:37:56 +00:00
transmission/gtk/SystemTrayIcon.cc
Mike Gelfand 3e072f9bd4
Fix most of critical issues reported by Sonar (GTK client) (#2309)
* (C++) Macros should not be used to define constants

* (C++) Memory should not be managed manually

* (C++) "void*" should not be used in typedefs, member variables, function parameters or return type

* (C++) When the "Rule-of-Zero" is not applicable, the "Rule-of-Five" should be followed

* (C++) "switch" statements should have "default" clauses

* (C++) "explicit" should be used on single-parameter constructors and conversiosn operators

* (C++) Non-const global variables should not be used
2021-12-14 11:43:27 +03:00

214 lines
4.8 KiB
C++

/*
* This file Copyright (C) 2007-2021 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
* or any future license endorsed by Mnemosyne LLC.
*
*/
// _AppIndicatorClass::{fallback,unfallback} use deprecated GtkStatusIcon
#undef GTK_DISABLE_DEPRECATED
// We're using deprecated Gtk::StatusItem ourselves as well
#undef GTKMM_DISABLE_DEPRECATED
#include <glibmm.h>
#include <glibmm/i18n.h>
#ifdef HAVE_LIBAPPINDICATOR
#include <libappindicator/app-indicator.h>
#endif
#include <libtransmission/transmission.h>
#include <libtransmission/utils.h>
#include "Actions.h"
#include "Session.h"
#include "SystemTrayIcon.h"
#include "Utils.h"
using namespace std::literals;
namespace
{
auto const TrayIconName = Glib::ustring("transmission-tray-icon"s);
auto const AppIconName = Glib::ustring("transmission"s);
auto const AppName = Glib::ustring("transmission-gtk"s);
} // namespace
class SystemTrayIcon::Impl
{
public:
Impl(Gtk::Window& main_window, Glib::RefPtr<Session> const& core);
~Impl();
TR_DISABLE_COPY_MOVE(Impl)
void refresh();
private:
void activated();
void popup(guint button, guint when);
private:
Glib::RefPtr<Session> const core_;
Gtk::Menu* menu_;
#ifdef HAVE_LIBAPPINDICATOR
AppIndicator* indicator_;
#else
Glib::RefPtr<Gtk::StatusIcon> icon_;
#endif
};
#ifdef HAVE_LIBAPPINDICATOR
SystemTrayIcon::Impl::~Impl()
{
g_object_unref(indicator_);
}
void SystemTrayIcon::Impl::refresh()
{
}
#else
SystemTrayIcon::Impl::~Impl() = default;
void SystemTrayIcon::Impl::activated()
{
gtr_action_activate("toggle-main-window");
}
void SystemTrayIcon::Impl::popup(guint /*button*/, guint /*when*/)
{
menu_->popup_at_pointer(nullptr);
}
void SystemTrayIcon::Impl::refresh()
{
double KBps;
double limit;
char up[64];
Glib::ustring upLimit;
char down[64];
Glib::ustring downLimit;
char const* idle = _("Idle");
auto* session = core_->get_session();
/* up */
KBps = tr_sessionGetRawSpeed_KBps(session, TR_UP);
if (KBps < 0.001)
{
g_strlcpy(up, idle, sizeof(up));
}
else
{
tr_formatter_speed_KBps(up, KBps, sizeof(up));
}
/* up limit */
if (tr_sessionGetActiveSpeedLimit_KBps(session, TR_UP, &limit))
{
char buf[64];
tr_formatter_speed_KBps(buf, limit, sizeof(buf));
upLimit = gtr_sprintf(_(" (Limit: %s)"), buf);
}
/* down */
KBps = tr_sessionGetRawSpeed_KBps(session, TR_DOWN);
if (KBps < 0.001)
{
g_strlcpy(down, idle, sizeof(down));
}
else
{
tr_formatter_speed_KBps(down, KBps, sizeof(down));
}
/* down limit */
if (tr_sessionGetActiveSpeedLimit_KBps(session, TR_DOWN, &limit))
{
char buf[64];
tr_formatter_speed_KBps(buf, limit, sizeof(buf));
downLimit = gtr_sprintf(_(" (Limit: %s)"), buf);
}
/* %1$s: current upload speed
* %2$s: current upload limit, if any
* %3$s: current download speed
* %4$s: current download limit, if any */
auto const tip = gtr_sprintf(_("Transmission\nUp: %1$s %2$s\nDown: %3$s %4$s"), up, upLimit, down, downLimit);
icon_->set_tooltip_text(tip);
}
#endif
namespace
{
Glib::ustring getIconName()
{
Glib::ustring icon_name;
auto theme = Gtk::IconTheme::get_default();
// if the tray's icon is a 48x48 file, use it.
// otherwise, use the fallback builtin icon.
if (!theme->has_icon(TrayIconName))
{
icon_name = AppIconName;
}
else
{
auto const icon_info = theme->lookup_icon(TrayIconName, 48, Gtk::ICON_LOOKUP_USE_BUILTIN);
bool const icon_is_builtin = icon_info.get_filename().empty();
icon_name = icon_is_builtin ? AppIconName : TrayIconName;
}
return icon_name;
}
} // namespace
SystemTrayIcon::SystemTrayIcon(Gtk::Window& main_window, Glib::RefPtr<Session> const& core)
: impl_(std::make_unique<Impl>(main_window, core))
{
}
SystemTrayIcon::~SystemTrayIcon() = default;
void SystemTrayIcon::refresh()
{
impl_->refresh();
}
SystemTrayIcon::Impl::Impl(Gtk::Window& main_window, Glib::RefPtr<Session> const& core)
: core_(core)
{
auto const icon_name = getIconName();
menu_ = Gtk::make_managed<Gtk::Menu>(gtr_action_get_object<Gio::Menu>("icon-popup"));
menu_->attach_to_widget(main_window);
#ifdef HAVE_LIBAPPINDICATOR
indicator_ = app_indicator_new(AppName.c_str(), icon_name.c_str(), APP_INDICATOR_CATEGORY_SYSTEM_SERVICES);
app_indicator_set_status(indicator_, APP_INDICATOR_STATUS_ACTIVE);
app_indicator_set_menu(indicator_, Glib::unwrap(menu_));
app_indicator_set_title(indicator_, Glib::get_application_name().c_str());
#else
icon_ = Gtk::StatusIcon::create(icon_name);
icon_->signal_activate().connect(sigc::mem_fun(*this, &Impl::activated));
icon_->signal_popup_menu().connect(sigc::mem_fun(*this, &Impl::popup));
#endif
}