mirror of
https://github.com/blackjack4494/yt-dlc.git
synced 2024-12-23 08:17:00 +00:00
[jsinterp] Avoid double key lookup for setting new key
In order to add a new key to both __objects and __functions dicts on jsinterp.py, it is necessary to first verify if a key was present and if not, create the key and assign it to a value. However, this can be done with a single step using dict setdefault method.
This commit is contained in:
parent
589568789f
commit
7c05097633
1 changed files with 3 additions and 5 deletions
|
@ -131,9 +131,8 @@ class JSInterpreter(object):
|
||||||
if variable in local_vars:
|
if variable in local_vars:
|
||||||
obj = local_vars[variable]
|
obj = local_vars[variable]
|
||||||
else:
|
else:
|
||||||
if variable not in self._objects:
|
obj = self._objects.setdefault(
|
||||||
self._objects[variable] = self.extract_object(variable)
|
variable, self.extract_object(variable))
|
||||||
obj = self._objects[variable]
|
|
||||||
|
|
||||||
if arg_str is None:
|
if arg_str is None:
|
||||||
# Member access
|
# Member access
|
||||||
|
@ -204,8 +203,7 @@ class JSInterpreter(object):
|
||||||
argvals = tuple([
|
argvals = tuple([
|
||||||
int(v) if v.isdigit() else local_vars[v]
|
int(v) if v.isdigit() else local_vars[v]
|
||||||
for v in m.group('args').split(',')])
|
for v in m.group('args').split(',')])
|
||||||
if fname not in self._functions:
|
self._functions.setdefault(fname, self.extract_function(fname))
|
||||||
self._functions[fname] = self.extract_function(fname)
|
|
||||||
return self._functions[fname](argvals)
|
return self._functions[fname](argvals)
|
||||||
|
|
||||||
raise ExtractorError('Unsupported JS expression %r' % expr)
|
raise ExtractorError('Unsupported JS expression %r' % expr)
|
||||||
|
|
Loading…
Reference in a new issue