From b96a939bbf2248f194daf9818c41e215c7b1854c Mon Sep 17 00:00:00 2001 From: Tom-Oliver Heidel Date: Wed, 23 Sep 2020 21:15:54 +0200 Subject: [PATCH 1/2] [skip travis] advice using pyinst.py for windows --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 701c90c5b..2a0cf3a48 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,7 @@ Using curl: **Windows** users can download [youtube-dlc.exe](https://github.com/blackjack4494/youtube-dlc/releases/latest/download/youtube-dlc.exe) (**do not** put in `C:\Windows\System32`!). **Compile** -To build the Windows executable yourself +To build the Windows executable yourself (without version info!) python -m pip install --upgrade pyinstaller pyinstaller.exe youtube_dlc\__main__.py --onefile --name youtube-dlc @@ -58,6 +58,9 @@ To build the Windows executable yourself Or simply execute the `make_win.bat` if pyinstaller is installed. There will be a `youtube-dlc.exe` in `/dist` +New way to build Windows is to use `python pyinst.py` (please use python3 64Bit) +For 32Bit Version use a 32Bit Version of python (3 preferred here as well) and run `python pyinst32.py` + For Unix: You will need the required build tools python, make (GNU), pandoc, zip, nosetests From 61e4c6ed454d0b015ad6f22d7540d3c914cd34bb Mon Sep 17 00:00:00 2001 From: stephen Date: Sun, 27 Sep 2020 05:33:37 -0500 Subject: [PATCH 2/2] Added regex for ABC.com site. --- youtube_dlc/extractor/go.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/youtube_dlc/extractor/go.py b/youtube_dlc/extractor/go.py index 03cfba91f..7a75dfa49 100644 --- a/youtube_dlc/extractor/go.py +++ b/youtube_dlc/extractor/go.py @@ -137,7 +137,11 @@ class GoIE(AdobePassIE): # There may be inner quotes, e.g. data-video-id="'VDKA3609139'" # from http://freeform.go.com/shows/shadowhunters/episodes/season-2/1-this-guilty-blood r'data-video-id=["\']*(VDKA\w+)', - # https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet + # https://github.com/ytdl-org/youtube-dl/pull/25216/files + # The following is based on the pull request on the line above. Changed the ABC.com URL to a show available now. + # https://abc.com/shows/the-rookie/episode-guide/season-02/19-the-q-word + r'\bvideoIdCode["\']\s*:\s*["\'](vdka\w+)', + # Deprecated fallback pattern r'\b(?:video)?id["\']\s*:\s*["\'](VDKA\w+)' ), webpage, 'video id', default=video_id) if not site_info: