Remove empty constructors

2023-05-18 20:44:05 +03:00 · 2023-05-18 20:44:05 +03:00 · fd76d67bae
parent 156def3138
commit fd76d67bae
25 changed files with 6 additions and 102 deletions
--- a/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs
+++ b/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs
@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading;
 using Moq;
 using NUnit.Framework;
@ -210,10 +210,6 @@ namespace NzbDrone.Core.Test.Messaging.Commands

    public class CommandB : Command
    {
-        public CommandB()
-        {
-        }
-
        public override string CompletionMessage => null;
    }
 }
--- a/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs
+++ b/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs
@ -4,8 +4,5 @@ namespace NzbDrone.Core.Download
 {
    public class DownloadsProcessedEvent : IEvent
    {
-        public DownloadsProcessedEvent()
-        {
-        }
    }
 }
--- a/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs
+++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs
@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.MediaBrowser
 {
    public class MediaBrowserSettingsValidator : AbstractValidator<MediaBrowserMetadataSettings>
    {
-        public MediaBrowserSettingsValidator()
-        {
-        }
    }

    public class MediaBrowserMetadataSettings : IProviderConfig
--- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs
+++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs
@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Roksbox
 {
    public class RoksboxSettingsValidator : AbstractValidator<RoksboxMetadataSettings>
    {
-        public RoksboxSettingsValidator()
-        {
-        }
    }

    public class RoksboxMetadataSettings : IProviderConfig
--- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs
+++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs
@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Wdtv
 {
    public class WdtvSettingsValidator : AbstractValidator<WdtvMetadataSettings>
    {
-        public WdtvSettingsValidator()
-        {
-        }
    }

    public class WdtvMetadataSettings : IProviderConfig
--- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs
+++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs
@ -8,9 +8,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Xbmc
 {
    public class XbmcSettingsValidator : AbstractValidator<XbmcMetadataSettings>
    {
-        public XbmcSettingsValidator()
-        {
-        }
    }

    public class XbmcMetadataSettings : IProviderConfig
--- a/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs
+++ b/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs
@ -12,10 +12,6 @@ namespace NzbDrone.Core.ImportLists.CouchPotato
    {
        private ImportListResponse _importListResponse;

-        public CouchPotatoParser()
-        {
-        }
-
        public IList<ImportListMovie> ParseResponse(ImportListResponse importListResponse)
        {
            _importListResponse = importListResponse;
--- a/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs
+++ b/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs
@ -14,10 +14,6 @@ namespace NzbDrone.Core.ImportLists.Plex
    {
        private ImportListResponse _importResponse;

-        public PlexParser()
-        {
-        }
-
        public virtual IList<ImportListMovie> ParseResponse(ImportListResponse importResponse)
        {
            List<PlexWatchlistItem> items;
--- a/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs
+++ b/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs
@ -9,10 +9,6 @@ namespace NzbDrone.Core.ImportLists.RadarrList
 {
    public class RadarrListParser : IParseImportListResponse
    {
-        public RadarrListParser()
-        {
-        }
-
        public IList<ImportListMovie> ParseResponse(ImportListResponse importListResponse)
        {
            var importResponse = importListResponse;
--- a/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs
+++ b/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs
@ -1,4 +1,4 @@
-using FluentValidation;
+using FluentValidation;
 using NzbDrone.Core.Annotations;
 using NzbDrone.Core.ThingiProvider;
 using NzbDrone.Core.Validation;
@ -19,10 +19,6 @@ namespace NzbDrone.Core.ImportLists.RadarrList2.IMDbList
    {
        private static readonly IMDbSettingsValidator Validator = new IMDbSettingsValidator();

-        public IMDbListSettings()
-        {
-        }
-
        [FieldDefinition(1, Label = "List/User ID", HelpText = "IMDb list ID (e.g ls12345678), IMDb user ID (e.g. ur12345678), 'top250' or 'popular'")]
        public string ListId { get; set; }

--- a/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs
+++ b/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs
@ -11,10 +11,6 @@ namespace NzbDrone.Core.ImportLists.StevenLu
    {
        private ImportListResponse _importResponse;

-        public StevenLuParser()
-        {
-        }
-
        public IList<ImportListMovie> ParseResponse(ImportListResponse importResponse)
        {
            _importResponse = importResponse;
--- a/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs
@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using Newtonsoft.Json;
 using NLog;
 using NzbDrone.Common.Http;
@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Company
        public Logger Logger { get; set; }
        public int MaxPages { get; set; }

-        public TMDbCompanyRequestGenerator()
-        {
-        }
-
        public virtual ImportListPageableRequestChain GetMovies()
        {
            var pageableRequests = new ImportListPageableRequestChain();
--- a/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs
@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Keyword
        public Logger Logger { get; set; }
        public int MaxPages { get; set; }

-        public TMDbKeywordRequestGenerator()
-        {
-        }
-
        public virtual ImportListPageableRequestChain GetMovies()
        {
            var pageableRequests = new ImportListPageableRequestChain();
--- a/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs
@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.List
        public Logger Logger { get; set; }
        public int MaxPages { get; set; }

-        public TMDbListRequestGenerator()
-        {
-        }
-
        public virtual ImportListPageableRequestChain GetMovies()
        {
            var pageableRequests = new ImportListPageableRequestChain();
--- a/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs
@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using NLog;
 using NzbDrone.Common.Http;

@ -11,10 +11,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Person
        public IHttpRequestBuilderFactory RequestBuilder { get; set; }
        public Logger Logger { get; set; }

-        public TMDbPersonRequestGenerator()
-        {
-        }
-
        public virtual ImportListPageableRequestChain GetMovies()
        {
            var pageableRequests = new ImportListPageableRequestChain();
--- a/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs
@ -1,4 +1,4 @@
-using FluentValidation;
+using FluentValidation;
 using NzbDrone.Core.ThingiProvider;
 using NzbDrone.Core.Validation;

@ -7,18 +7,12 @@ namespace NzbDrone.Core.ImportLists.TMDb
    public class TMDbSettingsBaseValidator<TSettings> : AbstractValidator<TSettings>
        where TSettings : TMDbSettingsBase<TSettings>
    {
-        public TMDbSettingsBaseValidator()
-        {
-        }
    }

    public class TMDbSettingsBase<TSettings> : IProviderConfig
        where TSettings : TMDbSettingsBase<TSettings>
    {
        protected virtual AbstractValidator<TSettings> Validator => new TMDbSettingsBaseValidator<TSettings>();
-        public TMDbSettingsBase()
-        {
-        }

        public NzbDroneValidationResult Validate()
        {
--- a/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs
+++ b/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs
@ -15,10 +15,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.User

        public int MaxPages { get; set; }

-        public TMDbUserRequestGenerator()
-        {
-        }
-
        public virtual ImportListPageableRequestChain GetMovies()
        {
            var pageableRequests = new ImportListPageableRequestChain();
--- a/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs
+++ b/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs
@ -17,10 +17,6 @@ namespace NzbDrone.Core.ImportLists.Trakt.List
    {
        protected override AbstractValidator<TraktListSettings> Validator => new TraktListSettingsValidator();

-        public TraktListSettings()
-        {
-        }
-
        [FieldDefinition(1, Label = "Username", Privacy = PrivacyLevel.UserName, HelpText = "Username for the List to import from")]
        public string Username { get; set; }

--- a/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs
+++ b/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs
@ -12,10 +12,6 @@ namespace NzbDrone.Core.ImportLists.Trakt
    {
        private ImportListResponse _importResponse;

-        public TraktParser()
-        {
-        }
-
        public virtual IList<ImportListMovie> ParseResponse(ImportListResponse importResponse)
        {
            _importResponse = importResponse;
--- a/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs
+++ b/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs
@ -10,10 +10,6 @@ namespace NzbDrone.Core.Indexers.TorrentPotato
    {
        public TorrentPotatoSettings Settings { get; set; }

-        public TorrentPotatoRequestGenerator()
-        {
-        }
-
        public virtual IndexerPageableRequestChain GetRecentRequests()
        {
            var pageableRequests = new IndexerPageableRequestChain();
--- a/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs
+++ b/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs
@ -9,9 +9,5 @@ namespace NzbDrone.Core.MediaFiles.Commands

        public override bool SendUpdatesToClient => true;
        public override bool RequiresDiskAccess => true;
-
-        public RenameMovieCommand()
-        {
-        }
    }
 }
--- a/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs
+++ b/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs
@ -1,4 +1,4 @@
-using FluentValidation;
+using FluentValidation;
 using NzbDrone.Core.Annotations;
 using NzbDrone.Core.ThingiProvider;
 using NzbDrone.Core.Validation;
@ -7,9 +7,6 @@ namespace NzbDrone.Core.Notifications.Synology
 {
    public class SynologyIndexerSettingsValidator : AbstractValidator<SynologyIndexerSettings>
    {
-        public SynologyIndexerSettingsValidator()
-        {
-        }
    }

    public class SynologyIndexerSettings : IProviderConfig
--- a/src/Radarr.Api.V3/Credits/CreditResource.cs
+++ b/src/Radarr.Api.V3/Credits/CreditResource.cs
@ -8,10 +8,6 @@ namespace Radarr.Api.V3.Credits
 {
    public class CreditResource : RestResource
    {
-        public CreditResource()
-        {
-        }
-
        public string PersonName { get; set; }
        public string CreditTmdbId { get; set; }
        public int PersonTmdbId { get; set; }
--- a/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs
+++ b/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs
@ -8,10 +8,6 @@ namespace Radarr.Api.V3.Movies
 {
    public class AlternativeTitleResource : RestResource
    {
-        public AlternativeTitleResource()
-        {
-        }
-
        // Todo: Sorters should be done completely on the client
        // Todo: Is there an easy way to keep IgnoreArticlesWhenSorting in sync between, Series, History, Missing?
        // Todo: We should get the entire Profile instead of ID and Name separately
--- a/src/Radarr.Http/ApiInfoController.cs
+++ b/src/Radarr.Http/ApiInfoController.cs
@ -5,10 +5,6 @@ namespace Radarr.Http
 {
    public class ApiInfoController : Controller
    {
-        public ApiInfoController()
-        {
-        }
-
        [HttpGet("/api")]
        [Produces("application/json")]
        public ApiInfoResource GetApiInfo()