d706409c59
Switch mbox locking from flock(2) to posix lockf(2)
...
flock() locks aren't portable; lockf() locks are.
2010-07-19 01:13:25 +02:00
d726589414
Rename procmail_lock->dotlock_lock
...
An entirely cosmetic variable rename, but it's just not correct to call
this a "procmail lock". Also reword some comments accordingly.
2010-07-19 01:13:25 +02:00
54821151e4
Fix minor race when deleting messages in a maildir/mh box
...
Nothing serious, but if another client deleted it in the small window after
we checked it, we would have crashed trying to delete a non-existing file.
2010-07-19 01:13:24 +02:00
a7414319c9
Simplify the final committing of the mailbox and archive
...
* Make the finalise() methods spot if they have anything to do
* We used to create the temporary mbox files on demand in the message
processing loop, if we needed to write to them. Now we create them
beforehand, but only if they might be needed (e.g. we don't create an
archive if options.delete_old_mail is set).
* The above combined makes the final committing of the changes simpler (a
*lot* simpler for mboxes), and we can dump the Mbox.leave_empty() method.
2010-07-19 01:13:24 +02:00
b37b3d627e
Split out new class TempMbox
...
This separates write-only mbox access to the temporary mboxes from the read-only
access to the original mbox.
2010-07-19 01:01:04 +02:00
d6a161cd9e
Simplify ArchiveMbox.__init__
2009-11-06 21:09:40 +01:00
df680c19be
Append to the archive, and don't use rename()
...
This is WIP to prepare locking for the archive. Since we no longer copy the
whole archive before appending, archiving should also be faster.
2009-11-06 21:09:40 +01:00
37f96c1c84
Remove unused method Mbox.is_empty()
2009-11-06 21:09:40 +01:00
a78af4c0ff
Keep mbox files open, so we don't break our locks
...
When committing a changed mbox, don't use os.rename(), and don't open/close
the mbox file to truncate it to zero length. Locking was pretty much broken
before -- at least in theory a quite severe bug.
2009-11-06 21:09:39 +01:00
ba8928d279
Cleanup restoring of the mbox timestamps
...
* Remove code duplication: restore the mbox timestamps once and for all when
we're done
* Don't bother restoring the file mode when finishing, since this is handled in
RetainMbox.finalise() (and need be)
* Therefore, rename Mbox.reset_stat() to reset_timestamps()
2009-11-06 21:09:39 +01:00
223e2f9802
Cosmetics: in verbose mode, report current mailbox early
...
This is now before we do the sanity checking, so in verbose mode, we don't error
out before having said that we now turn attention to the current mailbox.
2009-11-06 21:09:39 +01:00
aee4df2fcf
Refuse to process mailboxes owned by someone else
...
This should also protect people relying on the old setuid feature.
If the mailbox is local, by checking the ownership we necessarily check for
existance.
2009-11-06 21:09:39 +01:00
2e0f3cd3aa
Sanity check existing archives early
...
This used to happen when creating the temporary archive, we now do it before we
start processing the mailbox.
2009-11-06 21:09:39 +01:00
79bcf86860
Remove simple-minded security checks
...
Remove the checks if the mailbox is a symlink, and if the output directory is
world-writable. Better no security than half-baked security.
2009-11-06 21:09:39 +01:00
a3276f8c68
Move archive naming code into new function make_archive_name()
2009-11-06 21:09:38 +01:00
cd07a2663e
Remove the setuid functionality
...
It was not a good idea, and trying to do it right would be too much effort.
2009-11-06 21:09:38 +01:00
bd85cffe37
Simplify imap_get_namespace() and imap_guess_mailboxnames()
...
I don't think anybody wants to archive folders in shared or public IMAP
namespaces, so we don't bother checking all possible namespaces. The code was
ugly anyway.
2009-11-06 21:09:38 +01:00
9574c4f41c
Removed obsolete references to subversion
...
archivemail development has moved to git. This patch updates the project
webpage, removes the subversion $Id$ keyword that was stored in
archivemail.__svn_id__, and updates the Makefile.
2009-11-06 17:20:16 +01:00
c6cb0b4612
IMAP: imap_guess_mailboxnames: check for NIL delimiter.
...
Only replace the slash with the server's hierarchy delimiter if the latter
actually exists (is not NIL).
2008-04-09 00:22:07 +00:00
622c0105ea
IMAP: only check for \Deleted in PERMANENTFLAGS if mailbox isn't read-only.
...
This spewed an error when --dry-running.
2008-04-08 23:06:10 +00:00
775952ec98
IMAP: added sanity check for \Deleted in PERMANENTFLAGS.
2008-04-08 19:31:11 +00:00
681fd0c527
Minor, local variable renaming.
2008-04-08 19:10:41 +00:00
e5b6397dd5
Moved IMAP SELECT code into a separate function.
2008-04-08 19:06:42 +00:00
78b4923832
IMAP: be NAMESPACE-aware; improved probing for guessed mailbox names.
...
* Automatically add NAMESPACE prefix to the mailbox path if necessary,
* Explicitely check for guessed mailbox names with LIST instead of just trying
to SELECT them.
* Updated documentation about NAMESPACE handling.
2008-04-08 15:38:51 +00:00
bfff00e395
Code structuring: made a separate group of IMAP functions.
...
No code changes, just moved functions around.
2008-04-07 20:16:29 +00:00
07219ff14b
IMAP: servers should never advertise LOGINDISABLED with SSL; removed the check
...
for it, which was just used to spit a special error message anyway.
2008-03-21 01:05:15 +00:00
26ab4611ec
Archiving an IMAP folder with --all didn't archive *any* messages.
...
The message sequence numbers must be strings, but were generated as integers;
fixed.
2008-03-19 18:30:43 +00:00
efe02ea32a
Updated year in another copyright note, which I overlooked before.
2008-03-16 17:57:18 +00:00
a9215463c4
Removed an assertion which choked upon --days=0.
2008-03-15 20:34:52 +00:00
f43cbb106d
Added new option --all to archive all messages in a mailbox.
...
Updated documentation, and added a first simple unittest for this.
Closes : #1764846 .
2008-03-15 20:24:46 +00:00
2719645f2c
Updated copyright notes to include year 2008.
2008-03-15 19:39:28 +00:00
c0f0ad33d7
Fixed crash when archiving an empty maildir with python 2.5.
...
The incompatible changes in mailbox.Maildir triggered an assertion in
_archive_dir(); removing that assertion since it looks not useful anyway.
2008-03-15 18:42:56 +00:00
22e23d9d38
Sanitized parsing some IMAP server responses by switching to regular
...
expressions.
2008-03-15 15:59:05 +00:00
704d5a961e
Added --debug-imap option which just sets imaplib.Debug.
2008-02-14 22:26:10 +00:00
6abf732d2e
IMAP: catch LOGINDISABLED, and suggest using imaps.
2008-02-14 22:24:16 +00:00
533628c2fc
Only try CRAM-MD5 authentication if the server advertises it.
2008-02-14 22:19:34 +00:00
77481169d8
_archive_imap() used SSL only if the 'imaps://' url scheme was all lowercase.
...
Fixed.
2008-01-19 00:04:01 +00:00
8e5c870057
guess_delivery_time():
...
* look for the timestamp of the latest 'Received' header before resorting to
'Date' or 'Resent-Date'.
* let 'Resent-date' header take precedence over 'Date'.
Document these changes in manpage and changelog.
Closes : #1481316 , #1764855 , Debian bug #272666 .
2007-11-13 21:13:38 +00:00
4584dffe14
Fixed date header parsing to be precise with timezone information. Also, when
...
writing From_ line timestamps, don't use UTC but local time, without timezone
information.
2007-11-13 02:59:31 +00:00
5178c956bc
!%&$*# Repair previous broken commit where an unrelated hunk slipped through.
...
Reverted that hunk.
2007-11-13 00:36:51 +00:00
d9ffaf4a3b
When converting from other formats to mbox, re-use existing 'Status' and
...
'X-Status' headers if appropriate (instead of deleting and re-generating them).
2007-11-13 00:32:49 +00:00
ead112daba
If running as root, only call seteuid/setegid if the if the owner of the mailbox
...
is not root.
2007-11-09 17:04:52 +00:00
0ae7edab86
Bumped version to 0.7.2, and updated release info on the webpage.
2007-11-09 14:54:54 +00:00
e0c75a1001
IMAP: fixed crash by working around python bug #1277098 , which is still pending
...
in python << 2.5.
2007-11-09 14:33:13 +00:00
4b64da911e
Debug message improvements. Explicitely say if we're selecting an IMAP mailbox
...
read-only. Improve some formatting.
2007-11-07 23:57:03 +00:00
adf6515746
Added more debugging messages to the IMAP flag conversion.
2007-11-07 23:51:41 +00:00
9439e1fa8a
Minor code cleanup.
2007-11-07 23:50:18 +00:00
d5cb3dad61
IMAP: if selecting a mailbox fails with both the original path name and with
...
replaced path delimiters, report failure for the original path.
2007-11-07 21:10:08 +00:00
f47de26676
Minor code cleanups.
2007-11-07 19:52:52 +00:00
fbb00e08f4
IMAP: if selecting the mailbox fails, then detect the server's mailbox hierarchy
...
delimiter, replace slashes in the mailbox name with the delimiter and try again.
2007-11-07 16:31:49 +00:00
Nikolaus Schulz