mirror
/
borg
mirror of https://github.com/borgbackup/borg.git
1
0
Fork 0
Code Issues Releases Wiki Activity

ignore posix_fadvise errors in repository.py, work around #2095 

note: we also ignore the call's return value in _chunker.c.

both is harmless as the call not working does not cause incorrect function,
just worse performance due to constant flooding of the cache (as if we
would not issue the call).
This commit is contained in:
Thomas Waldmann 2017-01-27 21:09:55 +01:00
parent 5a39d5c4f8
commit add38e8cde
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
borg/repository.py
View File

@ -833,9 +833,19 @@ class LoggedIO:
fileno = fd.fileno()
os.fsync(fileno)
if hasattr(os, 'posix_fadvise'): # only on UNIX
# tell the OS that it does not need to cache what we just wrote,
# avoids spoiling the cache for the OS and other processes.
os.posix_fadvise(fileno, 0, 0, os.POSIX_FADV_DONTNEED)
try:
# tell the OS that it does not need to cache what we just wrote,
# avoids spoiling the cache for the OS and other processes.
os.posix_fadvise(fileno, 0, 0, os.POSIX_FADV_DONTNEED)
except OSError:
# usually, posix_fadvise can't fail for us, but there seem to
# be failures when running borg under docker on ARM, likely due
# to a bug outside of borg.
# also, there is a python wrapper bug, always giving errno = 0.
# https://github.com/borgbackup/borg/issues/2095
# as this call is not critical for correct function (just to
# optimize cache usage), we ignore these errors.
pass
finally:
fd.close()
if dirname: