Add an unique index on addresses url

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This commit is contained in:
Thomas Citharel 2021-04-22 17:48:43 +02:00
parent 67b537f380
commit 17a6a6eada
No known key found for this signature in database
GPG Key ID: A061B9DDE0CA0773
3 changed files with 87 additions and 0 deletions

View File

@ -63,6 +63,7 @@ defmodule Mobilizon.Addresses.Address do
|> cast(attrs, @attrs) |> cast(attrs, @attrs)
|> set_url() |> set_url()
|> validate_required(@required_attrs) |> validate_required(@required_attrs)
|> unique_constraint(:url, name: :addresses_url_index)
end end
@spec set_url(Ecto.Changeset.t()) :: Ecto.Changeset.t() @spec set_url(Ecto.Changeset.t()) :: Ecto.Changeset.t()

View File

@ -0,0 +1,75 @@
defmodule Mobilizon.Storage.Repo.Migrations.CleanupAddresses do
use Ecto.Migration
def up do
# Make sure we don't have any duplicate addresses
rows = fetch_bad_rows()
Enum.each(rows, &process_row/1)
flush()
end
def down do
# No way down
end
defp fetch_bad_rows() do
%Postgrex.Result{rows: rows} =
Ecto.Adapters.SQL.query!(
Mobilizon.Storage.Repo,
"SELECT * FROM (
SELECT id, url,
ROW_NUMBER() OVER(PARTITION BY url ORDER BY id asc) AS Row
FROM addresses
) dups
WHERE dups.Row > 1;"
)
rows
end
defp process_row([id, url, _row]) do
first_id = find_first_address_id(url)
if id != first_id do
repair_events(id, first_id)
repair_actors(id, first_id)
delete_row(id)
end
end
defp find_first_address_id(url) do
%Postgrex.Result{rows: [[id]]} =
Ecto.Adapters.SQL.query!(
Mobilizon.Storage.Repo,
"SELECT id FROM addresses WHERE url = $1 order by id asc limit 1",
[url]
)
id
end
defp repair_events(id, first_id) do
Ecto.Adapters.SQL.query!(
Mobilizon.Storage.Repo,
"UPDATE events SET physical_address_id = $1 WHERE physical_address_id = $2",
[first_id, id]
)
end
defp repair_actors(id, first_id) do
Ecto.Adapters.SQL.query!(
Mobilizon.Storage.Repo,
"UPDATE actors SET physical_address_id = $1 WHERE physical_address_id = $2",
[first_id, id]
)
end
defp delete_row(id) do
Ecto.Adapters.SQL.query!(
Mobilizon.Storage.Repo,
"DELETE FROM addresses WHERE id = $1",
[id]
)
end
end

View File

@ -0,0 +1,11 @@
defmodule Mobilizon.Storage.Repo.Migrations.AddIndexToAddresses do
use Ecto.Migration
def up do
create_if_not_exists(unique_index("addresses", [:url]))
end
def down do
drop_if_exists(index("addresses", [:url]))
end
end