mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity
transmission/qt/MainWindow.cc

1585 lines
46 KiB
C++
Raw Normal View History

(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
/*
Refactor RPC requests code for proper queueing (patch by intelfx @ GH-10) This refactoring is driven by the need to be able to do true queued RPC calls (where each successive call uses the result of the previous). Currently, such queueing of requests is done by assigning them special "magic" tag numbers, which are then intercepted in one big switch() statement and acted upon. This (aside from making code greatly unclear) effectively makes each such queue a singleton, because state passing is restricted to global variables. We refactor RpcClient to assign an unique tag to each remote call, and then abstract all the call<->response matching with Qt's future/promise mechanism. Finally, we introduce a "RPC request queue" class (RpcQueue) which is built on top of QFutureWatcher and C++11's <functional> library. This class maintains a queue of functions, where each function receives an RPC response, does necessary processing, performs another call and finally returns its future.
2016-04-19 20:41:59 +00:00
* This file Copyright (C) 2009-2016 Mnemosyne LLC
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
*
Fix license wording in Qt client .cc files to match the rest of the code.
2014-12-21 23:49:39 +00:00
* It may be used under the GNU GPL versions 2 or 3
Licensing changes: 1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed 2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :) 3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
* or any future license endorsed by Mnemosyne LLC.
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
*
*/
#include <cassert>
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
#include <QtGui>
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
#include <QCheckBox>
#5848: Use theme-provided icons in Qt client (patch by equeim + small additions)
2014-12-12 21:47:22 +00:00
#include <QIcon>
Set icon for "Open URL" action (Qt client)
2017-02-18 18:22:34 +00:00
#include <QPainter>
support qt5 in transmission-qt
2013-07-27 21:58:14 +00:00
#include <QProxyStyle>
#include <QLabel>
#include <QFileDialog>
#include <QMessageBox>
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
(trunk qt) fix qt build broken by r9719; error reported by Lacrocivious
2009-12-12 15:38:14 +00:00
#include <libtransmission/transmission.h>
(trunk) make it possible to #include "version.h" without having to add -I${TOP}/libtransmission/ to your CFLAGS
2009-04-13 19:04:21 +00:00
#include <libtransmission/version.h>
Use PascalCase for Qt client filenames Split FileTree.{h,cc} and FilterBar.{h,cc} files so that each class is in its own file. This breaks translations (some classes got renamed => context changed), to be fixed by next commit (along with Tx sync).
2015-06-10 21:27:11 +00:00
#include "AboutDialog.h"
#include "AddData.h"
#include "Application.h"
#include "DetailsDialog.h"
#include "FilterBar.h"
#include "Filters.h"
#include "Formatter.h"
#include "MainWindow.h"
#include "MakeDialog.h"
#include "OptionsDialog.h"
#include "Prefs.h"
#include "PrefsDialog.h"
#include "RelocateDialog.h"
#include "Session.h"
#include "SessionDialog.h"
#include "Speed.h"
#include "StatsDialog.h"
#include "TorrentDelegate.h"
#include "TorrentDelegateMin.h"
#include "TorrentFilter.h"
#include "TorrentModel.h"
Create dialogs on demand, don't keep them ready all the time
2015-07-30 06:18:02 +00:00
#include "Utils.h"
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
#define PREF_VARIANTS_KEY "pref-variants-list"
#define STATS_MODE_KEY "stats-mode"
#define SORT_MODE_KEY "sort-mode"
namespace
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QLatin1String const TotalRatioStatsModeName("total-ratio");
QLatin1String const TotalTransferStatsModeName("total-transfer");
QLatin1String const SessionRatioStatsModeName("session-ratio");
QLatin1String const SessionTransferStatsModeName("session-transfer");
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
} // namespace
(trunk, qt) #4624 "Inconsistent behavior when clicking on items at the torrent list" -- apply a nice patch by dirleyrls
2012-08-18 15:39:11 +00:00
/**
* This is a proxy-style for that forces it to be always disabled.
* We use this to make our torrent list view behave consistently on
* both GTK and Qt implementations.
*/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
class ListViewProxyStyle : public QProxyStyle
(trunk, qt) #4624 "Inconsistent behavior when clicking on items at the torrent list" -- apply a nice patch by dirleyrls
2012-08-18 15:39:11 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
public:
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
int styleHint(StyleHint hint, QStyleOption const* option = nullptr, QWidget const* widget = nullptr,
QStyleHintReturn* returnData = nullptr) const
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (hint == QStyle::SH_ItemView_ActivateItemOnSingleClick)
{
return 0;
}
return QProxyStyle::styleHint(hint, option, widget, returnData);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
}
(trunk, qt) #4624 "Inconsistent behavior when clicking on items at the torrent list" -- apply a nice patch by dirleyrls
2012-08-18 15:39:11 +00:00
};
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QIcon MainWindow::getStockIcon(QString const& name, int fallback)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QIcon icon = QIcon::fromTheme(name);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (icon.isNull() && fallback >= 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
icon = style()->standardIcon(QStyle::StandardPixmap(fallback), 0, this);
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return icon;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QIcon MainWindow::getStockIcon(QString const& name, int fallback, QStringList const& emblemNames)
Set icon for "Open URL" action (Qt client)
2017-02-18 18:22:34 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QIcon baseIcon = getStockIcon(name, fallback);
Set icon for "Open URL" action (Qt client)
2017-02-18 18:22:34 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (baseIcon.isNull())
Set icon for "Open URL" action (Qt client)
2017-02-18 18:22:34 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return baseIcon;
Set icon for "Open URL" action (Qt client)
2017-02-18 18:22:34 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QIcon emblemIcon;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QString const& emblemName : emblemNames)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
emblemIcon = QIcon::fromTheme(emblemName);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!emblemIcon.isNull())
{
break;
}
}
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (emblemIcon.isNull())
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return baseIcon;
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QIcon icon;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QSize const& size : baseIcon.availableSizes())
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QSize const emblemSize = size / 2;
QRect const emblemRect = QStyle::alignedRect(layoutDirection(), Qt::AlignBottom | Qt::AlignRight, emblemSize,
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QRect(QPoint(0, 0), size));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QPixmap pixmap = baseIcon.pixmap(size);
QPixmap emblemPixmap = emblemIcon.pixmap(emblemSize);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
QPainter painter(&pixmap);
painter.drawPixmap(emblemRect, emblemPixmap, emblemPixmap.rect());
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
icon.addPixmap(pixmap);
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return icon;
}
MainWindow::MainWindow(Session& session, Prefs& prefs, TorrentModel& model, bool minimized) :
mySession(session),
myPrefs(prefs),
myModel(model),
myLastFullUpdateTime(0),
mySessionDialog(),
myPrefsDialog(),
myAboutDialog(),
myStatsDialog(),
myDetailsDialog(),
myFilterModel(prefs),
myTorrentDelegate(new TorrentDelegate(this)),
myTorrentDelegateMin(new TorrentDelegateMin(this)),
myLastSendTime(0),
myLastReadTime(0),
myNetworkTimer(this),
myNetworkError(false),
myRefreshTrayIconTimer(this),
myRefreshActionSensitivityTimer(this)
{
setAcceptDrops(true);
QAction* sep = new QAction(this);
sep->setSeparator(true);
ui.setupUi(this);
ui.listView->setStyle(new ListViewProxyStyle);
ui.listView->setAttribute(Qt::WA_MacShowFocusRect, false);
// icons
ui.action_OpenFile->setIcon(getStockIcon(QLatin1String("document-open"), QStyle::SP_DialogOpenButton));
ui.action_AddURL->setIcon(getStockIcon(QLatin1String("document-open"), QStyle::SP_DialogOpenButton,
QStringList() << QLatin1String("emblem-web") << QLatin1String("applications-internet")));
ui.action_New->setIcon(getStockIcon(QLatin1String("document-new"), QStyle::SP_DesktopIcon));
ui.action_Properties->setIcon(getStockIcon(QLatin1String("document-properties"), QStyle::SP_DesktopIcon));
ui.action_OpenFolder->setIcon(getStockIcon(QLatin1String("folder-open"), QStyle::SP_DirOpenIcon));
ui.action_Start->setIcon(getStockIcon(QLatin1String("media-playback-start"), QStyle::SP_MediaPlay));
ui.action_StartNow->setIcon(getStockIcon(QLatin1String("media-playback-start"), QStyle::SP_MediaPlay));
ui.action_Announce->setIcon(getStockIcon(QLatin1String("network-transmit-receive")));
ui.action_Pause->setIcon(getStockIcon(QLatin1String("media-playback-pause"), QStyle::SP_MediaPause));
ui.action_Remove->setIcon(getStockIcon(QLatin1String("list-remove"), QStyle::SP_TrashIcon));
ui.action_Delete->setIcon(getStockIcon(QLatin1String("edit-delete"), QStyle::SP_TrashIcon));
ui.action_StartAll->setIcon(getStockIcon(QLatin1String("media-playback-start"), QStyle::SP_MediaPlay));
ui.action_PauseAll->setIcon(getStockIcon(QLatin1String("media-playback-pause"), QStyle::SP_MediaPause));
ui.action_Quit->setIcon(getStockIcon(QLatin1String("application-exit")));
ui.action_SelectAll->setIcon(getStockIcon(QLatin1String("edit-select-all")));
ui.action_ReverseSortOrder->setIcon(getStockIcon(QLatin1String("view-sort-ascending"), QStyle::SP_ArrowDown));
ui.action_Preferences->setIcon(getStockIcon(QLatin1String("preferences-system")));
ui.action_Contents->setIcon(getStockIcon(QLatin1String("help-contents"), QStyle::SP_DialogHelpButton));
ui.action_About->setIcon(getStockIcon(QLatin1String("help-about")));
ui.action_QueueMoveTop->setIcon(getStockIcon(QLatin1String("go-top")));
ui.action_QueueMoveUp->setIcon(getStockIcon(QLatin1String("go-up"), QStyle::SP_ArrowUp));
ui.action_QueueMoveDown->setIcon(getStockIcon(QLatin1String("go-down"), QStyle::SP_ArrowDown));
ui.action_QueueMoveBottom->setIcon(getStockIcon(QLatin1String("go-bottom")));
// ui signals
connect(ui.action_Toolbar, SIGNAL(toggled(bool)), this, SLOT(setToolbarVisible(bool)));
connect(ui.action_Filterbar, SIGNAL(toggled(bool)), this, SLOT(setFilterbarVisible(bool)));
connect(ui.action_Statusbar, SIGNAL(toggled(bool)), this, SLOT(setStatusbarVisible(bool)));
connect(ui.action_CompactView, SIGNAL(toggled(bool)), this, SLOT(setCompactView(bool)));
connect(ui.action_ReverseSortOrder, SIGNAL(toggled(bool)), this, SLOT(setSortAscendingPref(bool)));
connect(ui.action_Start, SIGNAL(triggered()), this, SLOT(startSelected()));
connect(ui.action_QueueMoveTop, SIGNAL(triggered()), this, SLOT(queueMoveTop()));
connect(ui.action_QueueMoveUp, SIGNAL(triggered()), this, SLOT(queueMoveUp()));
connect(ui.action_QueueMoveDown, SIGNAL(triggered()), this, SLOT(queueMoveDown()));
connect(ui.action_QueueMoveBottom, SIGNAL(triggered()), this, SLOT(queueMoveBottom()));
connect(ui.action_StartNow, SIGNAL(triggered()), this, SLOT(startSelectedNow()));
connect(ui.action_Pause, SIGNAL(triggered()), this, SLOT(pauseSelected()));
connect(ui.action_Remove, SIGNAL(triggered()), this, SLOT(removeSelected()));
connect(ui.action_Delete, SIGNAL(triggered()), this, SLOT(deleteSelected()));
connect(ui.action_Verify, SIGNAL(triggered()), this, SLOT(verifySelected()));
connect(ui.action_Announce, SIGNAL(triggered()), this, SLOT(reannounceSelected()));
connect(ui.action_StartAll, SIGNAL(triggered()), this, SLOT(startAll()));
connect(ui.action_PauseAll, SIGNAL(triggered()), this, SLOT(pauseAll()));
connect(ui.action_OpenFile, SIGNAL(triggered()), this, SLOT(openTorrent()));
connect(ui.action_AddURL, SIGNAL(triggered()), this, SLOT(openURL()));
connect(ui.action_New, SIGNAL(triggered()), this, SLOT(newTorrent()));
connect(ui.action_Preferences, SIGNAL(triggered()), this, SLOT(openPreferences()));
connect(ui.action_Statistics, SIGNAL(triggered()), this, SLOT(openStats()));
connect(ui.action_Donate, SIGNAL(triggered()), this, SLOT(openDonate()));
connect(ui.action_About, SIGNAL(triggered()), this, SLOT(openAbout()));
connect(ui.action_Contents, SIGNAL(triggered()), this, SLOT(openHelp()));
connect(ui.action_OpenFolder, SIGNAL(triggered()), this, SLOT(openFolder()));
connect(ui.action_CopyMagnetToClipboard, SIGNAL(triggered()), this, SLOT(copyMagnetLinkToClipboard()));
connect(ui.action_SetLocation, SIGNAL(triggered()), this, SLOT(setLocation()));
connect(ui.action_Properties, SIGNAL(triggered()), this, SLOT(openProperties()));
connect(ui.action_SessionDialog, SIGNAL(triggered()), this, SLOT(openSession()));
connect(ui.listView, SIGNAL(activated(QModelIndex)), ui.action_Properties, SLOT(trigger()));
// signals
connect(ui.action_SelectAll, SIGNAL(triggered()), ui.listView, SLOT(selectAll()));
connect(ui.action_DeselectAll, SIGNAL(triggered()), ui.listView, SLOT(clearSelection()));
connect(&myFilterModel, SIGNAL(rowsInserted(QModelIndex, int, int)), this, SLOT(refreshActionSensitivitySoon()));
connect(&myFilterModel, SIGNAL(rowsRemoved(QModelIndex, int, int)), this, SLOT(refreshActionSensitivitySoon()));
connect(ui.action_Quit, SIGNAL(triggered()), qApp, SLOT(quit()));
// torrent view
myFilterModel.setSourceModel(&myModel);
connect(&myModel, SIGNAL(modelReset()), this, SLOT(onModelReset()));
connect(&myModel, SIGNAL(rowsRemoved(QModelIndex, int, int)), this, SLOT(onModelReset()));
connect(&myModel, SIGNAL(rowsInserted(QModelIndex, int, int)), this, SLOT(onModelReset()));
connect(&myModel, SIGNAL(dataChanged(QModelIndex, QModelIndex)), this, SLOT(refreshTrayIconSoon()));
ui.listView->setModel(&myFilterModel);
connect(ui.listView->selectionModel(), SIGNAL(selectionChanged(QItemSelection, QItemSelection)), this,
SLOT(refreshActionSensitivitySoon()));
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QPair<QAction*, int> const sortModes[] =
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
qMakePair(ui.action_SortByActivity, static_cast<int>(SortMode::SORT_BY_ACTIVITY)),
qMakePair(ui.action_SortByAge, static_cast<int>(SortMode::SORT_BY_AGE)),
qMakePair(ui.action_SortByETA, static_cast<int>(SortMode::SORT_BY_ETA)),
qMakePair(ui.action_SortByName, static_cast<int>(SortMode::SORT_BY_NAME)),
qMakePair(ui.action_SortByProgress, static_cast<int>(SortMode::SORT_BY_PROGRESS)),
qMakePair(ui.action_SortByQueue, static_cast<int>(SortMode::SORT_BY_QUEUE)),
qMakePair(ui.action_SortByRatio, static_cast<int>(SortMode::SORT_BY_RATIO)),
qMakePair(ui.action_SortBySize, static_cast<int>(SortMode::SORT_BY_SIZE)),
qMakePair(ui.action_SortByState, static_cast<int>(SortMode::SORT_BY_STATE))
};
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QActionGroup* actionGroup = new QActionGroup(this);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (auto const& mode : sortModes)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
mode.first->setProperty(SORT_MODE_KEY, mode.second);
actionGroup->addAction(mode.first);
}
Show notice on top of filtered torrents list This has a couple of benefits: 1) it is clearly visible to the user that the list is filtered (doesn't display all the torrents) even when filter bar is hidden, 2) doesn't lead to filter bar controls being shifted to the left/right as when "Show:" label text changes.
2015-10-19 20:30:26 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(actionGroup, SIGNAL(triggered(QAction*)), this, SLOT(onSortModeChanged(QAction*)));
myAltSpeedAction = new QAction(tr("Speed Limits"), this);
myAltSpeedAction->setIcon(ui.altSpeedButton->icon());
myAltSpeedAction->setCheckable(true);
connect(myAltSpeedAction, SIGNAL(triggered()), this, SLOT(toggleSpeedMode()));
QMenu* menu = new QMenu(this);
menu->addAction(ui.action_OpenFile);
menu->addAction(ui.action_AddURL);
menu->addSeparator();
menu->addAction(ui.action_ShowMainWindow);
menu->addAction(ui.action_ShowMessageLog);
menu->addAction(ui.action_About);
menu->addSeparator();
menu->addAction(ui.action_StartAll);
menu->addAction(ui.action_PauseAll);
menu->addAction(myAltSpeedAction);
menu->addSeparator();
menu->addAction(ui.action_Quit);
myTrayIcon.setContextMenu(menu);
myTrayIcon.setIcon(QIcon::fromTheme(QLatin1String("transmission-tray-icon"), qApp->windowIcon()));
connect(&myPrefs, SIGNAL(changed(int)), this, SLOT(refreshPref(int)));
connect(ui.action_ShowMainWindow, SIGNAL(triggered(bool)), this, SLOT(toggleWindows(bool)));
connect(&myTrayIcon, SIGNAL(activated(QSystemTrayIcon::ActivationReason)), this,
SLOT(trayActivated(QSystemTrayIcon::ActivationReason)));
toggleWindows(!minimized);
ui.action_TrayIcon->setChecked(minimized || prefs.getBool(Prefs::SHOW_TRAY_ICON));
initStatusBar();
ui.verticalLayout->insertWidget(0, myFilterBar = new FilterBar(myPrefs, myModel, myFilterModel));
connect(&myModel, SIGNAL(rowsInserted(QModelIndex, int, int)), SLOT(refreshTorrentViewHeader()));
connect(&myModel, SIGNAL(rowsRemoved(QModelIndex, int, int)), SLOT(refreshTorrentViewHeader()));
connect(&myFilterModel, SIGNAL(rowsInserted(QModelIndex, int, int)), SLOT(refreshTorrentViewHeader()));
connect(&myFilterModel, SIGNAL(rowsRemoved(QModelIndex, int, int)), SLOT(refreshTorrentViewHeader()));
connect(ui.listView, SIGNAL(headerDoubleClicked()), myFilterBar, SLOT(clear()));
QList<int> initKeys;
initKeys << Prefs::MAIN_WINDOW_X << Prefs::SHOW_TRAY_ICON << Prefs::SORT_REVERSED << Prefs::SORT_MODE << Prefs::FILTERBAR <<
Prefs::STATUSBAR << Prefs::STATUSBAR_STATS << Prefs::TOOLBAR << Prefs::ALT_SPEED_LIMIT_ENABLED <<
Prefs::COMPACT_VIEW << Prefs::DSPEED << Prefs::DSPEED_ENABLED << Prefs::USPEED << Prefs::USPEED_ENABLED <<
Prefs::RATIO << Prefs::RATIO_ENABLED;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (int const key : initKeys)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
refreshPref(key);
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(&mySession, SIGNAL(sourceChanged()), this, SLOT(onSessionSourceChanged()));
connect(&mySession, SIGNAL(statsUpdated()), this, SLOT(refreshStatusBar()));
connect(&mySession, SIGNAL(dataReadProgress()), this, SLOT(dataReadProgress()));
connect(&mySession, SIGNAL(dataSendProgress()), this, SLOT(dataSendProgress()));
connect(&mySession, SIGNAL(httpAuthenticationRequired()), this, SLOT(wrongAuthentication()));
connect(&mySession, SIGNAL(networkResponse(QNetworkReply::NetworkError, QString)), this,
SLOT(onNetworkResponse(QNetworkReply::NetworkError, QString)));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mySession.isServer())
(trunk qt) use the bubble-filter button patch
2009-05-06 13:39:48 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.networkLabel->hide();
(trunk qt) use the bubble-filter button patch
2009-05-06 13:39:48 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(&myNetworkTimer, SIGNAL(timeout()), this, SLOT(onNetworkTimer()));
myNetworkTimer.start(1000);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(&myRefreshTrayIconTimer, SIGNAL(timeout()), this, SLOT(refreshTrayIcon()));
connect(&myRefreshActionSensitivityTimer, SIGNAL(timeout()), this, SLOT(refreshActionSensitivity()));
(trunk qt) fix high CPU load on startup caused by frequent updates to the u/d speed tooltips
2011-07-13 17:22:01 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refreshActionSensitivitySoon();
refreshTrayIconSoon();
refreshStatusBar();
refreshTitle();
refreshTorrentViewHeader();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
MainWindow::~MainWindow()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
}
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onSessionSourceChanged()
(trunk qt) Remember between runs whether we were running a local or remote session. Add a gui dialog for switching sessions during runtime.
2009-05-03 17:37:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myModel.clear();
(trunk qt) fix remove-torrent filtering error reported by W4pp
2009-05-03 18:35:33 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onModelReset()
(trunk qt) fix remove-torrent filtering error reported by W4pp
2009-05-03 18:35:33 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refreshTitle();
refreshActionSensitivitySoon();
refreshStatusBar();
refreshTrayIconSoon();
(trunk qt) Remember between runs whether we were running a local or remote session. Add a gui dialog for switching sessions during runtime.
2009-05-03 17:37:39 +00:00
}
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onSetPrefs()
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QVariantList const p = sender()->property(PREF_VARIANTS_KEY).toList();
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
assert(p.size() % 2 == 0);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
for (int i = 0, n = p.size(); i < n; i += 2)
{
myPrefs.set(p[i].toInt(), p[i + 1]);
}
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onSetPrefs(bool isChecked)
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (isChecked)
{
onSetPrefs();
}
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::initStatusBar()
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.optionsButton->setMenu(createOptionsMenu());
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const minimumSpeedWidth = ui.downloadSpeedLabel->fontMetrics().width(Formatter::uploadSpeedToString(Speed::fromKBps(
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
999.99)));
ui.downloadSpeedLabel->setMinimumWidth(minimumSpeedWidth);
ui.uploadSpeedLabel->setMinimumWidth(minimumSpeedWidth);
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.statsModeButton->setMenu(createStatsModeMenu());
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(ui.altSpeedButton, SIGNAL(clicked()), this, SLOT(toggleSpeedMode()));
(trunk qt) hack on the main window layout
2009-04-15 01:59:54 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QMenu* MainWindow::createOptionsMenu()
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
auto const initSpeedSubMenu = [this](QMenu* menu, QAction*& offAction, QAction*& onAction, int pref, int enabledPref)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const stockSpeeds[] = { 5, 10, 20, 30, 40, 50, 75, 100, 150, 200, 250, 500, 750 };
int const currentValue = myPrefs.get<int>(pref);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QActionGroup* actionGroup = new QActionGroup(this);
offAction = menu->addAction(tr("Unlimited"));
offAction->setCheckable(true);
offAction->setProperty(PREF_VARIANTS_KEY, QVariantList() << enabledPref << false);
actionGroup->addAction(offAction);
connect(offAction, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs(bool)));
onAction = menu->addAction(tr("Limited at %1").arg(Formatter::speedToString(Speed::fromKBps(currentValue))));
onAction->setCheckable(true);
onAction->setProperty(PREF_VARIANTS_KEY, QVariantList() << pref << currentValue << enabledPref << true);
actionGroup->addAction(onAction);
connect(onAction, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs(bool)));
menu->addSeparator();
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (int const i : stockSpeeds)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
QAction* action = menu->addAction(Formatter::speedToString(Speed::fromKBps(i)));
action->setProperty(PREF_VARIANTS_KEY, QVariantList() << pref << i << enabledPref << true);
connect(action, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs()));
}
};
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
auto const initSeedRatioSubMenu = [this](QMenu* menu, QAction*& offAction, QAction*& onAction, int pref, int enabledPref)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
double const stockRatios[] = { 0.25, 0.50, 0.75, 1, 1.5, 2, 3 };
double const currentValue = myPrefs.get<double>(pref);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QActionGroup* actionGroup = new QActionGroup(this);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
offAction = menu->addAction(tr("Seed Forever"));
offAction->setCheckable(true);
offAction->setProperty(PREF_VARIANTS_KEY, QVariantList() << enabledPref << false);
actionGroup->addAction(offAction);
connect(offAction, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs(bool)));
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
onAction = menu->addAction(tr("Stop at Ratio (%1)").arg(Formatter::ratioToString(currentValue)));
onAction->setCheckable(true);
onAction->setProperty(PREF_VARIANTS_KEY, QVariantList() << pref << currentValue << enabledPref << true);
actionGroup->addAction(onAction);
connect(onAction, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs(bool)));
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
menu->addSeparator();
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (double const i : stockRatios)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
QAction* action = menu->addAction(Formatter::ratioToString(i));
action->setProperty(PREF_VARIANTS_KEY, QVariantList() << pref << i << enabledPref << true);
connect(action, SIGNAL(triggered(bool)), this, SLOT(onSetPrefs()));
}
};
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QMenu* menu = new QMenu(this);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
initSpeedSubMenu(menu->addMenu(tr("Limit Download Speed")), myDlimitOffAction, myDlimitOnAction, Prefs::DSPEED,
Prefs::DSPEED_ENABLED);
initSpeedSubMenu(menu->addMenu(tr("Limit Upload Speed")), myUlimitOffAction, myUlimitOnAction, Prefs::USPEED,
Prefs::USPEED_ENABLED);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
menu->addSeparator();
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
initSeedRatioSubMenu(menu->addMenu(tr("Stop Seeding at Ratio")), myRatioOffAction, myRatioOnAction, Prefs::RATIO,
Prefs::RATIO_ENABLED);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return menu;
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QMenu* MainWindow::createStatsModeMenu()
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QPair<QAction*, QLatin1String> const statsModes[] =
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
qMakePair(ui.action_TotalRatio, TotalRatioStatsModeName),
qMakePair(ui.action_TotalTransfer, TotalTransferStatsModeName),
qMakePair(ui.action_SessionRatio, SessionRatioStatsModeName),
qMakePair(ui.action_SessionTransfer, SessionTransferStatsModeName)
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
};
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QActionGroup* actionGroup = new QActionGroup(this);
QMenu* menu = new QMenu(this);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (auto const& mode : statsModes)
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mode.first->setProperty(STATS_MODE_KEY, QString(mode.second));
actionGroup->addAction(mode.first);
menu->addAction(mode.first);
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
}
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(actionGroup, SIGNAL(triggered(QAction*)), this, SLOT(onStatsModeChanged(QAction*)));
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return menu;
Move status bar creation to mainwin.ui Among other things, * fix turtle icons size (20x14 -> 16x16) * use QIcon states instead of changing the turtle icon ourselves each time (unchecked - off, checked - on) * make speed limit action in tray menu checkable * simplify status bar buttons drawing and use QToolButton instead of QPushButton
2014-12-18 01:30:50 +00:00
}
(trunk qt) #1522: add upload/download/ratio limits popup menu at the bottom of the main window
2009-04-14 22:05:11 +00:00
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onSortModeChanged(QAction* action)
(qt) better integration of sort & filter modes into the preferences mechanism
2009-04-11 18:25:12 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::SORT_MODE, SortMode(action->property(SORT_MODE_KEY).toInt()));
(qt) better integration of sort & filter modes into the preferences mechanism
2009-04-11 18:25:12 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setSortAscendingPref(bool b)
(qt) better integration of sort & filter modes into the preferences mechanism
2009-04-11 18:25:12 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::SORT_REVERSED, b);
(qt) better integration of sort & filter modes into the preferences mechanism
2009-04-11 18:25:12 +00:00
}
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::showEvent(QShowEvent* event)
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Q_UNUSED(event);
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.action_ShowMainWindow->setChecked(true);
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
}
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::hideEvent(QHideEvent* event)
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Q_UNUSED(event);
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!isVisible())
{
ui.action_ShowMainWindow->setChecked(false);
}
(qt) #5206 'tray icon cancels logout in KDE' -- fixed with patch from basinilya
2013-01-01 20:02:20 +00:00
}
/****
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openSession()
(trunk qt) #2050 "properties dialog changes seem to undo themselves" -- applied 2nd patch from Longinus00
2010-05-06 04:49:10 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Utils::openDialog(mySessionDialog, mySession, myPrefs, this);
(trunk qt) #2050 "properties dialog changes seem to undo themselves" -- applied 2nd patch from Longinus00
2010-05-06 04:49:10 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openPreferences()
(trunk qt) handle multiple torrent selection in the properties dialog
2009-04-18 23:18:28 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Utils::openDialog(myPrefsDialog, mySession, myPrefs, this);
(trunk qt) handle multiple torrent selection in the properties dialog
2009-04-18 23:18:28 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openProperties()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Utils::openDialog(myDetailsDialog, mySession, myPrefs, myModel, this);
myDetailsDialog->setIds(getSelectedTorrents());
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setLocation()
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
RelocateDialog* d = new RelocateDialog(mySession, myModel, getSelectedTorrents(), this);
d->setAttribute(Qt::WA_DeleteOnClose, true);
d->show();
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
}
Fix a number of other style inconsistencies met along the way
2017-04-30 16:30:03 +00:00
namespace
{
(trunk, qt) fix #4824 'Open Folder bug' with a patch from rb07
2012-04-07 00:16:14 +00:00
// Open Folder & select torrent's file or top folder
(trunk, qt) #5194 'Qt: open folder: on single-file torrents opens the file, not directory, except on Windows and Mac' -- fixed with patch from basinilya
2012-12-27 18:22:48 +00:00
#undef HAVE_OPEN_SELECT
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
#if defined(Q_OS_WIN)
#define HAVE_OPEN_SELECT
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void openSelect(QString const& path)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QString const explorer = QLatin1String("explorer");
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString param;
if (!QFileInfo(path).isDir())
{
param = QLatin1String("/select,");
}
param += QDir::toNativeSeparators(path);
QProcess::startDetached(explorer, QStringList(param));
}
#elif defined(Q_OS_MAC)
#define HAVE_OPEN_SELECT
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void openSelect(QString const& path)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
QStringList scriptArgs;
scriptArgs << QLatin1String("-e") <<
QString::fromLatin1("tell application \"Finder\" to reveal POSIX file \"%1\"").arg(path);
QProcess::execute(QLatin1String("/usr/bin/osascript"), scriptArgs);
scriptArgs.clear();
scriptArgs << QLatin1String("-e") << QLatin1String("tell application \"Finder\" to activate");
QProcess::execute(QLatin1String("/usr/bin/osascript"), scriptArgs);
(trunk, qt) fix #4824 'Open Folder bug' with a patch from rb07
2012-04-07 00:16:14 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
(trunk, qt) #5194 'Qt: open folder: on single-file torrents opens the file, not directory, except on Windows and Mac' -- fixed with patch from basinilya
2012-12-27 18:22:48 +00:00
#endif
(trunk, qt) fix #4824 'Open Folder bug' with a patch from rb07
2012-04-07 00:16:14 +00:00
Fix a number of other style inconsistencies met along the way
2017-04-30 16:30:03 +00:00
} // namespace
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openFolder()
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QSet<int> const selectedTorrents = getSelectedTorrents();
#5993: Improve magnets handling in main window Disable "Open Folder" and "Verify Local Data" actions for magnets in Torrent menu. If more than one torrent is selected, "Verify Local Data" is enabled but only non-magnets are verified if activated. Add a few sanity checks when opening folder, just in case.
2015-10-04 06:16:59 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (selectedTorrents.size() != 1)
{
return;
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const torrentId(*selectedTorrents.begin());
Torrent const* tor(myModel.getTorrentFromId(torrentId));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tor == nullptr)
{
return;
}
#5993: Improve magnets handling in main window Disable "Open Folder" and "Verify Local Data" actions for magnets in Torrent menu. If more than one torrent is selected, "Verify Local Data" is enabled but only non-magnets are verified if activated. Add a few sanity checks when opening folder, just in case.
2015-10-04 06:16:59 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString path(tor->getPath());
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
FileList const& files = tor->files();
#5993: Improve magnets handling in main window Disable "Open Folder" and "Verify Local Data" actions for magnets in Torrent menu. If more than one torrent is selected, "Verify Local Data" is enabled but only non-magnets are verified if activated. Add a few sanity checks when opening folder, just in case.
2015-10-04 06:16:59 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (files.isEmpty())
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return;
(trunk, qt) fix #4824 'Open Folder bug' with a patch from rb07
2012-04-07 00:16:14 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QString const firstfile = files.at(0).filename;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int slashIndex = firstfile.indexOf(QLatin1Char('/'));
if (slashIndex > -1)
{
path = path + QLatin1Char('/') + firstfile.left(slashIndex);
}
(trunk, qt) #5194 'Qt: open folder: on single-file torrents opens the file, not directory, except on Windows and Mac' -- fixed with patch from basinilya
2012-12-27 18:22:48 +00:00
#ifdef HAVE_OPEN_SELECT
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
openSelect(path + QLatin1Char('/') + firstfile);
return;
(trunk, qt) #5194 'Qt: open folder: on single-file torrents opens the file, not directory, except on Windows and Mac' -- fixed with patch from basinilya
2012-12-27 18:22:48 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
(trunk, qt) #5194 'Qt: open folder: on single-file torrents opens the file, not directory, except on Windows and Mac' -- fixed with patch from basinilya
2012-12-27 18:22:48 +00:00
#endif
#5993: Improve magnets handling in main window Disable "Open Folder" and "Verify Local Data" actions for magnets in Torrent menu. If more than one torrent is selected, "Verify Local Data" is enabled but only non-magnets are verified if activated. Add a few sanity checks when opening folder, just in case.
2015-10-04 06:16:59 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QDesktopServices::openUrl(QUrl::fromLocalFile(path));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::copyMagnetLinkToClipboard()
(trunk, qt) #2096 "magnet links" -- Add the "Copy Magnet Link to Clipboard" feature to Qt client
2009-12-03 15:23:43 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const id(*getSelectedTorrents().begin());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.copyMagnetLinkToClipboard(id);
(trunk, qt) #2096 "magnet links" -- Add the "Copy Magnet Link to Clipboard" feature to Qt client
2009-12-03 15:23:43 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openStats()
Create dialogs on demand, don't keep them ready all the time
2015-07-30 06:18:02 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Utils::openDialog(myStatsDialog, mySession, this);
Create dialogs on demand, don't keep them ready all the time
2015-07-30 06:18:02 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openDonate()
(trunk) consistency tweaks between the GTK+ and Qt client: 1. synchronize some of the keyboard shortcuts 2. synchronize some text in the preferences dialog 3. add a "Desktop" tab in the Qt client's preferences dialog 4. add a "Donate" button to the Qt client's help menu
2010-08-02 03:07:42 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QDesktopServices::openUrl(QUrl(QLatin1String("https://transmissionbt.com/donate/")));
(trunk) consistency tweaks between the GTK+ and Qt client: 1. synchronize some of the keyboard shortcuts 2. synchronize some text in the preferences dialog 3. add a "Desktop" tab in the Qt client's preferences dialog 4. add a "Donate" button to the Qt client's help menu
2010-08-02 03:07:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openAbout()
Create dialogs on demand, don't keep them ready all the time
2015-07-30 06:18:02 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Utils::openDialog(myAboutDialog, this);
Create dialogs on demand, don't keep them ready all the time
2015-07-30 06:18:02 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openHelp()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QDesktopServices::openUrl(QUrl(QString::fromLatin1("https://transmissionbt.com/help/gtk/%1.%2x").arg(MAJOR_VERSION).
arg(MINOR_VERSION / 10)));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshTitle()
(trunk qt) Remember between runs whether we were running a local or remote session. Add a gui dialog for switching sessions during runtime.
2009-05-03 17:37:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString title(QLatin1String("Transmission"));
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QUrl const url(mySession.getRemoteUrl());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!url.isEmpty())
{
//: Second (optional) part of main window title "Transmission - host:port" (added when connected to remote session);
//: notice that leading space (before the dash) is included here
title += tr(" - %1:%2").arg(url.host()).arg(url.port());
}
setWindowTitle(title);
(trunk qt) Remember between runs whether we were running a local or remote session. Add a gui dialog for switching sessions during runtime.
2009-05-03 17:37:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshTrayIconSoon()
(trunk qt) fix high CPU load on startup caused by frequent updates to the u/d speed tooltips
2011-07-13 17:22:01 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!myRefreshTrayIconTimer.isActive())
(trunk qt) fix high CPU load on startup caused by frequent updates to the u/d speed tooltips
2011-07-13 17:22:01 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myRefreshTrayIconTimer.setSingleShot(true);
myRefreshTrayIconTimer.start(100);
(trunk qt) fix high CPU load on startup caused by frequent updates to the u/d speed tooltips
2011-07-13 17:22:01 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshTrayIcon()
(trunk qt) #3489 "Qt client should have up/down speeds in the tray icon's tooltip" -- fixed
2010-08-05 15:01:40 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Speed upSpeed, downSpeed;
size_t upCount, downCount;
QString tip;
(trunk qt) #3489 "Qt client should have up/down speeds in the tray icon's tooltip" -- fixed
2010-08-05 15:01:40 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myModel.getTransferSpeed(upSpeed, upCount, downSpeed, downCount);
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (myNetworkError)
(trunk qt) #5514 'enhanced network status' -- reset the torrent model when we reconnect to the transmission session after a network failure
2014-04-27 00:33:19 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tip = tr("Network Error");
(trunk qt) #5514 'enhanced network status' -- reset the torrent model when we reconnect to the transmission session after a network failure
2014-04-27 00:33:19 +00:00
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (upCount == 0 && downCount == 0)
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tip = tr("Idle");
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (downCount != 0)
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tip = Formatter::downloadSpeedToString(downSpeed) + QLatin1String(" ") + Formatter::uploadSpeedToString(upSpeed);
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (upCount != 0)
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tip = Formatter::uploadSpeedToString(upSpeed);
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myTrayIcon.setToolTip(tip);
(trunk qt) #3489 "Qt client should have up/down speeds in the tray icon's tooltip" -- fixed
2010-08-05 15:01:40 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshStatusBar()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Speed upSpeed, downSpeed;
size_t upCount, downCount;
myModel.getTransferSpeed(upSpeed, upCount, downSpeed, downCount);
(qt) experiment with making the statusbar's speed/ratio, the desktop icon's tooltip, and the delegate's shortTransferString() all behave the same wrt when to show which transfer speeds
2013-02-07 21:07:16 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.uploadSpeedLabel->setText(Formatter::uploadSpeedToString(upSpeed));
ui.uploadSpeedLabel->setVisible(downCount || upCount);
ui.downloadSpeedLabel->setText(Formatter::downloadSpeedToString(downSpeed));
ui.downloadSpeedLabel->setVisible(downCount);
(trunk qt) HiG: "When there is no interesting status to report, leave a status bar panel blank"
2009-05-02 14:25:18 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.networkLabel->setVisible(!mySession.isServer());
(trunk qt) hide the network icon when the transmission session is being run inside the client. patch by stdisease
2009-05-06 13:46:10 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QString const mode(myPrefs.getString(Prefs::STATUSBAR_STATS));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString str;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mode == SessionRatioStatsModeName)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = tr("Ratio: %1").arg(Formatter::ratioToString(mySession.getStats().ratio));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (mode == SessionTransferStatsModeName)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_session_stats const& stats(mySession.getStats());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = tr("Down: %1, Up: %2").arg(Formatter::sizeToString(stats.downloadedBytes)).
arg(Formatter::sizeToString(stats.uploadedBytes));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (mode == TotalTransferStatsModeName)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_session_stats const& stats(mySession.getCumulativeStats());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = tr("Down: %1, Up: %2").arg(Formatter::sizeToString(stats.downloadedBytes)).
arg(Formatter::sizeToString(stats.uploadedBytes));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else // default is "total-ratio"
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
assert(mode == TotalRatioStatsModeName);
str = tr("Ratio: %1").arg(Formatter::ratioToString(mySession.getCumulativeStats().ratio));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.statsLabel->setText(str);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshTorrentViewHeader()
Show notice on top of filtered torrents list This has a couple of benefits: 1) it is clearly visible to the user that the list is filtered (doesn't display all the torrents) even when filter bar is hidden, 2) doesn't lead to filter bar controls being shifted to the left/right as when "Show:" label text changes.
2015-10-19 20:30:26 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const totalCount = myModel.rowCount();
int const visibleCount = myFilterModel.rowCount();
(trunk qt) #4369 "Typing text into the main window's filter field causes high CPU" -- fixed.
2011-07-19 21:19:18 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (visibleCount == totalCount)
{
ui.listView->setHeaderText(QString());
}
else
{
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
ui.listView->setHeaderText(tr("Showing %L1 of %Ln torrent(s)", nullptr, totalCount).arg(visibleCount));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
Show notice on top of filtered torrents list This has a couple of benefits: 1) it is clearly visible to the user that the list is filtered (doesn't display all the torrents) even when filter bar is hidden, 2) doesn't lead to filter bar controls being shifted to the left/right as when "Show:" label text changes.
2015-10-19 20:30:26 +00:00
}
(trunk qt) #4369 "Typing text into the main window's filter field causes high CPU" -- fixed.
2011-07-19 21:19:18 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshActionSensitivitySoon()
(trunk qt) #4369 "Typing text into the main window's filter field causes high CPU" -- fixed.
2011-07-19 21:19:18 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!myRefreshActionSensitivityTimer.isActive())
(trunk qt) #4369 "Typing text into the main window's filter field causes high CPU" -- fixed.
2011-07-19 21:19:18 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myRefreshActionSensitivityTimer.setSingleShot(true);
myRefreshActionSensitivityTimer.start(100);
(trunk qt) #4369 "Typing text into the main window's filter field causes high CPU" -- fixed.
2011-07-19 21:19:18 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshActionSensitivity()
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int selected(0);
int paused(0);
int queued(0);
int selectedAndPaused(0);
int selectedAndQueued(0);
int selectedWithMetadata(0);
int canAnnounce(0);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QAbstractItemModel const* model(ui.listView->model());
QItemSelectionModel const* selectionModel(ui.listView->selectionModel());
int const rowCount(model->rowCount());
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
// count how many torrents are selected, paused, etc
for (int row = 0; row < rowCount; ++row)
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QModelIndex const modelIndex(model->index(row, 0));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
assert(model == modelIndex.model());
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
Torrent const* tor(model->data(modelIndex, TorrentModel::TorrentRole).value<Torrent const*>());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (tor != nullptr)
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const isSelected(selectionModel->isSelected(modelIndex));
bool const isPaused(tor->isPaused());
bool const isQueued(tor->isQueued());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (isSelected)
{
++selected;
}
if (isQueued)
{
++queued;
}
if (isPaused)
{
++paused;
}
if (isSelected && isPaused)
{
++selectedAndPaused;
}
if (isSelected && isQueued)
{
++selectedAndQueued;
}
if (isSelected && tor->hasMetadata())
{
++selectedWithMetadata;
}
if (tor->canManualAnnounce())
{
++canAnnounce;
}
(trunk Qt) #2298: qtr client crashes when expired torrent is removed
2009-10-10 00:39:38 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const haveSelection(selected > 0);
bool const haveSelectionWithMetadata = selectedWithMetadata > 0;
bool const oneSelection(selected == 1);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.action_Verify->setEnabled(haveSelectionWithMetadata);
ui.action_Remove->setEnabled(haveSelection);
ui.action_Delete->setEnabled(haveSelection);
ui.action_Properties->setEnabled(haveSelection);
ui.action_DeselectAll->setEnabled(haveSelection);
ui.action_SetLocation->setEnabled(haveSelection);
ui.action_OpenFolder->setEnabled(oneSelection && haveSelectionWithMetadata && mySession.isLocal());
ui.action_CopyMagnetToClipboard->setEnabled(oneSelection);
ui.action_SelectAll->setEnabled(selected < rowCount);
ui.action_StartAll->setEnabled(paused > 0);
ui.action_PauseAll->setEnabled(paused < rowCount);
ui.action_Start->setEnabled(selectedAndPaused > 0);
ui.action_StartNow->setEnabled(selectedAndPaused + selectedAndQueued > 0);
ui.action_Pause->setEnabled(selectedAndPaused < selected);
ui.action_Announce->setEnabled(selected > 0 && (canAnnounce == selected));
ui.action_QueueMoveTop->setEnabled(haveSelection);
ui.action_QueueMoveUp->setEnabled(haveSelection);
ui.action_QueueMoveDown->setEnabled(haveSelection);
ui.action_QueueMoveBottom->setEnabled(haveSelection);
if (!myDetailsDialog.isNull())
{
myDetailsDialog->setIds(getSelectedTorrents());
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
/**
***
**/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::clearSelection()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.action_DeselectAll->trigger();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QSet<int> MainWindow::getSelectedTorrents(bool withMetadataOnly) const
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QSet<int> ids;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QModelIndex const& index : ui.listView->selectionModel()->selectedRows())
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
Torrent const* tor(index.data(TorrentModel::TorrentRole).value<Torrent const*>());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tor != nullptr && (!withMetadataOnly || tor->hasMetadata()))
{
ids.insert(tor->id());
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return ids;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::startSelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.startTorrents(getSelectedTorrents());
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::startSelectedNow()
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.startTorrentsNow(getSelectedTorrents());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::pauseSelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.pauseTorrents(getSelectedTorrents());
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::queueMoveTop()
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.queueMoveTop(getSelectedTorrents());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::queueMoveUp()
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.queueMoveUp(getSelectedTorrents());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::queueMoveDown()
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.queueMoveDown(getSelectedTorrents());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::queueMoveBottom()
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.queueMoveBottom(getSelectedTorrents());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::startAll()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.startTorrents();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::pauseAll()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.pauseTorrents();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::removeSelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
removeTorrents(false);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::deleteSelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
removeTorrents(true);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::verifySelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.verifyTorrents(getSelectedTorrents(true));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::reannounceSelected()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.reannounceTorrents(getSelectedTorrents());
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
/**
***
**/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onStatsModeChanged(QAction* action)
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::STATUSBAR_STATS, action->property(STATS_MODE_KEY).toString());
Refactor action groups initialization/handling and trackers merging a bit
2015-08-06 20:28:44 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
/**
***
**/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setCompactView(bool visible)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::COMPACT_VIEW, visible);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::toggleSpeedMode()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.toggleBool(Prefs::ALT_SPEED_LIMIT_ENABLED);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const mode = myPrefs.get<bool>(Prefs::ALT_SPEED_LIMIT_ENABLED);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myAltSpeedAction->setChecked(mode);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setToolbarVisible(bool visible)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::TOOLBAR, visible);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setFilterbarVisible(bool visible)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::FILTERBAR, visible);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::setStatusbarVisible(bool visible)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myPrefs.set(Prefs::STATUSBAR, visible);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
/**
***
**/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::toggleWindows(bool doShow)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!doShow)
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hide();
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!isVisible())
{
show();
}
if (isMinimized())
{
showNormal();
}
// activateWindow ();
raise();
qApp->setActiveWindow(this);
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::trayActivated(QSystemTrayIcon::ActivationReason reason)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (reason == QSystemTrayIcon::Trigger || reason == QSystemTrayIcon::DoubleClick)
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (isMinimized())
{
toggleWindows(true);
}
else
{
toggleWindows(!isVisible());
}
(trunk qt) #2321: in qt client in 1.73, When main window minimized click on tray icon does nothing
2009-08-11 18:57:49 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::refreshPref(int key)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
bool b;
int i;
QString str;
QActionGroup* actionGroup;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
switch (key)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::STATUSBAR_STATS:
str = myPrefs.getString(key);
actionGroup = ui.action_TotalRatio->actionGroup();
assert(actionGroup != nullptr);
for (QAction* action : actionGroup->actions())
{
action->setChecked(str == action->property(STATS_MODE_KEY).toString());
}
refreshStatusBar();
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::SORT_REVERSED:
ui.action_ReverseSortOrder->setChecked(myPrefs.getBool(key));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::SORT_MODE:
i = myPrefs.get<SortMode>(key).mode();
actionGroup = ui.action_SortByActivity->actionGroup();
assert(actionGroup != nullptr);
for (QAction* action : actionGroup->actions())
{
action->setChecked(i == action->property(SORT_MODE_KEY).toInt());
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::DSPEED_ENABLED:
(myPrefs.get<bool>(key) ? myDlimitOnAction : myDlimitOffAction)->setChecked(true);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::DSPEED:
myDlimitOnAction->setText(tr("Limited at %1").arg(Formatter::speedToString(Speed::fromKBps(myPrefs.get<int>(key)))));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::USPEED_ENABLED:
(myPrefs.get<bool>(key) ? myUlimitOnAction : myUlimitOffAction)->setChecked(true);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::USPEED:
myUlimitOnAction->setText(tr("Limited at %1").arg(Formatter::speedToString(Speed::fromKBps(myPrefs.get<int>(key)))));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::RATIO_ENABLED:
(myPrefs.get<bool>(key) ? myRatioOnAction : myRatioOffAction)->setChecked(true);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::RATIO:
myRatioOnAction->setText(tr("Stop at Ratio (%1)").arg(Formatter::ratioToString(myPrefs.get<double>(key))));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::FILTERBAR:
b = myPrefs.getBool(key);
myFilterBar->setVisible(b);
ui.action_Filterbar->setChecked(b);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::STATUSBAR:
b = myPrefs.getBool(key);
ui.statusBar->setVisible(b);
ui.action_Statusbar->setChecked(b);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::TOOLBAR:
b = myPrefs.getBool(key);
ui.toolBar->setVisible(b);
ui.action_Toolbar->setChecked(b);
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::SHOW_TRAY_ICON:
b = myPrefs.getBool(key);
ui.action_TrayIcon->setChecked(b);
myTrayIcon.setVisible(b);
qApp->setQuitOnLastWindowClosed(!b);
refreshTrayIconSoon();
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::COMPACT_VIEW:
{
Ifdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG-33537)
2015-04-20 09:28:26 +00:00
#if QT_VERSION < QT_VERSION_CHECK(5, 4, 0) // QTBUG-33537
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QItemSelectionModel* selectionModel(ui.listView->selectionModel());
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QItemSelection const selection(selectionModel->selection());
QModelIndex const currentIndex(selectionModel->currentIndex());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Ifdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG-33537)
2015-04-20 09:28:26 +00:00
#endif
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
b = myPrefs.getBool(key);
ui.action_CompactView->setChecked(b);
ui.listView->setItemDelegate(b ? myTorrentDelegateMin : myTorrentDelegate);
Ifdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG-33537)
2015-04-20 09:28:26 +00:00
#if QT_VERSION < QT_VERSION_CHECK(5, 4, 0) // QTBUG-33537
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
selectionModel->clear();
ui.listView->reset(); // force the rows to resize
selectionModel->select(selection, QItemSelectionModel::Select);
selectionModel->setCurrentIndex(currentIndex, QItemSelectionModel::NoUpdate);
Ifdef the code which does manual relayout on compact view toggle to Qt < 5.4 (QTBUG-33537)
2015-04-20 09:28:26 +00:00
#endif
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
break;
(qt) Don't lose selection when changing to and from compact mode.
2010-09-18 15:51:38 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::MAIN_WINDOW_X:
case Prefs::MAIN_WINDOW_Y:
case Prefs::MAIN_WINDOW_WIDTH:
case Prefs::MAIN_WINDOW_HEIGHT:
setGeometry(myPrefs.getInt(Prefs::MAIN_WINDOW_X), myPrefs.getInt(Prefs::MAIN_WINDOW_Y),
myPrefs.getInt(Prefs::MAIN_WINDOW_WIDTH), myPrefs.getInt(Prefs::MAIN_WINDOW_HEIGHT));
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case Prefs::ALT_SPEED_LIMIT_ENABLED:
case Prefs::ALT_SPEED_LIMIT_UP:
case Prefs::ALT_SPEED_LIMIT_DOWN:
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
b = myPrefs.getBool(Prefs::ALT_SPEED_LIMIT_ENABLED);
myAltSpeedAction->setChecked(b);
ui.altSpeedButton->setChecked(b);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QString const fmt = b ? tr("Click to disable Temporary Speed Limits\n (%1 down, %2 up)") :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("Click to enable Temporary Speed Limits\n (%1 down, %2 up)");
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
Speed const d = Speed::fromKBps(myPrefs.getInt(Prefs::ALT_SPEED_LIMIT_DOWN));
Speed const u = Speed::fromKBps(myPrefs.getInt(Prefs::ALT_SPEED_LIMIT_UP));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.altSpeedButton->setToolTip(fmt.arg(Formatter::speedToString(d)).arg(Formatter::speedToString(u)));
break;
(trunk gtk,qt) more o/c simplification of the prefs dialog
2009-06-27 05:23:13 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
default:
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
break;
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
}
/***
****
***/
Define QT_NO_CAST_FROM_ASCII (Qt client) Use latin1 encoding most of the time where default encoding was used before. Qt 4 assumes latin1 by default while Qt 5 uses utf-8 which is not what we want. Use utf-8 encoding in some places where default encoding was used before. This includes strings coming from RPC. Fix an issue with SortMode::names[] (filters.cc) where missing comma between "sort-by-queue" and "sort-by-ratio" resulted in two array entries being merged into solid "sort-by-queuesort-by-ratio" string and all the following items being shifted compared to their enum counterparts.
2015-01-29 21:53:05 +00:00
namespace
{
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QLatin1String const SHOW_OPTIONS_CHECKBOX_NAME("show-options-checkbox");
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
} // namespace
void MainWindow::newTorrent()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
MakeDialog* dialog = new MakeDialog(mySession, this);
dialog->setAttribute(Qt::WA_DeleteOnClose);
dialog->show();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openTorrent()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QFileDialog* d;
d = new QFileDialog(this, tr("Open Torrent"), myPrefs.getString(Prefs::OPEN_DIALOG_FOLDER),
tr("Torrent Files (*.torrent);;All Files (*.*)"));
d->setFileMode(QFileDialog::ExistingFiles);
d->setAttribute(Qt::WA_DeleteOnClose);
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
auto const l = qobject_cast<QGridLayout*>(d->layout());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (l != nullptr)
fix crash when creating the Open Torrent dialog in Qt 5.2 on Ubuntu 14.04
2014-03-16 22:50:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QCheckBox* b = new QCheckBox(tr("Show &options dialog"));
b->setChecked(myPrefs.getBool(Prefs::OPTIONS_PROMPT));
b->setObjectName(SHOW_OPTIONS_CHECKBOX_NAME);
l->addWidget(b, l->rowCount(), 0, 1, -1, Qt::AlignLeft);
fix crash when creating the Open Torrent dialog in Qt 5.2 on Ubuntu 14.04
2014-03-16 22:50:39 +00:00
}
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(d, SIGNAL(filesSelected(QStringList)), this, SLOT(addTorrents(QStringList)));
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
d->open();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::openURL()
(trunk qt) #2840 "opening magnets with qt client opens new instances" -- fixed in trunk for 2.00
2010-04-27 03:10:32 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString str = qApp->clipboard()->text(QClipboard::Selection);
(trunk qt) #3930 - "Add URL" - auto-copy links from the clipboard When opening the "Add URL" dialog, check the clipboard selection & clipboard proper to see if either contains a URL, magnet link, or info hash code. If it has any of those things, put that in the dialog's entry field as the default action. Patch by cantabile.
2011-01-21 21:51:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!AddData::isSupported(str))
{
str = qApp->clipboard()->text(QClipboard::Clipboard);
}
(trunk qt) #3930 - "Add URL" - auto-copy links from the clipboard When opening the "Add URL" dialog, check the clipboard selection & clipboard proper to see if either contains a URL, magnet link, or info hash code. If it has any of those things, put that in the dialog's entry field as the default action. Patch by cantabile.
2011-01-21 21:51:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!AddData::isSupported(str))
{
str.clear();
}
(trunk qt) #3930 - "Add URL" - auto-copy links from the clipboard When opening the "Add URL" dialog, check the clipboard selection & clipboard proper to see if either contains a URL, magnet link, or info hash code. If it has any of those things, put that in the dialog's entry field as the default action. Patch by cantabile.
2011-01-21 21:51:50 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
addTorrent(str, true);
(trunk Qt) #2096 "magnet links" -- fix crashes when displaying magnet links in Qt client
2009-12-03 17:23:53 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
void MainWindow::addTorrents(QStringList const& filenames)
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
bool showOptions = myPrefs.getBool(Prefs::OPTIONS_PROMPT);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QFileDialog const* const fileDialog = qobject_cast<QFileDialog const*>(sender());
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
if (fileDialog != nullptr)
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QCheckBox const* const b = fileDialog->findChild<QCheckBox const*>(SHOW_OPTIONS_CHECKBOX_NAME);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
if (b != nullptr)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
showOptions = b->isChecked();
}
(trunk, qt) #5487 'Qt client crash when using Open URL action' -- fixed.
2013-09-14 22:50:25 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QString const& filename : filenames)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
addTorrent(filename, showOptions);
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
void MainWindow::addTorrent(AddData const& addMe, bool showOptions)
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (showOptions)
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
OptionsDialog* o = new OptionsDialog(mySession, myPrefs, addMe, this);
o->show();
qApp->alert(o);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(qt) merge together the two 'add url/magnet link' dialogs.
2013-02-09 23:11:17 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.addTorrent(addMe);
qApp->alert(this);
(qt) merge together the two 'add url/magnet link' dialogs.
2013-02-09 23:11:17 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
void MainWindow::removeTorrents(bool const deleteFiles)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QSet<int> ids;
QMessageBox msgBox(this);
QString primary_text, secondary_text;
int incomplete = 0;
int connected = 0;
int count;
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QModelIndex const& index : ui.listView->selectionModel()->selectedRows())
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
Torrent const* tor(index.data(TorrentModel::TorrentRole).value<Torrent const*>());
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ids.insert(tor->id());
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tor->connectedPeers())
{
++connected;
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!tor->isDone())
{
++incomplete;
}
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (ids.isEmpty())
{
return;
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
count = ids.size();
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!deleteFiles)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
primary_text = count == 1 ? tr("Remove torrent?") : tr("Remove %Ln torrent(s)?", nullptr, count);
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
primary_text = count == 1 ? tr("Delete this torrent's downloaded files?") :
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
tr("Delete these %Ln torrent(s)' downloaded files?", nullptr, count);
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!incomplete && !connected)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
secondary_text = count == 1 ?
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("Once removed, continuing the transfer will require the torrent file or magnet link.") :
tr("Once removed, continuing the transfers will require the torrent files or magnet links.");
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (count == incomplete)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
secondary_text = count == 1 ? tr("This torrent has not finished downloading.") :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("These torrents have not finished downloading.");
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (count == connected)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
secondary_text = count == 1 ? tr("This torrent is connected to peers.") :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("These torrents are connected to peers.");
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (connected != 0)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
secondary_text = connected == 1 ? tr("One of these torrents is connected to peers.") :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("Some of these torrents are connected to peers.");
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (connected != 0 && incomplete != 0)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
secondary_text += QLatin1Char('\n');
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (incomplete != 0)
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
secondary_text += incomplete == 1 ? tr("One of these torrents has not finished downloading.") :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr("Some of these torrents have not finished downloading.");
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
msgBox.setWindowTitle(QLatin1String(" "));
msgBox.setText(QString::fromLatin1("<big><b>%1</big></b>").arg(primary_text));
msgBox.setInformativeText(secondary_text);
msgBox.setStandardButtons(QMessageBox::Ok | QMessageBox::Cancel);
msgBox.setDefaultButton(QMessageBox::Cancel);
msgBox.setIcon(QMessageBox::Question);
// hack needed to keep the dialog from being too narrow
auto layout = qobject_cast<QGridLayout*>(msgBox.layout());
if (layout == nullptr)
fix crash when creating the Open Torrent dialog in Qt 5.2 on Ubuntu 14.04
2014-03-16 22:50:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
layout = new QGridLayout;
msgBox.setLayout(layout);
fix crash when creating the Open Torrent dialog in Qt 5.2 on Ubuntu 14.04
2014-03-16 22:50:39 +00:00
}
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QSpacerItem* spacer = new QSpacerItem(450, 0, QSizePolicy::Minimum, QSizePolicy::Expanding);
layout->addItem(spacer, layout->rowCount(), 0, 1, layout->columnCount());
if (msgBox.exec() == QMessageBox::Ok)
(qt) #3269: When changing session source we should request a full refresh right away
2010-06-16 03:01:09 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.listView->selectionModel()->clear();
mySession.removeTorrents(ids, deleteFiles);
(qt) #3269: When changing session source we should request a full refresh right away
2010-06-16 03:01:09 +00:00
}
(trunk qt) #2564 "Confirm on torrent remove" -- committed Longinus00's patch to trunk for 2.00
2010-04-23 03:58:42 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
/***
****
***/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::updateNetworkIcon()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Use nullptr consistencty instead of 0 and NULL (Qt client)
2017-04-30 09:29:58 +00:00
time_t const now = time(nullptr);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const period = 3;
time_t const secondsSinceLastSend = now - myLastSendTime;
time_t const secondsSinceLastRead = now - myLastReadTime;
bool const isSending = secondsSinceLastSend <= period;
bool const isReading = secondsSinceLastRead <= period;
char const* key;
(qt) tweak the network status icon's tooltip again. This is a followup to r13727
2013-01-03 04:21:45 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (myNetworkError)
{
key = "network-error";
}
else if (isSending && isReading)
{
key = "network-transmit-receive";
}
else if (isSending)
{
key = "network-transmit";
}
else if (isReading)
{
key = "network-receive";
}
else
{
key = "network-idle";
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QIcon const icon = getStockIcon(QLatin1String(key), QStyle::SP_DriveNetIcon);
QPixmap const pixmap = icon.pixmap(16, 16);
(qt) tweak the network status icon's tooltip again. This is a followup to r13727
2013-01-03 04:21:45 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString tip;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QString const url = mySession.getRemoteUrl().host();
(qt) tweak the network status icon's tooltip again. This is a followup to r13727
2013-01-03 04:21:45 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (myLastReadTime == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tip = tr("%1 has not responded yet").arg(url);
}
else if (myNetworkError)
{
tip = tr(myErrorMessage.toLatin1().constData());
}
else if (secondsSinceLastRead < 30)
{
tip = tr("%1 is responding").arg(url);
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (secondsSinceLastRead < 60 * 2)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tip = tr("%1 last responded %2 ago").arg(url).arg(Formatter::timeToString(secondsSinceLastRead));
}
else
{
tip = tr("%1 is not responding").arg(url);
}
ui.networkLabel->setPixmap(pixmap);
ui.networkLabel->setToolTip(tip);
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::onNetworkTimer()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
updateNetworkIcon();
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::dataReadProgress()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!myNetworkError)
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
myLastReadTime = time(nullptr);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::dataSendProgress()
(trunk) add the Qt beta into svn
2009-04-09 18:55:47 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
myLastSendTime = time(nullptr);
(trunk, qt) #5514 'enhanced network status in transmission-qt' -- patch by rb07
2013-10-20 19:57:48 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
void MainWindow::onNetworkResponse(QNetworkReply::NetworkError code, QString const& message)
(trunk, qt) #5514 'enhanced network status in transmission-qt' -- patch by rb07
2013-10-20 19:57:48 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const hadError = myNetworkError;
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
bool const haveError = code != QNetworkReply::NoError && code != QNetworkReply::UnknownContentError;
(trunk qt) #5514 'enhanced network status' -- reset the torrent model when we reconnect to the transmission session after a network failure
2014-04-27 00:33:19 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myNetworkError = haveError;
myErrorMessage = message;
refreshTrayIconSoon();
updateNetworkIcon();
(trunk qt) #5514 'enhanced network status' -- reset the torrent model when we reconnect to the transmission session after a network failure
2014-04-27 00:33:19 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
// Refresh our model if we've just gotten a clean connection to the session.
// That way we can rebuild after a restart of transmission-daemon
if (hadError && !haveError)
{
myModel.clear();
}
(trunk, qt) #5514 'enhanced network status in transmission-qt' -- patch by rb07
2013-10-20 19:57:48 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::wrongAuthentication()
(trunk qt) session dialog improvements from W4pp
2009-05-03 22:00:56 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.stop();
openSession();
(trunk qt) session dialog improvements from W4pp
2009-05-03 22:00:56 +00:00
}
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
/***
****
***/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::dragEnterEvent(QDragEnterEvent* event)
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QMimeData const* mime = event->mimeData();
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mime->hasFormat(QLatin1String("application/x-bittorrent")) || mime->hasUrls() ||
mime->text().trimmed().endsWith(QLatin1String(".torrent"), Qt::CaseInsensitive) ||
mime->text().startsWith(QLatin1String("magnet:"), Qt::CaseInsensitive))
{
event->acceptProposedAction();
}
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::dropEvent(QDropEvent* event)
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QStringList list;
(trunk, qt) #5374: add url support for dragging-and-dropping multiple URLs into transmission-qt. patch by rb07
2013-06-26 01:48:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (event->mimeData()->hasText())
(trunk, qt) #5374: add url support for dragging-and-dropping multiple URLs into transmission-qt. patch by rb07
2013-06-26 01:48:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
list = event->mimeData()->text().trimmed().split(QLatin1Char('\n'));
(trunk, qt) #5374: add url support for dragging-and-dropping multiple URLs into transmission-qt. patch by rb07
2013-06-26 01:48:47 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (event->mimeData()->hasUrls())
(trunk, qt) #5374: add url support for dragging-and-dropping multiple URLs into transmission-qt. patch by rb07
2013-06-26 01:48:47 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QUrl const& url : event->mimeData()->urls())
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
list.append(url.toLocalFile());
}
(trunk, qt) #5374: add url support for dragging-and-dropping multiple URLs into transmission-qt. patch by rb07
2013-06-26 01:48:47 +00:00
}
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (QString const& entry : list)
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString key = entry.trimmed();
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!key.isEmpty())
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
QUrl const url(key);
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (url.isLocalFile())
{
key = url.toLocalFile();
}
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
qApp->addTorrent(key);
(trunk, qt) #5374 handle multifile drag-and-drop in Qt client, patch by kernel_daemon
2013-06-09 20:18:47 +00:00
}
}
(trunk qt) #3465 "add drag-and-drop support for adding torrents/magnets" -- added.
2010-07-31 23:11:05 +00:00
}
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
/***
****
***/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void MainWindow::contextMenuEvent(QContextMenuEvent* event)
copyediting: modify more files to the new indentation/whitespace formatting
2013-01-27 18:09:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.menuTorrent->popup(event->globalPos());
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
}