mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

Only update info when necessary

This commit is contained in:
Mitchell Livingston 2006-10-21 15:36:20 +00:00
parent 7f370e9eaf
commit f5a6f4309e
1 changed files with 38 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
macosx/InfoWindowController.m
View File

@ -47,7 +47,9 @@
@interface InfoWindowController (Private) @interface InfoWindowController (Private)
- (void) reloadPeerTable; - (void) updateInfoActivity;
- (void) updateInfoPeers;
- (void) setWindowForTab: (NSString *) identifier animate: (BOOL) animate; - (void) setWindowForTab: (NSString *) identifier animate: (BOOL) animate;
- (NSArray *) peerSortDescriptors; - (NSArray *) peerSortDescriptors;
@ -242,6 +244,15 @@
} }
- (void) updateInfoStats - (void) updateInfoStats
{
if ([[[fTabView selectedTabViewItem] identifier] isEqualToString: TAB_ACTIVITY_IDENT])
[self updateInfoActivity];
else if ([[[fTabView selectedTabViewItem] identifier] isEqualToString: TAB_PEERS_IDENT])
[self updateInfoPeers];
else;
}
- (void) updateInfoActivity
{ {
int numberSelected = [fTorrents count]; int numberSelected = [fTorrents count];
if (numberSelected == 0) if (numberSelected == 0)
@ -272,31 +283,36 @@
[fStateField setStringValue: [torrent stateString]]; [fStateField setStringValue: [torrent stateString]];
int seeders = [torrent seeders], leechers = [torrent leechers];
[fSeedersField setStringValue: seeders < 0 ? @"" : [NSString stringWithInt: seeders]];
[fLeechersField setStringValue: leechers < 0 ? @"" : [NSString stringWithInt: leechers]];
BOOL active = [torrent isActive];
[fConnectedPeersField setStringValue: active ? [NSString stringWithFormat: @"%d (%d incoming)",
[torrent totalPeers], [torrent totalPeersIncoming]]: @""];
[fDownloadingFromField setStringValue: active ? [NSString stringWithInt: [torrent peersUploading]] : @""];
[fUploadingToField setStringValue: active ? [NSString stringWithInt: [torrent peersDownloading]] : @""];
[fRatioField setStringValue: [NSString stringForRatioWithDownload: downloadedTotal upload: uploadedTotal]]; [fRatioField setStringValue: [NSString stringForRatioWithDownload: downloadedTotal upload: uploadedTotal]];
[fSwarmSpeedField setStringValue: [torrent isActive] ? [NSString stringForSpeed: [torrent swarmSpeed]] : @""]; [fSwarmSpeedField setStringValue: [torrent isActive] ? [NSString stringForSpeed: [torrent swarmSpeed]] : @""];
//set peers table if visible [fPiecesView updateView: NO];
if ([[[fTabView selectedTabViewItem] identifier] isEqualToString: TAB_PEERS_IDENT])
[self reloadPeerTable];
//update pieces view if visible
if ([[[fTabView selectedTabViewItem] identifier] isEqualToString: TAB_ACTIVITY_IDENT])
[fPiecesView updateView: NO];
} }
} }
- (void) updateInfoPeers
{
if ([fTorrents count] != 1)
return;
Torrent * torrent = [fTorrents objectAtIndex: 0];
int seeders = [torrent seeders], leechers = [torrent leechers];
[fSeedersField setStringValue: seeders < 0 ? @"" : [NSString stringWithInt: seeders]];
[fLeechersField setStringValue: leechers < 0 ? @"" : [NSString stringWithInt: leechers]];
BOOL active = [torrent isActive];
[fConnectedPeersField setStringValue: active ? [NSString stringWithFormat: @"%d (%d incoming)",
[torrent totalPeers], [torrent totalPeersIncoming]]: @""];
[fDownloadingFromField setStringValue: active ? [NSString stringWithInt: [torrent peersUploading]] : @""];
[fUploadingToField setStringValue: active ? [NSString stringWithInt: [torrent peersDownloading]] : @""];
[fPeers setArray: [torrent peers]];
[fPeers sortUsingDescriptors: [self peerSortDescriptors]];
[fPeerTable reloadData];
}
- (void) updateInfoSettings - (void) updateInfoSettings
{ {
int numberSelected = [fTorrents count]; int numberSelected = [fTorrents count];
@ -356,17 +372,6 @@
[self updateInfoStats]; [self updateInfoStats];
} }
//requires a non-empty torrent array
- (void) reloadPeerTable
{
Torrent * torrent = [fTorrents objectAtIndex: 0];
[fPeers setArray: [torrent peers]];
[fPeers sortUsingDescriptors: [self peerSortDescriptors]];
[fPeerTable reloadData];
}
- (BOOL) validateMenuItem: (NSMenuItem *) menuItem - (BOOL) validateMenuItem: (NSMenuItem *) menuItem
{ {
SEL action = [menuItem action]; SEL action = [menuItem action];
@ -394,19 +399,17 @@
- (void) setWindowForTab: (NSString *) identifier animate: (BOOL) animate - (void) setWindowForTab: (NSString *) identifier animate: (BOOL) animate
{ {
[self updateInfoStats];
float height; float height;
if ([identifier isEqualToString: TAB_ACTIVITY_IDENT]) if ([identifier isEqualToString: TAB_ACTIVITY_IDENT])
{ {
height = TAB_ACTIVITY_HEIGHT; height = TAB_ACTIVITY_HEIGHT;
[fPiecesView updateView: YES]; [fPiecesView updateView: YES];
} }
else if ([identifier isEqualToString: TAB_PEERS_IDENT]) else if ([identifier isEqualToString: TAB_PEERS_IDENT])
{ {
height = TAB_PEERS_HEIGHT; height = TAB_PEERS_HEIGHT;
if ([fTorrents count] == 1)
[self reloadPeerTable]; //initial update of peer table
} }
else if ([identifier isEqualToString: TAB_FILES_IDENT]) else if ([identifier isEqualToString: TAB_FILES_IDENT])
height = TAB_FILES_HEIGHT; height = TAB_FILES_HEIGHT;