e191407dee
refactor: modernize-avoid-c-arrays pt. 1 ( #3702 )
2022-08-24 20:19:21 -05:00
e8686095ed
refactor: local peer discovery ( #3696 )
2022-08-24 16:03:30 -05:00
ab09718342
fixup! perf: sonarcloud warnings about temp objects ( #3686 ) ( #3699 )
2022-08-23 15:46:08 -05:00
258faf3623
gtk: Remember 4 recent relocate dirs ( #3691 )
...
* fix(gtk): prevent duplicate shortcut folders
This prevents duplicates if the recent destination is also a system
shortcut folder.
* refactor(gtk): create gtr_get_recent_dirs helper
* feat(gtk): remember 4 recent relocate dirs
2022-08-21 21:26:13 -05:00
cb17ea4914
Fix IPv6 announce socket binding interface. ( #3692 )
...
When Transmission listens on both IPv4 and IPv6 interfaces IPv4 listen address
is always passed to CURL's CURLOPT_INTERFACE. In general it stays unnoticed but
if user has multiple IPv6 addresses configured on his system random (first?)
IPv6 address is used. It happens because passed value to CURLOPT_INTERFACE
is not correct -- IPv6 expected but IPv4 is passed.
2022-08-21 18:37:38 -05:00
a0305a3a12
fix(gtk): fix conflicting hotkeys ( #2201 )
...
The torrent list hotkeys include `CTR + A` and were always active,
swallowing text edit hotkeys in the filter entry.
Now they are only active when the torrent list is focused.
2022-08-21 17:09:01 -05:00
4b96a264cf
Delete dead link and add new section in FAQ ( #3687 )
2022-08-21 14:59:31 -05:00
3c2e3714f9
docs: update 4.0.0-beta.1 release notes ( #3690 )
...
still needs more work, but it is tiring work so here is forward progress
2022-08-21 13:25:34 -05:00
bbb1ba6ea3
refactor: tr_urlPercentEncode() ( #3688 )
2022-08-21 08:43:09 -05:00
785119f2c2
perf: sonarcloud warnings about temp objects ( #3686 )
...
* perf: sonarcloud warnings about unnecessary temporary objects
* refactor: rename tr_sha1_digest_t::final() as finish()
2022-08-20 15:57:32 -05:00
4b615572c3
chore: re-enable readability-redundant-access-specifiers warning ( #3685 )
2022-08-20 14:49:11 -05:00
5bcbb7e34b
refactor: aggregate arc4 into libtransmission ( #3684 )
2022-08-20 13:41:40 -05:00
d2852b6043
fix: 3579 assertion when RPC client asks for torrent-id 0 ( #3683 )
...
Fixes #3579 .
2022-08-20 11:55:32 -05:00
da3d83eaed
refactor: make blockinfo methods constexpr ( #3682 )
...
this can be constexpr and is an outlier in CPU profiling.
2022-08-20 10:40:18 -05:00
7dd55b64e1
fix: close all timers before destroying the event loop ( #3679 )
2022-08-19 19:28:24 -05:00
aac1ab784d
refactor: replace tr_http_escape() with tr_urlEscape() ( #3678 )
2022-08-19 14:33:06 -05:00
1cf19550ad
Revert "refactor: use OutputIterator for url-escaped info hash strings ( #3672 )"
...
This reverts commit 479a16787e
2022-08-19 02:18:16 -05:00
dde626d5e5
refactor: remove unused ( #3675 )
...
* refactor: remove unused define TR_PATH_DELIMITER_STR
* refactor: make TR_DEFAULT_BIND_ADDRESS_IPV4 private
* refactor: make TR_DEFAULT_BIND_ADDRESS_IPV6 private
* refactor: make TR_DEFAULT_RPC_HOST_WHITELIST private
* refactor: remove unused function tr_sessionSetRPCUrl()
* refactor: remove unused function tr_sessionGetRPCUrl()
* refactor: remove unused field native_local_path_prefix
* refactor: remove unused field native_unc_path_prefix
2022-08-18 22:47:23 -05:00
c532728c42
refactor: remove TR_N_ELEMENTS macro ( #3674 )
...
* refactor: use std::array for keys in transmission-remote
* refactor: use std::array for wide_module_path in platform.cc
* refactor: use std::array for value in tr_env_get_int()
* refactor: use std::array for SysStoreNames in web.cc
* chore: remove unused macro TR_N_ELEMENTS
2022-08-18 21:31:53 -05:00
c4537e6d80
Add a new flag in remote for connecting through a Unix domain socket. ( #3552 )
2022-08-18 20:09:55 -05:00
479a16787e
refactor: use OutputIterator for url-escaped info hash strings ( #3672 )
2022-08-18 14:49:20 -05:00
c171d6df7c
refactor: remove tr_utf8_validate from public API ( #3671 )
...
it was only used as an impl helper, so make it private
2022-08-18 13:23:59 -05:00
2d3bcebf79
docs: Add FAQ to Readme.md ( #3644 )
2022-08-18 12:04:12 -05:00
74d2f1a2d6
refactor(gtk): use symbolic icons in status bar ( #3655 )
2022-08-18 11:15:27 -05:00
846442af83
For some reason self.fPieces.resize() won't work but _fPieces.resize() will ( #3669 )
2022-08-18 10:21:31 -05:00
76a7994eef
refactor: remove tr_free() ( #3668 )
2022-08-18 09:14:12 -05:00
963a8112a1
refactor: remove tr_strvDup() ( #3666 )
2022-08-17 21:18:44 -05:00
bfec98c323
refactor: avoid tr_new() in transmission-remote ( #3665 )
2022-08-17 20:25:42 -05:00
36675d183a
refactor: avoid tr_new() in tr_main_win32() ( #3664 )
2022-08-17 18:26:52 -05:00
7fe2cf68b9
refactor: avoid tr_new(), tr_free() in tr_variant ( #3663 )
...
* refactor: remove unused tr_renew()
* refactor: remove unused tr_realloc()
* refactor: avoid tr_strvDup() in tr-quark
2022-08-17 14:44:18 -05:00
9374e332ec
refactor: avoid tr_new in rpcimpl ( #3662 )
2022-08-17 13:11:44 -05:00
29f57bc296
chore: iwyu headers ( #3661 )
2022-08-17 11:08:36 -05:00
6b25a57899
refactor: don't use tr_free in tr_strvUtf8Clean() ( #3658 )
2022-08-16 21:47:07 -05:00
fecdc418e5
Add documentation for TR_CURL_SSL_NO_VERIFY environment variable. ( #3656 )
2022-08-16 20:47:46 -05:00
e49747ab51
feat: add tr_strvToBuf() ( #3657 )
...
* feat: add tr_getDefaultConfigDirToBuf()
* feat: add tr_getDefaultDownloadDirToBuf()
* feat: add tr_strvToBuf()
* feat: add tr_torrentFindFileToBuf()
* feat: add tr_torrentGetMagnetLinkToBuf()
* refactor: remove unused makeString() from tests
* feat: add tr_torrentFilenameToBuf()
* feat: add tr_torrentGetTrackerListToBuf()
* chore: remove obsolete comment references to tr_free
* chore: remove unused tr_strdup()
* chore: remove unused forward declarations
2022-08-16 19:28:57 -05:00
988d8ff9ac
test: possibly fix rename-test flakes ( #3653 )
...
* test: possibly fix rename-test flakes
* ci: add gettext-dev to alpine workflow
* ci: make utils if tests change, since transmission-show is needed
* ci: add linux-headers to alpine workflow
2022-08-16 17:47:02 -05:00
6278ea7017
refactor: reduce use of tr_malloc / tr_free ( #3652 )
...
* refactor: avoid tr_new in macos Torrent.trashDataFile
* refactor: avoid tr_new in maco PiecesView
* refactor: avoid tr_new in qt createVariant()
2022-08-16 12:03:09 -05:00
293f4f6759
refactor: fix sonarcloud warnings ( #3649 )
...
* refactor: help sonarcloud to see that tr_bandwidth dtor does not throw
* refactor: use std::map instead of QMap in qt FileTreeModel
2022-08-16 09:30:05 -05:00
99c21efecc
refactor: avoid tr_malloc / tr_free in subprocess-win32 ( #3648 )
2022-08-16 00:07:06 -05:00
c625ec7e0f
refactor: make tr_session.rpc_server_private_ ( #3646 )
...
* refactor: make tr_session.rpc_server_ private
* chore: sort some fields to reduce number of padding holes
* chore: remove unused forward declarations
* refactor: aggregate tr_bitfield in tr_turtle
* chore: remove unused forward declarations
* chore: remove unused forward declarations
2022-08-15 16:25:55 -05:00
0fbfed60b1
refactor: make tr_session.speed_limit_Bps_ private ( #3645 )
...
* refactor: make tr_session.speed_limit_Bps_ private
* refactor: make tr_session.is_utp_enabled_ private
* refactor: make tr_session.is_prefetch_enabled_ private
* refactor: make tr_session.is_ratio_limited_ private
* refactor: make tr_session.upload_slots_per_torrent_ private
* refactor: make tr_session.peer_id_ttl_hours_ private
* refactor: make tr_session.blocklists_ private
* refactor: make tr_session.umask_ private
* refactor: make tr_session.evdns_base_ private
* fixup! refactor: make tr_session.blocklists_ private
* refactor: make tr_session.default_trackers_ private
* refactor: make tr_session.idle_limit_minutes_ private
* refactor: make tr_session.WebMediator private
* refactor: make tr_session.session_id_ private
* refactor: make tr_session.peer_socket_tos_ private
2022-08-15 12:48:05 -05:00
a4c1a23fae
refactor: make tr_session.is_incomplete_file_naming_enabled_ private ( #3642 )
...
* refactor: make tr_session.is_incomplete_file_naming_enabled_ private
* refactor: make session callback setters constexpr
* refactor: make tr_session.is_port_random_ private
* refactor: make tr_session.desired_ratio_ private
* refactor: make tr_session.is_pex_enabled_ private
* refactor: make tr_session.is_idle_limited_ private
2022-08-14 19:33:28 -05:00
44a291ca39
refactor: remove tr_session nonmember functions ( #3641 )
2022-08-14 14:41:57 -05:00
6beca85ae2
refactor: make tr_session.rpc_func_ private ( #3640 )
2022-08-14 10:40:03 -05:00
08ec882055
refactor: remove tr_isSession() ( #3638 )
2022-08-14 09:16:08 -05:00
5c8695025a
refactor: make tr_session.is_closing_private_ ( #3637 )
2022-08-13 20:04:36 -05:00
f6bf652043
refactor: make tr_session.peer_count private ( #3635 )
2022-08-13 17:41:42 -05:00
ed6ee619a6
refactor: make tr_session.queue fields private ( #3634 )
2022-08-13 14:56:10 -05:00
403e81e163
refactor: make tr_session.web_mediator_ private ( #3633 )
2022-08-13 13:36:34 -05:00
c7466b3ff4
fix: coverity warnings ( #3632 )
...
* fix: uninitialized field natpmp
* fix: unchecked downcast result
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential tr_error leak
* fix: potential nullptr dereference in test fixtures
* fix: handshake fields not initialized in constructor
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: cast unchecked return value to void
* chore: make single-arg constructors explicit
* fix: code smell make variable a pointer-to-const
* fix: code smell make variable a pointer-to-const
* chore: make single-arg constructors explicit
* chore: silence sonarcloud false warning on commented-out-code
* chore: fix code smell use std::array
* chore: make EvTimer::handleTimer() const
* chore: mark tr_bandwidth remove_child as noexcept
2022-08-13 12:11:07 -05:00
Charles Kerr