Commit Graph

1469 Commits

Author SHA1 Message Date
Jordan Lee 45bdc18210 (trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761 2011-05-02 17:58:27 +00:00
Jordan Lee 7069534abf (trunk, gtk) #4218 "open url should set focus on the open button by default" -- fix r12409 oops 2011-05-01 05:04:09 +00:00
Jordan Lee a9b379777f (trunk gtk) #4218 "open url should set focus on the open button by default" -- done. 2011-05-01 04:14:50 +00:00
Jordan Lee 0cff181c09 (trunk gtk) #4203 "gnome-network-properties doesn't exist in GNOME 3" -- fixed with patch from lesnoland 2011-04-30 16:22:03 +00:00
Jordan Lee 9753aa6183 (trunk gtk) in the details dialog, use the GQuark versions of g_object_{get,set}_data() 2011-04-29 21:36:44 +00:00
Jordan Lee c1273a03a4 (trunk gtk) tweak to r12398: because most of the strings in category_filter_model_update() will be duplicates of each other, use g_string_chunk_insert_const() instead of g_string_insert(). 2011-04-29 20:22:11 +00:00
Jordan Lee 53fede89f6 (trunk gtk) in filter.c's category_filter_model_update(), use a string chunk for all those temporary strings that are allocated in a looop 2011-04-28 23:13:14 +00:00
Jordan Lee b93bef2712 (trunk gtk) gtr_get_host_from_url(): avoid a couple of malloc() + free() calls. 2011-04-28 18:37:27 +00:00
Jordan Lee 6326003e73 (trunk gtk) very minor tweak in deciding which rows to update in the torrent model.
Since we only display speed to two decimal places, we don't need to compare previous and current torrent speed with more precision than that.
2011-04-20 01:16:16 +00:00
Jordan Lee fdbe7dc2da (trunk gtk) more heap pruning, in tr_core
Tweak how we loop through the torrents in the model, again to avoid unnecessary GtkTreePath temporaries.
2011-04-13 22:16:50 +00:00
Jordan Lee 6cd1dcb574 (trunk gtk) Avoid unnecessary GtkComboBox queries.
Instead of calling gtk_combo_box_get_active_iter() on the filterbar's two comboboxes in every periodic update, keep the state information in a local struct and update it when the selection changes. That way the filter code doesn't even need to know about the GtkComboBox or the GtkTreeModel.
2011-04-13 22:04:31 +00:00
Jordan Lee 1d7a4eb528 (trunk gtk) more heap pruning: minor GtkTreeModel changes
Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
2011-04-13 22:00:55 +00:00
Jordan Lee 01461d0b4a (trunk gtk) more heap pruning:
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
Jordan Lee 4a15899499 (trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer. 2011-04-12 11:13:41 +00:00
Jordan Lee b1459c5d3b (trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings 2011-04-12 10:51:52 +00:00
Jordan Lee b797f51144 (trunk gtk) more heap pruning: give torrent-cell-renderer an internal GString buffer so that we don't have to create & free so many short-term strings 2011-04-12 10:04:05 +00:00
Jordan Lee 4ce3555786 (trunk gtk) minor janitorial: const correctness in tr-core's compare_by_name() 2011-04-11 16:27:41 +00:00
Jordan Lee 07e60d1fc0 (trunk gtk) more heap pruning: use a GStringChunk for the collated torrent names in tr-core.c 2011-04-07 04:29:37 +00:00
Jordan Lee e02ce61d3e (trunk gtk) removed the unused MC_NAME column from the torrent GtkListStore. 2011-04-05 17:00:38 +00:00
Jordan Lee fb2ffbc542 (trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window 2011-04-05 16:16:06 +00:00
Jordan Lee c213d91ffd (trunk gtk) use GQuarks instead of strings for keys in the filterbar's key/value pairs 2011-04-05 15:59:41 +00:00
Jordan Lee 708838b146 (trunk gtk) more heap pruning: in the main window's torrent list, only update the case-insensitive "collated name" of a torrent when the torrent's metadata changes (such as when a magnet link's metadata finishes downloading). 2011-04-05 15:41:51 +00:00
Jordan Lee afa016704f (trunk libT) more heap pruning: use a hash, rather than an allocated string in tr-core when watching for a torrent's tracker list to change 2011-04-05 01:36:37 +00:00
Jordan Lee d233ea82e7 (trunk gtk) more heap pruning: avoid unnecessary malloc() + free() calls in gtr_get_host_from_url() 2011-04-04 16:54:09 +00:00
Jordan Lee c16406bf7c (trunk gtk) remove "dead nested assignment" wart detected by clang static analyzer 2011-03-31 04:58:38 +00:00
Jordan Lee eb06d81fb9 (trunk) fix a handful of small memory leaks that valgrind found. 2011-03-25 17:42:47 +00:00
Jordan Lee bd88521332 (trunk) yet more "#include" tweaks 2011-03-25 15:03:42 +00:00
Jordan Lee b0379147d9 (trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5 2011-03-25 07:32:30 +00:00
Jordan Lee 4a1a4ebcc0 (trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
Jordan Lee 375694eda9 (trunk) copyediting: remove some unneeded #includes, and annotate some needed ones 2011-03-24 21:49:42 +00:00
Jordan Lee 433da8df9a (trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h 2011-03-24 18:32:05 +00:00
Jordan Lee a891136602 (trunk gtk) gtr_localtime() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:29:07 +00:00
Jordan Lee e46d0a72ba (trunk gtk) gtr_cell_renderer_get_padding() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:24:21 +00:00
Jordan Lee 5417711cd4 (trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0 2011-03-24 18:20:47 +00:00
Jordan Lee 0a1df687bb still trying to make hudson happy 2011-03-22 16:07:49 +00:00
Jordan Lee 034a65aaf1 (trunk gtk) revert r12201 to try & make hudson happy 2011-03-22 16:03:10 +00:00
Jordan Lee b4d36aeb54 (trunk) #4138 "use stdbool.h instead of tr_bool" -- done. 2011-03-22 15:19:54 +00:00
Jordan Lee e259d0abbe (trunk gtk) tweak Makefile.am 2011-03-21 20:45:50 +00:00
Jordan Lee 2544b4b228 (trunk gtk) dbus tweaks in Makefile.am based on examples from http://live.gnome.org/DBusGlibBindings .
1. tweak the way dbus-binding-tool is invoked... use --output=$@ $^

2. add the file generated by dbus-binding-tool to BUILT_SOURCES
2011-03-21 20:26:15 +00:00
Jordan Lee 374ed10f3b (trunk) it's bad form to #include so many system headers in libtransmission/utils.h... 2011-03-16 18:04:23 +00:00
Jordan Lee 591b95286f Show whether a tracker is http or udp. Without that context, it could be confusing to see the same tracker twice in a tier 2011-03-15 17:03:09 +00:00
Jordan Lee fee784f1d8 (trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done. 2011-03-15 04:22:47 +00:00
Jordan Lee 018585d3b0 (trunk gtk) fix condition that could crash in some cases when right-clicking in the file list menu. 2011-03-13 16:45:32 +00:00
Jordan Lee 55381159f6 (trunk gtk) #4075 "add x-scheme-handler/magnet to desktop file" -- fixed.
Thanks to ampelbein for the patch :)
2011-03-13 15:56:12 +00:00
Jordan Lee afe6d42ac1 (trunk gtk) when a tracker is manually added to a torrent, check the tracker's validity with tr_urlIsValidTracker() 2011-03-13 07:49:32 +00:00
Jordan Lee e45a6dabc9 (trunk gtk) fix 2.22+ time display regression in the GTK+ client. 2011-03-11 04:10:28 +00:00
Jordan Lee 9145bce9cd (trunk gtk) fix time display oops 2011-03-06 15:06:38 +00:00
Jordan Lee 05c39eaa3e add a missing icon 2011-03-06 05:41:41 +00:00
Jordan Lee 411b0bbd1a (trunk gtk) #4088 "Transmission needs 256x256 icon too" -- added large Tango icon by Andreas Nilsson. Thanks Andreas!
This larger icon is apparently needed for GNOME 3.
2011-03-05 19:15:37 +00:00
Jordan Lee 0a62f69f1c (trunk gtk) copyediting. 2011-03-04 15:49:51 +00:00