Commit Graph

4747 Commits

Author SHA1 Message Date
A Cœur 3cd2be381b
Fix Warn -> Warning (#3382)
* Fix Warn -> Warning

* Adopt "Warning" for English
2022-07-01 17:19:19 -05:00
Dzmitry Neviadomski 37f7f83d4d
[macOS] Apply ObjC modernizations once again. (#3358)
This doesn't include designated initializers refactoring.
2022-06-28 23:20:42 -05:00
Dmitry Serov 7e278c453a
[macOS] Optimise framework imports (#3323) 2022-06-28 19:15:52 -05:00
SweetPPro e678f7c5f5
macOS fix quicklook toolbar icon status (#3345)
Fixes #3235
2022-06-28 18:19:06 -05:00
SweetPPro b80e9bd8c2
macOS use standard toolbar buttons (#3356)
Co-authored-by: Dmitry Serov <barbari100@gmail.com>
2022-06-28 16:14:10 -05:00
Gary Elshaw e683cd504c
Fix: Flexibility of the Encryption column (#3348) 2022-06-28 14:08:15 -05:00
Dzmitry Neviadomski 534f9f7bc1
Update Copyright Year to 2022. (#3352) 2022-06-28 09:07:12 -05:00
Gary Elshaw e823b725f2
Delete ActionOn and QuitBadge image directories (#3364)
* Delete macosx/Images/Images.xcassets/ActionOn.imageset directory

* Delete macosx/Images/Images.xcassets/QuitBadge.imageset directory

* Deleted ActionOn and QuitBadge from CMakeLists
2022-06-27 23:33:13 -05:00
FX Coudert b893289392
Rename Mac OS X to macOS (#3362) 2022-06-27 15:28:37 -05:00
SweetPPro eefcbe7cb2
macOS remove gradient from PiecesView (#3342) 2022-06-25 01:03:07 -05:00
SweetPPro 849a36a30d
macOS fix Toolbar show/hide on macOS Mojave (#3327) 2022-06-24 00:26:36 -05:00
SweetPPro 286d438222
macOS use AutoLayout in utility bars (#3326)
update filterbar to use constraints=
2022-06-23 11:18:53 -05:00
A Cœur 7f01ee52fe
Set torrent file's metainfo for magnets (#3322) 2022-06-21 16:47:57 -05:00
Charles Kerr 308ae8487a
fix: code style in macosx/AboutWindowController.mm (#3334)
* build: when code-style fails, try giving a breadcrumb to find the diff

* fix: code style in AboutWindowController.mm

* fix: typo in what-to-make
2022-06-21 12:25:16 -05:00
FX Coudert 2ac049c7ba
Fix NSAttributedString deprecation (#3330) 2022-06-20 14:45:01 -05:00
FX Coudert 83927eade1
Update links in macOS credits (#3329) 2022-06-20 11:50:56 -05:00
SweetPPro b983a3ba5c
macOS fix quicklook in the Torrent Inspector files view (#3321) 2022-06-19 01:00:16 -05:00
Gary Elshaw 7030eb8530
Updated macOS ActionHover icon to grey chevron (#3239) 2022-06-18 18:39:39 -05:00
Mike Gelfand 6d54287785
Sync translations (#3318)
* Sync translations with code

* Sync translations with Transifex
2022-06-18 21:44:13 +03:00
SweetPPro 90f2757448
macOS fullscreen and autosize fixes (#3315)
use constraints to set window size and remove a bunch of manual calculations
2022-06-18 12:39:22 -05:00
FX Coudert e0c593741c
Raise minimum supported target to macOS 10.13 (High Sierra) (#3310) 2022-06-18 09:26:45 -05:00
SweetPPro 06e5767234
macOS add full screen support (#3305) 2022-06-16 14:59:54 -05:00
SweetPPro c6b49e99d8
macOS revert fullscreen changes (#3304)
* macOS remove NSWindow subclass

as discussed in #3297
2022-06-16 12:55:33 -05:00
SweetPPro 037f1bf403
macOS remove NSWindow subclass (#3303) 2022-06-16 09:29:50 -05:00
Dzmitry Neviadomski 57ed120a71
[macOS] Hide NSPopover Arrow for Torrent options. (#3294)
Fixes #3293
2022-06-15 13:53:23 -05:00
SweetPPro 092710fa16
macOS remove GearshapeTemplate from CMakeLists.txt (#3301)
Icon was removed from project in #3178
2022-06-15 10:21:11 -05:00
Dzmitry Neviadomski c806a1435e
[macOS] Fix Group auto-assigning based on NSPredicate (#3289)
* [macOS] Fix Group NSPredicate

Property was renames, but previously saved predicates were not updated.

* [macOS] Update xibs for creating Group NSPredicate with new name.

* [macOS] Allow execution for Group NSPredicate restored secured storage.
2022-06-14 10:17:02 -05:00
Dzmitry Neviadomski 438653a4ee
[macOS] Fix assert on save for WARN and TRACE log levels in Log window. (#3290) 2022-06-14 00:40:19 -05:00
Dzmitry Neviadomski b28aa943cb
[macOS] Update Preferences window sizing for Russian locale. (#3291)
Most of the changes are caused by Xcode touching XIB file.
2022-06-14 00:18:17 -05:00
Dzmitry Neviadomski f8264ce957
[macOS] Fix global popover clipping. (#3264)
* [macOS] Fix global popover clipping.

Fixes #3263

* [macOS] Detach global popover via ugly hack.
2022-06-13 12:26:30 -05:00
SweetPPro 955091ce12
macOS - fix some window drawing issues (#3278)
* macOS - fix some window drawing issues

fixes an issue with  torrent clipping when number of torrents displayed overflows the screen height
2022-06-13 09:48:09 -05:00
SweetPPro dd85cd20bd
replace macOS Groups indicators with dots (#3268)
* replace macOS Groups indicators with dots

the current Group indicator PR #3183 used bars. I feel using circles is a better fit with the overall theme of Transmission #3224

* simplified calculations
2022-06-12 20:56:12 -05:00
SweetPPro c3cd9cffad
re-add macOS Fullscreen support (#3261)
* re-add macOS Fullscreen support

re added Full Screen support for macOS. Also refactored window methods in Controller.mm and moved to their own category - ControllerWindowMethods.mm

This has currently only been tested on macOS Monterey, and should be good on earlier versions - but perhaps needs testing on earlier versions of macOS.

fixes #3231 #3234
2022-06-12 19:54:52 -05:00
Dzmitry Neviadomski da74fd21cc
[macOS] Use DDG favicons service and migrate to NSURLSession (#3270)
```objc
+ (NSData *)sendSynchronousRequest:(NSURLRequest *)request
                 returningResponse:(NSURLResponse * _Nullable *)response
                             error:(NSError * _Nullable *)error;
```
is deprecated on 10.11+
2022-06-12 15:29:00 -05:00
Gary Elshaw ed394af4d6
Replace gear icon with ellipsis in macOS client (#3178) 2022-06-11 23:24:31 -05:00
Gary Elshaw d4bc5662fe
Add files via upload (#3238) 2022-06-09 12:35:12 -05:00
A Cœur af5db6e6f2
refactor: autogenerate the macOS client's Message Log dots (#3224)
* Replaces DotFlat png with generated icons

* code review: udating popup item icons

* code review: increasing inset
2022-06-08 16:35:51 -05:00
SweetPPro 7056765468
update macOS group indicators (#3183)
* update macOS group indicators

proposal for updated Group indicators, inspired by Xcode, and ios Calendar.

Discussion over here: https://github.com/transmission/transmission/issues/3058

* Update TorrentCell.mm

resolve some pr isssues

* Update TorrentCell.mm

add a group indicator width definition
2022-06-08 15:13:29 -05:00
SweetPPro aabb8c809e
macOS remove FullScreen support (#3220)
removed fullscreen support, as it opens a can of worms trying to fully support it....

https://github.com/transmission/transmission/issues/3215#issuecomment-1147477253
2022-06-08 14:15:51 -05:00
A Cœur 7b6b87b0e6
fix: macOS build warning "cannot find protocol definition for 'PortCheckerDelegate'" (#3222) 2022-06-07 14:27:40 -05:00
SweetPPro 5a140d205d
feat: use system lock icon if available (#3221) 2022-06-06 17:56:05 -05:00
SweetPPro 8d61f07930
fix: missing source file in CMake macOS build (#3208)
* Update CMakeLists.txt

correctly add new files to xcode project
2022-06-05 13:33:18 -05:00
SweetPPro 9cbb4d3384
fix a number of UI render issues in the macOS torrent creator window (#3205)
* fixes a number of UI issues in the macOS torrent creator window listed in: https://github.com/transmission/transmission/issues/1891

* also fixes positioning of the source field, the piece info textfield, and the piece info stepper

* also updates the  tracker add/remove control to use the newer rounded trect style as in the rest of the UI
2022-06-05 11:14:33 -05:00
SweetPPro 70a54b3603
add gearshape temeplate to macOS CMakeLists.txt (#3202)
add missing macOS icon asset to CMakeLists.txt
https://github.com/transmission/transmission/issues/3199
2022-06-05 09:54:45 -05:00
SweetPPro 163f6c2544
more FullScreen fixes, and some toolbar animation fixes (#3195)
* Update Controller.mm

fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906

* more FullScreen fixes, and some toolbar animation fixes

https://github.com/transmission/transmission/issues/1906, https://github.com/transmission/transmission/issues/1903
2022-06-05 08:49:31 -05:00
A Cœur 84195254ec
Fix: "Cannot begin activity without reason string or empty reason string" (#3197) 2022-06-04 18:42:32 -05:00
SweetPPro d31254df50
Update Controller.mm (#3191)
fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906
2022-06-04 14:30:03 -05:00
A Cœur 4906349e3a
Make Sparkle optional to allow running Transmission without Apple Developer Program (#3050)
* Make Sparkle optional to allow building without Apple Developer Program

* Display a nice alert for developers clicking "checkForUpdates" when app isn't signed for Sparkle

Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-06-03 12:47:33 -05:00
Mike Gelfand 79d90167fd
Sync translations (#3184)
* Sync translations with code

* Sync translations with Transifex
2022-06-03 10:06:59 +01:00
SweetPPro df657e9a04
Updated macOS segmented control alignment and popup button style (#3156)
* updated macOS group popup button alignment

popup button alignment enhancements described in the following issue: https://github.com/transmission/transmission/issues/3143

* updated macOS segmented controls in Preferences window

as described in the following issue: https://github.com/transmission/transmission/issues/3143
2022-06-02 19:05:15 -05:00
FX Coudert f5e6c5b782
fix: minor xcode warnings in macOS client (#3174) 2022-06-01 19:51:09 -05:00
SweetPPro 182e51492a
fix macOS statusBar icons (#3113)
* fix macOS statusBar icons

* improved CleanupTemplagte images
2022-05-27 06:59:37 -05:00
A Cœur b033b6598e
Fix group icon border (#3094) 2022-05-26 16:04:20 -05:00
A Cœur 2e25370cc5
Fix QuickLook (#3001)
* Fix QuickLook symbol not found; add file sort and filesize
2022-05-19 23:07:17 -05:00
Antoine Cœur 3c056001b1
support pasting multiple magnet links (#3087) 2022-05-16 23:48:39 -05:00
Charles Kerr a28b07b390
Revert "refactor: move tr_torrent callbacks to tr_session (#3003)" (#3104)
This reverts commit 27fbfd8da6.

Fixes #3088.
2022-05-16 13:48:43 -05:00
Antoine Cœur e23a4b3589
refactor copyMagnetLinks (#3086) 2022-05-16 12:08:20 -05:00
Antoine Cœur 25ef121d71
Add "Verify Local Data" to context menu (#3025) 2022-05-14 21:14:54 -05:00
Antoine Cœur 60254710b8
Rename sortTorrentsAndIncludeQueueOrder and nonEmptyComponentsSeparatedByCharactersInSet (#3051)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 14:00:55 -05:00
SweetPPro 82bede40d1
fix for macOS "Stay within the global bandwith limits" always displaying true (#3079) 2022-05-14 12:57:22 -05:00
Charles Kerr 27fbfd8da6
refactor: move tr_torrent callbacks to tr_session (#3003)
* refactor: move tr_torrent callbacks to tr_session

* Support tr_sessionSet* (#3044)

Co-authored-by: Antoine Cœur <coeur@gmx.fr>
2022-05-14 10:00:13 -05:00
Antoine Cœur c1f5911fc7
'beginSheet:modalForWindow:modalDelegate:didEndSelector:contextInfo:' is deprecated: (#3031)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 08:20:56 -05:00
Antoine Cœur 340f88bc12
Fix "The left operand of '<' is a garbage value" (#3042) 2022-05-14 02:53:30 -05:00
wiz78 79274bb335
macOS: disable App Nap. Fixes #577 (#874)
* disable App Nap

* Update Controller.m

merged with upstream changes

* Delete Controller.m

* chore: code-style.sh

Co-authored-by: Simone Tellini <wiz78>
Co-authored-by: Simone Tellini <simone@Argon.local>
Co-authored-by: Simone Tellini <simone@tellini.info>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-14 01:57:20 -05:00
Antoine Cœur 5d52da8726
Address format conversion warnings in localizations (#3059) 2022-05-14 00:31:24 -05:00
Antoine Cœur 659969a436
Fix Display window option incorrectly enabled on start (#3056) 2022-05-13 21:27:31 -05:00
Antoine Cœur 67f6562ae4
Updating group icon style for newer macOS (#3065) 2022-05-13 19:54:10 -05:00
Antoine Cœur 5026d43920
Add ⌘C support (#3072) 2022-05-13 16:03:07 -05:00
Antoine Cœur d5533ee648
Fix "Port checker returned invalid status: 0" (#3064)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-10 09:54:39 -05:00
Antoine Cœur e7312eba14
Rename "Remove Data File" to "Trash Data File" (#3057) 2022-05-08 20:47:56 -05:00
Cœur 1f419a3a6f Fix retrieving groups with predicates 2022-05-05 16:14:06 +08:00
Antoine Cœur a57d265968
Set recommended CODE_SIGN_IDENTITY and PRODUCT_BUNDLE_IDENTIFIER (#3043) 2022-05-01 16:55:09 -05:00
Antoine Cœur d498aa1ae1
The left operand of '+' is a garbage value (#3041) 2022-05-01 07:26:45 -05:00
Antoine Cœur 7eecdca68e
clang-format version 12.0.1 + 14.0.3 (#3027) 2022-04-30 12:49:52 -05:00
Antoine Cœur 34ec2f5aa4
Adopting lightweight generics (#2974) 2022-04-29 17:51:40 -05:00
Antoine Cœur aafedcaae1
Address deprecations with NSKeyedUnarchiver (#2973) 2022-04-29 16:44:59 -05:00
Antoine Cœur 42713c6716
OS X → macOS (#2986) 2022-04-26 09:11:44 -05:00
Antoine Cœur 7f9264940e
Compatibility to build on the last macOS 32 bit system with its last compatible Xcode (#2844)
* Compatibility to build on the last macOS 32 bit system with its last compatible Xcode

* Code review: Compatibility declarations

* compatibility with `make`

* Code review: headers

* Avoiding dummy NSImageSymbolConfiguration implementation

* clang-format

* Don't force-include compat header

* Remove compat header from pch header

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-04-24 21:34:30 +01:00
Antoine Cœur fe40692dea
Balancing HTML opening-closing tags (#2975) 2022-04-24 12:15:02 -05:00
Charles Kerr 32f854a7cf
refactor: add a tr_port safety class (#2952) 2022-04-21 10:58:13 -05:00
Antoine Cœur bdac708762
docs: fix various typos and misspellings (#2955) 2022-04-21 09:28:38 -05:00
Charles Kerr 6cdc7e3828
refactor: remove tr_announce_list::tracker info.announce (#2931) 2022-04-16 15:41:51 -05:00
Antoine Cœur bafb8d6495
Trim spaces when using cmd+u sheet (#2915) 2022-04-15 23:02:25 -05:00
Charles Kerr 31c65eec1f
refactor: remove tr_strvJoin() (#2896) 2022-04-07 17:26:59 -05:00
Charles Kerr 7aeb5d8b2f
Merge branch 'main' into nevack/mojave-infowindow-fix 2022-04-03 13:34:31 -05:00
Dzmitry Neviadomski 7cf920a020 [macOS] Fix Tab selection in InfoWindow on Mojave
Fixes #2599
2022-04-03 16:41:09 +03:00
Gary Elshaw 57b03114dc
New images for 'Message Log' (#2779) 2022-04-02 20:08:39 -05:00
Mike Gelfand d943f069f5
Fix code_style.sh to include *.mm files after switch to Obj-C++ (#2846) 2022-03-31 00:52:23 +03:00
Ali 0a8cfba3b3
Add ability to change piece size during torrent creation in MacOS GUI… (#2805)
* Add ability to change piece size during torrent creation in MacOS GUI (#2416)

* Shouldn't have committed the xcodeproj file
2022-03-24 22:26:21 -05:00
Charles Kerr fa8aaf7631
refactor: remove remaining vararg log messages (#2776) 2022-03-17 17:39:06 -05:00
Charles Kerr 5df252d1e1
fix: calculate ratio as uploaded / sizeWhenDone (#2770) 2022-03-17 13:41:48 -05:00
Charles Kerr 54ef7341a2
refactor: fmt pt 4 (#2774)
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-16 19:23:44 -05:00
SweetPPro 4f2472cd93
Update Torrent.mm (#2777) 2022-03-16 15:16:23 -05:00
Charles Kerr 2bd42f8225
fixup: macos log error (#2764)
* fix: assertion failure in MessageWindowController

* feat: update messagwindow xib to new log levels
2022-03-12 11:42:43 -06:00
Charles Kerr d2f8e1d4e0
refactor: set logging levels (#2755) 2022-03-11 15:09:22 -06:00
Markus Amalthea Magnuson 143c5f5381
Added ability to filter on error status. (#19) 2022-03-07 01:01:01 -05:00
SweetPPro a009a7f930
migrate macOS client to using tr_sessionLoadTorrents (#2686)
* migrate macOS client to using tr_sessionLoadTorrents

With this PR the macOS client now loads torrents at startup using `tr_sessionLoadTorrents`

The history file is used in tandem to provide macOS specific additions
2022-03-02 15:11:04 -08:00
Charles Kerr 80ab910cbd
feat: update built-in speed limit settings (#2697)
Fixes #2092.
2022-02-23 20:27:28 -06:00
Dmitry Serov 54d1a02e92
Use properties instead of ivars (#2453) 2022-02-22 10:04:20 -06:00
Mike Gelfand b2a01df64d
Sync existing translations with Transifex 2022-02-21 21:30:30 +00:00