b7a8bd45b7
Reformat affected code after recent changes
2020-08-18 20:31:06 +03:00
ff8d0dbf3b
Switch from UNUSED macro to TR_UNUSED macro
...
Since there is no way to mark parameters as [potentially] unused in
standard C and when using MSVC compiler, use the widely accepted
cast-to-void approach instead.
2020-08-18 14:19:55 +03:00
677dc73eac
refactor: use GTest for running tests ( #1383 )
...
* refactor: use google-test on libtransmission tests
2020-08-11 13:11:55 -05:00
6da4a4dfad
Fix or silence gtk warnings ( #1380 )
...
* chore: disable deprecation warnings in GTK client
Yes, updating the GTK codebase is still a goal. (help welcomed!)
But there's a deluge of deprecation warnings that drown out other more
important warnings, so turn off deprecation warnings for now.
* fixup! chore: disable deprecation warnings in GTK client
* fix: gtk_tree_sortable_set_sort_column_id caller.
* fix: gtk_window_resize caller.
2020-07-30 14:45:11 -05:00
9da4abb003
feat: add 'transfer.complete' notification hint ( #1374 )
...
Described at https://developer.gnome.org/notification-spec/#categories ,
this is for a file transfer or download complete notification.
2020-07-28 16:51:01 -05:00
05a2e15b00
i18n: translate "Ratio:" string in compact view ( #1354 )
...
Use already available translation from gettext.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-07-27 13:51:31 -05:00
073ae6c206
chore: fix deprecation warnings of GTK_STOCK_ use. ( #1370 )
...
* chore: fix deprecation warnings of GTK_STOCK_ use.
This is just a tiny step towards getting all of the GTK code up-to-date,
but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so
let's fix them.
2020-07-27 12:49:45 -05:00
82020d2e8c
fix: fix console warning when adding magnet links ( #1229 )
2020-05-15 12:22:06 -05:00
fa6df52d58
chore: remove unused methods ( #1207 )
...
* chore: remove unused methods in qt client
* chore: remove unused libtransmission methods
* chore: remove unused gtk methods
* chore: remove more unused libtransmission methods
* chore: remove more unused code found by @reardonia
2020-05-11 17:20:46 -05:00
79d3133ebc
Fixed showing popup menu on RMB at tray icon ( #1210 )
2020-05-11 16:19:33 -05:00
2d940e5caf
Bump copyright to 2020 (some more places) ( #1206 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-05-02 12:26:42 -05:00
8739cb9c88
fixup! (trunk) update credits ( #1205 )
2020-05-02 11:42:18 -05:00
a6482b0061
GTK: behavior improvements of the torrent details window ( #892 )
...
* gtk: torrent details file-list default sort
* gtk: save torrent details window size
* gtk: torrent details window size & sort, code style
* gtk: torrent details window, conf.c dict fix
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 16:34:02 -05:00
def7634f18
fix availability not showing 100% in gtk details view ( #1181 )
...
#1180
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-26 00:07:40 -05:00
7b53f4238d
icon: update application icon ( #1141 )
...
Fixes https://github.com/transmission/transmission/issues/1140
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-25 20:01:49 -05:00
f6030b1d79
gtk: fix window width ( #1069 )
...
GTK window width cannot be smaller than the longest torrent title
Source: https://trac.transmissionbt.com/ticket/6128
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-24 15:15:57 -05:00
b0e33117c5
Fix some gtk warnings ( #1038 )
...
* fix gtk deprecation warning: gtk_misc_set_alignment
* fix gtk deprecation warning: gtk_alignment_new
* fix gtk deprecation warning: gtk_tree_view_set_rules_hint
* fix gtk deprecation warning: gtk_image_new_from_stock
* fixup! fix gtk deprecation warning: gtk_alignment_new
* fix gtk deprecation warning: gtk_dialog_set_alternative_button_order
* fix gtk deprecation warning: gtk_show_uri
* fix gtk deprecation warning: gtk_widget_set_margin_left
* fix gtk deprecation warning: gtk_button_set_alignment
* fix gtk deprecation warning: g_type_class_add_private
* fix gtk deprecation warning: gtk_menu_popup
* fix gtk deprecation warning: gtk_misc_set_padding
* chore: uncrustify
* fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning
Deprecaed starting in glib 2.58
* chore: uncrustify
2019-11-06 13:09:27 -06:00
abac811dd2
fix: gcc warnings in libtransmission/ and utils/ ( #843 )
...
* fix: __attribute__(__printf__) warnings
* fix: implicit fallthrough warning
* fixup! fix: implicit fallthrough warning
* fix: disable warnings for 3rd party code
Since we want to leave upstream code as-is
* fixup! fix: disable warnings for 3rd party code
* fixup! fix: disable warnings for 3rd party code
* silence spurious alignment warning
Xrefs
Discussion: https://stackoverflow.com/a/35554349
Macro inspiration: 90ac46f710/f/src/util/util_safealign.h (_35)https://gitlab.gnome.org/GNOME/gnome-terminal/issues/96 talks about both
the issue and its solution.
GCC 8's -Wcast-function-type, enabled by -Wextra, is problematic in glib
applications because it's idiomatic there to recast function signatures,
e.g. `g_slist_free(list, (GFunc)g_free, NULL);`.
Disabling the warning with pragmas causes "unrecognized pragma" warnings
on clang and older versions of gcc, and disabling the warning could miss
actual bugs. GCC defines `void (*)(void)` as a special case that matches
anything so we can silence warnings by double-casting through GCallback.
In the previous example, the warning is silenced by changing the code to
read `g_slist_free(list, (GFunc)(GCallback)g_free, NULL);`).
* fixup! fix "unused in lambda capture" warnings by clang++
* fixup! fix "unused in lambda capture" warnings by clang++
* fix two more libtransmission compiler warnings
* fix: in watchdir, use TR_ENABLE_ASSERTS not NDEBUG
2019-11-06 11:27:03 -06:00
eef4799388
Update Uncrustify config to 0.69
2019-07-15 02:30:41 +03:00
10cdd7f790
Use explicit boolean conversions
2019-07-14 16:25:07 +03:00
a3e4919385
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 12:00:06 +03:00
c567588587
Remove useless parentheses
2019-03-17 09:18:27 +03:00
5693e59256
Define each identifier in a dedicated statement
...
* MISRA C++:2008, 8-0-1 - An init-declarator-list or a member-declarator-list
shall consist of a single init-declarator or member-declarator respectively
* CERT, DCL52-J. - Do not declare more than one variable per declaration
* CERT, DCL04-C. - Do not declare more than one variable per declaration
2019-03-17 09:15:35 +03:00
17307e7484
Extract assignments from expression
...
Assignments explicitly enclosed in parentheses are ignored.
* MISRA C:2004, 13.1 - Assignment operators shall not be used in expressions
that yield a Boolean value
* MISRA C++:2008, 6-2-1 - Assignment operators shall not be used in
sub-expressions
* MISRA C:2012, 13.4 - The result of an assignment operator should not be used
* MITRE, CWE-481 - Assigning instead of Comparing
* CERT, EXP45-C. - Do not perform assignments in selection statements
* CERT, EXP51-J. - Do not perform assignments in conditional expressions
2019-03-17 08:00:15 +03:00
d3b8982195
Uppercase the literal suffixes
...
* MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case
* MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a
literal suffix
* CERT DCL16-C. - Use "L," not "l," to indicate a long value
* CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 07:07:48 +03:00
dab4857f90
Merge branch 'master' into rmintltool
2019-02-24 21:52:09 +03:00
82df3a87f4
Update to Uncrustify 0.68.1
...
Tweak a few rules in the process. Now all code in cli, daemon, gtk,
libtransmission, qt, and utils is properly formatted with no manual
intervention.
2019-02-15 09:21:48 +03:00
7058f37bed
Merge pull request #816 from PeterDaveHello/improve-shellscript
...
fix shell script syntax errors and spacing inconsistencies
2019-02-01 22:36:54 -06:00
7a0d2e63c7
Refactor shell scripts with syntax and styling fixes
2019-01-16 03:22:29 +08:00
3c0cb395c5
Updated copyright strings to 2019
...
Updated Transmission Project copyright dates to 2005-2019 in headers and code.
2019-01-11 19:36:19 +01:00
8c160aad2d
cmake: replace intltool with gettext
...
requires gettext 0.19.7 or higher
2018-04-18 09:25:13 +00:00
f388d17c2d
Updated copyright string to 2018
...
Small update to copyright string
2018-04-17 00:50:33 -10:00
94be7dbd9b
Merge branch '2.9x'
2018-01-25 03:07:52 +03:00
aa2730d47c
Switch to HTTPS links, adjust wiki links where possible
...
Fixes #39
2018-01-16 01:12:59 +03:00
a6ef87b92d
Update all instances of the donation link. Fixes #26 .
2018-01-15 23:57:46 +03:00
01ffcd5dcf
gtk: add symbolic icon
...
The -symbolic icon variant (if available) is used in the GNOME top bar,
and when the high contrast theme is in use. This icon was created by
Jakub Steiner, and comes from the gnome-icons repository:
https://github.com/gnome-design-team/gnome-icons/blob/master/apps-symbolic/Adwaita/scalable/apps/transmission-symbolic.svg
https://bugzilla.redhat.com/show_bug.cgi?id=1221292
There is some confusion over whether symbolic app icons should be
installed to icons/hicolor/scalable/apps (alongside the regular scalable
icon) or to icons/hicolor/symbolic/apps. On the one hand,
https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons has
this to say:
> […] obtain a suitable symbolic style icon […] and install it to the
> hicolor prefix, the same way you would for the full color variant.
>
> cp myapp-symbolic.svg /usr/share/icons/hicolor/scalable/apps/myapp-symbolic.svg
On the other hand, the Fedora package at
https://src.fedoraproject.org/rpms/transmission/blob/master/f/transmission.spec
ships this icon in icons/hicolor/symbolic/apps:
> # Install the symbolic icon
> mkdir -p %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps
> cp %{SOURCE1} %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps/transmission-symbolic.svg
Anecdotally, icons in scalable/ have minimum size 64×64 on openSUSE, so
symbolic/ is the safer location (given the GNOME top bar uses 32×32
icons). This has the advantage of matching the location used in the
distribution which already ships this file.
https://github.com/transmission/transmission/issues/414
2017-11-30 17:38:34 +00:00
7e6f1a8dc8
Set idle seed limit range to 1..40320 (4 weeks tops) in all clients
...
Fixes : #212
2017-07-05 21:07:16 +03:00
f701d501a8
Move generic macros to a separate tr-macros.h file
2017-06-18 17:11:20 +03:00
b0e3d4c37d
lossless compression of images saved 72KB
2017-06-03 23:52:34 +01:00
8f3cb1c68d
Wrap sizeof arguments in braces
2017-05-20 19:29:23 +03:00
7a1a1acd22
Fix autotools build
2017-05-17 00:56:39 +03:00
ef8cb30f7c
Merge pull request #224 from wjt/appdata
...
gtk: add AppData file
2017-05-16 23:13:25 +03:00
1e3d20422a
Reduce for loop variables scope
2017-05-14 01:38:31 +03:00
23d61b6457
gtk: add AppData file
...
This file was originally written by Richard Hughes, for Fedora, who
proposed it on the Transmission forum here:
https://forum.transmissionbt.com/viewtopic.php?f=3&t=16443
It's used to display a nice description and screenshot in GNOME
Software. The format is documented here:
https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html
The <_name/> and <_summary/> fields match the Name= and Comment= fields
in the .desktop file so are already translated.
The screenshot is taken with Transmission 2.92 (14714) on Fedora 25.
It's at one of the sizes recommended by the GNOME Shell Screenshot
Window Sizer extension.
The <update_contact/> is based on the Git history.
2017-05-03 17:43:23 +01:00
b99fb6f07a
Add queue up/down hotkeys (GTK+ client)
2017-05-01 18:58:27 +03:00
14370e5353
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 18:47:49 +03:00
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
fbd8d4c79f
Fix a number of other style inconsistencies met along the way
2017-04-30 19:33:55 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
ecd1eb7914
Update file icon when its name changes in details dialog (GTK+ client)
...
Additionally, make main window redraw the torrent so that new name and icon
are visible right away.
2017-02-21 23:21:25 +03:00
297c734c0b
Add Keywords to the .desktop file
...
It's a part of the Desktop Entry Specification [1] and it's used by,
among others, the search system in GNOME 3.
The comment is there to hopefully minimize the chance of translators
making a mistake that could potentially break build.
[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-29 01:13:53 +01:00
5cefddeaee
Remove X-GNOME-FullName from the .desktop file
...
It's a GNOME-specific hack for the 2.x era menu system that was never
standardized in [1] and is now unused in GNOME 3.
[1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
2017-01-28 23:52:32 +01:00
5f3abbd6d8
Add myself to the list of Transmission authors
2017-01-15 01:38:45 +03:00
5b9ba3be0d
HTTPS links for trac, forum, portcheck, and build subdomains.
2016-11-02 20:50:22 +01:00
727b9671f7
Update all website links to canonical HTTPS version.
2016-10-31 10:00:11 +01:00
13bae8179e
Update all instances of the donation link. Fixes #26 .
2016-09-23 04:36:41 +02:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
1af60ad6ad
use '#pragma once' instead of #ifndef..#define..#endif guards
2016-03-29 16:37:21 +00:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
197fc132b3
Update user-facing copyright years
2016-02-27 23:18:02 +00:00
495e9b2fa0
Load icons with GResource, remove deprecated inline pixbufs
2016-02-23 04:34:57 +00:00
939b31ae3d
#6051 : `transmission-gtk --version` shouldn't require display
2016-01-09 18:06:17 +00:00
13a98a02b8
Use `TR_BAD_SIZE` instead of -1 in `tr_quark_new()` calls
...
Extend quark test to improve branch coverage.
2016-01-07 19:20:14 +00:00
4f266a5b15
Optimize URL-parsing functions a bit; rewrite `tr_urlParse()`
2015-12-28 23:52:26 +00:00
4a4badd4af
Ongoing refactoring (use size_t instead of int)
2015-12-25 10:19:50 +00:00
bfc336614e
Add libevent include directories to GTK+ client
2015-12-12 18:46:39 +00:00
b559a20029
const correctness
...
silence some qual-cast warnings by sprinkling more consts throughout,
e.g. casting a const void* to a const struct foo * const *
2015-12-06 22:13:10 +00:00
f3cebc6663
link transmission-gtk against libappindicator if necessary
2015-12-06 16:12:27 +00:00
88983c1ac1
Use tr_sys_path_remove instead of remove
2015-10-23 04:09:40 +00:00
f89fab72f9
Remove unused session tag
2015-10-18 18:39:14 +00:00
18ea8c429a
Improve RPC performance for local sessions
...
Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
2e6d5c8bc9
Add more booleans to the picture
2015-05-31 22:13:31 +00:00
cdf3cf62f9
Fix some issues revealed by coverity
2015-05-09 11:56:35 +00:00
2321bc3fad
Fix some issues revealed by coverity
2015-05-09 08:37:55 +00:00
363069ff97
#5930 : Fix style of Gtk+3.16 overshoot and undershoot (patch by nagisa)
2015-05-03 10:30:35 +00:00
06d73853b9
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
829cbffaf7
Add version info to executables (on Windows). Group projects into folders (CMake).
2015-04-14 22:46:40 +00:00
c7d2a7f959
#4400 : Add CyaSSL support
2015-01-07 02:04:08 +00:00
c43a10ab9d
Mark GTK and Qt clients as GUI programs on Windows (detach from console)
2015-01-04 10:57:09 +00:00
440f482d01
Replace tabs with spaces; remove trailing spaces
2015-01-02 11:15:31 +00:00
b928ae1ba8
Use libb64 instead of OpenSSL to encode/decode BASE64
...
Some crypto libraries (like CyaSSL, MatrixSSL and CommonCrypto) either
don't have or expose this functionality at all, expose only part of it,
or (like OpenSSL) have heavyweight API for it. Also, for the task as
easy as BASE64 encoding and decoding it's much better to use small and
simple specialized library.
2015-01-01 21:16:36 +00:00
83c4edb008
#5828 : Initial CMake build system support
2014-12-01 19:55:22 +00:00
b325bc0a16
(trunk) #5759 compilation error, undefined reference to sqrt
2014-08-20 17:14:17 +00:00
ab24ef9fcb
use pkg-config to get the zlib cflags/libs; remove obsolete zlib.m4 macro
2014-07-13 21:54:56 +00:00
0323639e57
(trunk, libT) #4160 'foreign character support' -- merge mike.dld's 4160-02b-path.patch, which updates the codebase to use the new tr_sys_path_*() portability wrappers introduced in 4160-02a
2014-07-08 00:08:43 +00:00
d7368a58f5
Copyedit the license's revised text: (1) fix accidental word concatenations in the Qt and GTK+ clients' license popup text
2014-01-21 03:15:33 +00:00
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
5f2daaafb3
(trunk, gtk/qt/web) #5581 : 'Inconsistent ordering of Upload and Download speed limits' -- fixed.
2014-01-20 23:56:06 +00:00
bf85441aab
remove '-DGTK_DISABLE_DEPRECATED' for now; we'll migrate from GtkUIManager to GtkBuilder in transmission-gtk 2.90
2014-01-20 21:30:41 +00:00
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
4c8bda8805
function pointer type correctness. mikedld
2013-09-08 17:08:18 +00:00
28fe36f1f8
#include limits.h where we use it, and don't where we don't
2013-08-24 17:53:45 +00:00
229f9e5ae6
(trunk, gtk) #5450 : in transmission-gtk's main.c::on_app_exit(), check to see if shutdown's already been initiated so that we don't call tr_sessionClose() twice.
2013-08-05 02:39:30 +00:00
33795457b1
(trunk, gtk) #5032 'gobject warning' -- fix typo introduced in r14144
2013-07-27 18:20:32 +00:00
14c0256861
(trunk, gtk) #5032 'gobject warning when updating blocklist from URL' -- fixed with patch from fanatid
2013-07-24 17:20:21 +00:00
16ab373503
(trunk gtk) #5320 'can't opena folder with '#' in its name': in gtr_open_file(), use g_file_new_for_path().
2013-07-24 17:11:21 +00:00
cc1b1cd430
since Transmission supports older versions of glib, add a portability wrapper for G_DEFINE_QUARK
2013-07-24 00:13:31 +00:00
6a47b4a5d3
don't use a '-' character in the QN argument to G_DEFINE_QUARK. https://forum.transmissionbt.com/viewtopic.php?p=65548#p65548
2013-07-22 23:00:10 +00:00
f83ff36cd5
(trunk gtk) use G_SOURCE_REMOVE where appropriate
2013-07-20 16:37:59 +00:00
7cbb20279b
use consistent code indentation/whitespace in open dialog, file list, and set location dialog
2013-07-20 16:19:15 +00:00
2d6ace29ba
(trunk, gtk) #5430 : periodic update timer in 'Torrent > Set Location...' should be cleared immediately when dialog is closed.
2013-07-20 15:55:29 +00:00
94fd3b486b
(trunk) slightly better image compression by passing them through pngwolf
2013-07-14 23:03:31 +00:00
d244545979
use G_DEFINE_QUARK instead of rolling our own quark getters
2013-07-09 22:44:24 +00:00
7f9f86c55a
fix a minor GAppInfo memory leak in transmission-gtk
2013-07-08 19:34:58 +00:00
59af132947
replace deprecated gtk_icon_info_free() calls with g_object_unref() in GTK+ >= 3.8.0
2013-07-08 16:25:18 +00:00
59f27cc1c6
remove the ShowOnlyIn=Unity desktop entries. These were from bug #4804 as an interim measure until XDG action groups were more widely supported, and can be removed.
2013-07-02 21:20:33 +00:00
a95b6c1e6c
(trunk) #5382 : better compression of our bundled png files. recompressed by Mangix
2013-06-26 02:06:43 +00:00
beeb4d3b77
(trunk, gtk) minor fix to tr_prefs_init_default() -- avoid redundant calls to g_get_user_special_dir
2013-06-12 00:22:41 +00:00
027e3f3066
(trunk, libT) #4682 'Add return id from duplicate torrent torrent-add rpc' -- added.
2013-05-22 20:35:38 +00:00
96786b7fa1
(trunk) update web.h's API s.t. there's an explicit function to use when downloading webseed content.
2013-04-13 20:25:28 +00:00
c51132ad78
#5335 : better compression of .png files by Mangix
2013-04-10 02:27:42 +00:00
0abb762ed5
segfault when opening prefs dialog in gtk+ 3.8.0
2013-04-10 02:12:19 +00:00
d1571bda02
(gtk) use replace strcmp() with g_strcmp0() everywhere
2013-02-14 15:17:42 +00:00
76a3b116f0
use g_strcmp0() instead of strcmp() to guard against corrupt settings in the config file
2013-02-10 23:06:05 +00:00
90b95697e0
(gtk) #5284 'file tree should show the wanted size of the subtree, not the entire size': done.
2013-02-09 19:28:38 +00:00
cd09204a6e
(trunk) first draft of changing the FreeSpace API to behave as https://trac.transmissionbt.com/ticket/4076#comment:25 -- libT, rpc, qt, and gtk implementations.
2013-02-09 04:05:03 +00:00
d76d2a34d9
(gtk) match transmission-qt's way of showing up & down speeds in the statusbar
2013-02-08 01:34:59 +00:00
445609f690
(trunk) prefer tr_remove() to unlink() or rmdir()
2013-02-04 21:53:19 +00:00
1a768ab06f
(gtk) #5271 'once we start shutting down the application, stop updating the Action states': more safeguards
2013-02-04 18:34:39 +00:00
2e251f73cb
(gtk) #5246 'problems when incomplete-dir is a subdirectory of download-dir': change the file chooser API calls, based on suggestion from kraai
2013-02-04 16:51:52 +00:00
0c8c2b5bdd
(gtk) #5271 'once we start shutting down the application, stop updating the Action states': fixed
2013-02-04 16:11:08 +00:00
1c90e929d1
(gtk) #4076 'free space indicator': tweak the GTK+ client's visible count label's behavior as the previous commit did for the Qt client
2013-02-02 23:01:33 +00:00
085c37584e
#4076 'free space indicator': in the Qt and GTK+ clients, add 'Free' to the freespace labels to give more context of what the number means
2013-02-01 21:02:40 +00:00
16d46a72a1
in the Qt and GTK+ clients, move the torrent count indicator from the statusbar to the filterbar
2013-02-01 20:58:55 +00:00
69f3e31230
(libT) change the API signature for tr_torrentVerify() s.t. client code can be notified when the verify is finished
2013-01-31 21:58:25 +00:00
a4bbceb483
fix r13896 oops
2013-01-30 00:28:53 +00:00
20fe66bccf
more experimentation with the shortTransferString
2013-01-30 00:22:52 +00:00
4a059b79b8
when sorting by activity and both torrents' upload and download speed is zero, use how many peers we're ready to upload to / download from as a secondary key.
2013-01-30 00:20:51 +00:00
1d3bf93618
synchronize the Qt and GTK+ client's statusbars, including the new freespace indicator. Make the up/down speed ordering consistent between statusbar and torrent list.
2013-01-27 23:05:47 +00:00
f75027d5e9
make all the log functions/structs/enums use a single 'tr_log' namespace, such as tr_logGetQueue, tr_logAddInfo, tr_logIsLevelActive
2013-01-25 23:34:20 +00:00
29d6f5d934
(gtk) #5190 'Add borders instead of shadow on scrolled window': fixed, patch by nagisa
2013-01-21 17:05:55 +00:00
dc42791380
(gtk) remember to clear out the error pointer
2013-01-21 03:18:44 +00:00
6002ffdc37
(gtk) #5235 'Plural wrong in torrent-cell-renderer' -- fix with patch by RamsesDeNorre
2013-01-21 00:15:21 +00:00
5093f99652
(gtk) silence a couple of potential GFileInfo console warnings
2013-01-20 04:10:47 +00:00
03ac81e7c7
(trunk) #1220 'change top folder names' -- add file-renaming to the GTK+ GUI
2013-01-19 08:44:23 +00:00
bff4a98fa6
(gtk) silence a g_object_unref() warning when appending '.added' to a .torrent file fails
2013-01-17 00:45:31 +00:00
c385a1559f
re-sync the GTK+ and Qt clients' prefs dialogs.
2013-01-16 21:42:03 +00:00
c4276d832e
Tweak the text of the First Time User legal dialog.
2013-01-16 20:55:08 +00:00
63fb848f3e
(gtk) in makemeta-ui.c, don't rely on g_clear_pointer()... our GLIB_MINIMUM is 2.32.0
2013-01-05 00:19:11 +00:00
5b1cd134ad
(gtk) #5211 'Transmission main window does not get focus when toggling via AppIndicator applet' -- fixed.
2013-01-04 23:25:17 +00:00
10b96f0f12
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
2a52ebab20
(gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate
2013-01-04 16:36:52 +00:00
39dfe75cea
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- remove unnecessary gdk_threads_enter() / gdk_threads_leave() pair in the TrCore prefs-changed callback
2013-01-04 07:08:25 +00:00
5877747ad6
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- on shutdown, destruct the TrCore GObject in the glib thread, and then call tr_sessionClose() from a worker thread.
2013-01-04 06:57:39 +00:00
4e0ffffbf0
(gtk) #5203 transmission-gtk shouldn't use gdk_threads_enter() and gdk_threads_leave() -- when we get an RPC notification, delegate the work back to the gtk thread.
2013-01-04 06:35:08 +00:00
fd61c3af0b
(gtk) #5207 'Simplify GTK+ client's category filter to match Qt and Web clients' -- done.
2013-01-01 19:45:00 +00:00
db721de837
(gtk) copyediting: indentation & whitespace
2013-01-01 18:43:41 +00:00
8f9e96d0ce
(trunk gtk) #5205 'GTK+ client crashes in recent trunk' -- fixed.
2012-12-31 22:37:18 +00:00
3c9640bb8f
make tr_info.webseedCount and tr_info.trackerCount unsigned.
2012-12-30 22:06:45 +00:00
ff3a6df7a6
silence console warnings when fallback icons can't be found
2012-12-27 17:49:52 +00:00
d4ab5d299f
#5185 (trunk, gtk) fix sort-by-age with patch from elhana.
2012-12-26 23:36:23 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
e0a519fe8c
(trunk, gtk) #5174 'the text field in Properties>Trackers>Edit won't resize when the dialog is resized' -- fixed.
2012-12-16 22:51:29 +00:00
aea6d7cd6f
(trunk, libT) #5168 'make libtransmission's public funcs nonblocking when possible' -- remove tr_torrentRef() and tr_torrentUnref() as discussed in https://trac.transmissionbt.com/ticket/5168#comment:8
2012-12-14 20:04:37 +00:00
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
6429093cd0
copyediting: indentation
2012-12-13 03:37:55 +00:00
61bc1eabd6
fewer redundant gobject dynamic casts
2012-12-13 03:00:57 +00:00
079c78981c
(trunk) #5168 'make libtransmission's public funcs nonblocking when possible' -- first attempt.
2012-12-12 20:22:57 +00:00
9ddd7e0166
preallocate a couple of dictionaries to the right size before using them.
2012-12-09 21:28:20 +00:00
317185750c
copyediting: more whitespace reformatting
2012-12-05 21:26:40 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
6755e4e24f
(trunk, gtk) #5089 'Open-by-URL doesn't automatically paste URLs/magnet links from the clipboard if they contain leading whitespace' -- fixed.
2012-10-13 16:47:26 +00:00
b8ef3a9acd
(trunk, gtk) #5088 'gtr_is_supported_url(), gtr_is_magnet_link() aren't NULL-safe' -- fixed.
2012-10-13 16:45:20 +00:00
7219f26dae
(trunk, T) #5072 "In the torrent list, show how many web seeds we're downloading from" -- made the Qt, GTK+, and web client text consistent
2012-10-07 17:51:56 +00:00
33c4d25f19
fix a handful of console warnings that were generated by trying to trash a NULL .torrent file b/c the torrent had been added from a URL
2012-09-23 15:38:07 +00:00
7fe9042235
fix BUILT_SOURCES and CLEANFILES for the transmission-resource files
2012-09-22 22:36:05 +00:00
00b0678904
fix warnings generated by autoreconf -Wall
2012-09-22 22:23:04 +00:00
3946dd2452
minor plural fix for cell renderer downloading metadata, patch by ajf88
2012-09-20 03:39:00 +00:00
8096c12fe0
add UI_FILES to EXTRA_DIST to see if that fixes distcheck
2012-09-19 04:52:04 +00:00
fadd8f704f
fix the build by adding transmission.gresource.xml to EXTRA_DIST
2012-09-09 06:45:50 +00:00
1966ffe4f5
load the UI from a resource file rather than a string. Patch by fmuellner
2012-09-07 17:18:17 +00:00
357b160cde
remove trailing spaces
2012-09-07 04:25:04 +00:00
f4cfc0cf56
fix tab damage
2012-09-07 04:22:21 +00:00
2c15a957d8
(trunk gtk) #4997 "missing semicolon in the desktop file" -- reported & patched by kalev
2012-08-18 15:49:24 +00:00
6a3c7f34ec
(trunk, gtk) use GtkApplication and GtkApplicationWindow
2012-07-14 22:44:41 +00:00
dfbfdbc81b
(trunk, gtk) remove the pointless TrWindow typedef
2012-07-14 22:41:33 +00:00
cdd71c6427
(trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2
2012-07-14 19:26:55 +00:00
b6e0e48927
(trunk gtk) #4892 "support Startup Notification in the GTK interface" -- fixed.
2012-07-13 19:53:59 +00:00
3398a48e57
(trunk libT) #4402 "Transmission Bandwidth allocation getting overflows" -- use gvdl's patch '4402-uint-bpsoverflow.patch'
2012-07-01 02:17:35 +00:00
5ad842b6a8
(trunk, gtk) fix #4871 'appindicator does not set its title' w/patch from seb128
2012-04-16 18:42:26 +00:00
53ea28bdf6
(trunk, gtk) fix #4867 'Some strings are not translated in Transmission in Ubuntu 12.04'
2012-04-13 14:49:34 +00:00
cf716904f9
(trunk, gtk) #4573 'fix crash when opening a torrent file on systems that don't define G_USER_DIRECTORY_DOWNLOAD'. Thanks to Felipe Contreras for the initial patch.
2012-04-08 16:02:48 +00:00
01535743a0
(trunk) improved & translatable .desktop files patch from jbicha for ticket #4804
2012-04-07 15:45:12 +00:00
fd5014aef5
(trunk gtk) fix ticket #4827 'clicking cancel in Open URL dialog does nothing'
2012-04-07 00:41:21 +00:00
32f3186f84
(trunk gtk) fix #4849 'Transmission-gtk Ignores Notification Sound Setting' with a patch from Jan Varho
2012-04-07 00:30:37 +00:00
4c8c5f578d
(trunk gtk) #4764 "filenames should have a tooltip" -- fixed with patch from gulyan
2012-03-04 13:12:42 +00:00
a3039d444d
#4804 "Add quicklist to gnome-shell and unity" -- patch applied.
2012-03-04 12:58:46 +00:00
252560ddd9
(trunk gtk) #4791 "Should catch SIGTERM instead of SIGKILL" -- fixed with patch by Matt Krai
2012-02-24 19:52:50 +00:00
e110757013
(trunk gtk) when processing log messages for the Message Log window and we encounter an error messages, pass it to g_warning() as well
2012-02-04 23:59:42 +00:00
6d4858d8dd
(trunk) #4732 "allow switching between internal and system libnatpmp" -- fixed with patch scarabeus and applied by me, so any patch breakage is probably mine... ;)
2012-02-04 01:28:15 +00:00
fbc7f3dc3c
(trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
...
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)
Flame away.
2012-02-03 21:21:52 +00:00
e599b3a738
(trunk gtk) To improve translations, help gettext to differentiate between the gerund and verb forms of some -ing words like "Seeding" and "Downloading" -- fixed.
...
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found: https://trac.transmissionbt.com/ticket/4717#comment:6
2012-02-03 17:12:17 +00:00
631a77287d
(trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…).
2012-02-03 15:51:36 +00:00
7e83c406d4
(trunk gtk) fix a minor memory leak in gtr_open_file(). reported by clang static analyzer.
2012-01-24 18:09:12 +00:00
300f070104
Silence a minor compiler warning.
...
We used to pass no button text + response_id pairs when creating the dialog because only gtk_dialog_add_button() would return back the actual button widget s.t. we could use a grab on it. However as of GTK+ 2.20 we can use gtk_dialog_get_widget_for_response() to get the button, so we can create dialogs in the more common way (which also fixes the gcc warning)
2012-01-13 22:10:26 +00:00
d524deecb0
(trunk libT) #4372 "make notification and system sounds configurable" -- instead of using notify-send, use GDBus on the org.freedesktop.Notifications API. Patch by fmuellner.
2011-12-10 19:00:50 +00:00
00757d8d33
(trunk gtk) remove dead assignment
2011-11-03 04:57:45 +00:00
8e74ccb7a1
(trunk gtk) #4605 "'--minimized' switch not working any more" -- fixed.
2011-10-30 18:27:45 +00:00
7c9fdfa8dd
(trunk) run all our pngs through "pngout.exe" and "optipng -zc1-9 -zm1-9 -zs0-3 -f0-5"
2011-10-26 16:11:21 +00:00
76cf0520ba
(trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fix About dialog issue when hiding and then re-showing Transmission.
2011-10-13 00:36:19 +00:00
6ec4aec13a
(trunk gtk) #5204 "Transmission GTK client crashes on start" -- another possible fix ;)
2011-10-11 20:32:15 +00:00
b645959eea
(trunk gtk) #4554 "Transmission GTK client crashes on start" -- possible fix.
2011-10-11 15:30:33 +00:00
55c84fa9ea
(trunk gtk) #4552 "mark primary toolbars" -- applied patch from fmuellner
2011-10-11 15:27:32 +00:00
72a021a9f3
(trunk gtk) #4553 "Set about dialog to modal when compiled with GTK+-3" -- fixed.
2011-10-11 14:36:03 +00:00
f9388714b7
(trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2
2011-10-11 04:11:08 +00:00
01f68ca846
(trunk libT) #4323 "Allow usage of system miniupnpc" -- fixed.
2011-10-09 02:05:52 +00:00
cc237aa713
#4479 'magnet links are not included in filter results' -- fixed.
2011-09-14 17:22:54 +00:00
8bbc4c7b83
(trunk gtk) #4470 "Search in torrent list is broken" -- fixed.
2011-09-12 06:11:04 +00:00
84afa05662
(trunk) Roll back the right-to-left progressbar behavior added in #4281 -- it confused too many people.
2011-09-01 22:49:35 +00:00
a7a9c2b12e
(trunk gtk) #4399 "Add option to disable 'trash can' feature" -- done.
2011-08-13 22:58:49 +00:00
6315db10f2
(trunk libT) when building unordered lists, use g_slist_prepend() instead of g_slist_append() for efficiency's sake.
2011-08-13 22:37:25 +00:00
bb41777ac7
(trunk gtk) sync the gtk+ client's watchdir behavior with the daemon's wrt r12668
2011-08-13 22:24:31 +00:00
b5de483362
(trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places.
2011-08-13 21:08:53 +00:00
c00b97169c
use a gulong when remembering the return value of g_signal_connect(). we were using a guint in some places.
2011-08-13 21:03:38 +00:00
2487f455ef
silence a warning on 64-bit machines introduced in r12669
2011-08-13 20:18:10 +00:00
38a1df9344
(trunk gtk) remove some unnecessary #includes
2011-08-13 14:19:40 +00:00
b3eb4be9b3
rename 'torrent_idle_data' as 'rpc_idle_data'
2011-08-13 14:00:33 +00:00
5adcf5d32d
(trunk gtk) minor tweak to signal_handler()
2011-08-13 13:59:50 +00:00
6f850a3d87
(trunk gtk) simplify the gtk+ client's watchdir code
2011-08-13 13:58:35 +00:00
b795aae049
(trunk gtk) move function declarations to where they're needed
2011-08-13 05:52:36 +00:00
1564405655
(trunk gtk) simplify the details dialog manager
2011-08-13 05:47:32 +00:00
825c8bf083
(trunk gtk) remove unnecessary #includes
2011-08-13 05:04:06 +00:00
0e8b5612ed
(trunk gtk) simplify the implementation of get_details_dialog_key()
2011-08-13 05:03:18 +00:00
028cfcca5a
(trunk, gtk) remove the file "marshal.list"; it's unused after r12656 / r12638
2011-08-09 15:19:11 +00:00
7ab14ad4b1
(trunk gtk) in torrent-cell-renderer and tr-core, use the _parent_class field generated by G_DEFINE_TYPE.
2011-08-09 06:31:33 +00:00
6290169099
(trunk gtk) use G_DEFINE_TYPE when implementing the tr-core and torent-cell-renderer classes
2011-08-09 05:47:24 +00:00
ee706baa7f
(trunk gtk) fix minor memory leak introduced in r12657
2011-08-09 05:22:11 +00:00
4d4eeae682
(trunk gtk) first cut at using GApplication. This lets glib replace hundreds of lines of homegrown code. Whee!
2011-08-09 02:30:31 +00:00
8d89a16f4f
remove the gtr_idle_add() portability wrapper around gdk_threads_add_idle() -- it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:10:55 +00:00
6d1869c33b
remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:06:46 +00:00
b7371264fb
fix r12638 regression caused by the difference in return values from gtr_mkdir_with_parents() and g_mkdir_with_parents()
2011-08-08 16:56:36 +00:00
7554955eb8
queuing: fix false "Error" message reported by rb07
2011-08-08 16:38:22 +00:00
abea9d306f
queuing: tweak the status messages for queued torrents
2011-08-08 16:31:52 +00:00
10aa77490a
(trunk gtk) remove an unnecessary GTK_CHECK_VERSION(2,10,0) check now that the minimum gtk+ version's been bumped
2011-08-08 16:02:37 +00:00
0e48418f26
(trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010).
2011-08-07 18:41:13 +00:00
270126820a
(trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency
2011-08-07 16:42:38 +00:00
79cb75e57d
Tweak the phrasing of the queue preferences in the Qt and GTK+ preferences dialogs
2011-08-06 16:47:14 +00:00
307754e807
#671 "torrent queuing" -- modify the queue implementation s.t. every torrent has a queuePosition, even if it's not currently in the queue.
2011-08-02 03:59:54 +00:00
2e9d419bd4
#671 "torrent queuing" -- add a tr_stat.isStalled flag.
2011-08-01 23:27:11 +00:00
61174b007e
(trunk) #671 "torrent queuing" -- Preliminary implementation. Covers libtransmission; GTK+ and Qt clients, and rudimentary web client support.
2011-08-01 22:24:24 +00:00
0faddf054b
(trunk gtk) when N torrents change their state at the same time, use an idle timer so that the UI refreshes once instead of N times.
2011-07-30 13:28:03 +00:00
9448bc5e88
(trunk gtk) #1477 "Launchpad translations need comment for strings with non-standard context" -- apply patch from okram.
2011-07-26 01:09:39 +00:00
ee20cc2b24
(trunk gtk) #4320 "Port GTK client to GTK 3." -- transmission-gtk now compiles cleanly & runs on GTK 3.
2011-07-26 01:02:32 +00:00
d6f9e85850
(trunk gtk) #4366 "Use GAppInfo, rather than GConf2, for mime-type registration" -- fix build issue in r12562
2011-07-24 16:01:14 +00:00
bb57ac3c50
(trunk gtk) #4372 "make notification and system sounds configurable" -- fixed.
2011-07-23 17:23:12 +00:00
1bf6b884b5
(trunk gtk) #4366 -- wrap register_magnet_link_handler()'s body in #if HAVE_GIO ... #endif
2011-07-20 23:33:38 +00:00
Mike Gelfand
