Commit Graph

460 Commits

Author SHA1 Message Date
Jordan Lee bd1e5b8e12 avoid unnecessary callback closures in the inspector. 2011-09-03 19:15:03 +00:00
Jordan Lee 3efa1bfba4 remove unused functions 2011-09-03 19:13:32 +00:00
Jordan Lee 2944752972 tweak r12834. I shouldn't commit when I'm tired. 2011-09-03 07:29:53 +00:00
Jordan Lee b18c1b2087 avoid closures in Transmission.refilter, to prevent cyclic references 2011-09-03 07:10:03 +00:00
Jordan Lee 9951f8af9f plug a handful of context leaks. 2011-09-03 05:12:14 +00:00
Jordan Lee f836308b42 (trunk web) better encapsulation of FileRow -- make most of its fields and methods private. transmission.js and remote.js don't know about FileRow anymore. 2011-09-03 04:33:04 +00:00
Mitchell Livingston 0db7e2d242 update jQuery to 1.6.3 2011-09-02 22:08:29 +00:00
Jordan Lee f04a9f89a4 (trunk, web) run the jquery files through a better minifier, uglifyjs 2011-09-02 21:46:13 +00:00
Jordan Lee 3b4fccadf1 (trunk web) refactor the inspector into its own class; make most of the methods private. 2011-09-02 19:29:41 +00:00
Jordan Lee f65c557048 simplify the construction of the RPC constants object. Add a context argument to remote. 2011-09-02 05:36:00 +00:00
Jordan Lee 29c225623f don't use Object.keys(), since it's not supported in IE8. 2011-09-01 17:24:49 +00:00
Jordan Lee 11ed5784e9 (trunk web) as a followup to r12802 and r12799, run the images through pngout as well. 2011-09-01 17:12:06 +00:00
Jordan Lee dcf4e53559 (trunk web) #4465 "Change WebUI 'file' icon from 'blue circle' to 'paper files'" -- fixed by copying the image from macosx/Images/ 2011-09-01 17:06:43 +00:00
Jordan Lee 2e0986756f make make happy by removing a trailing backslash that came before a blank line. 2011-09-01 14:56:00 +00:00
Jordan Lee 7f3a0c33e3 (trunk web) rename the transmission.remote.js file as remote.js 2011-08-31 22:21:22 +00:00
Jordan Lee a0d456ca9c Undoing change committed in r12789. The root problem was using jQuery.remove() in Transmission.refilter() when we needed to use jQuery.detach(). 2011-08-31 21:18:31 +00:00
Jordan Lee d6c5817ffe (trunk web) #4462 "Selecting rows on iPhone doesn't work" -- possible fix. 2011-08-31 16:23:38 +00:00
Jordan Lee 0e74c86e61 (trunk web) minor code cleanup -- fixing comments, grouping argument lists, etc. 2011-08-31 14:24:35 +00:00
Jordan Lee 2b65db86ba fix a bug in jquery.transmenu that caused popping the menu up to be very slow if there are a lot of torrents in torrent_list. 2011-08-31 14:22:28 +00:00
Jordan Lee 8a678b304a (trunk web) add minor SFX when showing/hiding the stats and prefs dialogs 2011-08-31 05:59:24 +00:00
Jordan Lee 50336ff3f1 (trunk web) #4452 "stop/start toggle button doesn't work properly on Chrome 13" -- fixed. Gunzip deserves danger pay for all this web client testing. 2011-08-31 04:39:24 +00:00
Jordan Lee 2ca39d9f7b (trunk web) remove TorrentRow's public method "torrentSet()", since the torrent is only set once in the constructor. 2011-08-31 04:37:49 +00:00
Jordan Lee 1d9ba2a21b (trunk web) #4446 "some trackerless torrents with magnet link don't update the name" -- fixed. 2011-08-31 03:31:10 +00:00
Jordan Lee 1e24f764c1 (trunk web) #4452 "Pause / Resume buttons to the right of all torrents are nonfunctional" -- fixed. 2011-08-31 01:12:04 +00:00
Jordan Lee 6a57cbc52f #4461 "wrong regular expression for HTTP user-agent" -- fixed. 2011-08-31 00:50:28 +00:00
Jordan Lee 0980112555 try to avoid unnecessary reflows in two more ways: (1) use jQuery.css() to set a batch of style properties at once, instead of doing it one at a time (2) when appending rows to the torrent list, use a document fragment to batch them into a single append. 2011-08-31 00:09:21 +00:00
Jordan Lee 49458dcb2f use jQuery.proxy where useful. 2011-08-30 21:55:44 +00:00
Jordan Lee 4984bf0274 (trunk web) decouple the inspector's dataChanged listener from the torrent list's dataChanged listener. 2011-08-30 21:40:18 +00:00
Jordan Lee e0ef0effc1 setSelectedRow(), selectRow(), deselectRow(), selectAll(), deselectAll() -- use jQuery selectors 2011-08-30 21:31:10 +00:00
Jordan Lee 0c221893d3 (trunk web) in tr.refilter(), instead of calling the expensive tr.getSelectedRows(), use a cheaper jQuery equivalent. 2011-08-30 21:27:30 +00:00
Jordan Lee c44ce249d2 (trunk web) use String.localeCompare() instead of rolling our own compareTo() function. 2011-08-30 07:27:59 +00:00
Jordan Lee af1d2b76c0 now that refiltering is faster, shrink the delay between torrent updates and refiltering 2011-08-30 05:49:23 +00:00
Jordan Lee e940ab815f (trunk web) run 'em through optipng too, at jdhore's suggestion 2011-08-30 04:58:59 +00:00
Jordan Lee 8d90bcee39 (trunk web) Remove the "inspector is open" cookie. It doesn't make sense for the inspector to be open when we first open the app, since there will be no torrent selection anyway. 2011-08-30 04:54:37 +00:00
Jordan Lee f6bcaad44b (trunk web) #4452 "'Remove from List' doesn't update unless you manually refresh the page" -- fixed. 2011-08-30 04:27:09 +00:00
Jordan Lee 3eabe4517d (trunk web) run the png files through pngcrush to make them a little smaller 2011-08-30 03:24:31 +00:00
Jordan Lee 03b5f7e4da fix accidental tab indentation damage in r12797 2011-08-30 02:57:00 +00:00
Jordan Lee b23131a5b4 (trunk web) #4452 "file list not refreshing" -- instead of only requesting file info for the inspector when the inspector is opened (and also when torrent selection changes while the inspector is open), keep re-requesting the file info util we've got it. That way if the first request fails, we'll pick it up on subsequent updates. 2011-08-30 02:49:01 +00:00
Jordan Lee 27c6f96271 (trunk web) #4460 "Weird behavior when using up/down keys" -- fixed. 2011-08-30 02:03:17 +00:00
Jordan Lee 895f8ca465 (trunk web) #4459 "Remove 'Compact View' from the action menu" -- done. 2011-08-30 01:54:34 +00:00
Jordan Lee 05155db22c (trunk web) make the corners of the footer buttons handle transparency. 2011-08-30 00:16:34 +00:00
Jordan Lee e23697142e (trunk web) remove some redundant css rules that have no effect on FF, Chrome/Chromium, and IE. 2011-08-29 21:50:14 +00:00
Jordan Lee c1013ff1a4 in transmission.updateFileList(), move the var declarations to the front of the function. 2011-08-29 21:12:05 +00:00
Jordan Lee 4803b12a09 #4452 'Error: file.name is undefined' at file-row.js line 113 -- fixed. 2011-08-29 21:07:50 +00:00
Jordan Lee 2ef53ca5dd #4455 'Action on N>1 torrents doesn't work properly in web interface' -- when right-clicking in the torrent list, don't change the selection if the row we're hovering over is already selected. 2011-08-29 20:29:45 +00:00
Jordan Lee 92babd4141 #4455 'Action on N>1 torrents doesn't work properly in web interface' -- fix bug in jquery.contextmenu that clobbered jQuery.delegate bindings. 2011-08-29 20:28:19 +00:00
Mitchell Livingston 50c03d585d (trunk web) selecting the up arrow when no transfers are selected selects the bottom transfer; eliminate an error when pushing the up/down arrow keys with a blank torrent list 2011-08-28 19:30:17 +00:00
Jordan Lee 246df2b3e7 ...and in Makefile.am, too. 2011-08-28 17:28:05 +00:00
Jordan Lee 2faba73c5b (trunk web) rename "iphone" variables and css files as "mobile", since they also work on iPods and Android phones. 2011-08-28 17:24:56 +00:00
Jordan Lee 6d4a7a2f10 (trunk web) fix event propagation in keypress events 2011-08-28 16:33:22 +00:00
Jordan Lee f8195180ba (trunk web) fix regression that broke toolbar refresh 2011-08-28 15:16:54 +00:00
Jordan Lee 1d69770227 fix progressbar color regression 2011-08-28 14:57:13 +00:00
Jordan Lee dd2033107f (trunk web) migrate from json.js to json2.js. <http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/> 2011-08-28 14:51:49 +00:00
Jordan Lee e6b8b0339e (trunk web) code futzing: (1) fix mixed tab & space use (2) try to declare local variables at the front of the function, since there is no block scope in javascript. 2011-08-28 13:57:25 +00:00
Jordan Lee ab7fe4470e remove dead code 2011-08-28 06:20:32 +00:00
Jordan Lee 228e1064e1 (trunk web) add context arguments for the RPC methods' callbacks. 2011-08-28 06:05:46 +00:00
Jordan Lee 02c0f7355b (trunk web) some cleanup for r12770 -- better handling of the rebuildEverything flag in Transmission.refiler(). 2011-08-28 04:14:58 +00:00
Jordan Lee c639211f66 (trunk web) when mousing over the turtle or compact buttons, turn the cursor into a pointer. 2011-08-28 04:12:31 +00:00
Mitchell Livingston f2f0dc1861 (trunk web) fix selecting files 2011-08-27 21:42:34 +00:00
Jordan Lee 4c1f32836f (trunk web) in Transmission.refilter(), only refilter/resort the torrents that have changed since the last update. This makes the web client scale reasonably well even up to 1000s of torrents. 2011-08-27 21:35:19 +00:00
Jordan Lee fbaab34ec6 (trunk web) remove dead function call. 2011-08-27 02:48:06 +00:00
Jordan Lee 9cb9fd56d9 (trunk web) slightly faster Transmission.refilter(). Modify Transmission.refreshFilterPopup(), Torrent.getCollatedName(), and Torrent.getCollatedTrackers() for clarity. 2011-08-27 00:22:56 +00:00
Jordan Lee 4517155353 (trunk web) better bootstrapping when first loading all the torrents. 2011-08-26 23:34:43 +00:00
Jordan Lee 8949fbb01c (trunk web) Stop poking the torrent-row's progressbar's style.display fields unless the new value differs from the old. It's probably browser-dependent on whether or not this speeds anything up, but FF seems to like it. 2011-08-26 23:30:07 +00:00
Jordan Lee 354a92c73d (trunk web) safeguard against exceptions when sorting-by-name when a torrent's name hasn't yet finished downloading. 2011-08-26 22:59:42 +00:00
Jordan Lee 5715bae7fd (trunk web) Reduce the torrent-get RPC wrapper down to a single function. Annotate the torrent bootstrap process in Transmission.js. 2011-08-26 22:49:57 +00:00
Jordan Lee 6f8be90491 remove unnecessary field test 2011-08-26 21:51:14 +00:00
Jordan Lee ac73391524 (trunk web) tweak the font sizes for the torrent list in compact mode 2011-08-26 20:21:22 +00:00
Jordan Lee 05ce6674b6 (trunk web) in the statusbar, don't show idle speeds 2011-08-26 20:02:40 +00:00
Jordan Lee 6cff13feba fix r12756 oops 2011-08-26 19:59:26 +00:00
Jordan Lee a1094bafe4 (trunk web) another minor network/memory win: remove more fields that we don't use. 2011-08-26 19:47:23 +00:00
Jordan Lee 57962e7a60 (trunk web) simplify the periodic RPC request for info on recently-changed torrents 2011-08-26 19:42:07 +00:00
Jordan Lee c113975ec9 (trunk web) a batch of code cleanups that were too minor for individual commits 2011-08-26 18:36:09 +00:00
Jordan Lee 8192c38fcc (trunk web) remove an unneccesary field: the "trackerStats" field is a superset of of the "trackers" field, so our Torrent objects don't need to keep both -- the former can replace the latter. 2011-08-26 18:10:53 +00:00
Jordan Lee f744bb583c (trunk web) don't request the torrentFile field -- we don't use it 2011-08-26 17:56:49 +00:00
Jordan Lee 40b2cb4513 (trunk web) minor network traffic improvement: Transmission.js was periodically requesting redundant "Torrent.Fields.Stats" fields for selected torrents. 2011-08-26 17:34:09 +00:00
Jordan Lee 5e701872a7 (trunk web) lazy-create Torrent's collatedName and collatedTrackers fields. 2011-08-26 01:58:12 +00:00
Jordan Lee e081ecbd12 (trunk web) minor code sorting in Transmission.js: group the inspector functions together 2011-08-26 01:46:07 +00:00
Jordan Lee 6c02ff1012 (trunk web) when compact mode is toggled, force the torrent list to rebuild even if no torrents have changed 2011-08-26 01:27:16 +00:00
Jordan Lee e1641792e9 (trunk web) in Transmission.refilter(), don't rebuild the row array if the filtered + sorted list of torrents hasn't changed. This is a big CPU win on large torrent lists. 2011-08-26 00:43:35 +00:00
Jordan Lee ab7305fe64 (trunk web) fix issue with the "open torrent" dialog being covered by the inspector 2011-08-25 23:24:49 +00:00
Jordan Lee 3f7540675e (trunk web) significant shrinkage of our memory + network footprint by only loading torrent's fields when they're needed. 2011-08-25 23:06:41 +00:00
Jordan Lee 7bccb21bd9 (trunk web) remove an unnecessary link from the torrents' file objects to the torrent object that "owns" it 2011-08-25 12:04:20 +00:00
Jordan Lee ac86d3d740 (trunk web) fix accidental global variable introduced in r12742 2011-08-25 11:25:13 +00:00
Jordan Lee 398ee0cc18 (trunk web) #4271 "selecting multiple files with shift-arrow doesn't work" -- fixed. 2011-08-25 10:23:19 +00:00
Jordan Lee dd762bc7ea (trunk web) remove cruft from Transmission.onRowClicked() 2011-08-25 09:21:05 +00:00
Jordan Lee 00dfd6ce67 (trunk web) simplify the prefs tab selection code 2011-08-25 08:03:19 +00:00
Jordan Lee 465d57eb71 (trunk web) remove a handful of unnecessary wrapper functions. 2011-08-25 07:15:38 +00:00
Jordan Lee 2cff49a247 (trunk web) #4444 "'Show Transfers' missing Seeding category" -- fixed. 2011-08-25 06:26:07 +00:00
Jordan Lee f2b255a33d (trunk web) #4443 "progress bar colors for queued transfers" -- fixed. 2011-08-25 06:18:42 +00:00
Mitchell Livingston 741f3190dc (trunk web) adjust common.css 2011-08-25 04:06:08 +00:00
Mitchell Livingston e77b81c14e (trunk web) r12732 for the iphone 2011-08-25 04:04:13 +00:00
Mitchell Livingston 14f655285a (trunk web) for non-active seeds (paused or queued), draw the whole bar gray (r12731 was only for paused) 2011-08-25 03:27:33 +00:00
Mitchell Livingston f4ee57253a (trunk web) show the dark green bar for the complete side of the seeding progress bar, and the light green bar for the incomplete side 2011-08-25 02:50:47 +00:00
Mitchell Livingston ad5788feae (trunk web) for paused seeds, for the entire progress bar to be gray instead of only the finished-seeding section 2011-08-25 02:42:56 +00:00
Mitchell Livingston cee1bfd139 (trunk web) allow select all/deselect all in the files table when there's only a single file changed 2011-08-24 23:51:07 +00:00
Jordan Lee 2d0a59954a (trunk web) #4273 "Display ratio in web client compact view" -- fixed. 2011-08-24 19:20:59 +00:00
Jordan Lee e0410cd17b (trunk web) when sorting by ratio, use tr_stat.ratio rather than deriving it ourselves. 2011-08-24 19:20:22 +00:00
Jordan Lee 2da83079f9 (trunk web) #4438 "Add tooltip for peer status in web interface" -- patch by niol 2011-08-24 18:42:10 +00:00
Jordan Lee 296a2064f7 (trunk web) #4442 "WebUI doesn't update after performing 'Remove From List' - r12723" -- fixed. 2011-08-24 17:04:59 +00:00