Commit Graph

3231 Commits

Author SHA1 Message Date
Charles Kerr 057b80a9f9 (trunk libT) "tr_torrentSetAnnounceList() should not trigger reannounces to trackers" -- implemented in trunk for 1.90 2010-02-13 21:58:38 +00:00
Charles Kerr c0cf694b85 (trunk libT) optimize out some unnecessary cycles when there are missing files in a torrent being verified 2010-02-13 05:46:31 +00:00
Charles Kerr adc7d6f8a4 (trunk libT) minor tweak to verify: use tr_pread() instead of lseek+read 2010-02-12 21:06:21 +00:00
Charles Kerr d3ae2cf696 (trunk libT) use valloc() and st.st_blksize when verifying local data 2010-02-12 19:59:30 +00:00
Charles Kerr a694ac185c (trunk libT) #2982 "changing port number doesn't actually change until program restart" -- fixed in trunk for 1.90 2010-02-12 04:57:40 +00:00
Charles Kerr 8aa62240f8 (trunk libT) fix memory leak when trying to add duplicate torrents. thanks valgrind! 2010-02-12 04:13:51 +00:00
Charles Kerr b7b5a0e427 (trunk) #2894 "tr_torrentGetFileDL() and tr_torrentGetFilePriority() should go away" -- get rid of it in the mac client and libtransmission too 2010-02-11 15:05:07 +00:00
Charles Kerr 13b03ba195 (trunk libT) #2892 "changing port number doesn't actually change until program restart" -- possible fix 2010-02-11 14:28:40 +00:00
Charles Kerr 7c013c61c1 (trunk libT) tweak the shutdown code 2010-02-11 04:07:13 +00:00
Charles Kerr 5c9cd2c2db (trunk libT) revert part of r10064 at livings' request 2010-02-11 03:12:03 +00:00
Mitchell Livingston 9407b5f0f0 chop off a bit of text in an announce error message 2010-02-11 02:52:54 +00:00
Charles Kerr e03ad192c7 (trunk libT) demote the "Got N peers from tracker" and "Found N peers from DHT" messages from info to debug... there are just too many of them 2010-02-11 01:20:43 +00:00
Charles Kerr 7e28c375c9 (trunk libt) when generating json/benc strings, preallocate some space in the evbuffer to avoid excess realloc()s 2010-02-11 00:53:50 +00:00
Charles Kerr c35d4696ee (trunk libT) re-add the supportcrypto, requirecrypto announce arguments that were removed during announce testing in r10090 2010-02-11 00:43:47 +00:00
Charles Kerr 9fffb2be35 (trunk libT) Yippie, plug a small memory leak reported by valgrind! 2010-02-10 05:27:14 +00:00
Charles Kerr a95aae5591 (trunk) as promised, remove the announce logging code. now safe for general-purpose nightly build testing again. 2010-02-10 04:50:21 +00:00
Charles Kerr 42fcfbe804 (trunk libT) try to fix the mac build. This commit still has the announce logging code. 2010-02-10 04:42:34 +00:00
Charles Kerr acc8e64102 (trunk) another test build that logs tracker announces to a file in /tmp, so you probably shouldn't use it unless I've asked you to. After hudson-t is done building a debug dmg of this, I'll commit r10155 to remove the logging code 2010-02-10 04:35:59 +00:00
Charles Kerr 7efdd92f86 (trunk libT) oops, a couple of debugging printf()s snuck into the commit 2010-02-10 03:57:41 +00:00
Charles Kerr 2cbfe53717 (trunk libT) #2887 "dangling pointer in 1.81" -- fixed in trunk for 1.90 / 1.8x 2010-02-10 03:26:19 +00:00
Charles Kerr 2472970c53 (trunk libT) fix 1.82 memory corruption error reported by john doe 2010-02-10 02:59:15 +00:00
Charles Kerr 8ba3442408 (trunk libT) fix the &event= key when telling the tracker that a partial seed is being stopped 2010-02-09 21:51:11 +00:00
Charles Kerr a8a5a6cae5 (trunk) revert that last commit, which was only intended for about a dozen people. Unless you're one of them (and you don't know, then you're not) DON'T USE r10145. r10145 -- **ONLY** r10145 -- stored user's tracker announces to a logfile in /tmp. 2010-02-09 02:46:40 +00:00
Charles Kerr 8e51476258 pulling my hair out.... gaaaah 2010-02-09 01:47:16 +00:00
Charles Kerr 5a3f55c7dc (trunk libT) #2874 "Since 10094 The Schedule Speed Limit Not Working" -- fixed regression reported by bebbo 2010-02-08 19:21:07 +00:00
Charles Kerr 1724553212 (trunk) per-tier up/down/corrupt byte counts for announcing to trackers 2010-02-08 16:47:30 +00:00
Charles Kerr d1b282b647 (trunk libT) remove dead code. 2010-02-08 13:59:13 +00:00
Charles Kerr 9194325c95 (trunk libT) messages about SO_SNDBUF size and file preallocation should probably be debug messages rather than visible-by-default info messages... 2010-02-08 04:43:56 +00:00
Charles Kerr 0ea501355e (trunk daemon) #2877 "Don't let the daemon launch if settings.json is corrupt" -- implemented in trunk for 1.90 2010-02-07 22:17:42 +00:00
Charles Kerr 5134dd8966 (trunk libT) #2874 "Since 10094 The Schedule Speed Limit Not Working" -- fixed in trunk for 1.90 2010-02-07 17:13:38 +00:00
Charles Kerr 95a4adfd22 (trunk libT) #2745 "Crash with tr_sessionSetPortForwardingEnabled()" -- fixed in trunk for 1.90 2010-02-06 20:25:25 +00:00
Charles Kerr 5a69330344 (trunk libT) when we can't bind to a port and the error is EADDRINUSE, add a parenthetical hint "(Is another copy of Transmission already running?)" 2010-02-06 14:43:28 +00:00
Charles Kerr ef6d874c57 (trunk libT) #2716 "magnet torrents not being saved after quit" -- fix regression reported by RolCol @ http://trac.transmissionbt.com/ticket/2716#comment:8 2010-02-06 05:22:27 +00:00
Charles Kerr 74e3484e75 (trunk) add a new field to distinguish from error messages returned from the tracker, and announce timeouts, so that they can be displayed differently 2010-02-05 05:16:18 +00:00
Charles Kerr 8b3fb8a5e8 (trunk libT) #2854 "`tracker did not respond' errors" -- lengthen the time we wait before timing out. This was shortened not too many releases ago to prevent a logjam from dead tpb tracker announces; however, we now have better ways of doing that and the short deadline may be contributing to the "did not respond" errors. 2010-02-05 04:54:08 +00:00
Charles Kerr 7519f51fe9 (trunk libT) #2854 "Tracker did not respond" -- when calculating the interval to wait before retrying a failed announce or scrape, take into account that tracker's responses to other torrents' announces/scrapes 2010-02-05 01:47:33 +00:00
Charles Kerr b3d0309034 (trunk libT) #2854 "tracker did not respond" -- when both scrapes and announces are vying for a turn, give announces a higher priority 2010-02-05 01:16:30 +00:00
Charles Kerr c0da8ffb86 (trunk libT) fix turtle mode bug introduced in r10093 2010-02-05 00:45:49 +00:00
Charles Kerr 7579a8a5d2 (trunk libT) #2584 "Checks for AltTime (turtle mode) start and stop and may be missed" -- fixed in trunk for 1.90 2010-02-04 23:39:50 +00:00
Charles Kerr fbddf853b0 (trunk libT) fix possible null pointer dereference reported by wereHamster 2010-02-03 14:43:39 +00:00
Charles Kerr 168770f508 (trunk libT) #2716 "magnet torrents not being saved after quit" -- fix bencode bug. 2010-02-03 14:31:12 +00:00
Charles Kerr d118db0f37 (trunk libT) remove dead announce fields like supportscrypto and requirescrypto. these don't appear to be supported by any of the major clients so why waste the announce bandwidth... 2010-02-03 06:32:14 +00:00
Charles Kerr 5014319622 (trunk libT) experimental commit for faster tracker announces 2010-02-03 03:38:13 +00:00
Charles Kerr 9489762d26 (trunk libT) remove the last two experimental commits... nightly users, it's probably safe to use svn again. or at least as safe as usual... ;) 2010-02-03 01:00:08 +00:00
Charles Kerr 825d5c3a5a (trunk libT) this is an experimental commit for a debugging session with people who don't have access to build tools. unless you're one of those testers, or unless you enjoy not connecting to peers, you DO NOT WANT TO USE THIS REVISION 2010-02-03 00:39:27 +00:00
Charles Kerr bdb706edb9 (trunk libT) this is an experimental commit for a debugging session with people who don't have access to build tools. unless you're one of those testers, you might not want to use this revision. 2010-02-03 00:28:07 +00:00
Charles Kerr 30f85172c4 (trunk libT) taper off the number of new connections per pulse per torrent based on how long the torrent's been running. Brand-new torrents get a higher burst of new peer connection attempts, but long-running torrents don't need that kind of activity. 2010-02-03 00:12:19 +00:00
Charles Kerr 36d97610bd (trunk) #2802, #2716, #2717 -- remember magnet links and their settings between sessions, and allow their trackers to be modified 2010-02-02 22:45:22 +00:00
Charles Kerr b9e8624b3c (trunk daemon) #2751 "display-remote -si should show config directory" -- implemented for 1.90 2010-02-02 18:27:57 +00:00
Charles Kerr 54f874ffb1 (trunk) fix oops... 2010-02-02 08:10:28 +00:00
Charles Kerr 094f76d9ca (trunk libT) #2846 "Priority Selection in `Add' Window" -- added RPC hooks for doing this via remote client 2010-02-02 07:48:03 +00:00
Charles Kerr de2d0154e7 (trunk libT) #2849 "When possible, use fallocate64() for file preallocation" -- implemented for 1.90 2010-02-02 03:01:25 +00:00
Charles Kerr e62be48baa (trunk libT) don't scrape paused torrents 2010-02-02 02:59:40 +00:00
Charles Kerr f7c98630d7 (trunk libT) #2720 "Misleading error message when adding a duplicate magnet transfer" -- add a public API call in libtransmission for testing to see if we already have a magnet link as a torrent 2010-02-02 01:15:26 +00:00
Charles Kerr 42f63a63d3 (trunk libT) #2505 "Transmission loses config when disk is full" -- better implementation than r10068's from suggestions by elbandi 2010-02-02 01:05:27 +00:00
Mitchell Livingston 205b21dca3 add a convenience function for determining if an address is an IP address, and when picking a favicon in the Mac UI's tracker tab, use the full IP address when applicable 2010-02-01 23:52:46 +00:00
Charles Kerr 8f0f6679aa (trunk libT) #2505 "Transmission loses config when disk is full" -- implemented in trunk for 1.90 2010-02-01 21:09:31 +00:00
Charles Kerr 92f67263ee (trunk, libT) #2844 "add able to disable '.part' suffix for incomplete files" -- added to GTK+ and Qt clients and to RPC spec for 1.90 2010-02-01 04:43:10 +00:00
Charles Kerr dd9da625d1 (trunk libT) a better way to ignore peerCount from `stopped' responses 2010-02-01 03:49:59 +00:00
Charles Kerr 13179c5363 (trunk libT) ignore the peer count from `stopped' responses when calculating lastAnnouncePeerCount 2010-02-01 03:39:54 +00:00
Charles Kerr 7cb57b8480 (trunk libT) don't reset lastAnnouncePeerCount when stopping a torrent. 2010-02-01 01:13:25 +00:00
Charles Kerr f071f0ccea (trunk libT) another announcer tweak related to #2828 -- keep the last known good value of lastAnnouncePeerCount even if subsequent announces fail 2010-02-01 00:35:38 +00:00
Charles Kerr 9423821e7a (trunk libT) #2828 "Better reporting of announce timeouts in tr_tracker_stat" -- implemented in trunk for 1.90 2010-02-01 00:28:04 +00:00
Charles Kerr 02ffbe75e4 (trunk libT) #2778 "IPv6 accepts garbage addresses" -- fix typo reported by chris-jerichio @ http://trac.transmissionbt.com/ticket/2778#comment:16 2010-01-31 17:15:05 +00:00
Charles Kerr dcbb1ee872 #2778 (IPv6 PEX accepts garbage addresses) -- accept petch from jch to reject IPv6 addresses outside of 2000::/3 until the end of the 13th Baktun 2010-01-31 00:23:31 +00:00
Charles Kerr 8fc6e6a0f5 (trunk libT) #2656 "download speed limit of 0 is not honored" -- fixed in trunk for 1.90 2010-01-30 00:43:31 +00:00
Charles Kerr 63bca0fad4 (trunk libT) #2823 "crash in bsearch() while updating blocklist" -- fixed in trunk for 1.90 2010-01-29 18:10:50 +00:00
Charles Kerr 70e3e7156c (trunk libT) #2833 "LP64 bug on OpenBSD" -- fixed in trunk for 1.90 2010-01-29 18:07:21 +00:00
Charles Kerr 73deb80e77 (trunk libT) if a tracker doesn't respond during an announce, instead of automatically reannouncing in 120 seconds, add some fuzz to the interval. Rationale: if a bunch of torrents announce at once, overloading the router or server, they'll still be overloading it if we do the exact same thing the second time around... 2010-01-28 19:33:48 +00:00
Charles Kerr 931558aea3 (trunk libT) fix DNS timing issue reported by gn0s1s in irc 2010-01-28 18:25:18 +00:00
Charles Kerr dd41b5c257 (trunk libT) #2819 "announce URLs containing raw IP addresses won't announce/scrape in 1.82" -- possible fix 2010-01-28 17:24:23 +00:00
Charles Kerr a334b422c3 (trunk) remove unnecessary #includes 2010-01-28 13:33:40 +00:00
Charles Kerr ce5f82f413 (trunk libT) add a "const" to tr_ptrArrayRemove()'s second argument to silence a compiler warning 2010-01-28 13:31:54 +00:00
Charles Kerr a888c4d425 (trunk libT) web.c: add a cache for unresolvable hostnames 2010-01-27 06:40:12 +00:00
Charles Kerr 9c0900eb20 (trunk libT) possible fix for gn0s1s' "file not found" error message 2010-01-26 21:41:40 +00:00
Charles Kerr 6e8cc99374 (trunk libT) #2800 "crashing during operation" -- if a peer sends an out-of-bounds "have piece" message, drop the connection 2010-01-26 20:38:04 +00:00
Charles Kerr 3c02127a13 (trunk libT) #2800 "crashing during operation" -- use type correctness suggestion from kim wrt int --> size_t in bitset.h 2010-01-26 07:50:17 +00:00
Charles Kerr 3ace0afaae (trunk libT) #2792 "since 1.80 update downloads failing" -- try to handle non-resolving tracker addresses without blocking in curl 2010-01-26 07:22:50 +00:00
Charles Kerr ea36b9b888 (trunk libT) make "tr_globalAddress" a private function 2010-01-25 07:35:38 +00:00
Charles Kerr f010687d81 (trunk libT) #2792 "Since 1.80 update downloads failing" -- a better fix than r10015... 2010-01-25 05:19:54 +00:00
Mitchell Livingston 48d8d43c92 #2765 ignore case when ordering the file list in a newly-generated torrent file 2010-01-25 05:06:54 +00:00
Charles Kerr bfbc126ea0 (trunk libT) #2792 "Since 1.80 update downloads failing" -- fixed in trunk for 1.83 2010-01-25 04:54:04 +00:00
Charles Kerr c2adab97b2 (trunk libT) fix typo from prev commit 2010-01-25 04:26:08 +00:00
Charles Kerr 4164b17977 (trunk libT) extend the lifespan of the cached DNS entries 2010-01-25 04:24:48 +00:00
Charles Kerr 1d1b09b75b (trunk libT) #2804 "segmentation fault add-by-url when url scheme is ftp" -- fixed in trunk for 1.83 2010-01-25 04:00:08 +00:00
Charles Kerr 38fdcd5835 (trunk libT) (1) on startup, stagger new torrents' scrapes. (2) reduce the minimum number of block requests to peers. 2010-01-25 02:19:20 +00:00
Charles Kerr ae966e0725 (trunk libT) increase the announce timeout from 30 seconds to 45 seconds. 2010-01-24 23:32:49 +00:00
Charles Kerr 7e5e4db797 (trunk libT) #2783 "blocklist is empty" -- fix this 1.82 regression. apparently update.transmissionbt.com doesn't like it when you make the ":80" in the Host: header explicit instead of implicit... so probably other web servers have the same problem too. 2010-01-24 19:22:22 +00:00
Charles Kerr d97a04b001 (trunk libT) when adding the Host: header by hand, make include the host's port 2010-01-23 07:51:51 +00:00
Charles Kerr 2be24ec9a8 (trunk libT) #2783 "starting with r9992, IP blocklist is empty" -- when replacing a URL's hostname with an IP address before passing the URL to curl, manually set the Host: header to the original hostname. (Xref: #2781) 2010-01-22 07:27:19 +00:00
Charles Kerr 0f6214d9ae (trunk libT) if we're calling evdns_init(), we probably ought to call evdns_shutdown() on exit... 2010-01-22 03:39:21 +00:00
Charles Kerr 1f44272678 (trunk libT) #2781 "1.80 freezes on startup" -- possible fix. implement nonblocking dns before we hand the URLs over to libcurl 2010-01-22 02:40:11 +00:00
Charles Kerr e26a1783c6 (trunk libT) #2777 "some magnet links get misparsed" -- fixed in trunk for 1.81 2010-01-21 05:10:00 +00:00
Charles Kerr 0faaaeaa9a (trunk libT) #2756 "32 byte leak in tr_threadNew()" -- fixed for 1.81 2010-01-21 03:14:46 +00:00
Charles Kerr 1c8426cfee (trunk libT) fix some #include statements 2010-01-20 23:58:09 +00:00
Charles Kerr 649819d1be (trunk libT) fix tiny typo in previous commit... :/ 2010-01-20 20:25:13 +00:00
Charles Kerr 2dce44fbe7 (trunk libT) still too wordy 2010-01-20 20:15:23 +00:00
Charles Kerr 5b1af96165 (trunk libT) #2676 "Transmission writes to non-existent drive in '/Volumes'" -- we're already stopping the torrent when the local data disappears, but let's add a more explicit and helpful error message to help users diagnoses the problem. 2010-01-20 20:08:12 +00:00
Charles Kerr 8e16b74dad (trunk libT) #2775 "Saving some memory/storage" -- committed for 1.80 2010-01-20 18:48:52 +00:00
Charles Kerr 8a49d60f6f (trunk libT) tweak the last commit -- use strncmp() instead 2010-01-20 18:41:22 +00:00
Charles Kerr 7c29d46daa (trunk libT) #2771 "Unable to add magnet URI from Mininova via web interface" -- fixed for 1.80 2010-01-20 18:15:09 +00:00
Charles Kerr 9eb07e9b16 (trunk) No code changes here... filling in some of the blanks in the "peers" and "utils" doxygen groups' documentation. 2010-01-19 19:37:00 +00:00
Charles Kerr 5b4ec24deb (trunk libT) tweak the peer-io bugfix 2010-01-18 19:26:46 +00:00
Charles Kerr fd9021b655 (trunk libT) #2416 "crash in event_queue_insert()" -- this crash is definitely happening when we call event_del() twice on the same event without an event dispatch pass between the two calls. Start nailing down every possible case where that could happen in libtransmission 2010-01-17 19:21:04 +00:00
Charles Kerr 62c77900aa (trunk libT) add assertion to crash if tr_rpcSetPort() is called on a NULL RPC Server 2010-01-16 22:46:38 +00:00
Charles Kerr bf08de36d9 (trunk libT) remove the r9933 assertions and maybe fix Yada's bug 2010-01-15 00:20:48 +00:00
Charles Kerr e1005726a2 (trunk libT) add in some assertions to try & smoke out Yada's crash 2010-01-14 21:37:27 +00:00
Charles Kerr 616c09156a (trunk libt) #2755 "assert( session->fdInfo != NULL ) in tr_fdTorrentClose() is failing" -- fixed for 1.80 2010-01-14 14:22:43 +00:00
Charles Kerr 6ce8085243 (trunk) housekeeping: (1) add standard svn properties for $Id$ substitution in some files (2) add #include guards in a couple of libtransmission headers (3) refresh build instructions in README 2010-01-14 14:20:49 +00:00
Mitchell Livingston aac5e5cb61 add to RPC info for peers from DHT and LTEP 2010-01-14 00:25:03 +00:00
Charles Kerr de82e235af (trunk) second half of r9927.... :/ 2010-01-13 22:46:22 +00:00
Charles Kerr a77770a51a (trunk) add tr_torrent_stat.id to RPC documentation. Rename tr_tracker_stat.identifier as tr_tracker_stat.id for consistency with tr_torrent.id 2010-01-13 22:40:07 +00:00
Charles Kerr 86a5e6be8a (trunk libT) fix assertion-on-shutdown failure reported by livings 2010-01-13 01:21:26 +00:00
Charles Kerr 4b0c1ea332 (trunk libT) #2705 "speeding up request queue management" -- committed v1.1.diff for 1.80 2010-01-12 20:17:22 +00:00
Charles Kerr 5decc9ffb1 (trunk) add a log message telling the user which configDir is being used and whether or not its settings.json was used 2010-01-12 16:43:37 +00:00
Charles Kerr fae3516d4b (trunk libT) #2750 "Crash on quit r9862 in TrCloseFile" -- fixed for 1.80 2010-01-11 18:26:29 +00:00
Charles Kerr e2feb075b9 (trunk libT) reinstate proxies in the http announce 2010-01-10 20:15:56 +00:00
Charles Kerr 2ac553361a (trunk libT) #2416 "crash in event_queue_insert" -- I think this is happening if we queue up two changes, one to listen for read/write, and then a second one to delete the polling, in kqueue's event mechanism, at libcurl's request. Let's try disabling kqueue in libevent and use poll/select instead. 2010-01-10 19:52:01 +00:00
Mitchell Livingston da06bc054f take a shot at #2715 - modular division on a negative number doesn't return a positive 2010-01-10 16:26:56 +00:00
Mitchell Livingston 14da64ec06 assorted small cleanup and log removal 2010-01-10 16:26:30 +00:00
Mitchell Livingston 5af45426d4 random code optimization: when escaping http, use an if with a lot less comparisons rather than a switch 2010-01-10 14:56:04 +00:00
Mitchell Livingston 8f6e1dedf5 revert r9505, which appears to cause a crash on launch 2010-01-10 14:36:53 +00:00
Charles Kerr 5a60e4549d (trunk libT) #2416 "crash in event_queue_insert" -- another guess, based on the idea that we might queue two actions (one to insert, one to delete) on the same event before libevent's dispatcher is invoked 2010-01-10 08:53:17 +00:00
Mitchell Livingston d81389da50 add rpc fields for the tracker identifier stats 2010-01-10 04:23:09 +00:00
Charles Kerr 0f19dbd600 (trunk libT) #2740 "sefault in torrent creating" -- fixed for 1.80 2010-01-10 02:40:22 +00:00
Mitchell Livingston 6138daec3f add an identifier to trackers, for use by the ui's (this should hopefully fix the problem for removing trackers with "invisible" trackers) 2010-01-10 02:34:00 +00:00
Charles Kerr 69cb1362e3 (trunk libT) #2416 "crash in event_queue_insert" -- see if we can get the program to crash in a different way. 2010-01-09 07:27:45 +00:00
Charles Kerr 6076d7c6bd (trunk libT) add <stdarg.h> call before <evutil.h> to get 1.80 building on Fedora 11 2010-01-09 07:24:47 +00:00
Charles Kerr 0bb355d8df (trunk libT) #2416 "crash in event_queue_insert" -- continue throwing the kitchen sink at this ticket. (1) disable proxies to see if that makes any difference (2) rearrange the sequencing in sock_cb() to unconditionally delete the active event before doing anything else (3) use a libevent timer instead of CURLOPT_TIMEOUT to workaround curl bug http://tinyurl.com/ycm5d3e 2010-01-08 21:45:56 +00:00
Charles Kerr 0d91f3cadf (trunk libT) more documentation and doxygen markup 2010-01-06 00:18:33 +00:00
Charles Kerr 182cbb8b90 (trunk) one of the less-interesting commits in a while: remove trailing spaces from lines 2010-01-05 23:47:50 +00:00
Charles Kerr 5c26afdb52 happy new year! 2010-01-04 21:00:47 +00:00
Charles Kerr a5446669b4 (trunk libT) #2711 "no metadata exchange when using magnet links and trackerless torrents" -- fixed 2010-01-04 20:28:54 +00:00
Charles Kerr 42fb92170a (trunk libT) remove dead code: tr_announce_list_err 2010-01-04 20:14:25 +00:00
Charles Kerr 339173d1b4 (trunk libT) make sure to restart curl's periodic timer 2010-01-04 20:06:39 +00:00
Charles Kerr 59c10a3dc8 (trunk libT) #2722 "crash when removing/modifying trackers" -- fixed 2010-01-04 09:11:27 +00:00
Charles Kerr 6f68e30f37 (trunk libT) consistency tweak: rename tr_global{Lock,Unlock,IsLocked} as tr_session{Lock,Unlock,IsLocked} 2010-01-04 09:05:02 +00:00
Charles Kerr be77238af4 (trunk libT) #2709 "RPC files-unwanted" out-of-bounds access 2010-01-03 17:21:10 +00:00
Mitchell Livingston ba7dae1678 should've alphabetized by peer id, not client name 2010-01-02 18:50:59 +00:00
Mitchell Livingston 7a16959096 add "OneSwarm" to client list 2010-01-02 18:47:59 +00:00
Charles Kerr 696aa7aba6 (trunk libT) resolve thread condition in libtransmission by moving the `waiting' state variable to the stack in tr_sessionSet() and tr_sessionInit() 2010-01-01 22:35:49 +00:00
Charles Kerr 283b6d6a36 (trunk libT) rename tr_wait() tr_wait_msec() 2010-01-01 22:30:36 +00:00
Charles Kerr 08af516e12 (trunk libT) unset DHT's ip4 and ip6 sockets on shutdown so that the libtransmission thread doesn't block on tr_dhtStatus() during shutdown 2010-01-01 22:28:50 +00:00
Charles Kerr 6b8fb48d64 (trunk libT) replace the TR_INLINE macro with the standard "inline" keyword, since we require inline functions anyway 2010-01-01 22:26:35 +00:00
Charles Kerr 21bd268aa9 (trunk libT) fix <assert.h> #includes 2010-01-01 22:14:50 +00:00
Charles Kerr e61e0fcd3d (trunk libT) improved API documentation / commenting for doxygen 2010-01-01 22:13:27 +00:00
Mitchell Livingston f2bbae3fd8 some more insignificant changes I have sitting around locally 2009-12-31 03:19:54 +00:00
Mitchell Livingston 90ecb67c92 fix bug from r9820 where file progress was either 0.0 or 1.0 2009-12-29 01:35:52 +00:00
Charles Kerr 8ae3911477 (trunk libT) #2416 "crash in event_queue_insert" -- I am really quite sick of this bug. It's not reproducible at all under Linux and appears to be a bug in libevent's kqueue implementation. In this commit, we leak the event object on OS X. 2009-12-29 00:00:33 +00:00
Charles Kerr 6151881a03 (trunk libT) #2416 "crash in event_queue_insert" -- instead of freeing libevent's event objects, pool and reuse them. *sigh* 2009-12-28 23:29:59 +00:00
Charles Kerr 1eb0cdd7c6 (trunk libT) fix various minor compiler warnings that show up when you build libtransmission with NDEBUG defined 2009-12-28 23:27:17 +00:00
Charles Kerr ee58472ec2 (trunk libT) fix minor bug in r9651 "Reduce SO_SNDBUF and SO_RCVBUF for tracker announce/scrape messages" -- libcurl's CURLOPT_SOCKOPTFUNCTION doesn't return void; it returns an int that is nonzero if an error occurs. 2009-12-28 23:25:50 +00:00
Charles Kerr 196666da72 (trunk libT) fix minor bug in r9651 "Reduce SO_RCVBUF for outgoing peer connections on seeding torrents" -- remember the "isSeed" attribute so that we can use it on reconnects 2009-12-28 23:24:00 +00:00
Charles Kerr ac202f13bb (trunk libT) remove dead code -- tr_assert() 2009-12-28 23:11:26 +00:00
Charles Kerr 4e44e9c2cb (trunk libT) https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/500625 2009-12-28 00:35:29 +00:00
Charles Kerr bc86c0b364 (trunk libT) #2416 "crash in event_queue_insert" -- maybe this will finally fix it... 2009-12-26 23:57:25 +00:00
Charles Kerr 8bc90ca644 (trunk libT) fix crash in tr_fdSocketClose() reported by agsystem in the forums @ http://forum.transmissionbt.com/viewtopic.php?p=42993&f=1#p42993 2009-12-26 23:52:59 +00:00
Mitchell Livingston f6a5117ef9 calculate proper file progress for 0-byte files (fixes #2689) 2009-12-25 16:56:33 +00:00
Mitchell Livingston 8dbfb708f5 #2696 posix_fadv_dontneed undeclared 2009-12-25 15:48:41 +00:00
Charles Kerr 8903e1b4e3 (trunk libT) #2416 "crash in event_queue_insert" -- another experimental commit. /as an experiment/ let's just leak that event struct and see if that makes the crash go away. Obviously leaking those objects is not a long term fix but this will help point the way towards the real fix. 2009-12-24 18:50:34 +00:00
Charles Kerr 3e2269e5e3 (trunk libT) #2632 "Add streaming capability to libtransmission (but not the Transmission GUI clients)" -- revert this feature due to pushback from devs and users and the 1.80 freeze 2009-12-24 18:01:48 +00:00
Charles Kerr 12ffdb7d87 (trunk libT) #2632 "Add streaming capability to libtransmission (but not the Transmission GUI clients)" -- implemented 2009-12-24 01:02:54 +00:00
Charles Kerr b8d7e76750 (trunk libT) #2416 "crash in event_queue_insert" -- possible fix. it looks like the kqueue client is accessing the event after the callback and after event_del() is being called. *If* that's the case I don't know if it's a libevent bug or if libtransmission is making assumptions it shouldn't've... but it's easy enough to keep the memory in a pool and free it later when it's safer to do so. 2009-12-23 16:12:18 +00:00
Mitchell Livingston a7245651f2 avoid an extra comparison caused by macro expansion 2009-12-21 22:03:19 +00:00
Mitchell Livingston 25a023023f eliminate the clamp function for now, allow peer connections once again 2009-12-21 14:30:43 +00:00
Charles Kerr ef650d0398 (trunk libT) it certainly smells like we're using freed memory in the libcurl + libevent code in web.c... let's trash the structures right before free()ing them 2009-12-18 17:32:16 +00:00
Charles Kerr a653d37225 (trunk libT) possibly reduce the frequency of the "too many open files" errors 2009-12-18 07:05:36 +00:00
Charles Kerr 2ff810d18f (trunk) use AC_ARG_VAR for some autoconf variables s.t. their values will persist between reconfs 2009-12-18 05:02:48 +00:00
Charles Kerr d9369718b3 (trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down 2009-12-16 18:20:01 +00:00
Eric Petit a91c5e44e3 build fix 2009-12-16 07:47:04 +00:00
Charles Kerr 122d69d013 (trunk libT) try not to cache file data read in during verification 2009-12-16 06:34:17 +00:00
Charles Kerr 22e61e68ed (trunk libT) fix call to updateDesiredRequestCount() reported by sadface 2009-12-16 01:32:23 +00:00
Charles Kerr d6f7df8c9a (trunk libT) #2508 "atom->port never updated" -- (1) fix r9434 bug that used the wrong byte ordering scheme for port numbers. This is why most of the .resume file's peers are worthless in betas 1 and 2. :( (2) in the resume file, change the dictionary key for peers so that the worthless peers won't be reloaded on startup in beta 3. 2009-12-16 00:45:18 +00:00
Charles Kerr f3e8a29e0f (trunk libT) #2548 "T's request queue can send out too many duplicate requests" -- fix off-by-one when counting how many peers we'll send a given block request to during endgame 2009-12-15 21:33:24 +00:00
Charles Kerr 22e33f784b (trunk libT) #2548 "T's request queue can send out too many duplicate requests" -- experimental revision to r9465 to address further overdownloading issues 2009-12-15 20:13:34 +00:00
Charles Kerr c789454dba (trunk libT) #2667 "Ignore martian addresses" -- apply jch's 0001-Simplify-martian-address-detection.patch cleanup patch from http://trac.transmissionbt.com/ticket/2667#comment:8 2009-12-15 20:06:48 +00:00
Charles Kerr 33c6b0d9ec (trunk libT) #2667 "ignore martian addresses" -- revise the tests to tr_isValidPeerAddr() base
d on feedback from jch @ http://trac.transmissionbt.com/ticket/2667#comment:6
2009-12-15 19:39:01 +00:00
Charles Kerr c819d6dca6 (trunk libT) #2671 "downloading from too many peers" -- address a smaller aspect of this ticket, by reducing the minimum number of blocks we request from a peer, as noted by jch's comment @ http://trac.transmissionbt.com/ticket/2671#comment:2 2009-12-15 18:11:20 +00:00
Charles Kerr f4c744266f (trunk libT) #2667 "ignore martian addresses" -- modified this ticket. previously we ignored them from LTEP; now we ignore them regardless of the source. this commit implements this filtering change. 2009-12-15 17:39:19 +00:00
Charles Kerr de9498f1ab (trunk libT) #2669 "Apply IPV6_V6ONLY to the IPv6 DHT socket" -- committed jch's patch for 1.80 2009-12-15 16:48:26 +00:00
Charles Kerr c17932f533 (trunk libT) #2673 "crash in tr_torrentGetMetadataPiece" -- add safeguards against small sizes 2009-12-15 16:34:12 +00:00
Eric Petit 5fb945653f #2673 crash in tr_torrentGetMetadataPiece 2009-12-15 15:19:08 +00:00
Charles Kerr ed6e95eef3 (trunk) add #include guards to prevent non-libtransmission files from #including implementation headers 2009-12-15 00:51:39 +00:00
Charles Kerr e7baa2b480 (trunk libT) maybe fix that blocklist crash John_Clay reports about once a month 2009-12-14 18:47:45 +00:00
Charles Kerr 0601442f58 (trunk libT) #2416 "crash in event_queue_insert" -- another stab at fixing this. yay 2009-12-14 18:24:26 +00:00
Charles Kerr 8cee197cac (trunk libT) fix minor memory leak in libtransmission/tr-dht.c, found by valgrind 2009-12-14 17:46:00 +00:00
Charles Kerr 87aefaf5ff (trunk libT) #1699 "announce to multiple trackers at once" -- fix minor bug in reporting scrape results when an announce returns enough information that a separate scrape isn't necessary. 2009-12-14 17:17:05 +00:00
Charles Kerr ee0de4b06c (trunk libT) keep simplifying web.c... is there anything left to strip out? 2009-12-14 14:25:22 +00:00
Charles Kerr c33aef7e2d (trunk libT) more web.c simplification + handle an unhandled case CURL_POLL_NONE in the socket callback. 2009-12-14 12:54:30 +00:00
Charles Kerr 2653cd5153 (trunk libT) keep simplifying web.c. also, fix an improbable FMR at shutdown 2009-12-14 05:11:33 +00:00
Charles Kerr 3fe5db7113 (trunk libT) #2667 "Ignore martian addresses in LTEP messages" -- implemented for 1.80 2009-12-14 02:07:47 +00:00
Charles Kerr 6d9e6ececc (trunk libT) remove some more obsolete debug messages and other cruft from web.c 2009-12-13 19:33:02 +00:00
Charles Kerr 485b64a5e3 (trunk libT) it never ends 2009-12-13 17:54:01 +00:00
Mitchell Livingston bdf3144376 remove unnecessary asserts 2009-12-12 21:37:36 +00:00
Charles Kerr 2d1b6748ec (trunk libT) #2661 "better torrent prioritization when making outbound peer connection attempts" -- implemented for 1.80 2009-12-12 17:05:31 +00:00
Charles Kerr 20a4560198 (trunk libT) remove the test for duplicate trackers in the announce list. 2009-12-12 04:12:04 +00:00
Charles Kerr 196a7ccbb9 (trunk libT) #2658 "encryption improvements" - patch by sadface to make DH handshake ~2x faster. yay! 2009-12-12 03:51:36 +00:00
Charles Kerr ed1df8beac (trunk libT) removed dead code: tr_isTimeval(), tr_timevalMsec(), tr_timevalSet() 2009-12-12 01:05:29 +00:00
Charles Kerr 1f320b2ddd (trunk) fix a couple of cases where we don't use the tr_snprintf() portability wrapper 2009-12-11 20:26:40 +00:00
Charles Kerr a89d2217af (trunk libT) #2416 "crash in event_queue_insert()" 2009-12-11 15:41:34 +00:00
Charles Kerr 5f1f2b1e85 (trunk libT) use curl_multi_socket_action(), even on OS X. 2009-12-10 19:05:21 +00:00
Charles Kerr 0f14f62ac1 (trunk libT) new utility function tr_timerAddMsec() 2009-12-10 19:04:10 +00:00
Charles Kerr a1ccd10f89 (trunk libT) add simple tr_http_unescape() unit test 2009-12-10 10:44:06 +00:00
Charles Kerr cd0de2ebe5 (trunk libT) fix errors in tr_httpParseURL() 2009-12-10 09:13:08 +00:00
Charles Kerr 1c772bd1fe (trunk libT) finally get rid of the last remnants of tr_timer 2009-12-10 05:52:46 +00:00
Charles Kerr 9fb6c5b1c4 (trunk libT) #2655: "1.80b1 crash in peer-mgr.c's getPeersToClose()" -- fixed 2009-12-10 04:54:48 +00:00
Charles Kerr f73f223540 (trunk libT) #2653 "transmission-remote-dotnet makes transmission-daemon segfault" -- fixed for 1.80 2009-12-09 12:44:23 +00:00
Charles Kerr 02f4038f67 (trunk libT) #2641 "a magnetic-induced crash because of malformed url" -- fixed in trunk for 1.80b2 2009-12-09 04:28:53 +00:00
Charles Kerr 4b3b5dcd8a (trunk libT) by request, remove a clientData argument from tr_torrentDeleteLocalData() (reverts r9690) 2009-12-09 03:51:21 +00:00
Charles Kerr 5f9f97ee2a (trunk libT) by request, add a clientData argument to tr_torrentDeleteLocalData() 2009-12-09 03:40:35 +00:00
Charles Kerr c5af8965e0 (trunk libT) the deleteFunc passed in as the second argument to tr_torrentDeleteLocalData() should /not/ be called unless the file being passed to it actually exists. Reported by livings124 2009-12-09 03:00:20 +00:00
Charles Kerr bcd01fda3b (trunk libT) #2651: "missing errmsg in RPC torrentSet" -- reported & patched by elbandi 2009-12-09 01:36:31 +00:00
Charles Kerr 857e37bf77 (trunk libT) #2643 "Total UL/DL ratio reset when quitting abnormally" -- fixed. 2009-12-08 20:51:45 +00:00
Charles Kerr 907c67ba78 (trunk libT) remove unnecessary #includes 2009-12-07 03:57:55 +00:00
Eric Petit 769629499e The IPv6 check could always fail because we did not specify a port when
trying to set up the UDP socket (was reproducible here on 10.6 at least)
2009-12-06 16:21:29 +00:00
Charles Kerr d370222113 (trunk libT) #2551 "when uploading to peers, prefetch local data from disk" -- prefetching performance tweak described in http://trac.transmissionbt.com/ticket/2551#comment:22 -- instead of prefetching [8..12] blocks, always prefetch 12 blocks 2009-12-05 19:30:15 +00:00
Charles Kerr 78ead8c3dd (trunk) update the copyright notices 2009-12-05 02:19:24 +00:00
Mitchell Livingston 5fb643431e decrease the size of the buffer for logging 2009-12-05 01:28:42 +00:00
Mitchell Livingston 8efe3f7cce remove a redundant level check in tr_msg() 2009-12-05 01:02:37 +00:00
Charles Kerr 31a3ed1684 (trunk, qt) #2096 "magnet links" -- Add the "Copy Magnet Link to Clipboard" feature to Qt client 2009-12-03 15:23:43 +00:00
Charles Kerr 79154bac8a (trunk) #2096 "magnet links" -- fix RPC typo introduced in r9655 and reported by KyleK 2009-12-03 12:40:23 +00:00
Charles Kerr 7537f02589 (trunk libT) #2636: "wrong peer progress update" -- possible fix as described in comment:2 2009-12-03 03:11:22 +00:00
Charles Kerr bb44a31423 (trunk) #2096 "Magnet Links - Extension for Peers to Send Metadata Files (BEP #9)" -- publish tr_stat.metadataPecentComplete in the RPC so that kjg can use it in the web client 2009-12-02 20:05:19 +00:00
Charles Kerr d1935a4812 (trunk libT)
11:59 < klapaucjusz> charles: net.c line 314.
11:59 < klapaucjusz> Please change the value to 8192.
12:00 < charles> okay but why?
12:00 < klapaucjusz> I'm not sure it will trigger, but having space for 4 full-sized segments is always a good idea.
12:01 < klapaucjusz> It means you have a better chance of recovering from a lost segment
2009-12-02 20:03:27 +00:00
Charles Kerr 560ecbe9bb (trunk libT) fix implicit pointer conversion error when #included in C++ 2009-12-02 19:44:01 +00:00
Charles Kerr 6d008257c8 (trunk libT) minor tweaks: make bencode's int parser code more consistent; make some comments more readable 2009-12-02 15:16:29 +00:00
Charles Kerr 6eec59008c (trunk libT) experimental: Reduce SO_SNDBUF and SO_RCVBUF for tracker announce/scrape messages. Reduce SO_RCVBUF for outgoing peer connections on seeding torrents. 2009-12-02 05:30:46 +00:00
Mitchell Livingston 5392b262d7 10,000 log messages is enough for anyone 2009-12-02 01:55:09 +00:00
Mitchell Livingston ad06c660c8 cap libT's message log 2009-12-01 23:20:00 +00:00
Charles Kerr 9f347f8df1 (trunk) #2119 "daemon should reload settings.json on SIGHUP" -- reload the blocklists, too. Suggested by nano- in irc. 2009-12-01 00:07:18 +00:00
Charles Kerr 12bfde0c2b (trunk) #1663 "crashes on shutdown if libevent loop doesn't exit soon enough" -- maybe crash less frequently now. 2009-11-30 04:58:03 +00:00
Mitchell Livingston 0563580dda inline tr_removeElementFromArray() 2009-11-30 01:31:05 +00:00
Charles Kerr 03351e9a4e (trunk libT) #2607 "avoid unnecessary calls to getPeerCandidates(), wasted cycles in peerIsInUse()" 2009-11-29 18:35:02 +00:00
Charles Kerr 33658647d6 (trunk libT) #2576 "IPv6 support for DHT (BEP #32)" -- silence message "IPv6 DHT not ready." Reported by KyleK; fixed by jch 2009-11-29 18:31:36 +00:00
Charles Kerr 5c3fd1b5cc (trunk libT) #2631 "Add webseed support to magnet links" 2009-11-29 17:49:58 +00:00
Charles Kerr da7ab27ae2 (trunk libT) add SO_SNDBUF, SO_RCVBUF logging messages 2009-11-29 08:53:14 +00:00
Charles Kerr a38fb59c6f (trunk libT, gtk) #2625 "ability to create a magnet link" -- add hook for generating a magnet link from a tr_torrent, and use it in the Torrent Properties dialog in the GTK+ client 2009-11-29 08:27:55 +00:00
Charles Kerr 63027e1d5a (trunk libT) resolve "noslashes" vs "keep_slashes" variable name inconsistency between the declaration and the definition of tr_http_escape() 2009-11-29 08:05:47 +00:00
Mitchell Livingston 4e615c55a0 trivial change to array size 2009-11-29 00:04:29 +00:00
Mitchell Livingston 87823ba99c set two blank functions as inline 2009-11-28 22:29:41 +00:00
Charles Kerr de0d6af06b (trunk libT) remove unnecessary code 2009-11-28 16:25:05 +00:00
Charles Kerr d1f9b8ddee (trunk libT) performance improvements to peer-mgr.c's peerIsInUse() 2009-11-28 07:15:31 +00:00
Mitchell Livingston 2021706c6e remove an unneeded static variable 2009-11-27 18:13:36 +00:00
Mitchell Livingston 8214c797c6 trivial cleanup in the logging code 2009-11-27 17:55:09 +00:00
Charles Kerr 8e7d08fc83 (trunk libT) remove unnecessary calls to tr_msgInit(). Suggested by BentMyWookie. 2009-11-27 15:32:11 +00:00
Charles Kerr c7f061cafc (trunk libT) make tr_msgLoggingIsActive() an inlined function. suggested by BentMyWookie 2009-11-27 15:25:14 +00:00
Charles Kerr 864ae61a70 (trunk libT) tweak the debugging message for the atom manager 2009-11-27 14:27:44 +00:00
Charles Kerr fc0a8b7c93 (trunk) #2614: "incorrect memory usage when not using IPv6" -- accepted dht.c + tr-dht.c patches 2009-11-27 14:18:32 +00:00
Charles Kerr 47c6ec5efa (trunk libT) #2551: "when uploading to peers, prefetch local data from disk" -- fix peer-msgs.c NULL pointer dereference introduced in r9514 for this ticket. Reported by Waldorf 2009-11-27 03:21:21 +00:00
Charles Kerr d7d5bb6db7 (trunk libT) #2610 "avoid unnecessary calls to time(NULL)" -- fix new assertion error reported by John Clay and tstevens 2009-11-27 02:24:48 +00:00