c8e84f870b
ci: remove "brew update" step ( #5606 )
2023-06-11 16:28:43 -05:00
8ca02b8f28
Avoid locale use in `tr_truncd()` ( #5587 )
...
`tr_parseNum<>()` is implemented with `fast_float::from_chars()`, and
the latter is documented as "expecting a locale-indepent format
equivalent to what is used by std::strtod in the default ("C") locale".
To accomodate locale independent number parsing, switch back to
locale-independent number formatting in `tr_truncd()` by both removing a
`L` format specifier from `fmt::format_to_n()` call and using a fixed
"." decimal separator when truncating the value.
2023-06-10 17:09:18 -05:00
c1c27f3da0
Expose files' begin and end pieces via RPC ( #5578 )
...
* Expose files' begin and end pieces via RPC
This adds two arguments, `beginPiece` and `endPiece`, for each of the entries
in the `files` array of the RPC's `torrent-`get` method.
The point is to allow RPC clients to display a file's completion progress as
piece-based in addition to byte-based.
2023-06-05 13:15:32 -05:00
87472672a6
build: fix xcode build ( #5521 )
2023-05-19 23:17:24 -05:00
e171cbae9c
refactor: move Buffer::add_socket() to BufferWriter::add_socket() ( #5543 )
2023-05-19 23:06:26 -05:00
ae888ef08e
perf: avoid map insertion for complete blocks received ( #5540 )
2023-05-19 18:36:07 -05:00
52b03c2489
refactor: migrate methods to buffer reader ( #5533 )
2023-05-18 16:56:29 -05:00
4fd5f3a490
refactor: use reserve_space() in peer-io ( #5532 )
2023-05-17 13:57:27 -05:00
b9698210ef
refactor: restore part of Buffer::reserve_space() ( #5529 )
2023-05-16 21:46:41 -05:00
2cf9678737
fix: revert buffer reserve space ( #5528 )
...
* Revert "refactor: use BufferReader, BufferWriter as function args (#5518 )"
This reverts commit c2d48a7d11#5513 )"
This reverts commit b08e17beef#5513 )"
This reverts commit 51fd7056ba
2023-05-14 17:24:42 -05:00
e88bf946e1
perf: avoid extra work in read_vc() ( #5527 )
2023-05-14 15:01:04 -05:00
8a1a6dba49
perf: avoid extra heap alloc in block cache ( #5522 )
2023-05-13 14:16:00 -05:00
69fc149f07
fix: avoid unintentional map insertions in ActiveRequests::count() ( #5520 )
2023-05-12 20:18:26 -05:00
7cabeff24f
perf: use std::bitset instead of tr_bitfield in incoming_piece_data ( #5519 )
...
Since max size is small and known at compile time, we can avoid extra heap allocations
2023-05-12 19:31:59 -05:00
c2d48a7d11
refactor: use BufferReader, BufferWriter as function args ( #5518 )
2023-05-12 18:10:08 -05:00
b08e17beef
fixup! refactor: add BufferReader, BufferWriter::reserve_space() ( #5513 )
...
chore: remove tracer fmt::print() statements
2023-05-12 11:47:01 -05:00
51fd7056ba
refactor: add BufferReader, BufferWriter::reserve_space() ( #5513 )
2023-05-12 11:15:15 -05:00
c61d8b7cf7
refactor: rename tr_tracker_view.host to .host_and_port for clarity ( #5508 )
2023-05-08 20:28:10 -05:00
0d3b321bac
refactor: use snake_case for libtransmission class methods ( #5497 )
2023-05-05 23:11:05 -05:00
d65f9329cd
refactor: followup/cleanup of `tr_global_ip_cache` PR ( #5498 )
...
* remove tr_session::bindAddress()
* replace tr_net_hasIPv6 with tr_session::has_ip_protocol()
* update comment
2023-05-05 22:05:28 -05:00
693d202a64
refactor: save stats.json periodically and when closing session #5476 ( #5490 )
2023-05-05 15:33:23 -05:00
474a30ab2d
feat: add global IP cache, fix UDP connection failure warnings
2023-05-05 12:17:40 -05:00
2f1d5a225c
fix: comment typos in libtransmission ( #5473 )
2023-04-30 13:29:29 -05:00
e8fcb025a0
fix: use user-preferred locale ( #5444 )
...
* Use user-preferred locale
Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.
Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.
* Improve libtransmission's json-test
Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.
* Improve transmission-show test runner script
Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
2023-04-27 09:10:33 -05:00
47667bab8d
fix: bug that prevented providing the final metadata piece ( #5460 )
...
Fixes bug in implementation of BEP 9
Xref: https://www.bittorrent.org/beps/bep_0009.html
2023-04-26 19:40:49 -05:00
1b6b85989c
feat: add generic favicon_cache class for reuse between Qt, GTK app ( #5294 )
2023-04-22 21:11:16 -05:00
9d2507c7e3
refactor: snake_case in libtransmission class methods ( #5428 )
2023-04-22 20:25:55 -05:00
7e7d8137a0
fixup! feat: Add BufferWriter class ( #5154 ) ( #5437 )
2023-04-22 18:13:39 -05:00
9f8a7a656e
fix: Buffer::Buffer(Buffer&&) bug ( #5435 )
2023-04-22 16:10:09 -05:00
ce4ffc3bdb
fix: 5422 use-after-free in peerMsgs::canRead ( #5425 )
2023-04-20 13:18:53 -05:00
3044c14b10
perf: in Buffer::Iterator, defer evbuffer API calls ( #5420 )
2023-04-19 16:00:30 -05:00
f2aa3e197b
refactor: add tr_sys_dir_get_files() ( #5412 )
2023-04-18 16:23:20 -05:00
a8e01ac38d
fix: minor warnings ( #5409 )
...
* chore: fix readability-qualified-auto warnings
* chore: fix clang-analyzer-core.uninitialized.Branch warning
* fix: collision of key 'ERROR' in transmission-qt
* chore: silence -Wshadow warning
* chore: silence warning C4100: 'iter': unreferenced formal parameter
* chore: fix warning C4127: conditional expression is constant warning
2023-04-17 23:11:09 -05:00
7d86d67bc7
chore: prefer fmt/core.h over fmt/format.h ( #5404 )
2023-04-16 15:34:19 -05:00
3af9645615
refactor: add tr_address::is_any() ( #5398 )
...
As suggested by @tearfur
Xref: https://github.com/transmission/transmission/pull/5329#discussion_r1166236165
2023-04-15 19:30:20 -05:00
06c784f639
fix: uninitialized session_id_t values ( #5396 )
2023-04-15 00:07:07 -05:00
e91af26923
perf: remove staging step for outbound peer msgs ( #5394 )
...
Write non-piece peer messages directly to the peer's outbuf instead of
waiting for a pulse() message to refill it. This can help with latency
sending messages out.
Change the semantics of `tr_peerIo::get_write_buffer_space()`: this is
now interpreted as the preferred minimum size, rather than the maximum.
It's OK to enqueue an outgoing piece message as long as there's _some_
space left, even if the message is larger than that space.
Build peer messages with template fold expressions. This lets us move
all the message-building to a single function and add some sanity checks
to the outgoing messages.
2023-04-14 19:31:09 -05:00
9158ae7126
feat: add tr_bitfield::intersects() ( #5155 )
2023-04-14 18:45:46 -05:00
ed4919a4f4
feat: Add BufferWriter class ( #5154 )
2023-04-14 17:08:01 -05:00
68e965aa28
perf: pass by reference ( #4876 )
2023-04-14 17:06:26 -05:00
d445c7f061
fix: crash in peer stats ( #5279 )
2023-04-14 16:03:08 -05:00
d72cb67cfb
chore: include directory name in libtransmission #includes ( #5308 )
2023-04-14 14:33:23 -05:00
ebfba686b0
feat: sequential download ( #4795 )
2023-04-14 11:47:54 -05:00
afa9f64feb
refactor: align tr_formatter_speed_KBps with `stringForSpeed: kb: mb: gb:` ( #5108 )
2023-04-14 10:36:34 -05:00
63421489fe
refactor: tr_sys_dir_open() takes a std::string_view ( #5380 )
2023-04-14 09:31:46 -05:00
0e2b8d721c
fix: only torrent metainfo display-name as a fallback ( #5378 )
...
Fixes #5347 .
2023-04-12 17:26:43 -05:00
e33d9536ef
fix: return success on RPC add-torrent duplicate ( #5370 )
...
Keep Transmission 3's behavior to avoid unannounced API change
2023-04-12 13:37:04 -05:00
91717fe91d
fix: potential NSString leak in tr_strv_convert_utf8()
2023-04-11 17:36:22 -05:00
c76cb4db51
fix: silence torrent-metainfo warnings for cross_seed_entry, uid ( #5365 )
2023-04-10 11:07:43 -05:00
931beba56f
fix: set log level before constructing tr_session ( #5345 )
2023-04-03 15:37:28 -05:00
e68c72daa4
fix: tr_net_hasIPv6() ( #5312 )
2023-03-28 13:41:07 -05:00
85a00625dc
fix: intermediate fix for HTTP announce behaviour affected by `bind-address-ipv*` ( #5296 )
2023-03-28 12:59:42 -05:00
a216bd7cec
Use locale-dependent decimal separators for user-visible numbers ( #5288 )
...
This includes percents, ratios, sizes, speeds, etc. coming from shared
formatting helpers. Previously based on sprintf-like functions using
locale, now using libfmt which doesn't use locale by default and needs
to be instructed to do it explicitly.
2023-03-23 19:48:45 -05:00
3e97d0b9c2
fix: The right operand of '<' is a garbage value ( #5285 )
2023-03-23 12:05:11 -05:00
d63165e8a4
perf: fix wishlist cpu load regression, pt. 2 ( #5273 )
2023-03-22 10:24:10 -05:00
25f38d5ff3
fix: wrong tier value in torrent get tracker stat response ( #5274 )
2023-03-21 20:23:08 -05:00
58ce7bd437
fix: 4.0.2 wishlist CPU perf regression pt. 1 ( #5266 )
2023-03-20 21:08:16 -05:00
c60bb5b834
fix: crash when magnet dn isn't utf-8 ( #5244 )
2023-03-19 10:36:16 -05:00
5cc3bf8a97
fix: generate peer-id on launch ( #5233 )
2023-03-15 20:53:48 -05:00
3aeefec203
chore: remove unused header includes ( #5227 )
2023-03-14 18:36:15 -05:00
a87d39f3bd
fix: filter out peers with port 1 from DHT peer lists. ( #5218 )
2023-03-13 19:27:47 -05:00
6224b60728
fix: wrong error message when writing to incomplete dir ( #5217 )
2023-03-13 16:20:39 -05:00
59a157ebde
feat: restore support for nonstandard `path.utf-8` ( #3454 )
2023-03-13 13:58:59 -05:00
dabd29f2b2
fix: std::clamp() assertion failure in maxAvailableReqs() ( #5203 )
2023-03-11 22:25:21 -06:00
900281eb1c
fix: check tr_ctorSetFoo() return values before adding torrent via RPC ( #5202 )
2023-03-11 19:44:54 -06:00
86fd89fff4
fix: remove interest strategy code that could contribute to oscillating download speeds. ( #5176 )
2023-03-10 13:21:51 -06:00
b354337720
ci: check for clang tidy errors in libtransmission ( #5188 )
2023-03-10 00:23:22 -06:00
9c436d87dd
fix: torrentGet.wanted RPC breaking change in [4.0.0..4.0.1] ( #5170 )
2023-03-07 19:44:25 -06:00
033d698306
fix: parsing of ipv6 tracker announce URLs ( #5174 )
2023-03-07 12:19:12 -06:00
39e3e1d87b
fix: increase priority of first and last piece of each file ( #5167 )
...
The first and last pieces of a file generally include information needed
by preview generators, so prioritizing those pieces makes life easier
for users or tools that look at files while they're being downloaded.
This worked in 3.00 but isn't present in 4.0.0.
2023-03-06 15:50:19 -06:00
56c1bb2a9e
fix: publish 'leechers' iff it was in tracker response ( #5164 )
2023-03-06 09:22:40 -06:00
b2b0f0db39
fix: crash in curl_easy_pause() ( #5161 )
2023-03-05 23:42:52 -06:00
47001a394e
fix: 7f9ef4730 use-after-free in peerMsgs::canRead ( #5152 )
2023-03-05 11:50:11 -06:00
7f9ef4730e
fix: assertion failure in readBtPiece() ( #5097 )
2023-03-03 17:43:51 -06:00
848212eea1
fix: escaped representation of non-BMP characters when generating JSON ( #5096 )
2023-03-02 00:55:16 -06:00
d3273504bd
fix: 5053 old torrent files keep appearing ( #5117 )
2023-03-01 20:12:19 -06:00
211e3fc985
fix: always add `announce` key even when including announce-list ( #5106 )
2023-03-01 13:10:20 -06:00
63653b4831
fix: recheckCompleteness on setDownloadDir ( #5060 )
2023-02-28 08:51:11 -06:00
1a276fb145
fix: 4.0.0 bookkeeping of protocol overhead when receiving peer messages ( #5091 )
2023-02-27 20:25:15 -06:00
f53e58c8bd
fix: 4.0.0 regression that broke speed limits for utp peers ( #5086 )
2023-02-27 15:03:45 -06:00
ac319321b5
fix: assertion failure in std::clamp() when called from rechokeDownloads() ( #5080 )
2023-02-27 11:59:00 -06:00
238fd96041
fix: don't log full path, only the filename of source file ( #5055 )
...
Co-authored-by: Akos Horvath <koma@koma.sh>
2023-02-27 10:02:58 -06:00
47fd150bab
fix: some torrents think they are magnets ( #5025 )
2023-02-25 07:11:19 -06:00
81f8ceb0f9
Limit in-kernel file copying to 2 GiB blocks at a time ( #5039 )
...
This reportedly helps with copying to cifs target where
`copy_file_range()` would sometimes return `EINVAL` for no apparent
reason when copying large files. Extending the limit to `sendfile64()`
to avoid similar issue there, if it exists.
Overall, copying at most 2 GiB at a time will result in more syscalls
but shouldn't affect the performance gain in any noticeable way.
2023-02-25 03:15:17 +00:00
450e98fd91
fix: TR_TIME_LOCALTIME value in torrent scripts ( #5006 )
2023-02-23 07:18:29 -06:00
9d1a141482
fix: cannot build with clang on Windows ( #4978 )
...
Fixes #4977 .
2023-02-21 11:08:28 -06:00
ed8133520f
fix: blocklists allocate more memory than they need ( #4953 )
2023-02-19 09:20:23 -06:00
e29064023f
fix: try utp connection first; fix utp timeout issues. ( #4897 )
2023-02-18 10:03:59 -06:00
adf5051d46
fix: revert tr_torrentStat() acquires a session thread lock ( #4571 )
...
This reverts commit e4b480ecd4
2023-02-17 23:11:24 -06:00
b3abadf8ba
Bump bundled libutp to rollback anonymous unions fix ( #4877 )
2023-02-18 02:59:15 +00:00
1e5546280e
fix: Remove faulty `popcnt` features checks for MSVC [ #4872 ] ( #4886 )
...
The `popcnt` feature checks weren't actually checking the ISA feature
or cpuid. This caused an illegal instruction exception on x86 hardware
that doesn't support `popcnt` when compiled with MSVC.
Since MSVC doesn't support any x86 ISA defines, the only way to check
for `popcnt` is with cpuid. Since this is a tiny inline function,
dynamic dispatch is likley not worth it so just removing the MSVC
for `popcnt`. MSVC will now fallback to the generic implementation.
2023-02-18 02:11:56 +00:00
9b69c7d5ff
Don't force fetch metainfo at startup and new torrents. ( #4895 )
2023-02-14 22:19:47 -06:00
4461aa68d9
fix: handle block fragments that arrive from peers out-of-order ( #4890 )
2023-02-14 13:50:28 -06:00
9d91d1e969
fix: checksum of pieces that don't align on block boundaries ( #4880 )
2023-02-13 20:57:20 -06:00
a982c96518
fix: assertion failed leftUntilDone <= sizeWhenDone ( #4879 )
2023-02-13 19:51:23 -06:00
f551b4adbf
fix: magnet links are always paused when added ( #4856 )
2023-02-13 12:33:33 -06:00
62a60b4ea4
fix: link libquota on NetBSD to fix FTBFS ( #4863 )
2023-02-13 12:04:14 -06:00
a2faaabe69
chore: remove invalid assertion test ( #4860 )
...
Fixes #4078 .
2023-02-12 18:38:18 -06:00
649fd4d0d2
fix: do not lose magnet links when upgrading from tr3 to 4 ( #4840 )
2023-02-12 18:10:54 -06:00
0be7091eb1
Revert "fix: remove abort() call from tr_assert_message() ( #4696 )" ( #4851 )
...
This reverts commit 0493542f62
2023-02-12 08:16:20 -06:00
Charles Kerr